From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E87A1C433E7 for ; Wed, 14 Oct 2020 14:54:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B836212CC for ; Wed, 14 Oct 2020 14:54:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sigk2AWz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="j8awzeHZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B836212CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v2m9g61DuDxBWfLalcZXKz4sljU30cb9Ztk0v3CjP0I=; b=sigk2AWzSDBhMB+7mfx0J6WsS cpMAH7GGWHTlTalz4L6FVvqfsx+JiNhGy8sheLxHIHVYYfUa2aWaNmWBBB3t/PFRrvGj3B52H57YQ kW2j5/iYA1FihZF83CPj2EUjFpiUiDmeaROAwFrPbeK8g1Jqz6IRFHnzR1aSYVBTfYSLIRi5DNhnD qXg3Gfu8NZBEkt4WqukBOsiBLDe7Ak3evA1gbmubYupJ0C9mkqNat5pJqQ1kqNXBW01cr0cX7VgMK CH4AuQxkmpru217yVk1LsSr8b/8kevxwbhaAoOTC201sZRMdeFrlxCWoS74aJHkzbIDLpitGyUo0H wXSn3IJsQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSi8t-0006JD-RV; Wed, 14 Oct 2020 14:52:39 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSi8q-0006IT-Dt for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 14:52:37 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09EElA7Q021772; Wed, 14 Oct 2020 16:52:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=X/MWsrP7z5WuMmNAYYZR4RDLaLOxs5xIWa3Q7SjTPXA=; b=j8awzeHZs1RA5fGcdAinFtlqiaKQJtVcDqQjT84EjRp5xQFOMC3gcD6e6cJRVJ1cGTnp tiIco7f1Oc6BDRMuxyb4VEY0t197CmucZ3QFn6D3Lr/4UO0nlTV1VOxUXcnD4SVLcbSO Vjm/czKs/bgWVCtqDu2O1A1lA8EdcQK6IqXfQpJvte8u9d3iAPOmkS94xl9dhQhIIssb fwS1tzy7oBua8tNJkmkAFo4CKj1lTY3hbnPPD+q9ibP7HQ+Y9DTNMa3TKK7rzx23ERQV oztD3HVs5PGY5+pzgcP2f7B08dDKWNFBHe0ohBxQzB/thF5YmMhcFe4RAWth7IgdLNWq hw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3435876ns2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Oct 2020 16:52:33 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8722610002A; Wed, 14 Oct 2020 16:52:30 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 6DE1F2C9B37; Wed, 14 Oct 2020 16:52:30 +0200 (CEST) Received: from SFHDAG2NODE1.st.com (10.75.127.4) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 14 Oct 2020 16:52:30 +0200 Received: from SFHDAG2NODE1.st.com ([fe80::4413:c8c:992b:bb90]) by SFHDAG2NODE1.st.com ([fe80::4413:c8c:992b:bb90%20]) with mapi id 15.00.1473.003; Wed, 14 Oct 2020 16:52:29 +0200 From: Yann GAUTIER To: Marek Vasut , "linux-arm-kernel@lists.infradead.org" Subject: Re: [Linux-stm32] [PATCH] ARM: dts: stm32: Consistently enable internal pull-ups for SD bus Thread-Topic: [Linux-stm32] [PATCH] ARM: dts: stm32: Consistently enable internal pull-ups for SD bus Thread-Index: AQHWoi2b7WHkvVHtlkyJZn5NXXCBP6mW9l8AgAAXAIA= Date: Wed, 14 Oct 2020 14:52:29 +0000 Message-ID: <99663cc5-f897-8233-518b-1a485a2e15b6@st.com> References: <20201009210820.243659-1-marex@denx.de> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.51] Content-ID: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-14_08:2020-10-14, 2020-10-14 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_105236_972435_6BAFC47F X-CRM114-Status: GOOD ( 22.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre TORGUE , "a.fatoum@pengutronix.de" , Maxime Coquelin , Patrick DELAUNAY , "linux-stm32@st-md-mailman.stormreply.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/14/20 3:30 PM, Marek Vasut wrote: > On 10/14/20 3:26 PM, Yann GAUTIER wrote: > [...] >>> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >>> index b2d19583450c..73d9a5b7f5ba 100644 >>> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >>> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >>> @@ -1291,13 +1291,13 @@ pins1 { >>> ; /* SDMMC1_CMD */ >>> slew-rate = <1>; >>> drive-push-pull; >>> - bias-disable; >>> + bias-pull-up; >> Hi Marek, > > Hi, > >> This pin config is used by ST board, where we have a level shifter. >> This shouldn't be changed. We discussed this with Alex, and a new group >> should be added in this case. > > Is it a problem if we enable the pulls up unconditionally with the level > shifter present, to make the properties of the SD bus consistent ? > The risk of having 2 parallel pull-ups is that the resulting value could be below the lower acceptable value for SD. I'll check if that can occur. Yann >>> }; >>> pins2 { >>> pinmux = ; /* SDMMC1_CK */ >>> slew-rate = <2>; >>> drive-push-pull; >>> - bias-disable; >>> + bias-pull-up; >> Same case for this one. >>> }; >>> }; > > [...] > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel