From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91291C3A59D for ; Fri, 16 Aug 2019 22:40:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60ED62171F for ; Fri, 16 Aug 2019 22:40:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cJncHrTm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60ED62171F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=flIYRzGmJ5pmQVBeNUwMrKXQfwmFYi6fsFblK/59rIw=; b=cJncHrTm3qs1fMOuBDS6C2Yra bVhRDzDDsOsuwLSsTgWgx9sgl86Ctz6D1ZT3ipfZxEd9ZCz92SNVLM0jzvT7eymt4QAgrialm99l/ cggtfxixb/9oSCC/g05uZ0muDdZmJHEDz+lgIQw05X1pDymiz2a9Eaa6m1w7v8fj2pPy8AT6KwZkK oTg8ONNjK6VRLtFe3YD4BCXn52q5VK0J7uIUF5aopMXks/STqdSb+cTy0X14TKgbXCNh7kOUxgpMl K+V8CO34IspEdedlg5wkz/9t1aQGGuG0t6TOSby7ypASF+0rzS+YRYO5pM7VBvy8KubgIidbeLQMY M6o7XLjKw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hyktw-0002df-Iz; Fri, 16 Aug 2019 22:40:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hyktt-0002cx-UI for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2019 22:40:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 028F6344; Fri, 16 Aug 2019 15:40:46 -0700 (PDT) Received: from [10.37.12.84] (unknown [10.37.12.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A8B533F718; Fri, 16 Aug 2019 15:40:44 -0700 (PDT) Subject: Re: [Xen-devel] [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header To: Christoph Hellwig , Stefano Stabellini , Konrad Rzeszutek Wilk References: <20190816130013.31154-1-hch@lst.de> <20190816130013.31154-8-hch@lst.de> From: Julien Grall Message-ID: <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com> Date: Fri, 16 Aug 2019 23:40:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190816130013.31154-8-hch@lst.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190816_154050_019783_849D5723 X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 8/16/19 2:00 PM, Christoph Hellwig wrote: > Merge the various page-coherent.h files into a single one that either > provides prototypes or stubs depending on the need for cache > maintainance. > > For extra benefits alo include in the file > actually implementing the interfaces provided. > > Signed-off-by: Christoph Hellwig > --- > arch/arm/include/asm/xen/page-coherent.h | 2 -- > arch/arm/xen/mm.c | 1 + > arch/arm64/include/asm/xen/page-coherent.h | 2 -- > arch/x86/include/asm/xen/page-coherent.h | 22 ------------------ > drivers/xen/swiotlb-xen.c | 4 +--- > include/Kbuild | 2 +- > include/xen/{arm => }/page-coherent.h | 27 +++++++++++++++++++--- I am not sure I agree with this rename. The implementation of the helpers are very Arm specific as this is assuming Dom0 is 1:1 mapped. This was necessary due to the lack of IOMMU on Arm platforms back then. But this is now a pain to get rid of it on newer platform... Cheers, -- Julien Grall _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel