From: Cristian Marussi <cristian.marussi@arm.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: amit.kachhap@arm.com, andreyknvl@google.com, shuah@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v8 01/12] kselftest: arm64: extend toplevel skeleton Makefile
Date: Wed, 9 Oct 2019 12:52:14 +0100 [thread overview]
Message-ID: <9acb0be8-512f-5e32-8dc7-1dd9534dc3fb@arm.com> (raw)
In-Reply-To: <20191009111513.GA27757@arm.com>
On 09/10/2019 12:15, Dave Martin wrote:
> On Wed, Oct 09, 2019 at 09:26:00AM +0100, Cristian Marussi wrote:
>> Modify KSFT arm64 toplevel Makefile to maintain arm64 kselftests organized
>> by subsystem, keeping them into distinct subdirectories under arm64 custom
>> KSFT directory: tools/testing/selftests/arm64/
>>
>> Add to such toplevel Makefile a mechanism to guess the effective location
>> of Kernel headers as installed by KSFT framework.
>>
>> Fit existing arm64 tags kselftest into this new schema moving them into
>> their own subdirectory (arm64/tags).
>>
>> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
>> ---
>> Based on:
>> commit 9ce1263033cd ("selftests, arm64: add a selftest for passing
>> tagged pointers to kernel")
>> ---
>> v6 --> v7
>> - renamed SUBTARGETS to ARM64_SUBTARGETS to avoid name clashes
>> - rebased on v5.4-rc2 accounting for further new patches on top of commit 9ce1263033cd
>> v5 --> v6
>> - using realpath to avoid passing down relative paths
>> - fix commit msg & Copyright
>> - removed unneded Makefile export
>> - added SUBTARGETS specification, to allow building specific only some
>> arm64 test subsystems
>> v4 --> v5
>> - rebased on arm64/for-next/core
>> - merged this patch with KSFT arm64 tags patch, while moving the latter
>> into its own subdir
>> - moved kernel header includes search mechanism from KSFT arm64
>> SIGNAL Makefile
>> - export proper top_srcdir ENV for lib.mk
>> v3 --> v4
>> - comment reword
>> - simplified documentation in README
>> - dropped README about standalone
>> ---
>> tools/testing/selftests/Makefile | 1 +
>> tools/testing/selftests/arm64/Makefile | 64 +++++++++++++++++--
>> tools/testing/selftests/arm64/README | 25 ++++++++
>> tools/testing/selftests/arm64/tags/Makefile | 7 ++
>> .../arm64/{ => tags}/run_tags_test.sh | 0
>> .../selftests/arm64/{ => tags}/tags_test.c | 0
>> 6 files changed, 92 insertions(+), 5 deletions(-)
>> create mode 100644 tools/testing/selftests/arm64/README
>> create mode 100644 tools/testing/selftests/arm64/tags/Makefile
>> rename tools/testing/selftests/arm64/{ => tags}/run_tags_test.sh (100%)
>> rename tools/testing/selftests/arm64/{ => tags}/tags_test.c (100%)
>
> Do you need to move the tags_test line in arm64/.gitignore to
> arm64/tags/.gitignore?
>
Damn...I've not spotted that since it works anyway. I'll fix in v9.
Cristian
> With that change, FWIW:
>
> Reviewed-by: Dave Martin <Dave.Martin@arm.com>
>
> (i.e., this looks reasonable, but I'm not a kselftest expert...)
>
> [...]
>
> Cheers
> ---Dave
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-09 11:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 8:25 [PATCH v8 00/12] Add arm64/signal initial kselftest support Cristian Marussi
2019-10-09 8:26 ` [PATCH v8 01/12] kselftest: arm64: extend toplevel skeleton Makefile Cristian Marussi
2019-10-09 11:15 ` Dave Martin
2019-10-09 11:52 ` Cristian Marussi [this message]
2019-10-09 8:26 ` [PATCH v8 02/12] kselftest: arm64: mangle_pstate_invalid_compat_toggle and common utils Cristian Marussi
2019-10-09 11:18 ` Dave Martin
2019-10-09 11:55 ` Cristian Marussi
2019-10-09 8:26 ` [PATCH v8 03/12] kselftest: arm64: mangle_pstate_invalid_daif_bits Cristian Marussi
2019-10-09 8:26 ` [PATCH v8 04/12] kselftest: arm64: mangle_pstate_invalid_mode_el[123][ht] Cristian Marussi
2019-10-09 8:26 ` [PATCH v8 05/12] kselftest: arm64: extend test_init functionalities Cristian Marussi
2019-10-09 11:32 ` Dave Martin
2019-10-09 11:57 ` Cristian Marussi
2019-10-09 8:26 ` [PATCH v8 06/12] kselftest: arm64: add helper get_current_context Cristian Marussi
2019-10-09 11:32 ` Dave Martin
2019-10-09 11:57 ` Cristian Marussi
2019-10-09 8:26 ` [PATCH v8 07/12] kselftest: arm64: fake_sigreturn_bad_magic Cristian Marussi
2019-10-09 8:26 ` [PATCH v8 08/12] kselftest: arm64: fake_sigreturn_bad_size_for_magic0 Cristian Marussi
2019-10-09 8:26 ` [PATCH v8 09/12] kselftest: arm64: fake_sigreturn_missing_fpsimd Cristian Marussi
2019-10-09 8:26 ` [PATCH v8 10/12] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Cristian Marussi
2019-10-09 8:26 ` [PATCH v8 11/12] kselftest: arm64: fake_sigreturn_bad_size Cristian Marussi
2019-10-09 8:26 ` [PATCH v8 12/12] kselftest: arm64: fake_sigreturn_misaligned_sp Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9acb0be8-512f-5e32-8dc7-1dd9534dc3fb@arm.com \
--to=cristian.marussi@arm.com \
--cc=Dave.Martin@arm.com \
--cc=amit.kachhap@arm.com \
--cc=andreyknvl@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).