From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B420C43381 for ; Mon, 1 Apr 2019 12:47:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 070F120883 for ; Mon, 1 Apr 2019 12:47:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BSvLnbWv"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="QFqOfUxH"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="DXbA+KoZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 070F120883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LRlQl/UMjmgUpAVrpHINSRscS4KkkbwOXKGyfw1W2uM=; b=BSvLnbWvrMNfM005RXucQ786h W8xGdh4Iy1hjnZI17zsI5cQSkZRM1bAAwD+Xv3WMRQBfdx5EO1njMk+baaVb7f+OrXyV/QQMjFn2x hBPrQzmfpZAuUHQOOo0WowLKDwE8PBv0hYFJhqkIHWXTu1T1fPvh7MNLhJbgju1JU8//+OeDPcsxT hVtEoM7QOs5+Pn9ZJ0GKfIKa4BfptZcJlCEO65Yy8JZ5/HWCUacjZFPdHjXe6lKgTwOPX3HGkNHQb ra2GfqaCqI6eIBhde8fb/B2Xh8rmgimcURudJoCF/kBVUJX0OdabZEbxHPmhbnTXTFzw/PtR4d9zY QOGSirZXQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAwLK-0006re-NZ; Mon, 01 Apr 2019 12:47:14 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAwLI-0006rK-6O for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 12:47:13 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5F5306079C; Mon, 1 Apr 2019 12:47:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554122831; bh=iO570D9c/SeXl1+zXFPXhz4P9wddi3r2e2pcW4ldUsQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=QFqOfUxHVWB1ZRMmkB3gn7Vv32DyvjTPzJ8p0fEHvppuXlyRbnJWba5BbaZpX2+q9 e70YmSf//x+KOyPveJudeMzhP55keSx2SojVMI593wtHfngln654WHqVbb9UOrxJAI DjJqwyVJvYfaTvqxmmqR/atKd9AiZKlh95id1cTE= Received: from [10.204.79.83] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mojha@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id BF77060452; Mon, 1 Apr 2019 12:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554122830; bh=iO570D9c/SeXl1+zXFPXhz4P9wddi3r2e2pcW4ldUsQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=DXbA+KoZKVqVf4fN9kxVMkc7xbJbGs4337+sen+dUy36RLCihgwtbxqoOps3zabhL +FUVgUGcdl8dJzBj2oOiyu3RFM6Y6gCXmiCnCF7tna+VT3Aqu2jroWhvLq6FxVUuyJ oPsqASovMKYnNgmniKb9hteSjIrDLJz3tvI+L/e4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BF77060452 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mojha@codeaurora.org Subject: Re: [PATCH 12/12] drivers: firmware: psci: add missing of_node_put after of_device_is_available To: Julia Lawall , Mark Rutland References: <1550928043-14889-1-git-send-email-Julia.Lawall@lip6.fr> <1550928043-14889-13-git-send-email-Julia.Lawall@lip6.fr> From: Mukesh Ojha Message-ID: <9b159e80-1ad2-0254-9543-852e1d7f04f9@codeaurora.org> Date: Mon, 1 Apr 2019 18:17:03 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1550928043-14889-13-git-send-email-Julia.Lawall@lip6.fr> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_054712_271612_7D4EEBFA X-CRM114-Status: GOOD ( 18.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/23/2019 6:50 PM, Julia Lawall wrote: > Add an of_node_put when a tested device node is not available. > > The semantic patch that fixes this problem is as follows > (http://Reviewed-by: Mukesh Ojha > > Cheers, > -Mukesh.lip6.fr): > > // > @@ > identifier f; > local idexpression e; > expression x; > @@ > > e = f(...); > ... when != of_node_put(e) > when != x = e > when != e = x > when any > if (<+...of_device_is_available(e)...+>) { > ... when != of_node_put(e) > ( > return e; > | > + of_node_put(e); > return ...; > ) > } > // > > Fixes: d09a0011ec0d5 ("drivers: psci: Allow PSCI node to be disabled") > Signed-off-by: Julia Lawall Reviewed-by: Mukesh Ojha Cheers, -Mukesh > > --- > drivers/firmware/psci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff -u -p a/drivers/firmware/psci.c b/drivers/firmware/psci.c > --- a/drivers/firmware/psci.c > +++ b/drivers/firmware/psci.c > @@ -677,8 +677,10 @@ int __init psci_dt_init(void) > > np = of_find_matching_node_and_match(NULL, psci_of_match, &matched_np); > > - if (!np || !of_device_is_available(np)) > + if (!np || !of_device_is_available(np)) { > + of_node_put(np); > return -ENODEV; > + } > > init_fn = (psci_initcall_t)matched_np->data; > return init_fn(np); > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel