From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B13B8C433DF for ; Mon, 29 Jun 2020 20:04:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81B1F206A5 for ; Mon, 29 Jun 2020 20:04:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="09pQ5+X7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81B1F206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sQiAngwnGx2J7A0gL8K4WhUJHQTd9/+cVytQO0Hr6dQ=; b=09pQ5+X7TPMNICLVBaNwWyEPV 7F5CA7XgRlbh+cgQKS82cyTSBP+SAZ/g5z6fIkSHsQCKYpFtGNPbszm9Xj41suhlcK8ZNVzkQRYYq pisfsDQG4ZkTvcelvk6weWmfQQ6jtDCH5Jca+SacuLMydZnQYyg38HX7wfMgIfI2utaq3bsgtSLjj MtH58TfIb3XfMDhlF0vL5cF1g+cJar/DBAqrKferI2Wyg0F9q3kVSWp5XFlCocHVCkN9kXgC9XBf8 S83HfhYvnUG6qnyEcKL6CmUlPOQFR0qAKYpCZdPbk/P9qoY8jX+bo3BYxKRlsZvvPU0wvPvYUc1nj 2hVBP0Z8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpzzv-00020C-2d; Mon, 29 Jun 2020 20:03:23 +0000 Received: from smtprelay0186.hostedemail.com ([216.40.44.186] helo=smtprelay.hostedemail.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpzzs-0001yi-IS for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 20:03:21 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id F14C2100E7B45; Mon, 29 Jun 2020 20:03:16 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: cough56_6201ffd26e72 X-Filterd-Recvd-Size: 2768 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA; Mon, 29 Jun 2020 20:03:13 +0000 (UTC) Message-ID: <9b7f9c3aed7223e49def6e775d3b250aa780e562.camel@perches.com> Subject: Re: [PATCH v4 08/17] arm64/mm: Remove needless section quotes From: Joe Perches To: Nick Desaulniers , Kees Cook Date: Mon, 29 Jun 2020 13:03:12 -0700 In-Reply-To: References: <20200629061840.4065483-1-keescook@chromium.org> <20200629061840.4065483-9-keescook@chromium.org> User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch , linux-efi , Arnd Bergmann , Peter Collingbourne , Catalin Marinas , Masahiro Yamada , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Russell King , LKML , Nathan Chancellor , clang-built-linux , Arvind Sankar , Ingo Molnar , James Morse , Thomas Gleixner , Borislav Petkov , Will Deacon , Ard Biesheuvel , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-06-29 at 12:53 -0700, Nick Desaulniers wrote: > On Sun, Jun 28, 2020 at 11:18 PM Kees Cook wrote: > > Fix a case of needless quotes in __section(), which Clang doesn't like. > > > > Acked-by: Will Deacon > > Signed-off-by: Kees Cook > > Yep, I remember bugs from this. Probably should scan the kernel for > other instances of this. +Joe for checkpatch.pl validation. > Reviewed-by: Nick Desaulniers $ git grep -P -n '__section\s*\(\s*\"' arch/arm64/mm/mmu.c:45:u64 __section(".mmuoff.data.write") vabits_actual; include/linux/compiler.h:211: __section("___kentry" "+" #sym ) \ include/linux/export.h:133: static int __ksym_marker_##sym[0] __section(".discard.ksym") __used include/linux/srcutree.h:127: __section("___srcu_struct_ptrs") = &name My recollection is I submitted a patch to _add_ quotes https://lore.kernel.org/patchwork/patch/1125785/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel