From: Michal Simek <michal.simek@amd.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>,
"Kannan, Arun Balaji" <arun.balaji.kannan@amd.com>,
"Mutthareddyvari,
Jyotheeswar Reddy" <jyotheeswar.reddy.mutthareddyvari@amd.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, <git@xilinx.com>,
<saikrishna12468@gmail.com>
Subject: Re: [PATCH 0/4] pinctrl: pinctrl-zynqmp: Add tri-state configuration support
Date: Thu, 29 Sep 2022 09:08:26 +0200 [thread overview]
Message-ID: <9b7fac69-265e-52f2-21e4-83d9da0f257b@amd.com> (raw)
In-Reply-To: <YzR5ZoAbaYONnmPS@pendragon.ideasonboard.com>
Hi Laurent,
On 9/28/22 18:42, Laurent Pinchart wrote:
>
> On Wed, Sep 28, 2022 at 06:58:10PM +0300, Laurent Pinchart wrote:
>> Hi Sai,
>>
>> On Fri, Jun 17, 2022 at 04:16:55PM +0530, Sai Krishna Potthuri wrote:
>>> This series update the Xilinx firmware, ZynqMP dt-binding and ZynqMP
>>> pinctrl driver to handle 'output-enable' and 'bias-high-impedance'
>>> configurations. As part of these configurations, ZynqMP pinctrl driver
>>> takes care of pin tri-state setting.
>>> Also fix the kernel doc warning in ZynqMP pinctrl driver.
>>
>> I'm afraid this causes a regression :-( With this series applied, boot
>> breaks with the following message being printed to the serial console:
>>
>> Received exception
>> MSR: 0x200, EAR: 0xFF180198, EDR: 0x0, ESR: 0x64
>>
>> I've traced that to the probe of the UART, when it calls into the
>> firmware to set pin MIO18 to high impedance. According to v1.7 of the
>> ZynqMP registers reference (UG1087), there is no register at address
>> 0xFF180198.
>>
>> I am using the VCU TRD 2021.1 for testing. Does this series require a
>> firmware update ? If so backward compatibility needs to be preserved.
>> It's very late in the v6.0-rc cycle for a fix, a revert may be best at
>> this point, to give us time to fix the issue properly.
>
> I've now tested the VCU TRD 2022.1 (which AFAIK is the latest available
> version), and the problem doesn't occue then. It thus seems this depends
> on a firmware update, which is impractical at best for all old designs
> :-(
That's correct observation. Supporting these two properties requires newer pmufw
or that message is received.
I will let Arun and Jyotheeswar to comment it. I don't think there is a way to
detect which firmware has implementation for it available.
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-29 7:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 10:46 [PATCH 0/4] pinctrl: pinctrl-zynqmp: Add tri-state configuration support Sai Krishna Potthuri
2022-06-17 10:46 ` [PATCH 1/4] firmware: xilinx: Add configuration values for tri-state Sai Krishna Potthuri
2022-06-17 10:46 ` [PATCH 2/4] dt-bindings: pinctrl-zynqmp: Add output-enable configuration Sai Krishna Potthuri
2022-06-27 23:01 ` Rob Herring
2022-06-17 10:46 ` [PATCH 3/4] pinctrl: pinctrl-zynqmp: Add support for output-enable and bias-high-impedance Sai Krishna Potthuri
2022-06-17 10:46 ` [PATCH 4/4] pinctrl: pinctrl-zynqmp: Fix kernel-doc warning Sai Krishna Potthuri
2022-06-28 8:30 ` [PATCH 0/4] pinctrl: pinctrl-zynqmp: Add tri-state configuration support Linus Walleij
2022-09-28 15:58 ` Laurent Pinchart
2022-09-28 16:42 ` Laurent Pinchart
2022-09-29 7:08 ` Michal Simek [this message]
2022-10-12 17:12 ` Kannan, Arun Balaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b7fac69-265e-52f2-21e4-83d9da0f257b@amd.com \
--to=michal.simek@amd.com \
--cc=arun.balaji.kannan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=jyotheeswar.reddy.mutthareddyvari@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=saikrishna12468@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).