From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: linux-arm-kernel@lists.infradead.org, stijn@linux-ipv6.be,
f.fainelli@gmail.com, herbert@gondor.apana.org.au,
sbranden@broadcom.com, rjui@broadcom.com,
linux-kernel@vger.kernel.org, rikard.falkeborn@gmail.com,
bcm-kernel-feedback-list@broadcom.com,
linux-crypto@vger.kernel.org, mpm@selenic.com, ynezz@true.cz,
nsaenzjulienne@suse.de, linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] hwrng: bcm2835: set quality to 1000
Date: Sat, 20 Feb 2021 20:12:45 +0100 [thread overview]
Message-ID: <9b86c773-7153-1e18-472a-f66b01c83173@gmail.com> (raw)
In-Reply-To: <YDFeao/bOxvoXI9D@lunn.ch>
Hi Andrew,
I ran rngtest and this is what I got:
root@OpenWrt:/# cat /dev/hwrng | rngtest -c 1000
rngtest 6.10
Copyright (c) 2004 by Henrique de Moraes Holschuh
This is free software; see the source for copying conditions. There is
NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.
rngtest: starting FIPS tests...
rngtest: bits received from input: 20000032
rngtest: FIPS 140-2 successes: 996
rngtest: FIPS 140-2 failures: 4
rngtest: FIPS 140-2(2001-10-10) Monobit: 0
rngtest: FIPS 140-2(2001-10-10) Poker: 0
rngtest: FIPS 140-2(2001-10-10) Runs: 1
rngtest: FIPS 140-2(2001-10-10) Long run: 3
rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
rngtest: input channel speed: (min=146.002; avg=349.394;
max=1302083.333)Kibits/s
rngtest: FIPS tests speed: (min=12.126; avg=22.750; max=23.432)Mibits/s
rngtest: Program run time: 56826982 microseconds
996 successes and 4 failures -> 99.6% success rate
1024 * 99.6% = 1019 (rounded down to 1000)
I'm not sure if I can rely on rngtest for that...
Best regards,
Álvaro.
El 20/02/2021 a las 20:09, Andrew Lunn escribió:
> On Sat, Feb 20, 2021 at 06:47:40PM +0100, Álvaro Fernández Rojas wrote:
>> This allows devices without a high precission timer to reduce boot from >100s
>> to <30s.
>> diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c
>> index 1a7c43b43c6b..4b48cb7176b0 100644
>> --- a/drivers/char/hw_random/bcm2835-rng.c
>> +++ b/drivers/char/hw_random/bcm2835-rng.c
>> @@ -163,6 +163,7 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
>> priv->rng.init = bcm2835_rng_init;
>> priv->rng.read = bcm2835_rng_read;
>> priv->rng.cleanup = bcm2835_rng_cleanup;
>> + priv->rng.quality = 1000;
>
> Hi Alvero
>
> * @quality: Estimation of true entropy in RNG's bitstream
> * (in bits of entropy per 1024 bits of input;
> * valid values: 1 to 1024, or 0 for unknown).
>
> How did you determine this device produces 1000 bits of true entropy
> per 1024?
>
> Andrew
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-20 19:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 17:47 [PATCH] hwrng: bcm2835: set quality to 1000 Álvaro Fernández Rojas
2021-02-20 19:09 ` Andrew Lunn
2021-02-20 19:12 ` Álvaro Fernández Rojas [this message]
2021-02-20 19:40 ` Andrew Lunn
2021-03-03 9:20 ` Herbert Xu
2021-03-03 9:29 ` Álvaro Fernández Rojas
2021-03-04 15:11 ` Nicolas Saenz Julienne
2021-03-04 22:28 ` Florian Fainelli
2021-03-05 6:26 ` Álvaro Fernández Rojas
2021-03-12 4:52 ` Florian Fainelli
2021-02-20 19:57 ` [PATCH v2] " Álvaro Fernández Rojas
2021-02-22 19:50 ` [PATCH v3] hwrng: bcm2835: set quality Álvaro Fernández Rojas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b86c773-7153-1e18-472a-f66b01c83173@gmail.com \
--to=noltari@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mpm@selenic.com \
--cc=nsaenzjulienne@suse.de \
--cc=rikard.falkeborn@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stijn@linux-ipv6.be \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).