From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8D4C433ED for ; Wed, 14 Apr 2021 16:00:08 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D816E61158 for ; Wed, 14 Apr 2021 16:00:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D816E61158 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eJ34TGN5ce3YY0fJVS48q7jpuMk0yuNjjrbmtNNaSkY=; b=V1tYBN9NxmZiHnwz14eg3ktWt TUlTAaTROWFfrbAmgqkbTh5OBJH5mtk6I4nvXyggMCggRZZudVOh72E5mdJqnG3yS7NGGn9RbhU8S 9BCMRdrmqJ5XQBH1eGHPfDCU+TFx3ZMTpmacxJnnP9uIDtB6JhUuFP/ph/ossXytLuBnu6A77Ub9i /07/H2px5BikdFgIl0xi4rk5In2RY2Gh18dNkuAXd3WBULSdSpXGsn8CnETF22n37k9PDIILqM89u Jryl9F6bavSfkjkADzFFCM1V9e6jcdvrHqCyjZD4UApU5ZdYHKf7oKn0c0qfVO7VdN7MLV7Zk51gN EUXHXBP5g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWhub-00D5Pe-Br; Wed, 14 Apr 2021 15:58:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWhuU-00D5Ny-HL for linux-arm-kernel@desiato.infradead.org; Wed, 14 Apr 2021 15:58:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=xuItTKmz5+Knqt1+vfq/OkDfdneEY+UbE9qRzfYYMnc=; b=cAhQpsusMtuiEwUHl9DO3w7ORR +TxpPD3sNvhOXdiglCu//VmP7CpvDPKg3PSKhfG8TAVUa1R48M64UeMUyuxJS4ZGW+UriXwRCZhBS mw3yfAONGlDggTGC9zVqsQ27B8gY3KxwZKojWbnors7KzF0ycPofDY/LwkpkLJuJSTuEQ3W5HnXqT gPD7w4hA+JLW4Sij0xQJV+wmKy+vFdOWDqg5uMi1zrewjaMbkUOAWKRbLVb58aVkAjy2wZyRKTHFY OSCsDBg/1gtpUs1j0y7tZRYI+hM7cfo++wMuPCA7uL3tt9JDkwU1xx58CfR4kLDv1DwOcLBLzYtrj VAdsIkTw==; Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWhuR-007vYX-NG for linux-arm-kernel@lists.infradead.org; Wed, 14 Apr 2021 15:58:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618415910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xuItTKmz5+Knqt1+vfq/OkDfdneEY+UbE9qRzfYYMnc=; b=gTIh5q2tAD6g1Su6ChtlHQbbygIsjHa5HRSaKxi1fKF8gXZ+RLsOlaQBQZfcrOKN5xPNry DWaqBqJzP7SmlpQI+pDzG+L2p+mMValf3Wozag9tdbtlbzQuv1RKIToj0Df6FPf6EwxaAM vKwlXhD5htSIE409GPPJbwKPz4Uccwo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-578-I3tksEFKNmGiUZXGERrgEA-1; Wed, 14 Apr 2021 11:58:28 -0400 X-MC-Unique: I3tksEFKNmGiUZXGERrgEA-1 Received: by mail-wr1-f72.google.com with SMTP id k1-20020adfd2210000b02901040d1dbcaeso1260150wrh.17 for ; Wed, 14 Apr 2021 08:58:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=xuItTKmz5+Knqt1+vfq/OkDfdneEY+UbE9qRzfYYMnc=; b=K7Lj0+mJRtb41m1nkssTaiwbd2cdyLTF0OJ3cH2s+i112Z7GQDvD9MkdBus8WTt3O6 ycMAuRL3KhLGRhEnHCZucaoryUYlUP9rVrJ44tS5gR0vRA/rN93Ferni9dcCegg7LyjL 8I2UTFf74Yjvy0+CRY2h4IASddbsbniR7vjEbBAJTfeEzAwGMYQYc5S2Einb84SNVEke WtnVgGWBQsxv5XYJY7iYLUAWk9jsvnY5+gcYfCyqrCJc5rOj2KhVKg25nP+hWNuuydac 9FxnsT8XTlvP4kAyBzWjKgv6YYfZbi8nwBbp6mBwq3b8ZhbeIVvakvrVgYWId+s0b5Jn aE8A== X-Gm-Message-State: AOAM533Kxp0ACSTvLXCPwff6I3PIrx7kGdWyyu9MYmWLqFodbBkB3YUm qRMOVo34DWwsIbS0PT/N5U30i0cU16UahROVGvqD/UuvL0Y7IBEvXOaiqWdUP+LGK9s36Bjm0O4 q7jKVxOopDn5y5AtG9hKyMVshNHcmPhUcnL0= X-Received: by 2002:a5d:4689:: with SMTP id u9mr8195038wrq.10.1618415907425; Wed, 14 Apr 2021 08:58:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGqSCJM5+og5DryDMutS2KeHgtQzF2BtH5xs7DH3i6DfTgoCDlW4C+HHfPtOlPuTkx6JlsgA== X-Received: by 2002:a5d:4689:: with SMTP id u9mr8195011wrq.10.1618415907152; Wed, 14 Apr 2021 08:58:27 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6470.dip0.t-ipconnect.de. [91.12.100.112]) by smtp.gmail.com with ESMTPSA id y31sm5805675wmp.46.2021.04.14.08.58.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Apr 2021 08:58:26 -0700 (PDT) Subject: Re: [RFC/RFT PATCH 2/3] arm64: decouple check whether pfn is normal memory from pfn_valid() To: Anshuman Khandual , Mike Rapoport , linux-arm-kernel@lists.infradead.org Cc: Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210407172607.8812-1-rppt@kernel.org> <20210407172607.8812-3-rppt@kernel.org> <4a788546-b854-fd35-644a-f1d9075a9a78@arm.com> From: David Hildenbrand Organization: Red Hat Message-ID: <9c0956f0-494e-5c6b-bdc2-d4213afd5e2f@redhat.com> Date: Wed, 14 Apr 2021 17:58:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <4a788546-b854-fd35-644a-f1d9075a9a78@arm.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210414_085831_864736_456E380F X-CRM114-Status: GOOD ( 22.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08.04.21 07:14, Anshuman Khandual wrote: > > On 4/7/21 10:56 PM, Mike Rapoport wrote: >> From: Mike Rapoport >> >> The intended semantics of pfn_valid() is to verify whether there is a >> struct page for the pfn in question and nothing else. > > Should there be a comment affirming this semantics interpretation, above the > generic pfn_valid() in include/linux/mmzone.h ? > >> >> Yet, on arm64 it is used to distinguish memory areas that are mapped in the >> linear map vs those that require ioremap() to access them. >> >> Introduce a dedicated pfn_is_memory() to perform such check and use it >> where appropriate. >> >> Signed-off-by: Mike Rapoport >> --- >> arch/arm64/include/asm/memory.h | 2 +- >> arch/arm64/include/asm/page.h | 1 + >> arch/arm64/kvm/mmu.c | 2 +- >> arch/arm64/mm/init.c | 6 ++++++ >> arch/arm64/mm/ioremap.c | 4 ++-- >> arch/arm64/mm/mmu.c | 2 +- >> 6 files changed, 12 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h >> index 0aabc3be9a75..7e77fdf71b9d 100644 >> --- a/arch/arm64/include/asm/memory.h >> +++ b/arch/arm64/include/asm/memory.h >> @@ -351,7 +351,7 @@ static inline void *phys_to_virt(phys_addr_t x) >> >> #define virt_addr_valid(addr) ({ \ >> __typeof__(addr) __addr = __tag_reset(addr); \ >> - __is_lm_address(__addr) && pfn_valid(virt_to_pfn(__addr)); \ >> + __is_lm_address(__addr) && pfn_is_memory(virt_to_pfn(__addr)); \ >> }) >> >> void dump_mem_limit(void); >> diff --git a/arch/arm64/include/asm/page.h b/arch/arm64/include/asm/page.h >> index 012cffc574e8..32b485bcc6ff 100644 >> --- a/arch/arm64/include/asm/page.h >> +++ b/arch/arm64/include/asm/page.h >> @@ -38,6 +38,7 @@ void copy_highpage(struct page *to, struct page *from); >> typedef struct page *pgtable_t; >> >> extern int pfn_valid(unsigned long); >> +extern int pfn_is_memory(unsigned long); >> >> #include >> >> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c >> index 8711894db8c2..ad2ea65a3937 100644 >> --- a/arch/arm64/kvm/mmu.c >> +++ b/arch/arm64/kvm/mmu.c >> @@ -85,7 +85,7 @@ void kvm_flush_remote_tlbs(struct kvm *kvm) >> >> static bool kvm_is_device_pfn(unsigned long pfn) >> { >> - return !pfn_valid(pfn); >> + return !pfn_is_memory(pfn); >> } >> >> /* >> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c >> index 3685e12aba9b..258b1905ed4a 100644 >> --- a/arch/arm64/mm/init.c >> +++ b/arch/arm64/mm/init.c >> @@ -258,6 +258,12 @@ int pfn_valid(unsigned long pfn) >> } >> EXPORT_SYMBOL(pfn_valid); >> >> +int pfn_is_memory(unsigned long pfn) >> +{ >> + return memblock_is_map_memory(PFN_PHYS(pfn)); >> +} >> +EXPORT_SYMBOL(pfn_is_memory);> + > > Should not this be generic though ? There is nothing platform or arm64 > specific in here. Wondering as pfn_is_memory() just indicates that the > pfn is linear mapped, should not it be renamed as pfn_is_linear_memory() > instead ? Regardless, it's fine either way. TBH, I dislike (generic) pfn_is_memory(). It feels like we're mixing concepts. NOMAP memory vs !NOMAP memory; even NOMAP is some kind of memory after all. pfn_is_map_memory() would be more expressive, although still sub-optimal. We'd actually want some kind of arm64-specific pfn_is_system_memory() or the inverse pfn_is_device_memory() -- to be improved. -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel