From: Johan Jonker <jbx6244@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, heiko@sntech.de
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
"Lin Huang" <hl@rock-chips.com>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
"Gaël PORTAY" <gael.portay@collabora.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Helen Koike" <helen.koike@collabora.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jacob Chen" <jacob2.chen@rock-chips.com>,
"Shunqian Zheng" <zhengsq@rock-chips.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Boris Brezillon" <boris.brezillon@collabora.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v5 2/4] arm64: dts: rk3399: Add dfi and dmc nodes.
Date: Tue, 9 Mar 2021 12:42:40 +0100 [thread overview]
Message-ID: <9c36893a-6ca8-dade-e203-890a4071bf50@gmail.com> (raw)
In-Reply-To: <20210308233858.24741-2-daniel.lezcano@linaro.org>
Hi Daniel,
Some comments. Have a look if it's useful or that you disagree with.
New nodes should be verifiable if possible.
Especially with so many properties.
Could you convert rockchip-dfi.txt and rk3399_dmc.txt to yaml instead of
changing old txt documents?
Add rockchip-dfi.yaml and rk3399_dmc.yaml before this patch in version 6.
Nodes and properties have a sort order. Please fix.
Some goes for [RESEND PATCH v5 3/4].
(This is a generic dtsi. How about cooling and dmc ??)
----
Heiko rules:
compatible
reg
interrupts
[alphabetical]
status [if needed]
----
My incomplete list:
For nodes:
If exists on top: model, compatible and chosen.
Sort things without reg alphabetical first,
then sort the rest by reg address.
Inside nodes:
If exists on top: compatible, reg and interrupts.
In alphabetical order the required properties.
Then in alphabetical order the other properties.
And as last things that start with '#' in alphabetical order.
Add status below all other properties for soc internal components with
any board-specifics.
Keep an empty line between properties and nodes.
Exceptions:
Sort pinctrl-0 above pinctrl-names, so it stays in line with clock-names
and dma-names.
Sort simple-audio-card,name above other simple-audio-card properties.
Sort regulator-name above other regulator properties.
Sort regulator-min-microvolt above regulator-max-microvolt.
On 3/9/21 12:38 AM, Daniel Lezcano wrote:
> From: Lin Huang <hl@rock-chips.com>
>
> These are required to support DDR DVFS on rk3399 platform.
>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Signed-off-by: Gaël PORTAY <gael.portay@collabora.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index edbbf35fe19e..6f23d99236fe 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1937,6 +1937,25 @@
> status = "disabled";
> };
>
> + dfi: dfi@ff630000 {
> + reg = <0x00 0xff630000 0x00 0x4000>;
> + compatible = "rockchip,rk3399-dfi";
> + rockchip,pmu = <&pmugrf>;
> + interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&cru PCLK_DDR_MON>;
> + clock-names = "pclk_ddr_mon";
> + status = "disabled";
> + };
> +
> + dmc: dmc {
> + compatible = "rockchip,rk3399-dmc";
> + rockchip,pmu = <&pmugrf>;
> + devfreq-events = <&dfi>;
> + clocks = <&cru SCLK_DDRC>;
> + clock-names = "dmc_clk";
> + status = "disabled";
> + };
> +
> pinctrl: pinctrl {
> compatible = "rockchip,rk3399-pinctrl";
> rockchip,grf = <&grf>;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-09 11:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210308234058epcas1p43f00b9dcc3ea75e758ae2cf9a35d36ac@epcas1p4.samsung.com>
2021-03-08 23:38 ` [RESEND PATCH v5 1/4] dt-bindings: devfreq: rk3399_dmc: Add rockchip, pmu phandle Daniel Lezcano
2021-03-08 23:38 ` [RESEND PATCH v5 2/4] arm64: dts: rk3399: Add dfi and dmc nodes Daniel Lezcano
2021-03-09 11:42 ` Johan Jonker [this message]
2021-03-11 11:58 ` Daniel Lezcano
2021-03-11 12:05 ` Daniel Lezcano
2021-03-08 23:38 ` [RESEND PATCH v5 3/4] arm64: dts: rockchip: Enable dmc and dfi nodes on gru Daniel Lezcano
2021-03-08 23:38 ` [RESEND PATCH v5 4/4] dt-bindings: devfreq: rk3399_dmc: Remove references of unexistant defines Daniel Lezcano
2021-03-09 10:16 ` Chanwoo Choi
2021-03-08 23:42 ` [RESEND PATCH v5 1/4] dt-bindings: devfreq: rk3399_dmc: Add rockchip,pmu phandle Daniel Lezcano
2021-03-09 10:15 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c36893a-6ca8-dade-e203-890a4071bf50@gmail.com \
--to=jbx6244@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=gael.portay@collabora.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=hl@rock-chips.com \
--cc=jacob2.chen@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=wens@csie.org \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).