From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C27FC43460 for ; Fri, 14 May 2021 08:52:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD8C7613DF for ; Fri, 14 May 2021 08:52:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD8C7613DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:CC:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=be6JoIyGshXQC9YRzUSoopwNv3jTe3nJ/t5VDkOF9mQ=; b=WxUvJzFdSABFWMvM0af7gpNzx iO8KEpwLq4l/3ouqLNLM3uHAfTaRoBjjgw3WTAvxr756dLTv92IMGWPUtxDmccedYZOpSC8eguvyt 50wbhKtbTMPLTdIpts0PdN0DjFASSHEXdlup+SOBn0rsBwKi6jb1dmNVbkxf9soxoTdSDTU01XGGU 2ktMAiXfpvrqunQeVhGO/tHdN16Qns1N+CjqZl/+sIA4LdsHFkvHF2tfz0DJqElTC779dLntu++P9 RvUKYGmHySgVihfC+iP4AOR3ef81BM7fAhsoBkUJwjmCJCyy2jcP++GB/iDTKuJV2UdpIe/TFt2uW clVDFpBwA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhTX1-007YMj-BP; Fri, 14 May 2021 08:50:51 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhTWy-007YMX-EY for linux-arm-kernel@desiato.infradead.org; Fri, 14 May 2021 08:50:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:Subject:From:References :CC:To:Sender:Reply-To:Content-ID:Content-Description; bh=r39krYKCqV9rgP8FRk9VFNcwUh3QYOl4Mo+kp8DPhs8=; b=C8YGW34Q7YAc9HOMaPNxxjpPWR S6GPMxcpXSA3EulX+5NNH5kLZZ+J0gNziHPTUesCMikFr+HjQMGGDSc/ZhLJuLmI8fpBnqmou1W7j WhyGan+cFK7xSKNHLcoSZoJqS7CaWkPwIQzowZRqv19TNKu1oZoKR0g/xOJr4ln/aKmqMZ94KsZMT VZZY1kz5N7bWgZ86DSx60lh+pgIv7BPjg9T0obQyCSYwbJ/0BhyG+8qmebwOPrwOGQkORbmxBOiLc 3ugUcsxVe9lH68wuR4QroujUX0Phpt1kMj/nxZh8YYlLIuptGW2QbpI2jtyV+0ADSc+lGbDYQk0yQ k4gBDWVw==; Received: from mail-bn8nam12on2047.outbound.protection.outlook.com ([40.107.237.47] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhTWv-00Bpgy-Fg for linux-arm-kernel@lists.infradead.org; Fri, 14 May 2021 08:50:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dZr+6xJPGswucVKes87/OC2b217oUHGVB0qjiM7JaqBkMy32BiEOuATFXPE0Kh0mqsF6ZOF915diRDK733DIG6LmKt8ySb6c4AiZQvBK1mCGJFE1zl9hGZpQVHTpDrp1VzffW62hcRxHSS0ZE5zxvgRFLyuCmgmIC9Z3WgUIYyG9xaP0a4HTK1GM/1wz8SlnnYaw+xLmHONjQV8dxSmaTqXNMtQ/8ZqsAq3/L6L/Oc4v40gzLiBGfS69FwbaOTdhfQhQI3ipbX3rRObZJgW/i1NRZ8DdIhFE/icNKHoNWCOm3cYQ2oOPrNugxxau6RXp8lM/Di7Uyt9dbI9GLIK9Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r39krYKCqV9rgP8FRk9VFNcwUh3QYOl4Mo+kp8DPhs8=; b=TQRsRSSzizqLTh8upo/y+m9Y8aeq1A/LncUQll5/2bHOuwTeSGsNWyE5AseiVKfssp42NpTFid+cSu3G3QguzHDpW5ujmd4hzimWnN2H9ZS6Py9FnVYZ5ZYzIcTObstjkL573WrRpHng3n/0ePPEjY6OySs9HDa/X5fxoHswvLKhze9MfVY0yNRYivp6a06KXxzeuYe2oBT0HzNyXYaTqEkHvUcY5AjoCnFijgTWO9L5Bz6VcKSX9CwIU0mANkCvbAnlcSQ5OezsOmTUYn9bnlwE/IWjp61v5mt0OR9mbWJpsKZZckJsZVkw3I9Q3jJGBBB7utpZR7LEu+ls9kQclg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r39krYKCqV9rgP8FRk9VFNcwUh3QYOl4Mo+kp8DPhs8=; b=njWU7tiqv4xlpdA9d02YWg5vgdrFBhrToiEmlJbUPyndBlfqFq/42VriTRdLdgeFTRYW58i91g5vhLTYR02IOKfy3ZP57R/2iURPGOKsM8EEC81kYPPShloTVrF1hnikBGxFXZQLOKYX2AAj2LcZahz0XlcpyTGnfYDjz+rwoiQ= Received: from SN7PR04CA0117.namprd04.prod.outlook.com (2603:10b6:806:122::32) by BYAPR02MB5976.namprd02.prod.outlook.com (2603:10b6:a03:126::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Fri, 14 May 2021 08:50:40 +0000 Received: from SN1NAM02FT0054.eop-nam02.prod.protection.outlook.com (2603:10b6:806:122:cafe::d6) by SN7PR04CA0117.outlook.office365.com (2603:10b6:806:122::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Fri, 14 May 2021 08:50:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0054.mail.protection.outlook.com (10.97.4.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4129.27 via Frontend Transport; Fri, 14 May 2021 08:50:40 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 14 May 2021 01:50:39 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Fri, 14 May 2021 01:50:39 -0700 Received: from [172.30.17.109] (port=48736) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1lhTWp-0003m1-BM; Fri, 14 May 2021 01:50:39 -0700 To: Rob Herring , Sean Anderson CC: Linux PWM List , , Michal Simek , Alvaro Gamez , "linux-kernel@vger.kernel.org" , linux-arm-kernel References: <20210511191239.774570-1-sean.anderson@seco.com> <20210513021631.GA878860@robh.at.kernel.org> <70176596-2250-8ae1-912a-9f9c30694e7d@seco.com> From: Michal Simek Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: Add Xilinx AXI Timer Message-ID: <9cf3a580-e4d3-07fc-956f-dc5c84802d93@xilinx.com> Date: Fri, 14 May 2021 10:50:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c9bc8903-c8f8-4746-7434-08d916b559fa X-MS-TrafficTypeDiagnostic: BYAPR02MB5976: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C423qjS67oYh7RzhdAnZw/AmKY0bRMS38cEoHhAbA5u9N4wchnhyOwWAE9SKE+KicNMrRacjYlExnhSoNEs4U5CZARin98QBLIPesKNAI75Kskybm+4qJguWroGwTJme6F753G67HhvFDHF/fYE90AReODhhArLGsWqDHLXNYlS5UK/jDabSgkx3PsIP0hZ0HpqtuFNvtdtQgtpmYz8JKggK4vrEaGE5VJulBc7LXMHlByjZkWerPze0Dz3JAJQXazEMYUB/iNKuOLKiE3cGYRyTQvgC32yo9/ZqX1dzPeduq1ESB+3FU9veta+5qcNcL07/4+m+a0312v+DMhSw9xU8lYzqzIftP9KUr6+iLHAS5DBpAN+HIhecGwBOJztuKgokNjoBgzWLl5IXqRi++Gyw+EI26A8NUsrLovCmK+MJCIsWTYN88tYQni2/unXMRcjksMPtZZJCWNty7MLfusDXOBqQXHp70ClsVc3GcZxuwS4uQwq8v34AIfRP9fuPhMuxFX0HllIcBspGOwT1/IjBwaHUG2zUa6ovobsfJR++bykGcbR3oR3d6Z4JLkeVImDBEQ8DCY1jxH+cUSVxOQz1PPfddqGuePrOr2jnlwDowkpzXZw/Kh7+HC4Fmg8w3bVfVndd7y/Z/RDyOHcVqQ6bNmYeseaMDBsKeJw56ynUwLYiYq4lHbWc0yTIgLfNro1ynOCW8z+KRefPJm/DJw== X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(36860700001)(8936002)(53546011)(426003)(356005)(7636003)(31686004)(44832011)(70206006)(47076005)(5660300002)(4326008)(186003)(70586007)(2616005)(83380400001)(9786002)(8676002)(336012)(498600001)(82310400003)(31696002)(110136005)(2906002)(54906003)(36756003)(36906005)(26005)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2021 08:50:40.3313 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9bc8903-c8f8-4746-7434-08d916b559fa X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0054.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5976 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_015045_567949_251A1D9F X-CRM114-Status: GOOD ( 38.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/13/21 10:43 PM, Rob Herring wrote: > On Thu, May 13, 2021 at 10:28 AM Sean Anderson wrote: >> >> >> >> On 5/13/21 10:33 AM, Sean Anderson wrote: >> > >> > >> > On 5/12/21 10:16 PM, Rob Herring wrote: >> > > On Tue, May 11, 2021 at 03:12:37PM -0400, Sean Anderson wrote: >> > >> This adds a binding for the Xilinx LogiCORE IP AXI Timer. This device is >> > >> a "soft" block, so it has many parameters which would not be >> > >> configurable in most hardware. This binding is usually automatically >> > >> generated by Xilinx's tools, so the names and values of some properties >> > >> must be kept as they are. Replacement properties have been provided for >> > >> new device trees. >> > > >> > > Because you have some tool generating properties is not a reason we have >> > > to accept them upstream. >> > >> > These properties are already in arch/microblaze/boot/dts/system.dts and >> > in the devicetree supplied to Linux by qemu. Removing these properties >> > will break existing setups, which I would like to avoid. > > Already in use in upstream dts files is different than just > 'automatically generated' by vendor tools. > >> > >> > > 'deprecated' is for what *we* have deprecated. >> > >> > Ok. I will remove that then. >> > >> > > >> > > In this case, I don't really see the point in defining new properties >> > > just to have bool. >> > >> > I don't either, but it was requested, by Michal... >> >> Err, your comment on the original bindings was >> >> > Can't all these be boolean? > > With no other context, yes that's what I would ask. Now you've given > me some context, between using the existing ones and 2 sets of > properties to maintain, I choose the former. > >> And Michal commented >> >> > I think in this case you should described what it is used by current >> > driver in Microblaze and these options are required. The rest are by >> > design optional. >> > If you want to change them to different value then current binding >> > should be deprecated and have any transition time with code alignment. >> >> So that is what I tried to accomplish with this revision. I also tried >> allowing something like >> >> xlnx,one-timer-only = <0>; /* two timers */ >> xlnx,one-timer-only = <1>; /* one timer */ >> xlnx,one-timer-only; /* one timer */ >> /* property absent means two timers */ >> >> but I was unable to figure out how to express this with json-schema. I >> don't think it's the best design either... > > json-schema would certainly let you, but generally we don't want > properties to have more than 1 type. One thing is what it is in system.dts file which was committed in 2009 and there are just small alignments there. But none is really using it. Maybe I should just delete it. And this version was generated by Xilinx ancient tools at that time. All parameters there are fully describing HW and they are not changing. Only new one can be added. >From the current microblaze code you can see which properties are really used. reg interrupts xlnx,one-timer-only clocks clock-frequency It means from my point of view these should be listed in the binding. clock-frequency is optional by code when clock is defined. All other properties listed in system.dts are from my perspective optional and that's how it should be. I think DT binding patch should reflect this state as patch itself. And then PWM should be added on the top as separate patch. Note: In past we were using only parameters and name we got from tools but over years we were fine to use for example bool properties and we just aligned Xilinx device tree generator to match it. That's why not a problem to deprecate any property and move to new one. Xilinx DTG is already prepared for it and it is easy to remap it. Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel