linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
@ 2019-11-22 21:44 Leonard Crestez
  2019-11-22 21:45 ` [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks Leonard Crestez
                   ` (5 more replies)
  0 siblings, 6 replies; 25+ messages in thread
From: Leonard Crestez @ 2019-11-22 21:44 UTC (permalink / raw)
  To: Stephen Boyd, Chanwoo Choi, Rob Herring
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, MyungJoo Ham, linux-imx,
	devicetree, linux-pm, Martin Kepplinger, Silvano di Ninno,
	linux-arm-kernel, Dong Aisheng, Anson Huang, Rafael J. Wysocki,
	Kyungmin Park, kernel, Fabio Estevam, Shawn Guo, Georgi Djakov

This adds support for dynamic scaling of the DDR Controller (ddrc)
present on i.MX8M series chips. Actual frequency switching is
implemented inside TF-A, this driver wraps the SMC calls and
synchronizes the clk tree.

DRAM frequency switching requires clock manipulation but during this operation
DRAM itself is briefly inaccessible so this operation is performed a SMC call
to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree
is updated to correspond to hardware configuration.

This is handled via CLK_GET_RATE_NO_CACHE for dividers but muxes are handled
manually: the driver will prepare/enable the new parents ahead of switching (so
that the expected roots are enabled) and afterwards it will call clk_set_parent
to ensure the parents in clock framework are up-to-date.

This series is useful standalone and roughly similar to devfreq drivers for
tegra and rockchip.

Running at lower dram rates saves power but can affect the functionality of
other blocks in the chip (display, vpu etc). Support for in-kernel constraints
will some separately.

This series has no dependencies outside linux-next. The driver depends
on features from the NXP branch of TF-A and will cleanly fail to probe
on mainline. There are also plans to upstream dram dvfs in TF-A.

Changes since v6:
* Replace ARCH_MXC || COMPILE_TEST with ARCH_MXC && HAVE_ARM_SMCCC
* Collect reviews
Link to v6: https://patchwork.kernel.org/cover/11244283/

I'd rather not fix COMPILE_TEST with ifdefs for this driver, if anything
that should be fixed in smccc header. ARCH_MXC doesn't imply SMCCC, it
also covers some very old chips which don't have it.

Resending full series because that's the standard method.

Changes since v5:
* Fix a dram_apb/dram_alt mixup in imx8m_ddrc_set_freq
* Make clk_get_parent_by_index static (kbuild robot)
* Adjust messages in imx8m_ddrc_set_freq
* Use a for loop inside imx8m_ddrc_check_opps instead of while
* More elaborate description in dt-bindings file.
Link to v5: https://patchwork.kernel.org/cover/11240289/

Changes since v4:
* Restore empty _get_dev_status: testing shows this is *NOT* optional. If
absent then switching to simple_ondemand governor will trigger an Oops.
* Keep clk registration on single-line in clk-imx8m* for consistency with rest
of the file.
* Drop explicit "select PM_OPP"
* Check for NULL new_dram_core_parent
* Rename "out_dis_" labels to out_disable_*
* Use dev_warn on imx8m_ddrc_set_freq error paths after SMC call (where
operation is not abandoned).
* More elaborate error messages in imx8m_ddrc_target
* More elaborate checks when fetching clks in imx8m_ddrc_set_freq
* Rename ddrc nodes to memory-controller@* as per devicetree.org "Generic Names
Recommendation"
* Defer perf support, it requires perf changes to fetch PMU by DT
Link to v4: https://patchwork.kernel.org/cover/11235685/

Changes since v3:
* Rename to imx8m-ddrc. Similar blocks are present on imx7d and imx8qxp/imx8qm
but soc integration is different.
* Move dt bindings to /memory-controllers/fsl/
* Fix dt validation issues
* Fix imx8mm.dtsi ddrc referencing ddrc_opp_table which is only defined in evk
* Move opps to child of ddrc device node
* Only add imx_ddrc_get_dev_status in perf patch.
* Adjust print messages
Link to v3: https://patchwork.kernel.org/cover/11221935/

Changes since v2:
* Add support for entire imx8m family including imx8mq B0.
* Also mark dram PLLs as CLK_GET_RATE_NO_CACHE (required for imx8mq b0 low OPP)
* Explicitly update dram pll rate at the end of imx_ddrc_set_freq.
* Use do_div in imx-ddrc (kbuild robot)
* Improve explanations around adding CLK_GET_RATE_NO_CACHE to dram clks.
(Stephen Boyd)
* Handle ddrc devfreq-events earlier for fewer probe defers.
* Validate DDRC opp tables versus firmware: supported OPPs depend on board and
SOC revision.
* Move DDRC opp tables to board dts because they can vary based on ram type on
board.
* Verify DDRC rate is changed in clk tree and otherwise report an error.
* Change imx_ddrc_freq.rate to be measure in MT/s and round down from HZ in
imx_ddrc_find_freq instead.
* Split away from NOC scaling and interconnect support.
Link to v2: https://patchwork.kernel.org/cover/11104113/

Changes since v1:
* bindings: Stop using "contains" for "compatible"
* bindings: Set "additionalProperties: false" and document missing stuff.
* Remove (c) from NXP copyright notice
* Fix various checkpatch issues
* Remove unused dram_alt_root clk from imx-ddrc
Link to v1: https://patchwork.kernel.org/cover/11090649/

Leonard Crestez (5):
  clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
  clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
  dt-bindings: memory: Add bindings for imx8m ddr controller
  PM / devfreq: Add dynamic scaling for imx8m ddr controller
  arm64: dts: imx8m: Add ddr controller nodes

 .../memory-controllers/fsl/imx8m-ddrc.yaml    |  72 +++
 arch/arm64/boot/dts/freescale/imx8mm-evk.dts  |  18 +
 arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  10 +
 .../boot/dts/freescale/imx8mn-ddr4-evk.dts    |  18 +
 arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  10 +
 arch/arm64/boot/dts/freescale/imx8mq-evk.dts  |  24 +
 arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  10 +
 drivers/clk/imx/clk-imx8mm.c                  |  11 +-
 drivers/clk/imx/clk-imx8mn.c                  |  12 +-
 drivers/clk/imx/clk-imx8mq.c                  |  12 +-
 drivers/clk/imx/clk-pll14xx.c                 |   7 +
 drivers/clk/imx/clk.h                         |   1 +
 drivers/devfreq/Kconfig                       |   9 +
 drivers/devfreq/Makefile                      |   1 +
 drivers/devfreq/imx8m-ddrc.c                  | 465 ++++++++++++++++++
 15 files changed, 670 insertions(+), 10 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml
 create mode 100644 drivers/devfreq/imx8m-ddrc.c

-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
  2019-11-22 21:44 [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Leonard Crestez
@ 2019-11-22 21:45 ` Leonard Crestez
  2019-11-25  1:25   ` Stephen Boyd
  2019-12-09  1:15   ` Shawn Guo
  2019-11-22 21:45 ` [PATCH v7 2/5] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE Leonard Crestez
                   ` (4 subsequent siblings)
  5 siblings, 2 replies; 25+ messages in thread
From: Leonard Crestez @ 2019-11-22 21:45 UTC (permalink / raw)
  To: Stephen Boyd, Chanwoo Choi, Rob Herring
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, MyungJoo Ham, linux-imx,
	devicetree, linux-pm, Martin Kepplinger, Silvano di Ninno,
	linux-arm-kernel, Dong Aisheng, Anson Huang, Rafael J. Wysocki,
	Kyungmin Park, kernel, Fabio Estevam, Shawn Guo, Georgi Djakov

These clocks are only modified as part of DRAM frequency switches during
which DRAM itself is briefly inaccessible. The switch is performed with
a SMC call to by TF-A which runs from a SRAM area; upon returning to
linux several clocks bits are modified and we need to update them.

For rate bits an easy solution is to just mark with
CLK_GET_RATE_NOCACHE so that new rates are always read back from
registers.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
---
 drivers/clk/imx/clk-imx8mm.c |  9 +++++++--
 drivers/clk/imx/clk-imx8mn.c | 10 ++++++++--
 drivers/clk/imx/clk-imx8mq.c | 12 ++++++++----
 3 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index ed3ce492151c..1f43e8f6b362 100644
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -440,13 +440,18 @@ static int imx8mm_clocks_probe(struct platform_device *pdev)
 
 	/* IPG */
 	clks[IMX8MM_CLK_IPG_ROOT] = imx_clk_divider2("ipg_root", "ahb", base + 0x9080, 0, 1);
 	clks[IMX8MM_CLK_IPG_AUDIO_ROOT] = imx_clk_divider2("ipg_audio_root", "audio_ahb", base + 0x9180, 0, 1);
 
+	/*
+	 * DRAM clocks are manipulated from TF-A outside clock framework.
+	 * Mark with GET_RATE_NOCACHE to always read div value from hardware
+	 */
+	clks[IMX8MM_CLK_DRAM_ALT] = __imx8m_clk_composite("dram_alt", imx8mm_dram_alt_sels, base + 0xa000, CLK_GET_RATE_NOCACHE);
+	clks[IMX8MM_CLK_DRAM_APB] = __imx8m_clk_composite("dram_apb", imx8mm_dram_apb_sels, base + 0xa080, CLK_IS_CRITICAL | CLK_GET_RATE_NOCACHE);
+
 	/* IP */
-	clks[IMX8MM_CLK_DRAM_ALT] = imx8m_clk_composite("dram_alt", imx8mm_dram_alt_sels, base + 0xa000);
-	clks[IMX8MM_CLK_DRAM_APB] = imx8m_clk_composite_critical("dram_apb", imx8mm_dram_apb_sels, base + 0xa080);
 	clks[IMX8MM_CLK_VPU_G1] = imx8m_clk_composite("vpu_g1", imx8mm_vpu_g1_sels, base + 0xa100);
 	clks[IMX8MM_CLK_VPU_G2] = imx8m_clk_composite("vpu_g2", imx8mm_vpu_g2_sels, base + 0xa180);
 	clks[IMX8MM_CLK_DISP_DTRC] = imx8m_clk_composite("disp_dtrc", imx8mm_disp_dtrc_sels, base + 0xa200);
 	clks[IMX8MM_CLK_DISP_DC8000] = imx8m_clk_composite("disp_dc8000", imx8mm_disp_dc8000_sels, base + 0xa280);
 	clks[IMX8MM_CLK_PCIE1_CTRL] = imx8m_clk_composite("pcie1_ctrl", imx8mm_pcie1_ctrl_sels, base + 0xa300);
diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index d95e282ff1fb..49a05c5576fe 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -428,12 +428,18 @@ static int imx8mn_clocks_probe(struct platform_device *pdev)
 	clks[IMX8MN_CLK_AHB] = imx8m_clk_composite_critical("ahb", imx8mn_ahb_sels, base + 0x9000);
 	clks[IMX8MN_CLK_AUDIO_AHB] = imx8m_clk_composite("audio_ahb", imx8mn_audio_ahb_sels, base + 0x9100);
 	clks[IMX8MN_CLK_IPG_ROOT] = imx_clk_divider2("ipg_root", "ahb", base + 0x9080, 0, 1);
 	clks[IMX8MN_CLK_IPG_AUDIO_ROOT] = imx_clk_divider2("ipg_audio_root", "audio_ahb", base + 0x9180, 0, 1);
 	clks[IMX8MN_CLK_DRAM_CORE] = imx_clk_mux2_flags("dram_core_clk", base + 0x9800, 24, 1, imx8mn_dram_core_sels, ARRAY_SIZE(imx8mn_dram_core_sels), CLK_IS_CRITICAL);
-	clks[IMX8MN_CLK_DRAM_ALT] = imx8m_clk_composite("dram_alt", imx8mn_dram_alt_sels, base + 0xa000);
-	clks[IMX8MN_CLK_DRAM_APB] = imx8m_clk_composite_critical("dram_apb", imx8mn_dram_apb_sels, base + 0xa080);
+
+	/*
+	 * DRAM clocks are manipulated from TF-A outside clock framework.
+	 * Mark with GET_RATE_NOCACHE to always read div value from hardware
+	 */
+	clks[IMX8MN_CLK_DRAM_ALT] = __imx8m_clk_composite("dram_alt", imx8mn_dram_alt_sels, base + 0xa000, CLK_GET_RATE_NOCACHE);
+	clks[IMX8MN_CLK_DRAM_APB] = __imx8m_clk_composite("dram_apb", imx8mn_dram_apb_sels, base + 0xa080, CLK_IS_CRITICAL | CLK_GET_RATE_NOCACHE);
+
 	clks[IMX8MN_CLK_DISP_PIXEL] = imx8m_clk_composite("disp_pixel", imx8mn_disp_pixel_sels, base + 0xa500);
 	clks[IMX8MN_CLK_SAI2] = imx8m_clk_composite("sai2", imx8mn_sai2_sels, base + 0xa600);
 	clks[IMX8MN_CLK_SAI3] = imx8m_clk_composite("sai3", imx8mn_sai3_sels, base + 0xa680);
 	clks[IMX8MN_CLK_SAI5] = imx8m_clk_composite("sai5", imx8mn_sai5_sels, base + 0xa780);
 	clks[IMX8MN_CLK_SAI6] = imx8m_clk_composite("sai6", imx8mn_sai6_sels, base + 0xa800);
diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
index 2168fe6cf7e4..14a1483b7d9f 100644
--- a/drivers/clk/imx/clk-imx8mq.c
+++ b/drivers/clk/imx/clk-imx8mq.c
@@ -341,11 +341,11 @@ static int imx8mq_clocks_probe(struct platform_device *pdev)
 	clks[IMX8MQ_VIDEO_PLL1_OUT] = imx_clk_gate("video_pll1_out", "video_pll1_bypass", base + 0x10, 21);
 
 	clks[IMX8MQ_SYS1_PLL_OUT] = imx_clk_fixed("sys1_pll_out", 800000000);
 	clks[IMX8MQ_SYS2_PLL_OUT] = imx_clk_fixed("sys2_pll_out", 1000000000);
 	clks[IMX8MQ_SYS3_PLL_OUT] = imx_clk_sccg_pll("sys3_pll_out", sys3_pll_out_sels, ARRAY_SIZE(sys3_pll_out_sels), 0, 0, 0, base + 0x48, CLK_IS_CRITICAL);
-	clks[IMX8MQ_DRAM_PLL_OUT] = imx_clk_sccg_pll("dram_pll_out", dram_pll_out_sels, ARRAY_SIZE(dram_pll_out_sels), 0, 0, 0, base + 0x60, CLK_IS_CRITICAL);
+	clks[IMX8MQ_DRAM_PLL_OUT] = imx_clk_sccg_pll("dram_pll_out", dram_pll_out_sels, ARRAY_SIZE(dram_pll_out_sels), 0, 0, 0, base + 0x60, CLK_IS_CRITICAL | CLK_GET_RATE_NOCACHE);
 	clks[IMX8MQ_VIDEO2_PLL_OUT] = imx_clk_sccg_pll("video2_pll_out", video2_pll_out_sels, ARRAY_SIZE(video2_pll_out_sels), 0, 0, 0, base + 0x54, 0);
 
 	/* SYS PLL1 fixed output */
 	clks[IMX8MQ_SYS1_PLL_40M_CG] = imx_clk_gate("sys1_pll_40m_cg", "sys1_pll_out", base + 0x30, 9);
 	clks[IMX8MQ_SYS1_PLL_80M_CG] = imx_clk_gate("sys1_pll_80m_cg", "sys1_pll_out", base + 0x30, 11);
@@ -433,15 +433,19 @@ static int imx8mq_clocks_probe(struct platform_device *pdev)
 
 	/* IPG */
 	clks[IMX8MQ_CLK_IPG_ROOT] = imx_clk_divider2("ipg_root", "ahb", base + 0x9080, 0, 1);
 	clks[IMX8MQ_CLK_IPG_AUDIO_ROOT] = imx_clk_divider2("ipg_audio_root", "audio_ahb", base + 0x9180, 0, 1);
 
-	/* IP */
+	/*
+	 * DRAM clocks are manipulated from TF-A outside clock framework.
+	 * Mark with GET_RATE_NOCACHE to always read div value from hardware
+	 */
 	clks[IMX8MQ_CLK_DRAM_CORE] = imx_clk_mux2_flags("dram_core_clk", base + 0x9800, 24, 1, imx8mq_dram_core_sels, ARRAY_SIZE(imx8mq_dram_core_sels), CLK_IS_CRITICAL);
+	clks[IMX8MQ_CLK_DRAM_ALT] = __imx8m_clk_composite("dram_alt", imx8mq_dram_alt_sels, base + 0xa000, CLK_GET_RATE_NOCACHE);
+	clks[IMX8MQ_CLK_DRAM_APB] = __imx8m_clk_composite("dram_apb", imx8mq_dram_apb_sels, base + 0xa080, CLK_IS_CRITICAL | CLK_GET_RATE_NOCACHE);
 
-	clks[IMX8MQ_CLK_DRAM_ALT] = imx8m_clk_composite("dram_alt", imx8mq_dram_alt_sels, base + 0xa000);
-	clks[IMX8MQ_CLK_DRAM_APB] = imx8m_clk_composite_critical("dram_apb", imx8mq_dram_apb_sels, base + 0xa080);
+	/* IP */
 	clks[IMX8MQ_CLK_VPU_G1] = imx8m_clk_composite("vpu_g1", imx8mq_vpu_g1_sels, base + 0xa100);
 	clks[IMX8MQ_CLK_VPU_G2] = imx8m_clk_composite("vpu_g2", imx8mq_vpu_g2_sels, base + 0xa180);
 	clks[IMX8MQ_CLK_DISP_DTRC] = imx8m_clk_composite("disp_dtrc", imx8mq_disp_dtrc_sels, base + 0xa200);
 	clks[IMX8MQ_CLK_DISP_DC8000] = imx8m_clk_composite("disp_dc8000", imx8mq_disp_dc8000_sels, base + 0xa280);
 	clks[IMX8MQ_CLK_PCIE1_CTRL] = imx8m_clk_composite("pcie1_ctrl", imx8mq_pcie1_ctrl_sels, base + 0xa300);
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v7 2/5] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
  2019-11-22 21:44 [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Leonard Crestez
  2019-11-22 21:45 ` [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks Leonard Crestez
@ 2019-11-22 21:45 ` Leonard Crestez
  2019-11-25  1:26   ` Stephen Boyd
  2019-12-09  1:16   ` Shawn Guo
  2019-11-22 21:45 ` [PATCH v7 3/5] dt-bindings: memory: Add bindings for imx8m ddr controller Leonard Crestez
                   ` (3 subsequent siblings)
  5 siblings, 2 replies; 25+ messages in thread
From: Leonard Crestez @ 2019-11-22 21:45 UTC (permalink / raw)
  To: Stephen Boyd, Chanwoo Choi, Rob Herring
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, MyungJoo Ham, linux-imx,
	devicetree, linux-pm, Martin Kepplinger, Silvano di Ninno,
	linux-arm-kernel, Dong Aisheng, Anson Huang, Rafael J. Wysocki,
	Kyungmin Park, kernel, Fabio Estevam, Shawn Guo, Georgi Djakov

DRAM frequency switches are executed in firmware and can change the
configuration of the DRAM PLL outside linux. Mark these CLKs with
CLK_GET_RATE_NOCACHE so we always read back the PLL config registers and
recalculate rates.

In current DRAM frequency tables on 8mm/8mn only the maximum frequency
uses the PLL so it's always configured in the same way. However reading
back the PLL configuration is the correct behavior and allows additional
setpoints in the future.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
---
 drivers/clk/imx/clk-imx8mm.c  | 2 +-
 drivers/clk/imx/clk-imx8mn.c  | 2 +-
 drivers/clk/imx/clk-pll14xx.c | 7 +++++++
 drivers/clk/imx/clk.h         | 1 +
 4 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index 1f43e8f6b362..d5e767e399db 100644
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -326,11 +326,11 @@ static int imx8mm_clocks_probe(struct platform_device *pdev)
 	clks[IMX8MM_SYS_PLL3_REF_SEL] = imx_clk_mux("sys_pll3_ref_sel", base + 0x114, 0, 2, pll_ref_sels, ARRAY_SIZE(pll_ref_sels));
 
 	clks[IMX8MM_AUDIO_PLL1] = imx_clk_pll14xx("audio_pll1", "audio_pll1_ref_sel", base, &imx_1443x_pll);
 	clks[IMX8MM_AUDIO_PLL2] = imx_clk_pll14xx("audio_pll2", "audio_pll2_ref_sel", base + 0x14, &imx_1443x_pll);
 	clks[IMX8MM_VIDEO_PLL1] = imx_clk_pll14xx("video_pll1", "video_pll1_ref_sel", base + 0x28, &imx_1443x_pll);
-	clks[IMX8MM_DRAM_PLL] = imx_clk_pll14xx("dram_pll", "dram_pll_ref_sel", base + 0x50, &imx_1443x_pll);
+	clks[IMX8MM_DRAM_PLL] = imx_clk_pll14xx("dram_pll", "dram_pll_ref_sel", base + 0x50, &imx_1443x_dram_pll);
 	clks[IMX8MM_GPU_PLL] = imx_clk_pll14xx("gpu_pll", "gpu_pll_ref_sel", base + 0x64, &imx_1416x_pll);
 	clks[IMX8MM_VPU_PLL] = imx_clk_pll14xx("vpu_pll", "vpu_pll_ref_sel", base + 0x74, &imx_1416x_pll);
 	clks[IMX8MM_ARM_PLL] = imx_clk_pll14xx("arm_pll", "arm_pll_ref_sel", base + 0x84, &imx_1416x_pll);
 	clks[IMX8MM_SYS_PLL1] = imx_clk_fixed("sys_pll1", 800000000);
 	clks[IMX8MM_SYS_PLL2] = imx_clk_fixed("sys_pll2", 1000000000);
diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index 49a05c5576fe..b0e07784defb 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -323,11 +323,11 @@ static int imx8mn_clocks_probe(struct platform_device *pdev)
 	clks[IMX8MN_SYS_PLL3_REF_SEL] = imx_clk_mux("sys_pll3_ref_sel", base + 0x114, 0, 2, pll_ref_sels, ARRAY_SIZE(pll_ref_sels));
 
 	clks[IMX8MN_AUDIO_PLL1] = imx_clk_pll14xx("audio_pll1", "audio_pll1_ref_sel", base, &imx_1443x_pll);
 	clks[IMX8MN_AUDIO_PLL2] = imx_clk_pll14xx("audio_pll2", "audio_pll2_ref_sel", base + 0x14, &imx_1443x_pll);
 	clks[IMX8MN_VIDEO_PLL1] = imx_clk_pll14xx("video_pll1", "video_pll1_ref_sel", base + 0x28, &imx_1443x_pll);
-	clks[IMX8MN_DRAM_PLL] = imx_clk_pll14xx("dram_pll", "dram_pll_ref_sel", base + 0x50, &imx_1443x_pll);
+	clks[IMX8MN_DRAM_PLL] = imx_clk_pll14xx("dram_pll", "dram_pll_ref_sel", base + 0x50, &imx_1443x_dram_pll);
 	clks[IMX8MN_GPU_PLL] = imx_clk_pll14xx("gpu_pll", "gpu_pll_ref_sel", base + 0x64, &imx_1416x_pll);
 	clks[IMX8MN_VPU_PLL] = imx_clk_pll14xx("vpu_pll", "vpu_pll_ref_sel", base + 0x74, &imx_1416x_pll);
 	clks[IMX8MN_ARM_PLL] = imx_clk_pll14xx("arm_pll", "arm_pll_ref_sel", base + 0x84, &imx_1416x_pll);
 	clks[IMX8MN_SYS_PLL1] = imx_clk_fixed("sys_pll1", 800000000);
 	clks[IMX8MN_SYS_PLL2] = imx_clk_fixed("sys_pll2", 1000000000);
diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c
index 5c458199060a..a6d31a7262ef 100644
--- a/drivers/clk/imx/clk-pll14xx.c
+++ b/drivers/clk/imx/clk-pll14xx.c
@@ -65,10 +65,17 @@ struct imx_pll14xx_clk imx_1443x_pll = {
 	.type = PLL_1443X,
 	.rate_table = imx_pll1443x_tbl,
 	.rate_count = ARRAY_SIZE(imx_pll1443x_tbl),
 };
 
+struct imx_pll14xx_clk imx_1443x_dram_pll = {
+	.type = PLL_1443X,
+	.rate_table = imx_pll1443x_tbl,
+	.rate_count = ARRAY_SIZE(imx_pll1443x_tbl),
+	.flags = CLK_GET_RATE_NOCACHE,
+};
+
 struct imx_pll14xx_clk imx_1416x_pll = {
 	.type = PLL_1416X,
 	.rate_table = imx_pll1416x_tbl,
 	.rate_count = ARRAY_SIZE(imx_pll1416x_tbl),
 };
diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h
index bc5bb6ac8636..81122c9ab842 100644
--- a/drivers/clk/imx/clk.h
+++ b/drivers/clk/imx/clk.h
@@ -50,10 +50,11 @@ struct imx_pll14xx_clk {
 	int flags;
 };
 
 extern struct imx_pll14xx_clk imx_1416x_pll;
 extern struct imx_pll14xx_clk imx_1443x_pll;
+extern struct imx_pll14xx_clk imx_1443x_dram_pll;
 
 #define imx_clk_cpu(name, parent_name, div, mux, pll, step) \
 	imx_clk_hw_cpu(name, parent_name, div, mux, pll, step)->clk
 
 #define clk_register_gate2(dev, name, parent_name, flags, reg, bit_idx, \
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v7 3/5] dt-bindings: memory: Add bindings for imx8m ddr controller
  2019-11-22 21:44 [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Leonard Crestez
  2019-11-22 21:45 ` [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks Leonard Crestez
  2019-11-22 21:45 ` [PATCH v7 2/5] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE Leonard Crestez
@ 2019-11-22 21:45 ` Leonard Crestez
  2019-11-22 21:45 ` [PATCH v7 4/5] PM / devfreq: Add dynamic scaling " Leonard Crestez
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 25+ messages in thread
From: Leonard Crestez @ 2019-11-22 21:45 UTC (permalink / raw)
  To: Stephen Boyd, Chanwoo Choi, Rob Herring
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, MyungJoo Ham, linux-imx,
	devicetree, linux-pm, Martin Kepplinger, Silvano di Ninno,
	linux-arm-kernel, Dong Aisheng, Anson Huang, Rafael J. Wysocki,
	Kyungmin Park, kernel, Fabio Estevam, Shawn Guo, Georgi Djakov

Add devicetree bindings for the i.MX DDR Controller on imx8m series
chips. It supports dynamic frequency switching between multiple data
rates and this is exposed to Linux via the devfreq subsystem.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../memory-controllers/fsl/imx8m-ddrc.yaml    | 72 +++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml

diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml
new file mode 100644
index 000000000000..c9e6c22cb5be
--- /dev/null
+++ b/Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml
@@ -0,0 +1,72 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/memory-controllers/fsl/imx8m-ddrc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: i.MX8M DDR Controller
+
+maintainers:
+  - Leonard Crestez <leonard.crestez@nxp.com>
+
+description:
+  The DDRC block is integrated in i.MX8M for interfacing with DDR based
+  memories.
+
+  It supports switching between different frequencies at runtime but during
+  this process RAM itself becomes briefly inaccessible so actual frequency
+  switching is implemented by TF-A code which runs from a SRAM area.
+
+  The Linux driver for the DDRC doesn't even map registers (they're included
+  for the sake of "describing hardware"), it mostly just exposes firmware
+  capabilities through standard Linux mechanism like devfreq and OPP tables.
+
+properties:
+  compatible:
+    items:
+      - enum:
+        - fsl,imx8mn-ddrc
+        - fsl,imx8mm-ddrc
+        - fsl,imx8mq-ddrc
+      - const: fsl,imx8m-ddrc
+
+  reg:
+    maxItems: 1
+    description:
+      Base address and size of DDRC CTL area.
+      This is not currently mapped by the imx8m-ddrc driver.
+
+  clocks:
+    maxItems: 4
+
+  clock-names:
+    items:
+      - const: core
+      - const: pll
+      - const: alt
+      - const: apb
+
+  operating-points-v2: true
+  opp-table: true
+
+required:
+  - reg
+  - compatible
+  - clocks
+  - clock-names
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/imx8mm-clock.h>
+    ddrc: memory-controller@3d400000 {
+        compatible = "fsl,imx8mm-ddrc", "fsl,imx8m-ddrc";
+        reg = <0x3d400000 0x400000>;
+        clock-names = "core", "pll", "alt", "apb";
+        clocks = <&clk IMX8MM_CLK_DRAM_CORE>,
+                 <&clk IMX8MM_DRAM_PLL>,
+                 <&clk IMX8MM_CLK_DRAM_ALT>,
+                 <&clk IMX8MM_CLK_DRAM_APB>;
+        operating-points-v2 = <&ddrc_opp_table>;
+    };
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v7 4/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2019-11-22 21:44 [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Leonard Crestez
                   ` (2 preceding siblings ...)
  2019-11-22 21:45 ` [PATCH v7 3/5] dt-bindings: memory: Add bindings for imx8m ddr controller Leonard Crestez
@ 2019-11-22 21:45 ` Leonard Crestez
  2019-11-24 23:59   ` Chanwoo Choi
  2019-11-22 21:45 ` [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes Leonard Crestez
  2019-12-18 13:35 ` [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Adam Ford
  5 siblings, 1 reply; 25+ messages in thread
From: Leonard Crestez @ 2019-11-22 21:45 UTC (permalink / raw)
  To: Stephen Boyd, Chanwoo Choi, Rob Herring
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, MyungJoo Ham, linux-imx,
	devicetree, linux-pm, Martin Kepplinger, Silvano di Ninno,
	linux-arm-kernel, Dong Aisheng, Anson Huang, Rafael J. Wysocki,
	Kyungmin Park, kernel, Fabio Estevam, Shawn Guo, Georgi Djakov

Add driver for dynamic scaling the DDR Controller on imx8m chips. Actual
frequency switching is implemented inside TF-A, this driver wraps the
SMC calls and synchronizes the clk tree.

The DRAM clocks on imx8m have the following structure (abridged):

 +----------+       |\            +------+
 | dram_pll |-------|M| dram_core |      |
 +----------+       |U|---------->| D    |
                 /--|X|           |  D   |
   dram_alt_root |  |/            |   R  |
                 |                |    C |
            +---------+           |      |
            |FIX DIV/4|           |      |
            +---------+           |      |
  composite:     |                |      |
 +----------+    |                |      |
 | dram_alt |----/                |      |
 +----------+                     |      |
 | dram_apb |-------------------->|      |
 +----------+                     +------+

The dram_pll is used for higher rates and dram_alt is used for lower
rates. The dram_alt and dram_apb clocks are "imx composite" and their
parent can also be modified.

This driver will prepare/enable the new parents ahead of switching (so
that the expected roots are enabled) and afterwards it will call
clk_set_parent to ensure the parents in clock framework are up-to-date.

The driver relies on dram_pll dram_alt and dram_apb being marked with
CLK_GET_RATE_NOCACHE for rate updates.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/devfreq/Kconfig      |   9 +
 drivers/devfreq/Makefile     |   1 +
 drivers/devfreq/imx8m-ddrc.c | 465 +++++++++++++++++++++++++++++++++++
 3 files changed, 475 insertions(+)
 create mode 100644 drivers/devfreq/imx8m-ddrc.c

diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index 59027d7ddf2a..5eac479dd05f 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -89,10 +89,19 @@ config ARM_EXYNOS_BUS_DEVFREQ
 	  Each memory bus group could contain many memoby bus block. It reads
 	  PPMU counters of memory controllers by using DEVFREQ-event device
 	  and adjusts the operating frequencies and voltages with OPP support.
 	  This does not yet operate with optimal voltages.
 
+config ARM_IMX8M_DDRC_DEVFREQ
+	tristate "i.MX8M DDRC DEVFREQ Driver"
+	depends on ARCH_MXC && HAVE_ARM_SMCCC
+	select DEVFREQ_GOV_SIMPLE_ONDEMAND
+	select DEVFREQ_GOV_USERSPACE
+	help
+	  This adds the DEVFREQ driver for the i.MX8M DDR Controller. It allows
+	  adjusting DRAM frequency.
+
 config ARM_TEGRA_DEVFREQ
 	tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
 	depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
 		ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
 		ARCH_TEGRA_210_SOC || \
diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile
index 338ae8440db6..3eb4d5e6635c 100644
--- a/drivers/devfreq/Makefile
+++ b/drivers/devfreq/Makefile
@@ -7,10 +7,11 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE)	+= governor_powersave.o
 obj-$(CONFIG_DEVFREQ_GOV_USERSPACE)	+= governor_userspace.o
 obj-$(CONFIG_DEVFREQ_GOV_PASSIVE)	+= governor_passive.o
 
 # DEVFREQ Drivers
 obj-$(CONFIG_ARM_EXYNOS_BUS_DEVFREQ)	+= exynos-bus.o
+obj-$(CONFIG_ARM_IMX8M_DDRC_DEVFREQ)	+= imx8m-ddrc.o
 obj-$(CONFIG_ARM_RK3399_DMC_DEVFREQ)	+= rk3399_dmc.o
 obj-$(CONFIG_ARM_TEGRA_DEVFREQ)		+= tegra30-devfreq.o
 obj-$(CONFIG_ARM_TEGRA20_DEVFREQ)	+= tegra20-devfreq.o
 
 # DEVFREQ Event Drivers
diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
new file mode 100644
index 000000000000..fea169619c59
--- /dev/null
+++ b/drivers/devfreq/imx8m-ddrc.c
@@ -0,0 +1,465 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2019 NXP
+ */
+
+#include <linux/module.h>
+#include <linux/device.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/devfreq.h>
+#include <linux/pm_opp.h>
+#include <linux/clk.h>
+#include <linux/clk-provider.h>
+#include <linux/arm-smccc.h>
+
+#define IMX_SIP_DDR_DVFS			0xc2000004
+
+/* Values starting from 0 switch to specific frequency */
+#define IMX_SIP_DDR_FREQ_SET_HIGH		0x00
+
+/* Deprecated after moving IRQ handling to ATF */
+#define IMX_SIP_DDR_DVFS_WAIT_CHANGE		0x0F
+
+/* Query available frequencies. */
+#define IMX_SIP_DDR_DVFS_GET_FREQ_COUNT		0x10
+#define IMX_SIP_DDR_DVFS_GET_FREQ_INFO		0x11
+
+/*
+ * This should be in a 1:1 mapping with devicetree OPPs but
+ * firmware provides additional info.
+ */
+struct imx8m_ddrc_freq {
+	unsigned long rate;
+	unsigned long smcarg;
+	int dram_core_parent_index;
+	int dram_alt_parent_index;
+	int dram_apb_parent_index;
+};
+
+/* Hardware limitation */
+#define IMX8M_DDRC_MAX_FREQ_COUNT 4
+
+/*
+ * i.MX8M DRAM Controller clocks have the following structure (abridged):
+ *
+ * +----------+       |\            +------+
+ * | dram_pll |-------|M| dram_core |      |
+ * +----------+       |U|---------->| D    |
+ *                 /--|X|           |  D   |
+ *   dram_alt_root |  |/            |   R  |
+ *                 |                |    C |
+ *            +---------+           |      |
+ *            |FIX DIV/4|           |      |
+ *            +---------+           |      |
+ *  composite:     |                |      |
+ * +----------+    |                |      |
+ * | dram_alt |----/                |      |
+ * +----------+                     |      |
+ * | dram_apb |-------------------->|      |
+ * +----------+                     +------+
+ *
+ * The dram_pll is used for higher rates and dram_alt is used for lower rates.
+ *
+ * Frequency switching is implemented in TF-A (via SMC call) and can change the
+ * configuration of the clocks, including mux parents. The dram_alt and
+ * dram_apb clocks are "imx composite" and their parent can change too.
+ *
+ * We need to prepare/enable the new mux parents head of switching and update
+ * their information afterwards.
+ */
+struct imx8m_ddrc {
+	struct devfreq_dev_profile profile;
+	struct devfreq *devfreq;
+
+	/* For frequency switching: */
+	struct clk *dram_core;
+	struct clk *dram_pll;
+	struct clk *dram_alt;
+	struct clk *dram_apb;
+
+	int freq_count;
+	struct imx8m_ddrc_freq freq_table[IMX8M_DDRC_MAX_FREQ_COUNT];
+};
+
+static struct imx8m_ddrc_freq *imx8m_ddrc_find_freq(struct imx8m_ddrc *priv,
+						    unsigned long rate)
+{
+	struct imx8m_ddrc_freq *freq;
+	int i;
+
+	/*
+	 * Firmware reports values in MT/s, so we round-down from Hz
+	 * Rounding is extra generous to ensure a match.
+	 */
+	rate = DIV_ROUND_CLOSEST(rate, 250000);
+	for (i = 0; i < priv->freq_count; ++i) {
+		freq = &priv->freq_table[i];
+		if (freq->rate == rate ||
+				freq->rate + 1 == rate ||
+				freq->rate - 1 == rate)
+			return freq;
+	}
+
+	return NULL;
+}
+
+static void imx8m_ddrc_smc_set_freq(int target_freq)
+{
+	struct arm_smccc_res res;
+	u32 online_cpus = 0;
+	int cpu;
+
+	local_irq_disable();
+
+	for_each_online_cpu(cpu)
+		online_cpus |= (1 << (cpu * 8));
+
+	/* change the ddr freqency */
+	arm_smccc_smc(IMX_SIP_DDR_DVFS, target_freq, online_cpus,
+			0, 0, 0, 0, 0, &res);
+
+	local_irq_enable();
+}
+
+static struct clk *clk_get_parent_by_index(struct clk *clk, int index)
+{
+	struct clk_hw *hw;
+
+	hw = clk_hw_get_parent_by_index(__clk_get_hw(clk), index);
+
+	return hw ? hw->clk : NULL;
+}
+
+static int imx8m_ddrc_set_freq(struct device *dev, struct imx8m_ddrc_freq *freq)
+{
+	struct imx8m_ddrc *priv = dev_get_drvdata(dev);
+	struct clk *new_dram_core_parent;
+	struct clk *new_dram_alt_parent;
+	struct clk *new_dram_apb_parent;
+	int ret;
+
+	/*
+	 * Fetch new parents
+	 *
+	 * new_dram_alt_parent and new_dram_apb_parent are optional but
+	 * new_dram_core_parent is not.
+	 */
+	new_dram_core_parent = clk_get_parent_by_index(
+			priv->dram_core, freq->dram_core_parent_index - 1);
+	if (!new_dram_core_parent) {
+		dev_err(dev, "failed to fetch new dram_core parent\n");
+		return -EINVAL;
+	}
+	if (freq->dram_alt_parent_index) {
+		new_dram_alt_parent = clk_get_parent_by_index(
+				priv->dram_alt,
+				freq->dram_alt_parent_index - 1);
+		if (!new_dram_alt_parent) {
+			dev_err(dev, "failed to fetch new dram_alt parent\n");
+			return -EINVAL;
+		}
+	} else
+		new_dram_alt_parent = NULL;
+
+	if (freq->dram_apb_parent_index) {
+		new_dram_apb_parent = clk_get_parent_by_index(
+				priv->dram_apb,
+				freq->dram_apb_parent_index - 1);
+		if (!new_dram_apb_parent) {
+			dev_err(dev, "failed to fetch new dram_apb parent\n");
+			return -EINVAL;
+		}
+	} else
+		new_dram_apb_parent = NULL;
+
+	/* increase reference counts and ensure clks are ON before switch */
+	ret = clk_prepare_enable(new_dram_core_parent);
+	if (ret) {
+		dev_err(dev, "failed to enable new dram_core parent: %d\n",
+			ret);
+		goto out;
+	}
+	ret = clk_prepare_enable(new_dram_alt_parent);
+	if (ret) {
+		dev_err(dev, "failed to enable new dram_alt parent: %d\n",
+			ret);
+		goto out_disable_core_parent;
+	}
+	ret = clk_prepare_enable(new_dram_apb_parent);
+	if (ret) {
+		dev_err(dev, "failed to enable new dram_apb parent: %d\n",
+			ret);
+		goto out_disable_alt_parent;
+	}
+
+	imx8m_ddrc_smc_set_freq(freq->smcarg);
+
+	/* update parents in clk tree after switch. */
+	ret = clk_set_parent(priv->dram_core, new_dram_core_parent);
+	if (ret)
+		dev_warn(dev, "failed to set dram_core parent: %d\n", ret);
+	if (new_dram_alt_parent) {
+		ret = clk_set_parent(priv->dram_alt, new_dram_alt_parent);
+		if (ret)
+			dev_warn(dev, "failed to set dram_alt parent: %d\n",
+				 ret);
+	}
+	if (new_dram_apb_parent) {
+		ret = clk_set_parent(priv->dram_apb, new_dram_apb_parent);
+		if (ret)
+			dev_warn(dev, "failed to set dram_apb parent: %d\n",
+				 ret);
+	}
+
+	/*
+	 * Explicitly refresh dram PLL rate.
+	 *
+	 * Even if it's marked with CLK_GET_RATE_NOCACHE the rate will not be
+	 * automatically refreshed when clk_get_rate is called on children.
+	 */
+	clk_get_rate(priv->dram_pll);
+
+	/*
+	 * clk_set_parent transfer the reference count from old parent.
+	 * now we drop extra reference counts used during the switch
+	 */
+	clk_disable_unprepare(new_dram_apb_parent);
+out_disable_alt_parent:
+	clk_disable_unprepare(new_dram_alt_parent);
+out_disable_core_parent:
+	clk_disable_unprepare(new_dram_core_parent);
+out:
+	return ret;
+}
+
+static int imx8m_ddrc_target(struct device *dev, unsigned long *freq, u32 flags)
+{
+	struct imx8m_ddrc *priv = dev_get_drvdata(dev);
+	struct imx8m_ddrc_freq *freq_info;
+	struct dev_pm_opp *new_opp;
+	unsigned long old_freq, new_freq;
+	int ret;
+
+	new_opp = devfreq_recommended_opp(dev, freq, flags);
+	if (IS_ERR(new_opp)) {
+		ret = PTR_ERR(new_opp);
+		dev_err(dev, "failed to get recommended opp: %d\n", ret);
+		return ret;
+	}
+	dev_pm_opp_put(new_opp);
+
+	old_freq = clk_get_rate(priv->dram_core);
+	if (*freq == old_freq)
+		return 0;
+
+	freq_info = imx8m_ddrc_find_freq(priv, *freq);
+	if (!freq_info)
+		return -EINVAL;
+
+	/*
+	 * Read back the clk rate to verify switch was correct and so that
+	 * we can report it on all error paths.
+	 */
+	ret = imx8m_ddrc_set_freq(dev, freq_info);
+
+	new_freq = clk_get_rate(priv->dram_core);
+	if (ret)
+		dev_err(dev, "ddrc failed freq switch to %lu from %lu: error %d. now at %lu\n",
+			old_freq, *freq, ret, new_freq);
+	else if (*freq != new_freq)
+		dev_err(dev, "ddrc failed freq update to %lu from %lu, now at %lu\n",
+			old_freq, *freq, new_freq);
+	else
+		dev_dbg(dev, "ddrc freq set to %lu (was %lu)\n",
+			*freq, old_freq);
+
+	return ret;
+}
+
+static int imx8m_ddrc_get_cur_freq(struct device *dev, unsigned long *freq)
+{
+	struct imx8m_ddrc *priv = dev_get_drvdata(dev);
+
+	*freq = clk_get_rate(priv->dram_core);
+
+	return 0;
+}
+
+static int imx8m_ddrc_get_dev_status(struct device *dev,
+				     struct devfreq_dev_status *stat)
+{
+	struct imx8m_ddrc *priv = dev_get_drvdata(dev);
+
+	stat->busy_time = 0;
+	stat->total_time = 0;
+	stat->current_frequency = clk_get_rate(priv->dram_core);
+
+	return 0;
+}
+
+static int imx8m_ddrc_init_freq_info(struct device *dev)
+{
+	struct imx8m_ddrc *priv = dev_get_drvdata(dev);
+	struct arm_smccc_res res;
+	int index;
+
+	/* An error here means DDR DVFS API not supported by firmware */
+	arm_smccc_smc(IMX_SIP_DDR_DVFS, IMX_SIP_DDR_DVFS_GET_FREQ_COUNT,
+			0, 0, 0, 0, 0, 0, &res);
+	priv->freq_count = res.a0;
+	if (priv->freq_count <= 0 ||
+			priv->freq_count > IMX8M_DDRC_MAX_FREQ_COUNT)
+		return -ENODEV;
+
+	for (index = 0; index < priv->freq_count; ++index) {
+		struct imx8m_ddrc_freq *freq = &priv->freq_table[index];
+
+		arm_smccc_smc(IMX_SIP_DDR_DVFS, IMX_SIP_DDR_DVFS_GET_FREQ_INFO,
+			      index, 0, 0, 0, 0, 0, &res);
+		/* Result should be strictly positive */
+		if ((long)res.a0 <= 0)
+			return -ENODEV;
+
+		freq->rate = res.a0;
+		freq->smcarg = index;
+		freq->dram_core_parent_index = res.a1;
+		freq->dram_alt_parent_index = res.a2;
+		freq->dram_apb_parent_index = res.a3;
+
+		/* dram_core has 2 options: dram_pll or dram_alt_root */
+		if (freq->dram_core_parent_index != 1 &&
+				freq->dram_core_parent_index != 2)
+			return -ENODEV;
+		/* dram_apb and dram_alt have exactly 8 possible parents */
+		if (freq->dram_alt_parent_index > 8 ||
+				freq->dram_apb_parent_index > 8)
+			return -ENODEV;
+		/* dram_core from alt requires explicit dram_alt parent */
+		if (freq->dram_core_parent_index == 2 &&
+				freq->dram_alt_parent_index == 0)
+			return -ENODEV;
+	}
+
+	return 0;
+}
+
+static int imx8m_ddrc_check_opps(struct device *dev)
+{
+	struct imx8m_ddrc *priv = dev_get_drvdata(dev);
+	struct imx8m_ddrc_freq *freq_info;
+	struct dev_pm_opp *opp;
+	unsigned long freq;
+	int i, opp_count;
+
+	/* Enumerate DT OPPs and disable those not supported by firmware */
+	opp_count = dev_pm_opp_get_opp_count(dev);
+	if (opp_count < 0)
+		return opp_count;
+	for (i = 0, freq = 0; i < opp_count; ++i, ++freq) {
+		opp = dev_pm_opp_find_freq_ceil(dev, &freq);
+		if (IS_ERR(opp)) {
+			dev_err(dev, "Failed enumerating OPPs: %ld\n",
+				PTR_ERR(opp));
+			return PTR_ERR(opp);
+		}
+		dev_pm_opp_put(opp);
+
+		freq_info = imx8m_ddrc_find_freq(priv, freq);
+		if (!freq_info) {
+			dev_info(dev, "Disable unsupported OPP %luHz %luMT/s\n",
+					freq, DIV_ROUND_CLOSEST(freq, 250000));
+			dev_pm_opp_disable(dev, freq);
+		}
+	}
+
+	return 0;
+}
+
+static void imx8m_ddrc_exit(struct device *dev)
+{
+	dev_pm_opp_of_remove_table(dev);
+}
+
+static int imx8m_ddrc_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct imx8m_ddrc *priv;
+	const char *gov = DEVFREQ_GOV_USERSPACE;
+	int ret;
+
+	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv)
+		return -ENOMEM;
+
+	platform_set_drvdata(pdev, priv);
+
+	ret = imx8m_ddrc_init_freq_info(dev);
+	if (ret) {
+		dev_err(dev, "failed to init firmware freq info: %d\n", ret);
+		return ret;
+	}
+
+	priv->dram_core = devm_clk_get(dev, "core");
+	priv->dram_pll = devm_clk_get(dev, "pll");
+	priv->dram_alt = devm_clk_get(dev, "alt");
+	priv->dram_apb = devm_clk_get(dev, "apb");
+	if (IS_ERR(priv->dram_core) ||
+		IS_ERR(priv->dram_pll) ||
+		IS_ERR(priv->dram_alt) ||
+		IS_ERR(priv->dram_apb)) {
+		ret = PTR_ERR(priv->devfreq);
+		dev_err(dev, "failed to fetch clocks: %d\n", ret);
+		return ret;
+	}
+
+	ret = dev_pm_opp_of_add_table(dev);
+	if (ret < 0) {
+		dev_err(dev, "failed to get OPP table\n");
+		return ret;
+	}
+
+	ret = imx8m_ddrc_check_opps(dev);
+	if (ret < 0)
+		goto err;
+
+	priv->profile.polling_ms = 1000;
+	priv->profile.target = imx8m_ddrc_target;
+	priv->profile.get_dev_status = imx8m_ddrc_get_dev_status;
+	priv->profile.exit = imx8m_ddrc_exit;
+	priv->profile.get_cur_freq = imx8m_ddrc_get_cur_freq;
+	priv->profile.initial_freq = clk_get_rate(priv->dram_core);
+
+	priv->devfreq = devm_devfreq_add_device(dev, &priv->profile,
+						gov, NULL);
+	if (IS_ERR(priv->devfreq)) {
+		ret = PTR_ERR(priv->devfreq);
+		dev_err(dev, "failed to add devfreq device: %d\n", ret);
+		goto err;
+	}
+
+	return 0;
+
+err:
+	dev_pm_opp_of_remove_table(dev);
+	return ret;
+}
+
+static const struct of_device_id imx8m_ddrc_of_match[] = {
+	{ .compatible = "fsl,imx8m-ddrc", },
+	{ /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, imx8m_ddrc_of_match);
+
+static struct platform_driver imx8m_ddrc_platdrv = {
+	.probe		= imx8m_ddrc_probe,
+	.driver = {
+		.name	= "imx8m-ddrc-devfreq",
+		.of_match_table = of_match_ptr(imx8m_ddrc_of_match),
+	},
+};
+module_platform_driver(imx8m_ddrc_platdrv);
+
+MODULE_DESCRIPTION("i.MX8M DDR Controller frequency driver");
+MODULE_AUTHOR("Leonard Crestez <leonard.crestez@nxp.com>");
+MODULE_LICENSE("GPL v2");
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes
  2019-11-22 21:44 [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Leonard Crestez
                   ` (3 preceding siblings ...)
  2019-11-22 21:45 ` [PATCH v7 4/5] PM / devfreq: Add dynamic scaling " Leonard Crestez
@ 2019-11-22 21:45 ` Leonard Crestez
  2019-11-28 14:43   ` Adam Ford
  2019-12-09  1:34   ` Shawn Guo
  2019-12-18 13:35 ` [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Adam Ford
  5 siblings, 2 replies; 25+ messages in thread
From: Leonard Crestez @ 2019-11-22 21:45 UTC (permalink / raw)
  To: Stephen Boyd, Chanwoo Choi, Rob Herring
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, MyungJoo Ham, linux-imx,
	devicetree, linux-pm, Martin Kepplinger, Silvano di Ninno,
	linux-arm-kernel, Dong Aisheng, Anson Huang, Rafael J. Wysocki,
	Kyungmin Park, kernel, Fabio Estevam, Shawn Guo, Georgi Djakov

This is used by the imx-ddrc devfreq driver to implement dynamic
frequency scaling of DRAM.

Support for proactive scaling via interconnect will come later. The
high-performance bus masters which need that (display, vpu, gpu) are
mostly not yet enabled in upstream anyway.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mm-evk.dts  | 18 ++++++++++++++
 arch/arm64/boot/dts/freescale/imx8mm.dtsi     | 10 ++++++++
 .../boot/dts/freescale/imx8mn-ddr4-evk.dts    | 18 ++++++++++++++
 arch/arm64/boot/dts/freescale/imx8mn.dtsi     | 10 ++++++++
 arch/arm64/boot/dts/freescale/imx8mq-evk.dts  | 24 +++++++++++++++++++
 arch/arm64/boot/dts/freescale/imx8mq.dtsi     | 10 ++++++++
 6 files changed, 90 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
index 28ab17a277bb..ecf0d385c164 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
@@ -75,10 +75,28 @@
 
 &A53_0 {
 	cpu-supply = <&buck2_reg>;
 };
 
+&ddrc {
+	operating-points-v2 = <&ddrc_opp_table>;
+
+	ddrc_opp_table: opp-table {
+		compatible = "operating-points-v2";
+
+		opp-25M {
+			opp-hz = /bits/ 64 <25000000>;
+		};
+		opp-100M {
+			opp-hz = /bits/ 64 <100000000>;
+		};
+		opp-750M {
+			opp-hz = /bits/ 64 <750000000>;
+		};
+	};
+};
+
 &fec1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_fec1>;
 	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy0>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 6edbdfe2d0d7..3d4802375715 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -856,10 +856,20 @@
 			#interrupt-cells = <3>;
 			interrupt-controller;
 			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
+		ddrc: memory-controller@3d400000 {
+			compatible = "fsl,imx8mm-ddrc", "fsl,imx8m-ddrc";
+			reg = <0x3d400000 0x400000>;
+			clock-names = "core", "pll", "alt", "apb";
+			clocks = <&clk IMX8MM_CLK_DRAM_CORE>,
+				 <&clk IMX8MM_DRAM_PLL>,
+				 <&clk IMX8MM_CLK_DRAM_ALT>,
+				 <&clk IMX8MM_CLK_DRAM_APB>;
+		};
+
 		ddr-pmu@3d800000 {
 			compatible = "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu";
 			reg = <0x3d800000 0x400000>;
 			interrupt-parent = <&gic>;
 			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
index 071949412caf..b051c927c11e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
@@ -15,10 +15,28 @@
 
 &A53_0 {
 	cpu-supply = <&buck2_reg>;
 };
 
+&ddrc {
+	operating-points-v2 = <&ddrc_opp_table>;
+
+	ddrc_opp_table: opp-table {
+		compatible = "operating-points-v2";
+
+		opp-25M {
+			opp-hz = /bits/ 64 <25000000>;
+		};
+		opp-100M {
+			opp-hz = /bits/ 64 <100000000>;
+		};
+		opp-600M {
+			opp-hz = /bits/ 64 <600000000>;
+		};
+	};
+};
+
 &i2c1 {
 	pmic@4b {
 		compatible = "rohm,bd71847";
 		reg = <0x4b>;
 		pinctrl-0 = <&pinctrl_pmic>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index e91625063f8e..3a79fdddc72b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -757,10 +757,20 @@
 			#interrupt-cells = <3>;
 			interrupt-controller;
 			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
+		ddrc: memory-controller@3d400000 {
+			compatible = "fsl,imx8mn-ddrc", "fsl,imx8m-ddrc";
+			reg = <0x3d400000 0x400000>;
+			clock-names = "core", "pll", "alt", "apb";
+			clocks = <&clk IMX8MN_CLK_DRAM_CORE>,
+				 <&clk IMX8MN_DRAM_PLL>,
+				 <&clk IMX8MN_CLK_DRAM_ALT>,
+				 <&clk IMX8MN_CLK_DRAM_APB>;
+		};
+
 		ddr-pmu@3d800000 {
 			compatible = "fsl,imx8mn-ddr-pmu", "fsl,imx8m-ddr-pmu";
 			reg = <0x3d800000 0x400000>;
 			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
 		};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
index c36685916683..ee6dc5f07622 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
@@ -103,10 +103,34 @@
 
 &A53_3 {
 	cpu-supply = <&buck2_reg>;
 };
 
+&ddrc {
+	operating-points-v2 = <&ddrc_opp_table>;
+
+	ddrc_opp_table: opp-table {
+		compatible = "operating-points-v2";
+
+		opp-25M {
+			opp-hz = /bits/ 64 <25000000>;
+		};
+		opp-100M {
+			opp-hz = /bits/ 64 <100000000>;
+		};
+		/*
+		 * On imx8mq B0 PLL can't be bypassed so low bus is 166M
+		 */
+		opp-166M {
+			opp-hz = /bits/ 64 <166935483>;
+		};
+		opp-800M {
+			opp-hz = /bits/ 64 <800000000>;
+		};
+	};
+};
+
 &fec1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_fec1>;
 	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy0>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 7f9319452b58..d1fcf9887f8b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1111,10 +1111,20 @@
 			interrupt-controller;
 			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-parent = <&gic>;
 		};
 
+		ddrc: memory-controller@3d400000 {
+			compatible = "fsl,imx8mq-ddrc", "fsl,imx8m-ddrc";
+			reg = <0x3d400000 0x400000>;
+			clock-names = "core", "pll", "alt", "apb";
+			clocks = <&clk IMX8MQ_CLK_DRAM_CORE>,
+				 <&clk IMX8MQ_DRAM_PLL_OUT>,
+				 <&clk IMX8MQ_CLK_DRAM_ALT>,
+				 <&clk IMX8MQ_CLK_DRAM_APB>;
+		};
+
 		ddr-pmu@3d800000 {
 			compatible = "fsl,imx8mq-ddr-pmu", "fsl,imx8m-ddr-pmu";
 			reg = <0x3d800000 0x400000>;
 			interrupt-parent = <&gic>;
 			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 4/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2019-11-22 21:45 ` [PATCH v7 4/5] PM / devfreq: Add dynamic scaling " Leonard Crestez
@ 2019-11-24 23:59   ` Chanwoo Choi
  2019-11-26 19:44     ` Rob Herring
  0 siblings, 1 reply; 25+ messages in thread
From: Chanwoo Choi @ 2019-11-24 23:59 UTC (permalink / raw)
  To: Leonard Crestez, Stephen Boyd, Rob Herring
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, MyungJoo Ham, linux-imx,
	devicetree, linux-pm, Martin Kepplinger, Silvano di Ninno,
	linux-arm-kernel, Dong Aisheng, Anson Huang, Rafael J. Wysocki,
	Kyungmin Park, kernel, Fabio Estevam, Shawn Guo, Georgi Djakov

Hi Leonard,

On 11/23/19 6:45 AM, Leonard Crestez wrote:
> Add driver for dynamic scaling the DDR Controller on imx8m chips. Actual
> frequency switching is implemented inside TF-A, this driver wraps the
> SMC calls and synchronizes the clk tree.
> 
> The DRAM clocks on imx8m have the following structure (abridged):
> 
>  +----------+       |\            +------+
>  | dram_pll |-------|M| dram_core |      |
>  +----------+       |U|---------->| D    |
>                  /--|X|           |  D   |
>    dram_alt_root |  |/            |   R  |
>                  |                |    C |
>             +---------+           |      |
>             |FIX DIV/4|           |      |
>             +---------+           |      |
>   composite:     |                |      |
>  +----------+    |                |      |
>  | dram_alt |----/                |      |
>  +----------+                     |      |
>  | dram_apb |-------------------->|      |
>  +----------+                     +------+
> 
> The dram_pll is used for higher rates and dram_alt is used for lower
> rates. The dram_alt and dram_apb clocks are "imx composite" and their
> parent can also be modified.
> 
> This driver will prepare/enable the new parents ahead of switching (so
> that the expected roots are enabled) and afterwards it will call
> clk_set_parent to ensure the parents in clock framework are up-to-date.
> 
> The driver relies on dram_pll dram_alt and dram_apb being marked with
> CLK_GET_RATE_NOCACHE for rate updates.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/devfreq/Kconfig      |   9 +
>  drivers/devfreq/Makefile     |   1 +
>  drivers/devfreq/imx8m-ddrc.c | 465 +++++++++++++++++++++++++++++++++++
>  3 files changed, 475 insertions(+)
>  create mode 100644 drivers/devfreq/imx8m-ddrc.c
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 59027d7ddf2a..5eac479dd05f 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -89,10 +89,19 @@ config ARM_EXYNOS_BUS_DEVFREQ
>  	  Each memory bus group could contain many memoby bus block. It reads
>  	  PPMU counters of memory controllers by using DEVFREQ-event device
>  	  and adjusts the operating frequencies and voltages with OPP support.
>  	  This does not yet operate with optimal voltages.
>  
> +config ARM_IMX8M_DDRC_DEVFREQ
> +	tristate "i.MX8M DDRC DEVFREQ Driver"
> +	depends on ARCH_MXC && HAVE_ARM_SMCCC

I'll edit it as following and applied it.

diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index 5eac479dd05f..38a94df749a2 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -93,7 +93,8 @@ config ARM_EXYNOS_BUS_DEVFREQ
 
 config ARM_IMX8M_DDRC_DEVFREQ
        tristate "i.MX8M DDRC DEVFREQ Driver"
-       depends on ARCH_MXC && HAVE_ARM_SMCCC
+       depends on (ARCH_MXC && HAVE_ARM_SMCCC) || \
+               (COMPILE_TEST && HAVE_ARM_SMCCC)

(snip)

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
  2019-11-22 21:45 ` [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks Leonard Crestez
@ 2019-11-25  1:25   ` Stephen Boyd
  2019-12-09  1:15   ` Shawn Guo
  1 sibling, 0 replies; 25+ messages in thread
From: Stephen Boyd @ 2019-11-25  1:25 UTC (permalink / raw)
  To: Chanwoo Choi, Leonard Crestez, Rob Herring
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, MyungJoo Ham, linux-imx,
	devicetree, linux-pm, Martin Kepplinger, Silvano di Ninno,
	linux-arm-kernel, Dong Aisheng, Anson Huang, Rafael J. Wysocki,
	Kyungmin Park, kernel, Fabio Estevam, Shawn Guo, Georgi Djakov

Quoting Leonard Crestez (2019-11-22 13:45:00)
> These clocks are only modified as part of DRAM frequency switches during
> which DRAM itself is briefly inaccessible. The switch is performed with
> a SMC call to by TF-A which runs from a SRAM area; upon returning to
> linux several clocks bits are modified and we need to update them.
> 
> For rate bits an easy solution is to just mark with
> CLK_GET_RATE_NOCACHE so that new rates are always read back from
> registers.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 2/5] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
  2019-11-22 21:45 ` [PATCH v7 2/5] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE Leonard Crestez
@ 2019-11-25  1:26   ` Stephen Boyd
  2019-12-09  1:16   ` Shawn Guo
  1 sibling, 0 replies; 25+ messages in thread
From: Stephen Boyd @ 2019-11-25  1:26 UTC (permalink / raw)
  To: Chanwoo Choi, Leonard Crestez, Rob Herring
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, MyungJoo Ham, linux-imx,
	devicetree, linux-pm, Martin Kepplinger, Silvano di Ninno,
	linux-arm-kernel, Dong Aisheng, Anson Huang, Rafael J. Wysocki,
	Kyungmin Park, kernel, Fabio Estevam, Shawn Guo, Georgi Djakov

Quoting Leonard Crestez (2019-11-22 13:45:01)
> DRAM frequency switches are executed in firmware and can change the
> configuration of the DRAM PLL outside linux. Mark these CLKs with
> CLK_GET_RATE_NOCACHE so we always read back the PLL config registers and
> recalculate rates.
> 
> In current DRAM frequency tables on 8mm/8mn only the maximum frequency
> uses the PLL so it's always configured in the same way. However reading
> back the PLL configuration is the correct behavior and allows additional
> setpoints in the future.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 4/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2019-11-24 23:59   ` Chanwoo Choi
@ 2019-11-26 19:44     ` Rob Herring
  2019-11-26 23:25       ` Chanwoo Choi
  0 siblings, 1 reply; 25+ messages in thread
From: Rob Herring @ 2019-11-26 19:44 UTC (permalink / raw)
  To: Chanwoo Choi
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Leonard Crestez, Matthias Kaehlcke, Abel Vesa,
	Saravana Kannan, Krzysztof Kozlowski, linux-clk, MyungJoo Ham,
	NXP Linux Team, devicetree, open list:THERMAL, Martin Kepplinger,
	Silvano di Ninno,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Dong Aisheng, Anson Huang, Stephen Boyd, Rafael J. Wysocki,
	Kyungmin Park, Sascha Hauer, Fabio Estevam, Shawn Guo,
	Georgi Djakov

On Sun, Nov 24, 2019 at 4:53 PM Chanwoo Choi <cw00.choi@samsung.com> wrote:
>
> Hi Leonard,
>
> On 11/23/19 6:45 AM, Leonard Crestez wrote:
> > Add driver for dynamic scaling the DDR Controller on imx8m chips. Actual
> > frequency switching is implemented inside TF-A, this driver wraps the
> > SMC calls and synchronizes the clk tree.
> >
> > The DRAM clocks on imx8m have the following structure (abridged):
> >
> >  +----------+       |\            +------+
> >  | dram_pll |-------|M| dram_core |      |
> >  +----------+       |U|---------->| D    |
> >                  /--|X|           |  D   |
> >    dram_alt_root |  |/            |   R  |
> >                  |                |    C |
> >             +---------+           |      |
> >             |FIX DIV/4|           |      |
> >             +---------+           |      |
> >   composite:     |                |      |
> >  +----------+    |                |      |
> >  | dram_alt |----/                |      |
> >  +----------+                     |      |
> >  | dram_apb |-------------------->|      |
> >  +----------+                     +------+
> >
> > The dram_pll is used for higher rates and dram_alt is used for lower
> > rates. The dram_alt and dram_apb clocks are "imx composite" and their
> > parent can also be modified.
> >
> > This driver will prepare/enable the new parents ahead of switching (so
> > that the expected roots are enabled) and afterwards it will call
> > clk_set_parent to ensure the parents in clock framework are up-to-date.
> >
> > The driver relies on dram_pll dram_alt and dram_apb being marked with
> > CLK_GET_RATE_NOCACHE for rate updates.
> >
> > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> > Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
> > ---
> >  drivers/devfreq/Kconfig      |   9 +
> >  drivers/devfreq/Makefile     |   1 +
> >  drivers/devfreq/imx8m-ddrc.c | 465 +++++++++++++++++++++++++++++++++++
> >  3 files changed, 475 insertions(+)
> >  create mode 100644 drivers/devfreq/imx8m-ddrc.c
> >
> > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> > index 59027d7ddf2a..5eac479dd05f 100644
> > --- a/drivers/devfreq/Kconfig
> > +++ b/drivers/devfreq/Kconfig
> > @@ -89,10 +89,19 @@ config ARM_EXYNOS_BUS_DEVFREQ
> >         Each memory bus group could contain many memoby bus block. It reads
> >         PPMU counters of memory controllers by using DEVFREQ-event device
> >         and adjusts the operating frequencies and voltages with OPP support.
> >         This does not yet operate with optimal voltages.
> >
> > +config ARM_IMX8M_DDRC_DEVFREQ
> > +     tristate "i.MX8M DDRC DEVFREQ Driver"
> > +     depends on ARCH_MXC && HAVE_ARM_SMCCC
>
> I'll edit it as following and applied it.

You corrupted the URLs in the binding patch when applying the series:

Traceback (most recent call last):
 File "/usr/local/lib/python3.6/dist-packages/jsonschema/validators.py",
line 774, in resolve_from_url
 document = self.store[url]
 File "/usr/local/lib/python3.6/dist-packages/jsonschema/_utils.py",
line 22, in __getitem__
 return self.store[self.normalize(uri)]
KeyError: 'https://protect2.fireeye.com/url?k=b51ff83f-e8cff0d7-b51e7370-000babff32e3-c25c03b8af1b12ee&u=http://devicetree.org/meta-schemas/core.yaml'

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 4/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2019-11-26 19:44     ` Rob Herring
@ 2019-11-26 23:25       ` Chanwoo Choi
  0 siblings, 0 replies; 25+ messages in thread
From: Chanwoo Choi @ 2019-11-26 23:25 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Leonard Crestez, Matthias Kaehlcke, Abel Vesa,
	Saravana Kannan, Krzysztof Kozlowski, linux-clk, MyungJoo Ham,
	NXP Linux Team, devicetree, open list:THERMAL, Martin Kepplinger,
	Silvano di Ninno,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Dong Aisheng, Anson Huang, Stephen Boyd, Rafael J. Wysocki,
	Kyungmin Park, Sascha Hauer, Fabio Estevam, Shawn Guo,
	Georgi Djakov

On 11/27/19 4:44 AM, Rob Herring wrote:
> On Sun, Nov 24, 2019 at 4:53 PM Chanwoo Choi <cw00.choi@samsung.com> wrote:
>>
>> Hi Leonard,
>>
>> On 11/23/19 6:45 AM, Leonard Crestez wrote:
>>> Add driver for dynamic scaling the DDR Controller on imx8m chips. Actual
>>> frequency switching is implemented inside TF-A, this driver wraps the
>>> SMC calls and synchronizes the clk tree.
>>>
>>> The DRAM clocks on imx8m have the following structure (abridged):
>>>
>>>  +----------+       |\            +------+
>>>  | dram_pll |-------|M| dram_core |      |
>>>  +----------+       |U|---------->| D    |
>>>                  /--|X|           |  D   |
>>>    dram_alt_root |  |/            |   R  |
>>>                  |                |    C |
>>>             +---------+           |      |
>>>             |FIX DIV/4|           |      |
>>>             +---------+           |      |
>>>   composite:     |                |      |
>>>  +----------+    |                |      |
>>>  | dram_alt |----/                |      |
>>>  +----------+                     |      |
>>>  | dram_apb |-------------------->|      |
>>>  +----------+                     +------+
>>>
>>> The dram_pll is used for higher rates and dram_alt is used for lower
>>> rates. The dram_alt and dram_apb clocks are "imx composite" and their
>>> parent can also be modified.
>>>
>>> This driver will prepare/enable the new parents ahead of switching (so
>>> that the expected roots are enabled) and afterwards it will call
>>> clk_set_parent to ensure the parents in clock framework are up-to-date.
>>>
>>> The driver relies on dram_pll dram_alt and dram_apb being marked with
>>> CLK_GET_RATE_NOCACHE for rate updates.
>>>
>>> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>>> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> ---
>>>  drivers/devfreq/Kconfig      |   9 +
>>>  drivers/devfreq/Makefile     |   1 +
>>>  drivers/devfreq/imx8m-ddrc.c | 465 +++++++++++++++++++++++++++++++++++
>>>  3 files changed, 475 insertions(+)
>>>  create mode 100644 drivers/devfreq/imx8m-ddrc.c
>>>
>>> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
>>> index 59027d7ddf2a..5eac479dd05f 100644
>>> --- a/drivers/devfreq/Kconfig
>>> +++ b/drivers/devfreq/Kconfig
>>> @@ -89,10 +89,19 @@ config ARM_EXYNOS_BUS_DEVFREQ
>>>         Each memory bus group could contain many memoby bus block. It reads
>>>         PPMU counters of memory controllers by using DEVFREQ-event device
>>>         and adjusts the operating frequencies and voltages with OPP support.
>>>         This does not yet operate with optimal voltages.
>>>
>>> +config ARM_IMX8M_DDRC_DEVFREQ
>>> +     tristate "i.MX8M DDRC DEVFREQ Driver"
>>> +     depends on ARCH_MXC && HAVE_ARM_SMCCC
>>
>> I'll edit it as following and applied it.
> 
> You corrupted the URLs in the binding patch when applying the series:
> 
> Traceback (most recent call last):
>  File "/usr/local/lib/python3.6/dist-packages/jsonschema/validators.py",
> line 774, in resolve_from_url
>  document = self.store[url]
>  File "/usr/local/lib/python3.6/dist-packages/jsonschema/_utils.py",
> line 22, in __getitem__
>  return self.store[self.normalize(uri)]
> KeyError: 'https://protect2.fireeye.com/url?k=b51ff83f-e8cff0d7-b51e7370-000babff32e3-c25c03b8af1b12ee&u=http://devicetree.org/meta-schemas/core.yaml'
> 

I'm sorry the url was changed when I applied them
because of the internal security system..
I fixed and updated it to devfreq next branch.

Thanks,
Chanwoo Choi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes
  2019-11-22 21:45 ` [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes Leonard Crestez
@ 2019-11-28 14:43   ` Adam Ford
  2019-11-29  5:33     ` Leonard Crestez
  2019-12-09  1:34   ` Shawn Guo
  1 sibling, 1 reply; 25+ messages in thread
From: Adam Ford @ 2019-11-28 14:43 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, linux-clk, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, Chanwoo Choi, MyungJoo Ham, NXP Linux Team,
	devicetree, linux-pm, Rob Herring, Martin Kepplinger,
	Silvano di Ninno, arm-soc, Dong Aisheng, Anson Huang,
	Stephen Boyd, Matthias Kaehlcke, Rafael J. Wysocki,
	Kyungmin Park, Sascha Hauer, Fabio Estevam, Shawn Guo,
	Georgi Djakov

On Fri, Nov 22, 2019 at 3:46 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>
> This is used by the imx-ddrc devfreq driver to implement dynamic
> frequency scaling of DRAM.
>
> Support for proactive scaling via interconnect will come later. The
> high-performance bus masters which need that (display, vpu, gpu) are
> mostly not yet enabled in upstream anyway.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dts  | 18 ++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi     | 10 ++++++++
>  .../boot/dts/freescale/imx8mn-ddr4-evk.dts    | 18 ++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mn.dtsi     | 10 ++++++++
>  arch/arm64/boot/dts/freescale/imx8mq-evk.dts  | 24 +++++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi     | 10 ++++++++
>  6 files changed, 90 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index 28ab17a277bb..ecf0d385c164 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -75,10 +75,28 @@
>
>  &A53_0 {
>         cpu-supply = <&buck2_reg>;
>  };
>
> +&ddrc {
> +       operating-points-v2 = <&ddrc_opp_table>;
> +
> +       ddrc_opp_table: opp-table {
> +               compatible = "operating-points-v2";
> +
> +               opp-25M {
> +                       opp-hz = /bits/ 64 <25000000>;
> +               };
> +               opp-100M {
> +                       opp-hz = /bits/ 64 <100000000>;
> +               };
> +               opp-750M {
> +                       opp-hz = /bits/ 64 <750000000>;
> +               };
> +       };
> +};

The SoC's device tree has the opp for the SoC.  Since the SoC also has
the DDR controller, why not put the opp for the DDR into the SoC's
device tree set for its maximum rates.  If the individual boards need
to change them, they can do it on a case-by-case basis.

As more and more people add devices based on imx8m q/m/n, I can
imaging a lot of these entries will be duplicated if they base their
design on the reference evk for their respective SoC.

> +
>  &fec1 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_fec1>;
>         phy-mode = "rgmii-id";
>         phy-handle = <&ethphy0>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index 6edbdfe2d0d7..3d4802375715 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -856,10 +856,20 @@
>                         #interrupt-cells = <3>;
>                         interrupt-controller;
>                         interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>                 };
>
> +               ddrc: memory-controller@3d400000 {
> +                       compatible = "fsl,imx8mm-ddrc", "fsl,imx8m-ddrc";
> +                       reg = <0x3d400000 0x400000>;
> +                       clock-names = "core", "pll", "alt", "apb";
> +                       clocks = <&clk IMX8MM_CLK_DRAM_CORE>,
> +                                <&clk IMX8MM_DRAM_PLL>,
> +                                <&clk IMX8MM_CLK_DRAM_ALT>,
> +                                <&clk IMX8MM_CLK_DRAM_APB>;
> +               };
> +
>                 ddr-pmu@3d800000 {
>                         compatible = "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu";
>                         reg = <0x3d800000 0x400000>;
>                         interrupt-parent = <&gic>;
>                         interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> index 071949412caf..b051c927c11e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> @@ -15,10 +15,28 @@
>
>  &A53_0 {
>         cpu-supply = <&buck2_reg>;
>  };
>
> +&ddrc {
> +       operating-points-v2 = <&ddrc_opp_table>;
> +
> +       ddrc_opp_table: opp-table {
> +               compatible = "operating-points-v2";
> +
> +               opp-25M {
> +                       opp-hz = /bits/ 64 <25000000>;
> +               };
> +               opp-100M {
> +                       opp-hz = /bits/ 64 <100000000>;
> +               };
> +               opp-600M {
> +                       opp-hz = /bits/ 64 <600000000>;
> +               };
> +       };
> +};
> +
>  &i2c1 {
>         pmic@4b {
>                 compatible = "rohm,bd71847";
>                 reg = <0x4b>;
>                 pinctrl-0 = <&pinctrl_pmic>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index e91625063f8e..3a79fdddc72b 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -757,10 +757,20 @@
>                         #interrupt-cells = <3>;
>                         interrupt-controller;
>                         interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>                 };
>
> +               ddrc: memory-controller@3d400000 {
> +                       compatible = "fsl,imx8mn-ddrc", "fsl,imx8m-ddrc";
> +                       reg = <0x3d400000 0x400000>;
> +                       clock-names = "core", "pll", "alt", "apb";
> +                       clocks = <&clk IMX8MN_CLK_DRAM_CORE>,
> +                                <&clk IMX8MN_DRAM_PLL>,
> +                                <&clk IMX8MN_CLK_DRAM_ALT>,
> +                                <&clk IMX8MN_CLK_DRAM_APB>;
> +               };
> +
>                 ddr-pmu@3d800000 {
>                         compatible = "fsl,imx8mn-ddr-pmu", "fsl,imx8m-ddr-pmu";
>                         reg = <0x3d800000 0x400000>;
>                         interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
>                 };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> index c36685916683..ee6dc5f07622 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -103,10 +103,34 @@
>
>  &A53_3 {
>         cpu-supply = <&buck2_reg>;
>  };
>
> +&ddrc {
> +       operating-points-v2 = <&ddrc_opp_table>;
> +
> +       ddrc_opp_table: opp-table {
> +               compatible = "operating-points-v2";
> +
> +               opp-25M {
> +                       opp-hz = /bits/ 64 <25000000>;
> +               };
> +               opp-100M {
> +                       opp-hz = /bits/ 64 <100000000>;
> +               };
> +               /*
> +                * On imx8mq B0 PLL can't be bypassed so low bus is 166M
> +                */
> +               opp-166M {
> +                       opp-hz = /bits/ 64 <166935483>;
> +               };
> +               opp-800M {
> +                       opp-hz = /bits/ 64 <800000000>;
> +               };
> +       };
> +};
> +
>  &fec1 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_fec1>;
>         phy-mode = "rgmii-id";
>         phy-handle = <&ethphy0>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 7f9319452b58..d1fcf9887f8b 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1111,10 +1111,20 @@
>                         interrupt-controller;
>                         interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>                         interrupt-parent = <&gic>;
>                 };
>
> +               ddrc: memory-controller@3d400000 {
> +                       compatible = "fsl,imx8mq-ddrc", "fsl,imx8m-ddrc";
> +                       reg = <0x3d400000 0x400000>;
> +                       clock-names = "core", "pll", "alt", "apb";
> +                       clocks = <&clk IMX8MQ_CLK_DRAM_CORE>,
> +                                <&clk IMX8MQ_DRAM_PLL_OUT>,
> +                                <&clk IMX8MQ_CLK_DRAM_ALT>,
> +                                <&clk IMX8MQ_CLK_DRAM_APB>;
> +               };
> +
>                 ddr-pmu@3d800000 {
>                         compatible = "fsl,imx8mq-ddr-pmu", "fsl,imx8m-ddr-pmu";
>                         reg = <0x3d800000 0x400000>;
>                         interrupt-parent = <&gic>;
>                         interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes
  2019-11-28 14:43   ` Adam Ford
@ 2019-11-29  5:33     ` Leonard Crestez
  0 siblings, 0 replies; 25+ messages in thread
From: Leonard Crestez @ 2019-11-29  5:33 UTC (permalink / raw)
  To: Adam Ford, Rob Herring, Shawn Guo
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, Chanwoo Choi, MyungJoo Ham,
	dl-linux-imx, devicetree, linux-pm, Martin Kepplinger,
	Silvano Di Ninno, arm-soc, Aisheng Dong, Anson Huang,
	Stephen Boyd, Rafael J. Wysocki, Kyungmin Park, Sascha Hauer,
	Fabio Estevam, Georgi Djakov

On 2019-11-28 4:43 PM, Adam Ford wrote:
> On Fri, Nov 22, 2019 at 3:46 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>>
>> This is used by the imx-ddrc devfreq driver to implement dynamic
>> frequency scaling of DRAM.
>>
>> Support for proactive scaling via interconnect will come later. The
>> high-performance bus masters which need that (display, vpu, gpu) are
>> mostly not yet enabled in upstream anyway.
>>
>> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mm-evk.dts  | 18 ++++++++++++++
>>   arch/arm64/boot/dts/freescale/imx8mm.dtsi     | 10 ++++++++
>>   .../boot/dts/freescale/imx8mn-ddr4-evk.dts    | 18 ++++++++++++++
>>   arch/arm64/boot/dts/freescale/imx8mn.dtsi     | 10 ++++++++
>>   arch/arm64/boot/dts/freescale/imx8mq-evk.dts  | 24 +++++++++++++++++++
>>   arch/arm64/boot/dts/freescale/imx8mq.dtsi     | 10 ++++++++
>>   6 files changed, 90 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
>> index 28ab17a277bb..ecf0d385c164 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
>> @@ -75,10 +75,28 @@
>>
>>   &A53_0 {
>>          cpu-supply = <&buck2_reg>;
>>   };
>>
>> +&ddrc {
>> +       operating-points-v2 = <&ddrc_opp_table>;
>> +
>> +       ddrc_opp_table: opp-table {
>> +               compatible = "operating-points-v2";
>> +
>> +               opp-25M {
>> +                       opp-hz = /bits/ 64 <25000000>;
>> +               };
>> +               opp-100M {
>> +                       opp-hz = /bits/ 64 <100000000>;
>> +               };
>> +               opp-750M {
>> +                       opp-hz = /bits/ 64 <750000000>;
>> +               };
>> +       };
>> +};
> 
> The SoC's device tree has the opp for the SoC.  Since the SoC also has
> the DDR controller, why not put the opp for the DDR into the SoC's
> device tree set for its maximum rates.  If the individual boards need
> to change them, they can do it on a case-by-case basis.
> 
> As more and more people add devices based on imx8m q/m/n, I can
> imaging a lot of these entries will be duplicated if they base their
> design on the reference evk for their respective SoC.

The OPPs can vary from board to board for the same SoC. For example ddr4 
and lpddr4 variants of the NXP evk boards have different setpoints.

If a default set was included in soc dtsi then some boards would end up 
having to use /delete-node/ and I wanted to avoid that. Last I check 
that feature wasn't even officially documented for dtc?

Perhaps this could be revisited if it ends up being duplicated on many 
boards.

--
Regards,
Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
  2019-11-22 21:45 ` [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks Leonard Crestez
  2019-11-25  1:25   ` Stephen Boyd
@ 2019-12-09  1:15   ` Shawn Guo
  1 sibling, 0 replies; 25+ messages in thread
From: Shawn Guo @ 2019-12-09  1:15 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, Chanwoo Choi, MyungJoo Ham,
	linux-imx, devicetree, linux-pm, Rob Herring, Martin Kepplinger,
	Silvano di Ninno, linux-arm-kernel, Dong Aisheng, Anson Huang,
	Stephen Boyd, Rafael J. Wysocki, Kyungmin Park, kernel,
	Fabio Estevam, Georgi Djakov

On Fri, Nov 22, 2019 at 11:45:00PM +0200, Leonard Crestez wrote:
> These clocks are only modified as part of DRAM frequency switches during
> which DRAM itself is briefly inaccessible. The switch is performed with
> a SMC call to by TF-A which runs from a SRAM area; upon returning to
> linux several clocks bits are modified and we need to update them.
> 
> For rate bits an easy solution is to just mark with
> CLK_GET_RATE_NOCACHE so that new rates are always read back from
> registers.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 2/5] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
  2019-11-22 21:45 ` [PATCH v7 2/5] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE Leonard Crestez
  2019-11-25  1:26   ` Stephen Boyd
@ 2019-12-09  1:16   ` Shawn Guo
  1 sibling, 0 replies; 25+ messages in thread
From: Shawn Guo @ 2019-12-09  1:16 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, Chanwoo Choi, MyungJoo Ham,
	linux-imx, devicetree, linux-pm, Rob Herring, Martin Kepplinger,
	Silvano di Ninno, linux-arm-kernel, Dong Aisheng, Anson Huang,
	Stephen Boyd, Rafael J. Wysocki, Kyungmin Park, kernel,
	Fabio Estevam, Georgi Djakov

On Fri, Nov 22, 2019 at 11:45:01PM +0200, Leonard Crestez wrote:
> DRAM frequency switches are executed in firmware and can change the
> configuration of the DRAM PLL outside linux. Mark these CLKs with
> CLK_GET_RATE_NOCACHE so we always read back the PLL config registers and
> recalculate rates.
> 
> In current DRAM frequency tables on 8mm/8mn only the maximum frequency
> uses the PLL so it's always configured in the same way. However reading
> back the PLL configuration is the correct behavior and allows additional
> setpoints in the future.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes
  2019-11-22 21:45 ` [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes Leonard Crestez
  2019-11-28 14:43   ` Adam Ford
@ 2019-12-09  1:34   ` Shawn Guo
  1 sibling, 0 replies; 25+ messages in thread
From: Shawn Guo @ 2019-12-09  1:34 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, Matthias Kaehlcke, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, linux-clk, Chanwoo Choi, MyungJoo Ham,
	linux-imx, devicetree, linux-pm, Rob Herring, Martin Kepplinger,
	Silvano di Ninno, linux-arm-kernel, Dong Aisheng, Anson Huang,
	Stephen Boyd, Rafael J. Wysocki, Kyungmin Park, kernel,
	Fabio Estevam, Georgi Djakov

On Fri, Nov 22, 2019 at 11:45:04PM +0200, Leonard Crestez wrote:
> This is used by the imx-ddrc devfreq driver to implement dynamic
> frequency scaling of DRAM.
> 
> Support for proactive scaling via interconnect will come later. The
> high-performance bus masters which need that (display, vpu, gpu) are
> mostly not yet enabled in upstream anyway.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dts  | 18 ++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi     | 10 ++++++++
>  .../boot/dts/freescale/imx8mn-ddr4-evk.dts    | 18 ++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mn.dtsi     | 10 ++++++++
>  arch/arm64/boot/dts/freescale/imx8mq-evk.dts  | 24 +++++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi     | 10 ++++++++
>  6 files changed, 90 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index 28ab17a277bb..ecf0d385c164 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -75,10 +75,28 @@
>  
>  &A53_0 {
>  	cpu-supply = <&buck2_reg>;
>  };
>  
> +&ddrc {
> +	operating-points-v2 = <&ddrc_opp_table>;
> +
> +	ddrc_opp_table: opp-table {
> +		compatible = "operating-points-v2";
> +
> +		opp-25M {
> +			opp-hz = /bits/ 64 <25000000>;
> +		};

As an idiomatic practice, we have newline between nodes.

I fixed it up and applied the patch.

Shawn

> +		opp-100M {
> +			opp-hz = /bits/ 64 <100000000>;
> +		};
> +		opp-750M {
> +			opp-hz = /bits/ 64 <750000000>;
> +		};
> +	};
> +};
> +
>  &fec1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_fec1>;
>  	phy-mode = "rgmii-id";
>  	phy-handle = <&ethphy0>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index 6edbdfe2d0d7..3d4802375715 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -856,10 +856,20 @@
>  			#interrupt-cells = <3>;
>  			interrupt-controller;
>  			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>  		};
>  
> +		ddrc: memory-controller@3d400000 {
> +			compatible = "fsl,imx8mm-ddrc", "fsl,imx8m-ddrc";
> +			reg = <0x3d400000 0x400000>;
> +			clock-names = "core", "pll", "alt", "apb";
> +			clocks = <&clk IMX8MM_CLK_DRAM_CORE>,
> +				 <&clk IMX8MM_DRAM_PLL>,
> +				 <&clk IMX8MM_CLK_DRAM_ALT>,
> +				 <&clk IMX8MM_CLK_DRAM_APB>;
> +		};
> +
>  		ddr-pmu@3d800000 {
>  			compatible = "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu";
>  			reg = <0x3d800000 0x400000>;
>  			interrupt-parent = <&gic>;
>  			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> index 071949412caf..b051c927c11e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> @@ -15,10 +15,28 @@
>  
>  &A53_0 {
>  	cpu-supply = <&buck2_reg>;
>  };
>  
> +&ddrc {
> +	operating-points-v2 = <&ddrc_opp_table>;
> +
> +	ddrc_opp_table: opp-table {
> +		compatible = "operating-points-v2";
> +
> +		opp-25M {
> +			opp-hz = /bits/ 64 <25000000>;
> +		};
> +		opp-100M {
> +			opp-hz = /bits/ 64 <100000000>;
> +		};
> +		opp-600M {
> +			opp-hz = /bits/ 64 <600000000>;
> +		};
> +	};
> +};
> +
>  &i2c1 {
>  	pmic@4b {
>  		compatible = "rohm,bd71847";
>  		reg = <0x4b>;
>  		pinctrl-0 = <&pinctrl_pmic>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index e91625063f8e..3a79fdddc72b 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -757,10 +757,20 @@
>  			#interrupt-cells = <3>;
>  			interrupt-controller;
>  			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>  		};
>  
> +		ddrc: memory-controller@3d400000 {
> +			compatible = "fsl,imx8mn-ddrc", "fsl,imx8m-ddrc";
> +			reg = <0x3d400000 0x400000>;
> +			clock-names = "core", "pll", "alt", "apb";
> +			clocks = <&clk IMX8MN_CLK_DRAM_CORE>,
> +				 <&clk IMX8MN_DRAM_PLL>,
> +				 <&clk IMX8MN_CLK_DRAM_ALT>,
> +				 <&clk IMX8MN_CLK_DRAM_APB>;
> +		};
> +
>  		ddr-pmu@3d800000 {
>  			compatible = "fsl,imx8mn-ddr-pmu", "fsl,imx8m-ddr-pmu";
>  			reg = <0x3d800000 0x400000>;
>  			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
>  		};
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> index c36685916683..ee6dc5f07622 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -103,10 +103,34 @@
>  
>  &A53_3 {
>  	cpu-supply = <&buck2_reg>;
>  };
>  
> +&ddrc {
> +	operating-points-v2 = <&ddrc_opp_table>;
> +
> +	ddrc_opp_table: opp-table {
> +		compatible = "operating-points-v2";
> +
> +		opp-25M {
> +			opp-hz = /bits/ 64 <25000000>;
> +		};
> +		opp-100M {
> +			opp-hz = /bits/ 64 <100000000>;
> +		};
> +		/*
> +		 * On imx8mq B0 PLL can't be bypassed so low bus is 166M
> +		 */
> +		opp-166M {
> +			opp-hz = /bits/ 64 <166935483>;
> +		};
> +		opp-800M {
> +			opp-hz = /bits/ 64 <800000000>;
> +		};
> +	};
> +};
> +
>  &fec1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_fec1>;
>  	phy-mode = "rgmii-id";
>  	phy-handle = <&ethphy0>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 7f9319452b58..d1fcf9887f8b 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1111,10 +1111,20 @@
>  			interrupt-controller;
>  			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>  			interrupt-parent = <&gic>;
>  		};
>  
> +		ddrc: memory-controller@3d400000 {
> +			compatible = "fsl,imx8mq-ddrc", "fsl,imx8m-ddrc";
> +			reg = <0x3d400000 0x400000>;
> +			clock-names = "core", "pll", "alt", "apb";
> +			clocks = <&clk IMX8MQ_CLK_DRAM_CORE>,
> +				 <&clk IMX8MQ_DRAM_PLL_OUT>,
> +				 <&clk IMX8MQ_CLK_DRAM_ALT>,
> +				 <&clk IMX8MQ_CLK_DRAM_APB>;
> +		};
> +
>  		ddr-pmu@3d800000 {
>  			compatible = "fsl,imx8mq-ddr-pmu", "fsl,imx8m-ddr-pmu";
>  			reg = <0x3d800000 0x400000>;
>  			interrupt-parent = <&gic>;
>  			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2019-11-22 21:44 [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Leonard Crestez
                   ` (4 preceding siblings ...)
  2019-11-22 21:45 ` [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes Leonard Crestez
@ 2019-12-18 13:35 ` Adam Ford
  2019-12-18 14:44   ` Leonard Crestez
  5 siblings, 1 reply; 25+ messages in thread
From: Adam Ford @ 2019-12-18 13:35 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, linux-clk, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, Chanwoo Choi, MyungJoo Ham, NXP Linux Team,
	devicetree, linux-pm, Rob Herring, Martin Kepplinger,
	Silvano di Ninno, arm-soc, Dong Aisheng, Anson Huang,
	Stephen Boyd, Matthias Kaehlcke, Rafael J. Wysocki,
	Kyungmin Park, Sascha Hauer, Fabio Estevam, Shawn Guo,
	Georgi Djakov

On Fri, Nov 22, 2019 at 3:45 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>
> This adds support for dynamic scaling of the DDR Controller (ddrc)
> present on i.MX8M series chips. Actual frequency switching is
> implemented inside TF-A, this driver wraps the SMC calls and
> synchronizes the clk tree.
>
> DRAM frequency switching requires clock manipulation but during this operation
> DRAM itself is briefly inaccessible so this operation is performed a SMC call
> to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree
> is updated to correspond to hardware configuration.
>
> This is handled via CLK_GET_RATE_NO_CACHE for dividers but muxes are handled
> manually: the driver will prepare/enable the new parents ahead of switching (so
> that the expected roots are enabled) and afterwards it will call clk_set_parent
> to ensure the parents in clock framework are up-to-date.
>
> This series is useful standalone and roughly similar to devfreq drivers for
> tegra and rockchip.
>
> Running at lower dram rates saves power but can affect the functionality of
> other blocks in the chip (display, vpu etc). Support for in-kernel constraints
> will some separately.
>
> This series has no dependencies outside linux-next. The driver depends
> on features from the NXP branch of TF-A and will cleanly fail to probe
> on mainline. There are also plans to upstream dram dvfs in TF-A.
>
> Changes since v6:
> * Replace ARCH_MXC || COMPILE_TEST with ARCH_MXC && HAVE_ARM_SMCCC
> * Collect reviews
> Link to v6: https://patchwork.kernel.org/cover/11244283/
>
> I'd rather not fix COMPILE_TEST with ifdefs for this driver, if anything
> that should be fixed in smccc header. ARCH_MXC doesn't imply SMCCC, it
> also covers some very old chips which don't have it.
>
> Resending full series because that's the standard method.
>
> Changes since v5:
> * Fix a dram_apb/dram_alt mixup in imx8m_ddrc_set_freq
> * Make clk_get_parent_by_index static (kbuild robot)
> * Adjust messages in imx8m_ddrc_set_freq
> * Use a for loop inside imx8m_ddrc_check_opps instead of while
> * More elaborate description in dt-bindings file.
> Link to v5: https://patchwork.kernel.org/cover/11240289/
>
> Changes since v4:
> * Restore empty _get_dev_status: testing shows this is *NOT* optional. If
> absent then switching to simple_ondemand governor will trigger an Oops.
> * Keep clk registration on single-line in clk-imx8m* for consistency with rest
> of the file.
> * Drop explicit "select PM_OPP"
> * Check for NULL new_dram_core_parent
> * Rename "out_dis_" labels to out_disable_*
> * Use dev_warn on imx8m_ddrc_set_freq error paths after SMC call (where
> operation is not abandoned).
> * More elaborate error messages in imx8m_ddrc_target
> * More elaborate checks when fetching clks in imx8m_ddrc_set_freq
> * Rename ddrc nodes to memory-controller@* as per devicetree.org "Generic Names
> Recommendation"
> * Defer perf support, it requires perf changes to fetch PMU by DT
> Link to v4: https://patchwork.kernel.org/cover/11235685/
>
> Changes since v3:
> * Rename to imx8m-ddrc. Similar blocks are present on imx7d and imx8qxp/imx8qm
> but soc integration is different.
> * Move dt bindings to /memory-controllers/fsl/
> * Fix dt validation issues
> * Fix imx8mm.dtsi ddrc referencing ddrc_opp_table which is only defined in evk
> * Move opps to child of ddrc device node
> * Only add imx_ddrc_get_dev_status in perf patch.
> * Adjust print messages
> Link to v3: https://patchwork.kernel.org/cover/11221935/
>
> Changes since v2:
> * Add support for entire imx8m family including imx8mq B0.
> * Also mark dram PLLs as CLK_GET_RATE_NO_CACHE (required for imx8mq b0 low OPP)
> * Explicitly update dram pll rate at the end of imx_ddrc_set_freq.
> * Use do_div in imx-ddrc (kbuild robot)
> * Improve explanations around adding CLK_GET_RATE_NO_CACHE to dram clks.
> (Stephen Boyd)
> * Handle ddrc devfreq-events earlier for fewer probe defers.
> * Validate DDRC opp tables versus firmware: supported OPPs depend on board and
> SOC revision.
> * Move DDRC opp tables to board dts because they can vary based on ram type on
> board.
> * Verify DDRC rate is changed in clk tree and otherwise report an error.
> * Change imx_ddrc_freq.rate to be measure in MT/s and round down from HZ in
> imx_ddrc_find_freq instead.
> * Split away from NOC scaling and interconnect support.
> Link to v2: https://patchwork.kernel.org/cover/11104113/
>
> Changes since v1:
> * bindings: Stop using "contains" for "compatible"
> * bindings: Set "additionalProperties: false" and document missing stuff.
> * Remove (c) from NXP copyright notice
> * Fix various checkpatch issues
> * Remove unused dram_alt_root clk from imx-ddrc
> Link to v1: https://patchwork.kernel.org/cover/11090649/
>
> Leonard Crestez (5):
>   clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
>   clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
>   dt-bindings: memory: Add bindings for imx8m ddr controller
>   PM / devfreq: Add dynamic scaling for imx8m ddr controller
>   arm64: dts: imx8m: Add ddr controller nodes
>
>  .../memory-controllers/fsl/imx8m-ddrc.yaml    |  72 +++
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dts  |  18 +
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  10 +
>  .../boot/dts/freescale/imx8mn-ddr4-evk.dts    |  18 +
>  arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  10 +
>  arch/arm64/boot/dts/freescale/imx8mq-evk.dts  |  24 +
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  10 +
>  drivers/clk/imx/clk-imx8mm.c                  |  11 +-
>  drivers/clk/imx/clk-imx8mn.c                  |  12 +-
>  drivers/clk/imx/clk-imx8mq.c                  |  12 +-
>  drivers/clk/imx/clk-pll14xx.c                 |   7 +
>  drivers/clk/imx/clk.h                         |   1 +
>  drivers/devfreq/Kconfig                       |   9 +

Since there is a Kconfig change, should there me a defconfig change?

>  drivers/devfreq/Makefile                      |   1 +
>  drivers/devfreq/imx8m-ddrc.c                  | 465 ++++++++++++++++++
>  15 files changed, 670 insertions(+), 10 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml
>  create mode 100644 drivers/devfreq/imx8m-ddrc.c

I applied the whole series against 5.5-rc1 and I am trying to test it.
I know the 4.14 kernel NXP posted on Code Aurora is capable to
lowering the DDRC controller to 25MHz on the 8MM when the video is
off.  Since there is no video support yet for the 8MM, I was expecting
to see the DDRC clock to be at or around 25MHz.

Using debug FS, I can see the dram core clock is still running at
750MHz, and measuring power, it shows something consistent with what I
see on the Code Aurora kernel with video turned on and the clock at
750MHz.

Is there some way to get the dram_core_clk to drop to 25MHz to see
some power reduction?  The same commands used in the Yocto build don't
apply here since we don't have video.

thanks,

adam
>
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2019-12-18 13:35 ` [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Adam Ford
@ 2019-12-18 14:44   ` Leonard Crestez
  2019-12-18 15:05     ` Adam Ford
  0 siblings, 1 reply; 25+ messages in thread
From: Leonard Crestez @ 2019-12-18 14:44 UTC (permalink / raw)
  To: Adam Ford
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, linux-clk, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, Chanwoo Choi, MyungJoo Ham, dl-linux-imx,
	devicetree, linux-pm, Rob Herring, Martin Kepplinger,
	Silvano Di Ninno, arm-soc, Aisheng Dong, Anson Huang,
	Stephen Boyd, Matthias Kaehlcke, Rafael J. Wysocki,
	Kyungmin Park, Sascha Hauer, Fabio Estevam, Shawn Guo,
	Georgi Djakov

On 18.12.2019 15:35, Adam Ford wrote:
> On Fri, Nov 22, 2019 at 3:45 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>>
>> This adds support for dynamic scaling of the DDR Controller (ddrc)
>> present on i.MX8M series chips. Actual frequency switching is
>> implemented inside TF-A, this driver wraps the SMC calls and
>> synchronizes the clk tree.
>>
>> DRAM frequency switching requires clock manipulation but during this operation
>> DRAM itself is briefly inaccessible so this operation is performed a SMC call
>> to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree
>> is updated to correspond to hardware configuration.
>>
>> This is handled via CLK_GET_RATE_NO_CACHE for dividers but muxes are handled
>> manually: the driver will prepare/enable the new parents ahead of switching (so
>> that the expected roots are enabled) and afterwards it will call clk_set_parent
>> to ensure the parents in clock framework are up-to-date.
>>
>> This series is useful standalone and roughly similar to devfreq drivers for
>> tegra and rockchip.
>>
>> Running at lower dram rates saves power but can affect the functionality of
>> other blocks in the chip (display, vpu etc). Support for in-kernel constraints
>> will some separately.
>>
>> This series has no dependencies outside linux-next. The driver depends
>> on features from the NXP branch of TF-A and will cleanly fail to probe
>> on mainline. There are also plans to upstream dram dvfs in TF-A.
>>
>> Changes since v6:
>> * Replace ARCH_MXC || COMPILE_TEST with ARCH_MXC && HAVE_ARM_SMCCC
>> * Collect reviews
>> Link to v6: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11244283%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275120308&amp;sdata=ZEZnG6pijjj4MObC99c6%2BvC8BFEfT1KLVxbJCNocoWw%3D&amp;reserved=0
>>
>> I'd rather not fix COMPILE_TEST with ifdefs for this driver, if anything
>> that should be fixed in smccc header. ARCH_MXC doesn't imply SMCCC, it
>> also covers some very old chips which don't have it.
>>
>> Resending full series because that's the standard method.
>>
>> Changes since v5:
>> * Fix a dram_apb/dram_alt mixup in imx8m_ddrc_set_freq
>> * Make clk_get_parent_by_index static (kbuild robot)
>> * Adjust messages in imx8m_ddrc_set_freq
>> * Use a for loop inside imx8m_ddrc_check_opps instead of while
>> * More elaborate description in dt-bindings file.
>> Link to v5: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11240289%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&amp;sdata=mMqglPQign%2B6NHgmDYoZ74%2FZeThGI6%2FgNkajo1VaHTI%3D&amp;reserved=0
>>
>> Changes since v4:
>> * Restore empty _get_dev_status: testing shows this is *NOT* optional. If
>> absent then switching to simple_ondemand governor will trigger an Oops.
>> * Keep clk registration on single-line in clk-imx8m* for consistency with rest
>> of the file.
>> * Drop explicit "select PM_OPP"
>> * Check for NULL new_dram_core_parent
>> * Rename "out_dis_" labels to out_disable_*
>> * Use dev_warn on imx8m_ddrc_set_freq error paths after SMC call (where
>> operation is not abandoned).
>> * More elaborate error messages in imx8m_ddrc_target
>> * More elaborate checks when fetching clks in imx8m_ddrc_set_freq
>> * Rename ddrc nodes to memory-controller@* as per devicetree.org "Generic Names
>> Recommendation"
>> * Defer perf support, it requires perf changes to fetch PMU by DT
>> Link to v4: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11235685%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&amp;sdata=LXG4bo0l7FOttZIolJE73CK67AAAW72xfx8yq3Vld7o%3D&amp;reserved=0
>>
>> Changes since v3:
>> * Rename to imx8m-ddrc. Similar blocks are present on imx7d and imx8qxp/imx8qm
>> but soc integration is different.
>> * Move dt bindings to /memory-controllers/fsl/
>> * Fix dt validation issues
>> * Fix imx8mm.dtsi ddrc referencing ddrc_opp_table which is only defined in evk
>> * Move opps to child of ddrc device node
>> * Only add imx_ddrc_get_dev_status in perf patch.
>> * Adjust print messages
>> Link to v3: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11221935%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&amp;sdata=%2FFGddgm7jq87j7tz6gNd%2B7V%2BGX4KF5RaPsnXK2kITdQ%3D&amp;reserved=0
>>
>> Changes since v2:
>> * Add support for entire imx8m family including imx8mq B0.
>> * Also mark dram PLLs as CLK_GET_RATE_NO_CACHE (required for imx8mq b0 low OPP)
>> * Explicitly update dram pll rate at the end of imx_ddrc_set_freq.
>> * Use do_div in imx-ddrc (kbuild robot)
>> * Improve explanations around adding CLK_GET_RATE_NO_CACHE to dram clks.
>> (Stephen Boyd)
>> * Handle ddrc devfreq-events earlier for fewer probe defers.
>> * Validate DDRC opp tables versus firmware: supported OPPs depend on board and
>> SOC revision.
>> * Move DDRC opp tables to board dts because they can vary based on ram type on
>> board.
>> * Verify DDRC rate is changed in clk tree and otherwise report an error.
>> * Change imx_ddrc_freq.rate to be measure in MT/s and round down from HZ in
>> imx_ddrc_find_freq instead.
>> * Split away from NOC scaling and interconnect support.
>> Link to v2: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11104113%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&amp;sdata=3hh0dR1h4Esc6qo79QQKH%2FkUQjrOUgLANR0PcIz1Pss%3D&amp;reserved=0
>>
>> Changes since v1:
>> * bindings: Stop using "contains" for "compatible"
>> * bindings: Set "additionalProperties: false" and document missing stuff.
>> * Remove (c) from NXP copyright notice
>> * Fix various checkpatch issues
>> * Remove unused dram_alt_root clk from imx-ddrc
>> Link to v1: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11090649%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&amp;sdata=Hj6NEmoaRHoR%2BQpFoUDdTlybO%2FSTatO2fFo20UGLJf0%3D&amp;reserved=0
>>
>> Leonard Crestez (5):
>>    clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
>>    clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
>>    dt-bindings: memory: Add bindings for imx8m ddr controller
>>    PM / devfreq: Add dynamic scaling for imx8m ddr controller
>>    arm64: dts: imx8m: Add ddr controller nodes
>>
>>   .../memory-controllers/fsl/imx8m-ddrc.yaml    |  72 +++
>>   arch/arm64/boot/dts/freescale/imx8mm-evk.dts  |  18 +
>>   arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  10 +
>>   .../boot/dts/freescale/imx8mn-ddr4-evk.dts    |  18 +
>>   arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  10 +
>>   arch/arm64/boot/dts/freescale/imx8mq-evk.dts  |  24 +
>>   arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  10 +
>>   drivers/clk/imx/clk-imx8mm.c                  |  11 +-
>>   drivers/clk/imx/clk-imx8mn.c                  |  12 +-
>>   drivers/clk/imx/clk-imx8mq.c                  |  12 +-
>>   drivers/clk/imx/clk-pll14xx.c                 |   7 +
>>   drivers/clk/imx/clk.h                         |   1 +
>>   drivers/devfreq/Kconfig                       |   9 +
> 
> Since there is a Kconfig change, should there me a defconfig change?

Yes, you need to enable CONFIG_ARM_IMX8M_DDRC_DEVFREQ in order to test 
this. Enabling as "m" should work.

>>   drivers/devfreq/Makefile                      |   1 +
>>   drivers/devfreq/imx8m-ddrc.c                  | 465 ++++++++++++++++++
>>   15 files changed, 670 insertions(+), 10 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml
>>   create mode 100644 drivers/devfreq/imx8m-ddrc.c
> 
> I applied the whole series against 5.5-rc1 and I am trying to test it.
> I know the 4.14 kernel NXP posted on Code Aurora is capable to
> lowering the DDRC controller to 25MHz on the 8MM when the video is
> off.  Since there is no video support yet for the 8MM, I was expecting
> to see the DDRC clock to be at or around 25MHz.
> 
> Using debug FS, I can see the dram core clock is still running at
> 750MHz, and measuring power, it shows something consistent with what I
> see on the Code Aurora kernel with video turned on and the clock at
> 750MHz.
> 
> Is there some way to get the dram_core_clk to drop to 25MHz to see
> some power reduction?  The same commands used in the Yocto build don't
> apply here since we don't have video.

Current upstream driver just keeps current frequency by default. Try the 
following:

cd /sys/class/devfreq/devices/devfreq0
echo userspace > governor
echo 25000000 > userspace/set_freq
cat /sys/kernel/debug/clk/dram_core_clk/clk_rate
echo 750000000 > userspace/set_freq
cat /sys/kernel/debug/clk/dram_core_clk/clk_rate

--
Regards,
Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2019-12-18 14:44   ` Leonard Crestez
@ 2019-12-18 15:05     ` Adam Ford
  2019-12-18 15:16       ` Leonard Crestez
  0 siblings, 1 reply; 25+ messages in thread
From: Adam Ford @ 2019-12-18 15:05 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, linux-clk, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, Chanwoo Choi, MyungJoo Ham, dl-linux-imx,
	devicetree, linux-pm, Rob Herring, Martin Kepplinger,
	Silvano Di Ninno, arm-soc, Aisheng Dong, Anson Huang,
	Stephen Boyd, Matthias Kaehlcke, Rafael J. Wysocki,
	Kyungmin Park, Sascha Hauer, Fabio Estevam, Shawn Guo,
	Georgi Djakov

On Wed, Dec 18, 2019 at 8:44 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>
> On 18.12.2019 15:35, Adam Ford wrote:
> > On Fri, Nov 22, 2019 at 3:45 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
> >>
> >> This adds support for dynamic scaling of the DDR Controller (ddrc)
> >> present on i.MX8M series chips. Actual frequency switching is
> >> implemented inside TF-A, this driver wraps the SMC calls and
> >> synchronizes the clk tree.
> >>
> >> DRAM frequency switching requires clock manipulation but during this operation
> >> DRAM itself is briefly inaccessible so this operation is performed a SMC call
> >> to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree
> >> is updated to correspond to hardware configuration.
> >>
> >> This is handled via CLK_GET_RATE_NO_CACHE for dividers but muxes are handled
> >> manually: the driver will prepare/enable the new parents ahead of switching (so
> >> that the expected roots are enabled) and afterwards it will call clk_set_parent
> >> to ensure the parents in clock framework are up-to-date.
> >>
> >> This series is useful standalone and roughly similar to devfreq drivers for
> >> tegra and rockchip.
> >>
> >> Running at lower dram rates saves power but can affect the functionality of
> >> other blocks in the chip (display, vpu etc). Support for in-kernel constraints
> >> will some separately.
> >>
> >> This series has no dependencies outside linux-next. The driver depends
> >> on features from the NXP branch of TF-A and will cleanly fail to probe
> >> on mainline. There are also plans to upstream dram dvfs in TF-A.
> >>
> >> Changes since v6:
> >> * Replace ARCH_MXC || COMPILE_TEST with ARCH_MXC && HAVE_ARM_SMCCC
> >> * Collect reviews
> >> Link to v6: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11244283%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275120308&amp;sdata=ZEZnG6pijjj4MObC99c6%2BvC8BFEfT1KLVxbJCNocoWw%3D&amp;reserved=0
> >>
> >> I'd rather not fix COMPILE_TEST with ifdefs for this driver, if anything
> >> that should be fixed in smccc header. ARCH_MXC doesn't imply SMCCC, it
> >> also covers some very old chips which don't have it.
> >>
> >> Resending full series because that's the standard method.
> >>
> >> Changes since v5:
> >> * Fix a dram_apb/dram_alt mixup in imx8m_ddrc_set_freq
> >> * Make clk_get_parent_by_index static (kbuild robot)
> >> * Adjust messages in imx8m_ddrc_set_freq
> >> * Use a for loop inside imx8m_ddrc_check_opps instead of while
> >> * More elaborate description in dt-bindings file.
> >> Link to v5: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11240289%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&amp;sdata=mMqglPQign%2B6NHgmDYoZ74%2FZeThGI6%2FgNkajo1VaHTI%3D&amp;reserved=0
> >>
> >> Changes since v4:
> >> * Restore empty _get_dev_status: testing shows this is *NOT* optional. If
> >> absent then switching to simple_ondemand governor will trigger an Oops.
> >> * Keep clk registration on single-line in clk-imx8m* for consistency with rest
> >> of the file.
> >> * Drop explicit "select PM_OPP"
> >> * Check for NULL new_dram_core_parent
> >> * Rename "out_dis_" labels to out_disable_*
> >> * Use dev_warn on imx8m_ddrc_set_freq error paths after SMC call (where
> >> operation is not abandoned).
> >> * More elaborate error messages in imx8m_ddrc_target
> >> * More elaborate checks when fetching clks in imx8m_ddrc_set_freq
> >> * Rename ddrc nodes to memory-controller@* as per devicetree.org "Generic Names
> >> Recommendation"
> >> * Defer perf support, it requires perf changes to fetch PMU by DT
> >> Link to v4: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11235685%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&amp;sdata=LXG4bo0l7FOttZIolJE73CK67AAAW72xfx8yq3Vld7o%3D&amp;reserved=0
> >>
> >> Changes since v3:
> >> * Rename to imx8m-ddrc. Similar blocks are present on imx7d and imx8qxp/imx8qm
> >> but soc integration is different.
> >> * Move dt bindings to /memory-controllers/fsl/
> >> * Fix dt validation issues
> >> * Fix imx8mm.dtsi ddrc referencing ddrc_opp_table which is only defined in evk
> >> * Move opps to child of ddrc device node
> >> * Only add imx_ddrc_get_dev_status in perf patch.
> >> * Adjust print messages
> >> Link to v3: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11221935%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&amp;sdata=%2FFGddgm7jq87j7tz6gNd%2B7V%2BGX4KF5RaPsnXK2kITdQ%3D&amp;reserved=0
> >>
> >> Changes since v2:
> >> * Add support for entire imx8m family including imx8mq B0.
> >> * Also mark dram PLLs as CLK_GET_RATE_NO_CACHE (required for imx8mq b0 low OPP)
> >> * Explicitly update dram pll rate at the end of imx_ddrc_set_freq.
> >> * Use do_div in imx-ddrc (kbuild robot)
> >> * Improve explanations around adding CLK_GET_RATE_NO_CACHE to dram clks.
> >> (Stephen Boyd)
> >> * Handle ddrc devfreq-events earlier for fewer probe defers.
> >> * Validate DDRC opp tables versus firmware: supported OPPs depend on board and
> >> SOC revision.
> >> * Move DDRC opp tables to board dts because they can vary based on ram type on
> >> board.
> >> * Verify DDRC rate is changed in clk tree and otherwise report an error.
> >> * Change imx_ddrc_freq.rate to be measure in MT/s and round down from HZ in
> >> imx_ddrc_find_freq instead.
> >> * Split away from NOC scaling and interconnect support.
> >> Link to v2: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11104113%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&amp;sdata=3hh0dR1h4Esc6qo79QQKH%2FkUQjrOUgLANR0PcIz1Pss%3D&amp;reserved=0
> >>
> >> Changes since v1:
> >> * bindings: Stop using "contains" for "compatible"
> >> * bindings: Set "additionalProperties: false" and document missing stuff.
> >> * Remove (c) from NXP copyright notice
> >> * Fix various checkpatch issues
> >> * Remove unused dram_alt_root clk from imx-ddrc
> >> Link to v1: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11090649%2F&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&amp;sdata=Hj6NEmoaRHoR%2BQpFoUDdTlybO%2FSTatO2fFo20UGLJf0%3D&amp;reserved=0
> >>
> >> Leonard Crestez (5):
> >>    clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
> >>    clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
> >>    dt-bindings: memory: Add bindings for imx8m ddr controller
> >>    PM / devfreq: Add dynamic scaling for imx8m ddr controller
> >>    arm64: dts: imx8m: Add ddr controller nodes
> >>
> >>   .../memory-controllers/fsl/imx8m-ddrc.yaml    |  72 +++
> >>   arch/arm64/boot/dts/freescale/imx8mm-evk.dts  |  18 +
> >>   arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  10 +
> >>   .../boot/dts/freescale/imx8mn-ddr4-evk.dts    |  18 +
> >>   arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  10 +
> >>   arch/arm64/boot/dts/freescale/imx8mq-evk.dts  |  24 +
> >>   arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  10 +
> >>   drivers/clk/imx/clk-imx8mm.c                  |  11 +-
> >>   drivers/clk/imx/clk-imx8mn.c                  |  12 +-
> >>   drivers/clk/imx/clk-imx8mq.c                  |  12 +-
> >>   drivers/clk/imx/clk-pll14xx.c                 |   7 +
> >>   drivers/clk/imx/clk.h                         |   1 +
> >>   drivers/devfreq/Kconfig                       |   9 +
> >
> > Since there is a Kconfig change, should there me a defconfig change?
>
> Yes, you need to enable CONFIG_ARM_IMX8M_DDRC_DEVFREQ in order to test
> this. Enabling as "m" should work.

I enabled it as 'm' but I was more curious to know if we should push
this upstream with the rest of the series.

>
> >>   drivers/devfreq/Makefile                      |   1 +
> >>   drivers/devfreq/imx8m-ddrc.c                  | 465 ++++++++++++++++++
> >>   15 files changed, 670 insertions(+), 10 deletions(-)
> >>   create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml
> >>   create mode 100644 drivers/devfreq/imx8m-ddrc.c
> >
> > I applied the whole series against 5.5-rc1 and I am trying to test it.
> > I know the 4.14 kernel NXP posted on Code Aurora is capable to
> > lowering the DDRC controller to 25MHz on the 8MM when the video is
> > off.  Since there is no video support yet for the 8MM, I was expecting
> > to see the DDRC clock to be at or around 25MHz.
> >
> > Using debug FS, I can see the dram core clock is still running at
> > 750MHz, and measuring power, it shows something consistent with what I
> > see on the Code Aurora kernel with video turned on and the clock at
> > 750MHz.
> >
> > Is there some way to get the dram_core_clk to drop to 25MHz to see
> > some power reduction?  The same commands used in the Yocto build don't
> > apply here since we don't have video.
>
> Current upstream driver just keeps current frequency by default. Try the
> following:
>
> cd /sys/class/devfreq/devices/devfreq0

can't cd to /sys/class/devfreq/devices/devfreq0: No such file or directory

I did some checking and I found:
    imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
firmware freq info: -19

Was there some prerequisite patches I needed to apply before your series?

I applied them against 5.5-r1, but if there is a better branch
somewhere, I can try that as well.

adam

> echo userspace > governor
> echo 25000000 > userspace/set_freq
> cat /sys/kernel/debug/clk/dram_core_clk/clk_rate
> echo 750000000 > userspace/set_freq
> cat /sys/kernel/debug/clk/dram_core_clk/clk_rate
>
> --
> Regards,
> Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2019-12-18 15:05     ` Adam Ford
@ 2019-12-18 15:16       ` Leonard Crestez
  2019-12-18 15:37         ` Adam Ford
  0 siblings, 1 reply; 25+ messages in thread
From: Leonard Crestez @ 2019-12-18 15:16 UTC (permalink / raw)
  To: Adam Ford, Jacky Bai
  Cc: Mark Rutland, Artur Świgoń,
	Viresh Kumar, Michael Turquette, Angus Ainslie, Alexandre Bailon,
	linux-clk, Abel Vesa, Saravana Kannan, Krzysztof Kozlowski,
	Chanwoo Choi, MyungJoo Ham, dl-linux-imx, devicetree, linux-pm,
	Rob Herring, Martin Kepplinger, Silvano Di Ninno, arm-soc,
	Aisheng Dong, Anson Huang, Stephen Boyd, Matthias Kaehlcke,
	Rafael J. Wysocki, Kyungmin Park, Sascha Hauer, Fabio Estevam,
	Shawn Guo, Georgi Djakov

On 18.12.2019 17:05, Adam Ford wrote:
> On Wed, Dec 18, 2019 at 8:44 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>>
>> On 18.12.2019 15:35, Adam Ford wrote:
>>> On Fri, Nov 22, 2019 at 3:45 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>>>>
>>>> This adds support for dynamic scaling of the DDR Controller (ddrc)
>>>> present on i.MX8M series chips. Actual frequency switching is
>>>> implemented inside TF-A, this driver wraps the SMC calls and
>>>> synchronizes the clk tree.
>>>>
>>>> DRAM frequency switching requires clock manipulation but during this operation
>>>> DRAM itself is briefly inaccessible so this operation is performed a SMC call
>>>> to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree
>>>> is updated to correspond to hardware configuration.
>>>>
>>>> This is handled via CLK_GET_RATE_NO_CACHE for dividers but muxes are handled
>>>> manually: the driver will prepare/enable the new parents ahead of switching (so
>>>> that the expected roots are enabled) and afterwards it will call clk_set_parent
>>>> to ensure the parents in clock framework are up-to-date.
>>>>
>>>> This series is useful standalone and roughly similar to devfreq drivers for
>>>> tegra and rockchip.
>>>>
>>>> Running at lower dram rates saves power but can affect the functionality of
>>>> other blocks in the chip (display, vpu etc). Support for in-kernel constraints
>>>> will some separately.
>>>>
>>>> This series has no dependencies outside linux-next. The driver depends
>>>> on features from the NXP branch of TF-A and will cleanly fail to probe
>>>> on mainline. There are also plans to upstream dram dvfs in TF-A.
>>>>
>>>> Leonard Crestez (5):
>>>>     clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
>>>>     clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
>>>>     dt-bindings: memory: Add bindings for imx8m ddr controller
>>>>     PM / devfreq: Add dynamic scaling for imx8m ddr controller
>>>>     arm64: dts: imx8m: Add ddr controller nodes
>>>>
>>>>    .../memory-controllers/fsl/imx8m-ddrc.yaml    |  72 +++
>>>>    arch/arm64/boot/dts/freescale/imx8mm-evk.dts  |  18 +
>>>>    arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  10 +
>>>>    .../boot/dts/freescale/imx8mn-ddr4-evk.dts    |  18 +
>>>>    arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  10 +
>>>>    arch/arm64/boot/dts/freescale/imx8mq-evk.dts  |  24 +
>>>>    arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  10 +
>>>>    drivers/clk/imx/clk-imx8mm.c                  |  11 +-
>>>>    drivers/clk/imx/clk-imx8mn.c                  |  12 +-
>>>>    drivers/clk/imx/clk-imx8mq.c                  |  12 +-
>>>>    drivers/clk/imx/clk-pll14xx.c                 |   7 +
>>>>    drivers/clk/imx/clk.h                         |   1 +
>>>>    drivers/devfreq/Kconfig                       |   9 +
>>>
>>> Since there is a Kconfig change, should there me a defconfig change?
>>
>> Yes, you need to enable CONFIG_ARM_IMX8M_DDRC_DEVFREQ in order to test
>> this. Enabling as "m" should work.
> 
> I enabled it as 'm' but I was more curious to know if we should push
> this upstream with the rest of the series.

I skipped enabling because it's very experimental; maybe after imx 
interconnect is also enabled?

>>>>    drivers/devfreq/Makefile                      |   1 +
>>>>    drivers/devfreq/imx8m-ddrc.c                  | 465 ++++++++++++++++++
>>>>    15 files changed, 670 insertions(+), 10 deletions(-)
>>>>    create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml
>>>>    create mode 100644 drivers/devfreq/imx8m-ddrc.c
>>>
>>> I applied the whole series against 5.5-rc1 and I am trying to test it.
>>> I know the 4.14 kernel NXP posted on Code Aurora is capable to
>>> lowering the DDRC controller to 25MHz on the 8MM when the video is
>>> off.  Since there is no video support yet for the 8MM, I was expecting
>>> to see the DDRC clock to be at or around 25MHz.
>>>
>>> Using debug FS, I can see the dram core clock is still running at
>>> 750MHz, and measuring power, it shows something consistent with what I
>>> see on the Code Aurora kernel with video turned on and the clock at
>>> 750MHz.
>>>
>>> Is there some way to get the dram_core_clk to drop to 25MHz to see
>>> some power reduction?  The same commands used in the Yocto build don't
>>> apply here since we don't have video.
>>
>> Current upstream driver just keeps current frequency by default. Try the
>> following:
>>
>> cd /sys/class/devfreq/devices/devfreq0
> 
> can't cd to /sys/class/devfreq/devices/devfreq0: No such file or directory
> 
> I did some checking and I found:
>      imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
> firmware freq info: -19
> 
> Was there some prerequisite patches I needed to apply before your series?

You need a recent version of TF-A from nxp ( upstream). Try this:

https://source.codeaurora.org/external/imx/imx-atf/log/?h=imx_4.19.35_1.1.0

Or this: 
https://github.com/cdleonard/arm-trusted-firmware/commits/imx_2.0.y_busfreq

Support on upstream ATF is not yet available

--
Regards,
Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2019-12-18 15:16       ` Leonard Crestez
@ 2019-12-18 15:37         ` Adam Ford
  2019-12-18 16:22           ` Leonard Crestez
  0 siblings, 1 reply; 25+ messages in thread
From: Adam Ford @ 2019-12-18 15:37 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Mark Rutland, Artur Świgoń,
	Jacky Bai, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, linux-clk, Abel Vesa, Saravana Kannan,
	Krzysztof Kozlowski, Chanwoo Choi, MyungJoo Ham, dl-linux-imx,
	devicetree, linux-pm, Rob Herring, Martin Kepplinger,
	Silvano Di Ninno, arm-soc, Aisheng Dong, Anson Huang,
	Stephen Boyd, Matthias Kaehlcke, Rafael J. Wysocki,
	Kyungmin Park, Sascha Hauer, Fabio Estevam, Shawn Guo,
	Georgi Djakov

On Wed, Dec 18, 2019 at 9:16 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>
> On 18.12.2019 17:05, Adam Ford wrote:
> > On Wed, Dec 18, 2019 at 8:44 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
> >>
> >> On 18.12.2019 15:35, Adam Ford wrote:
> >>> On Fri, Nov 22, 2019 at 3:45 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
> >>>>
> >>>> This adds support for dynamic scaling of the DDR Controller (ddrc)
> >>>> present on i.MX8M series chips. Actual frequency switching is
> >>>> implemented inside TF-A, this driver wraps the SMC calls and
> >>>> synchronizes the clk tree.
> >>>>
> >>>> DRAM frequency switching requires clock manipulation but during this operation
> >>>> DRAM itself is briefly inaccessible so this operation is performed a SMC call
> >>>> to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree
> >>>> is updated to correspond to hardware configuration.
> >>>>
> >>>> This is handled via CLK_GET_RATE_NO_CACHE for dividers but muxes are handled
> >>>> manually: the driver will prepare/enable the new parents ahead of switching (so
> >>>> that the expected roots are enabled) and afterwards it will call clk_set_parent
> >>>> to ensure the parents in clock framework are up-to-date.
> >>>>
> >>>> This series is useful standalone and roughly similar to devfreq drivers for
> >>>> tegra and rockchip.
> >>>>
> >>>> Running at lower dram rates saves power but can affect the functionality of
> >>>> other blocks in the chip (display, vpu etc). Support for in-kernel constraints
> >>>> will some separately.
> >>>>
> >>>> This series has no dependencies outside linux-next. The driver depends
> >>>> on features from the NXP branch of TF-A and will cleanly fail to probe
> >>>> on mainline. There are also plans to upstream dram dvfs in TF-A.
> >>>>
> >>>> Leonard Crestez (5):
> >>>>     clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
> >>>>     clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
> >>>>     dt-bindings: memory: Add bindings for imx8m ddr controller
> >>>>     PM / devfreq: Add dynamic scaling for imx8m ddr controller
> >>>>     arm64: dts: imx8m: Add ddr controller nodes
> >>>>
> >>>>    .../memory-controllers/fsl/imx8m-ddrc.yaml    |  72 +++
> >>>>    arch/arm64/boot/dts/freescale/imx8mm-evk.dts  |  18 +
> >>>>    arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  10 +
> >>>>    .../boot/dts/freescale/imx8mn-ddr4-evk.dts    |  18 +
> >>>>    arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  10 +
> >>>>    arch/arm64/boot/dts/freescale/imx8mq-evk.dts  |  24 +
> >>>>    arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  10 +
> >>>>    drivers/clk/imx/clk-imx8mm.c                  |  11 +-
> >>>>    drivers/clk/imx/clk-imx8mn.c                  |  12 +-
> >>>>    drivers/clk/imx/clk-imx8mq.c                  |  12 +-
> >>>>    drivers/clk/imx/clk-pll14xx.c                 |   7 +
> >>>>    drivers/clk/imx/clk.h                         |   1 +
> >>>>    drivers/devfreq/Kconfig                       |   9 +
> >>>
> >>> Since there is a Kconfig change, should there me a defconfig change?
> >>
> >> Yes, you need to enable CONFIG_ARM_IMX8M_DDRC_DEVFREQ in order to test
> >> this. Enabling as "m" should work.
> >
> > I enabled it as 'm' but I was more curious to know if we should push
> > this upstream with the rest of the series.
>
> I skipped enabling because it's very experimental; maybe after imx
> interconnect is also enabled?
>
> >>>>    drivers/devfreq/Makefile                      |   1 +
> >>>>    drivers/devfreq/imx8m-ddrc.c                  | 465 ++++++++++++++++++
> >>>>    15 files changed, 670 insertions(+), 10 deletions(-)
> >>>>    create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml
> >>>>    create mode 100644 drivers/devfreq/imx8m-ddrc.c
> >>>
> >>> I applied the whole series against 5.5-rc1 and I am trying to test it.
> >>> I know the 4.14 kernel NXP posted on Code Aurora is capable to
> >>> lowering the DDRC controller to 25MHz on the 8MM when the video is
> >>> off.  Since there is no video support yet for the 8MM, I was expecting
> >>> to see the DDRC clock to be at or around 25MHz.
> >>>
> >>> Using debug FS, I can see the dram core clock is still running at
> >>> 750MHz, and measuring power, it shows something consistent with what I
> >>> see on the Code Aurora kernel with video turned on and the clock at
> >>> 750MHz.
> >>>
> >>> Is there some way to get the dram_core_clk to drop to 25MHz to see
> >>> some power reduction?  The same commands used in the Yocto build don't
> >>> apply here since we don't have video.
> >>
> >> Current upstream driver just keeps current frequency by default. Try the
> >> following:
> >>
> >> cd /sys/class/devfreq/devices/devfreq0
> >
> > can't cd to /sys/class/devfreq/devices/devfreq0: No such file or directory
> >
> > I did some checking and I found:
> >      imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
> > firmware freq info: -19
> >
> > Was there some prerequisite patches I needed to apply before your series?
>
> You need a recent version of TF-A from nxp ( upstream). Try this:
>
> https://source.codeaurora.org/external/imx/imx-atf/log/?h=imx_4.19.35_1.1.0
>
> Or this:
> https://github.com/cdleonard/arm-trusted-firmware/commits/imx_2.0.y_busfreq
>
> Support on upstream ATF is not yet available

I cloned your github branch and built it per the instructions in the
u-boot readme file.
did a make clean on u-boot, copied the bl31.bin to u-boot and rebuild
per U-Boot's instructions.

U-Boot booted and Linux booted, but I still get:

   imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
firmware freq info: -19

I am still learning the imx8mm platform, so please forgive my ignorance.

adam
>
> --
> Regards,
> Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2019-12-18 15:37         ` Adam Ford
@ 2019-12-18 16:22           ` Leonard Crestez
  2019-12-18 16:42             ` Adam Ford
  0 siblings, 1 reply; 25+ messages in thread
From: Leonard Crestez @ 2019-12-18 16:22 UTC (permalink / raw)
  To: Adam Ford, Jacky Bai
  Cc: Mark Rutland, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, linux-clk, Abel Vesa, Anson Huang,
	Krzysztof Kozlowski, Chanwoo Choi, MyungJoo Ham, dl-linux-imx,
	devicetree, linux-pm, Rob Herring, Martin Kepplinger,
	Silvano Di Ninno, arm-soc, Aisheng Dong, Saravana Kannan,
	Stephen Boyd, Matthias Kaehlcke, Rafael J. Wysocki,
	Kyungmin Park, Sascha Hauer, Fabio Estevam, Shawn Guo,
	Georgi Djakov

On 18.12.2019 17:37, Adam Ford wrote:
> On Wed, Dec 18, 2019 at 9:16 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>>
>> On 18.12.2019 17:05, Adam Ford wrote:
>>> On Wed, Dec 18, 2019 at 8:44 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>>>>
>>>> On 18.12.2019 15:35, Adam Ford wrote:
>>>>> On Fri, Nov 22, 2019 at 3:45 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>>>>>>
>>>>>> This adds support for dynamic scaling of the DDR Controller (ddrc)
>>>>>> present on i.MX8M series chips. Actual frequency switching is
>>>>>> implemented inside TF-A, this driver wraps the SMC calls and
>>>>>> synchronizes the clk tree.
>>>>>>
>>>>>> DRAM frequency switching requires clock manipulation but during this operation
>>>>>> DRAM itself is briefly inaccessible so this operation is performed a SMC call
>>>>>> to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree
>>>>>> is updated to correspond to hardware configuration.
>>>>>>
>>>>>> This is handled via CLK_GET_RATE_NO_CACHE for dividers but muxes are handled
>>>>>> manually: the driver will prepare/enable the new parents ahead of switching (so
>>>>>> that the expected roots are enabled) and afterwards it will call clk_set_parent
>>>>>> to ensure the parents in clock framework are up-to-date.
>>>>>>
>>>>>> This series is useful standalone and roughly similar to devfreq drivers for
>>>>>> tegra and rockchip.
>>>>>>
>>>>>> Running at lower dram rates saves power but can affect the functionality of
>>>>>> other blocks in the chip (display, vpu etc). Support for in-kernel constraints
>>>>>> will some separately.
>>>>>>
>>>>>> This series has no dependencies outside linux-next. The driver depends
>>>>>> on features from the NXP branch of TF-A and will cleanly fail to probe
>>>>>> on mainline. There are also plans to upstream dram dvfs in TF-A.
>>>>>>
>>>>>> Leonard Crestez (5):
>>>>>>      clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
>>>>>>      clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
>>>>>>      dt-bindings: memory: Add bindings for imx8m ddr controller
>>>>>>      PM / devfreq: Add dynamic scaling for imx8m ddr controller
>>>>>>      arm64: dts: imx8m: Add ddr controller nodes
>>>>>>
>>>>>>     .../memory-controllers/fsl/imx8m-ddrc.yaml    |  72 +++
>>>>>>     arch/arm64/boot/dts/freescale/imx8mm-evk.dts  |  18 +
>>>>>>     arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  10 +
>>>>>>     .../boot/dts/freescale/imx8mn-ddr4-evk.dts    |  18 +
>>>>>>     arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  10 +
>>>>>>     arch/arm64/boot/dts/freescale/imx8mq-evk.dts  |  24 +
>>>>>>     arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  10 +
>>>>>>     drivers/clk/imx/clk-imx8mm.c                  |  11 +-
>>>>>>     drivers/clk/imx/clk-imx8mn.c                  |  12 +-
>>>>>>     drivers/clk/imx/clk-imx8mq.c                  |  12 +-
>>>>>>     drivers/clk/imx/clk-pll14xx.c                 |   7 +
>>>>>>     drivers/clk/imx/clk.h                         |   1 +
>>>>>>     drivers/devfreq/Kconfig                       |   9 +
>>>>>
>>>>> Since there is a Kconfig change, should there me a defconfig change?
>>>>
>>>> Yes, you need to enable CONFIG_ARM_IMX8M_DDRC_DEVFREQ in order to test
>>>> this. Enabling as "m" should work.
>>>
>>> I enabled it as 'm' but I was more curious to know if we should push
>>> this upstream with the rest of the series.
>>
>> I skipped enabling because it's very experimental; maybe after imx
>> interconnect is also enabled?
>>
>>>>>>     drivers/devfreq/Makefile                      |   1 +
>>>>>>     drivers/devfreq/imx8m-ddrc.c                  | 465 ++++++++++++++++++
>>>>>>     15 files changed, 670 insertions(+), 10 deletions(-)
>>>>>>     create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml
>>>>>>     create mode 100644 drivers/devfreq/imx8m-ddrc.c
>>>>>
>>>>> I applied the whole series against 5.5-rc1 and I am trying to test it.
>>>>> I know the 4.14 kernel NXP posted on Code Aurora is capable to
>>>>> lowering the DDRC controller to 25MHz on the 8MM when the video is
>>>>> off.  Since there is no video support yet for the 8MM, I was expecting
>>>>> to see the DDRC clock to be at or around 25MHz.
>>>>>
>>>>> Using debug FS, I can see the dram core clock is still running at
>>>>> 750MHz, and measuring power, it shows something consistent with what I
>>>>> see on the Code Aurora kernel with video turned on and the clock at
>>>>> 750MHz.
>>>>>
>>>>> Is there some way to get the dram_core_clk to drop to 25MHz to see
>>>>> some power reduction?  The same commands used in the Yocto build don't
>>>>> apply here since we don't have video.
>>>>
>>>> Current upstream driver just keeps current frequency by default. Try the
>>>> following:
>>>>
>>>> cd /sys/class/devfreq/devices/devfreq0
>>>
>>> can't cd to /sys/class/devfreq/devices/devfreq0: No such file or directory
>>>
>>> I did some checking and I found:
>>>       imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
>>> firmware freq info: -19
>>>
>>> Was there some prerequisite patches I needed to apply before your series?
>>
>> You need a recent version of TF-A from nxp ( upstream). Try this:
>>
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fimx-atf%2Flog%2F%3Fh%3Dimx_4.19.35_1.1.0&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cc07fadd829994fe6293c08d783d02fa9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122802480130351&amp;sdata=dVovGr1ttwrnSz39MPNNVg%2FB8HV5AjrHXGbksO3XvVo%3D&amp;reserved=0
>>
>> Or this:
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcdleonard%2Farm-trusted-firmware%2Fcommits%2Fimx_2.0.y_busfreq&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cc07fadd829994fe6293c08d783d02fa9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122802480140347&amp;sdata=Q9KPq60FOxJ7GflwupNaXvbqHIR40Ej5GxeY%2BhHI658%3D&amp;reserved=0
>>
>> Support on upstream ATF is not yet available
> 
> I cloned your github branch and built it per the instructions in the
> u-boot readme file.
> did a make clean on u-boot, copied the bl31.bin to u-boot and rebuild
> per U-Boot's instructions.
> 
> U-Boot booted and Linux booted, but I still get:
> 
>     imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
> firmware freq info: -19

Which version of u-boot is that, upstream? I'm subscribed to uboot 
mailing list and I see that imx8m support has its own separate issues 
but my familiarity is limited :(

I've only ever tested with NXP uboot and the NXP version of mkimage:

https://source.codeaurora.org/external/imx/uboot-imx/log/?h=imx_v2019.04_4.19.35_1.1.0
https://source.codeaurora.org/external/imx/imx-mkimage/

My bootloader prints the following BuildInfo:
   - ATF 70fa7bc 

   - U-Boot 2019.04-00019-g4d377539a119

--
Regards,
Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2019-12-18 16:22           ` Leonard Crestez
@ 2019-12-18 16:42             ` Adam Ford
       [not found]               ` <CAHCN7xKjpN_XEGLj-1jMG5mBbF=su67k+10frheLt+L1XaR0-g@mail.gmail.com>
  0 siblings, 1 reply; 25+ messages in thread
From: Adam Ford @ 2019-12-18 16:42 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Mark Rutland, Jacky Bai, Viresh Kumar, Michael Turquette,
	Angus Ainslie, Alexandre Bailon, linux-clk, Abel Vesa,
	Saravana Kannan, Krzysztof Kozlowski, Chanwoo Choi, MyungJoo Ham,
	dl-linux-imx, devicetree, linux-pm, Rob Herring,
	Martin Kepplinger, Silvano Di Ninno, arm-soc, Aisheng Dong,
	Anson Huang, Stephen Boyd, Matthias Kaehlcke, Rafael J. Wysocki,
	Kyungmin Park, Sascha Hauer, Fabio Estevam, Shawn Guo,
	Georgi Djakov

On Wed, Dec 18, 2019 at 10:22 AM Leonard Crestez
<leonard.crestez@nxp.com> wrote:
>
> On 18.12.2019 17:37, Adam Ford wrote:
> > On Wed, Dec 18, 2019 at 9:16 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
> >>
> >> On 18.12.2019 17:05, Adam Ford wrote:
> >>> On Wed, Dec 18, 2019 at 8:44 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
> >>>>
> >>>> On 18.12.2019 15:35, Adam Ford wrote:
> >>>>> On Fri, Nov 22, 2019 at 3:45 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
> >>>>>>
> >>>>>> This adds support for dynamic scaling of the DDR Controller (ddrc)
> >>>>>> present on i.MX8M series chips. Actual frequency switching is
> >>>>>> implemented inside TF-A, this driver wraps the SMC calls and
> >>>>>> synchronizes the clk tree.
> >>>>>>
> >>>>>> DRAM frequency switching requires clock manipulation but during this operation
> >>>>>> DRAM itself is briefly inaccessible so this operation is performed a SMC call
> >>>>>> to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree
> >>>>>> is updated to correspond to hardware configuration.
> >>>>>>
> >>>>>> This is handled via CLK_GET_RATE_NO_CACHE for dividers but muxes are handled
> >>>>>> manually: the driver will prepare/enable the new parents ahead of switching (so
> >>>>>> that the expected roots are enabled) and afterwards it will call clk_set_parent
> >>>>>> to ensure the parents in clock framework are up-to-date.
> >>>>>>
> >>>>>> This series is useful standalone and roughly similar to devfreq drivers for
> >>>>>> tegra and rockchip.
> >>>>>>
> >>>>>> Running at lower dram rates saves power but can affect the functionality of
> >>>>>> other blocks in the chip (display, vpu etc). Support for in-kernel constraints
> >>>>>> will some separately.
> >>>>>>
> >>>>>> This series has no dependencies outside linux-next. The driver depends
> >>>>>> on features from the NXP branch of TF-A and will cleanly fail to probe
> >>>>>> on mainline. There are also plans to upstream dram dvfs in TF-A.
> >>>>>>
> >>>>>> Leonard Crestez (5):
> >>>>>>      clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
> >>>>>>      clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
> >>>>>>      dt-bindings: memory: Add bindings for imx8m ddr controller
> >>>>>>      PM / devfreq: Add dynamic scaling for imx8m ddr controller
> >>>>>>      arm64: dts: imx8m: Add ddr controller nodes
> >>>>>>
> >>>>>>     .../memory-controllers/fsl/imx8m-ddrc.yaml    |  72 +++
> >>>>>>     arch/arm64/boot/dts/freescale/imx8mm-evk.dts  |  18 +
> >>>>>>     arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  10 +
> >>>>>>     .../boot/dts/freescale/imx8mn-ddr4-evk.dts    |  18 +
> >>>>>>     arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  10 +
> >>>>>>     arch/arm64/boot/dts/freescale/imx8mq-evk.dts  |  24 +
> >>>>>>     arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  10 +
> >>>>>>     drivers/clk/imx/clk-imx8mm.c                  |  11 +-
> >>>>>>     drivers/clk/imx/clk-imx8mn.c                  |  12 +-
> >>>>>>     drivers/clk/imx/clk-imx8mq.c                  |  12 +-
> >>>>>>     drivers/clk/imx/clk-pll14xx.c                 |   7 +
> >>>>>>     drivers/clk/imx/clk.h                         |   1 +
> >>>>>>     drivers/devfreq/Kconfig                       |   9 +
> >>>>>
> >>>>> Since there is a Kconfig change, should there me a defconfig change?
> >>>>
> >>>> Yes, you need to enable CONFIG_ARM_IMX8M_DDRC_DEVFREQ in order to test
> >>>> this. Enabling as "m" should work.
> >>>
> >>> I enabled it as 'm' but I was more curious to know if we should push
> >>> this upstream with the rest of the series.
> >>
> >> I skipped enabling because it's very experimental; maybe after imx
> >> interconnect is also enabled?
> >>
> >>>>>>     drivers/devfreq/Makefile                      |   1 +
> >>>>>>     drivers/devfreq/imx8m-ddrc.c                  | 465 ++++++++++++++++++
> >>>>>>     15 files changed, 670 insertions(+), 10 deletions(-)
> >>>>>>     create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml
> >>>>>>     create mode 100644 drivers/devfreq/imx8m-ddrc.c
> >>>>>
> >>>>> I applied the whole series against 5.5-rc1 and I am trying to test it.
> >>>>> I know the 4.14 kernel NXP posted on Code Aurora is capable to
> >>>>> lowering the DDRC controller to 25MHz on the 8MM when the video is
> >>>>> off.  Since there is no video support yet for the 8MM, I was expecting
> >>>>> to see the DDRC clock to be at or around 25MHz.
> >>>>>
> >>>>> Using debug FS, I can see the dram core clock is still running at
> >>>>> 750MHz, and measuring power, it shows something consistent with what I
> >>>>> see on the Code Aurora kernel with video turned on and the clock at
> >>>>> 750MHz.
> >>>>>
> >>>>> Is there some way to get the dram_core_clk to drop to 25MHz to see
> >>>>> some power reduction?  The same commands used in the Yocto build don't
> >>>>> apply here since we don't have video.
> >>>>
> >>>> Current upstream driver just keeps current frequency by default. Try the
> >>>> following:
> >>>>
> >>>> cd /sys/class/devfreq/devices/devfreq0
> >>>
> >>> can't cd to /sys/class/devfreq/devices/devfreq0: No such file or directory
> >>>
> >>> I did some checking and I found:
> >>>       imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
> >>> firmware freq info: -19
> >>>
> >>> Was there some prerequisite patches I needed to apply before your series?
> >>
> >> You need a recent version of TF-A from nxp ( upstream). Try this:
> >>
> >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fimx-atf%2Flog%2F%3Fh%3Dimx_4.19.35_1.1.0&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cc07fadd829994fe6293c08d783d02fa9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122802480130351&amp;sdata=dVovGr1ttwrnSz39MPNNVg%2FB8HV5AjrHXGbksO3XvVo%3D&amp;reserved=0
> >>
> >> Or this:
> >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcdleonard%2Farm-trusted-firmware%2Fcommits%2Fimx_2.0.y_busfreq&amp;data=02%7C01%7Cleonard.crestez%40nxp.com%7Cc07fadd829994fe6293c08d783d02fa9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122802480140347&amp;sdata=Q9KPq60FOxJ7GflwupNaXvbqHIR40Ej5GxeY%2BhHI658%3D&amp;reserved=0
> >>
> >> Support on upstream ATF is not yet available
> >
> > I cloned your github branch and built it per the instructions in the
> > u-boot readme file.
> > did a make clean on u-boot, copied the bl31.bin to u-boot and rebuild
> > per U-Boot's instructions.
> >
> > U-Boot booted and Linux booted, but I still get:
> >
> >     imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
> > firmware freq info: -19
>
> Which version of u-boot is that, upstream? I'm subscribed to uboot
> mailing list and I see that imx8m support has its own separate issues
> but my familiarity is limited :(

U-Boot 2020.01-rc4-00244-gf39abbbc53-dirty (Dec 18 2019 - 09:27:40 -0600)

>
> I've only ever tested with NXP uboot and the NXP version of mkimage:
>
> https://source.codeaurora.org/external/imx/uboot-imx/log/?h=imx_v2019.04_4.19.35_1.1.0
> https://source.codeaurora.org/external/imx/imx-mkimage/

I will try your versions and see what happens.

> My bootloader prints the following BuildInfo:
>    - ATF 70fa7bc
>
>    - U-Boot 2019.04-00019-g4d377539a119
>

Thanks for your help.

adam
> --
> Regards,
> Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
       [not found]               ` <CAHCN7xKjpN_XEGLj-1jMG5mBbF=su67k+10frheLt+L1XaR0-g@mail.gmail.com>
@ 2020-01-13 23:36                 ` Leonard Crestez
  2020-01-15 20:09                   ` Adam Ford
  0 siblings, 1 reply; 25+ messages in thread
From: Leonard Crestez @ 2020-01-13 23:36 UTC (permalink / raw)
  To: Adam Ford, Jacky Bai, Peng Fan
  Cc: Mark Rutland, Viresh Kumar, Michael Turquette, Angus Ainslie,
	Alexandre Bailon, linux-clk, Abel Vesa, Anson Huang,
	Krzysztof Kozlowski, Chanwoo Choi, MyungJoo Ham, dl-linux-imx,
	devicetree, linux-pm, Rob Herring, Martin Kepplinger,
	Silvano Di Ninno, arm-soc, Aisheng Dong, Saravana Kannan,
	Stephen Boyd, Matthias Kaehlcke, Rafael J. Wysocki,
	Kyungmin Park, Sascha Hauer, Fabio Estevam, Shawn Guo,
	Georgi Djakov

On 10.01.2020 20:34, Adam Ford wrote:
> On Wed, Dec 18, 2019 at 10:42 AM Adam Ford <aford173@gmail.com 
> <mailto:aford173@gmail.com>> wrote:
>      > > U-Boot booted and Linux booted, but I still get:
>      > >
>      > >     imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
>      > > firmware freq info: -19
>      >
>      > Which version of u-boot is that, upstream? I'm subscribed to uboot
>      > mailing list and I see that imx8m support has its own separate issues
>      > but my familiarity is limited :(
> 
>     U-Boot 2020.01-rc4-00244-gf39abbbc53-dirty (Dec 18 2019 - 09:27:40
>     -0600)
> 
>      >
>      > I've only ever tested with NXP uboot and the NXP version of mkimage:
>      >
>      >
>     https://source.codeaurora.org/external/imx/uboot-imx/log/?h=imx_v2019.04_4.19.35_1.1.0
>     <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2Flog%2F%3Fh%3Dimx_v2019.04_4.19.35_1.1.0&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735473321&sdata=LhleGMcJzjiNsPbVxmPbvgRVMnl%2F2HxUqVYKcgCFiEg%3D&reserved=0>
>      > https://source.codeaurora.org/external/imx/imx-mkimage/
>     <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fimx-mkimage%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735483320&sdata=enJQ9hgVkIG7frJ9v6QBQAgJBL8j3hWB7RAKa8XhPaw%3D&reserved=0>
> 
>     I will try your versions and see what happens.
> 
>      > My bootloader prints the following BuildInfo:
>      >    - ATF 70fa7bc
>      >
>      >    - U-Boot 2019.04-00019-g4d377539a119
>      >
> 
>     Thanks for your help.
> 
> 
> I wanted to try again after everything was merged into linux-next.
> 
> I am using the U-Boot master (as of 10 Jan 2020), with ATF from 
> 4.19.35_1.1.0 from Code Aurora.  I have tried your ATF, but I don't see 
> any change in behavior.  I have made the DDRC a module, but I still get 
> the same error message.
> 
> [    2.204554] imx8m-ddrc-devfreq 3d400000.memory-controller: failed to 
> init firmware freq info: -19
> 
> Is there something else I can try?

Yes, the NXP branch of uboot from Code Aurora (my commit hash is above).

I understand you want to use uboot and atf master, apparently they both 
need to be patched for this feature to work. It would still be 
interesting to validate.

--
Regards,
Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
  2020-01-13 23:36                 ` Leonard Crestez
@ 2020-01-15 20:09                   ` Adam Ford
  0 siblings, 0 replies; 25+ messages in thread
From: Adam Ford @ 2020-01-15 20:09 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Mark Rutland, Peng Fan, Jacky Bai, Viresh Kumar,
	Michael Turquette, Angus Ainslie, Alexandre Bailon, linux-clk,
	Abel Vesa, Saravana Kannan, Krzysztof Kozlowski, Chanwoo Choi,
	MyungJoo Ham, dl-linux-imx, devicetree, linux-pm, Rob Herring,
	Martin Kepplinger, Silvano Di Ninno, arm-soc, Aisheng Dong,
	Anson Huang, Stephen Boyd, Matthias Kaehlcke, Rafael J. Wysocki,
	Kyungmin Park, Sascha Hauer, Fabio Estevam, Shawn Guo,
	Georgi Djakov

On Mon, Jan 13, 2020 at 5:36 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>
> On 10.01.2020 20:34, Adam Ford wrote:
> > On Wed, Dec 18, 2019 at 10:42 AM Adam Ford <aford173@gmail.com
> > <mailto:aford173@gmail.com>> wrote:
> >      > > U-Boot booted and Linux booted, but I still get:
> >      > >
> >      > >     imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
> >      > > firmware freq info: -19
> >      >
> >      > Which version of u-boot is that, upstream? I'm subscribed to uboot
> >      > mailing list and I see that imx8m support has its own separate issues
> >      > but my familiarity is limited :(
> >
> >     U-Boot 2020.01-rc4-00244-gf39abbbc53-dirty (Dec 18 2019 - 09:27:40
> >     -0600)
> >
> >      >
> >      > I've only ever tested with NXP uboot and the NXP version of mkimage:
> >      >
> >      >
> >     https://source.codeaurora.org/external/imx/uboot-imx/log/?h=imx_v2019.04_4.19.35_1.1.0
> >     <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2Flog%2F%3Fh%3Dimx_v2019.04_4.19.35_1.1.0&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735473321&sdata=LhleGMcJzjiNsPbVxmPbvgRVMnl%2F2HxUqVYKcgCFiEg%3D&reserved=0>
> >      > https://source.codeaurora.org/external/imx/imx-mkimage/
> >     <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fimx-mkimage%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735483320&sdata=enJQ9hgVkIG7frJ9v6QBQAgJBL8j3hWB7RAKa8XhPaw%3D&reserved=0>
> >
> >     I will try your versions and see what happens.
> >
> >      > My bootloader prints the following BuildInfo:
> >      >    - ATF 70fa7bc
> >      >
> >      >    - U-Boot 2019.04-00019-g4d377539a119
> >      >
> >
> >     Thanks for your help.
> >
> >
> > I wanted to try again after everything was merged into linux-next.
> >
> > I am using the U-Boot master (as of 10 Jan 2020), with ATF from
> > 4.19.35_1.1.0 from Code Aurora.  I have tried your ATF, but I don't see
> > any change in behavior.  I have made the DDRC a module, but I still get
> > the same error message.
> >
> > [    2.204554] imx8m-ddrc-devfreq 3d400000.memory-controller: failed to
> > init firmware freq info: -19
> >
> > Is there something else I can try?
>
> Yes, the NXP branch of uboot from Code Aurora (my commit hash is above).
>
> I understand you want to use uboot and atf master, apparently they both
> need to be patched for this feature to work. It would still be
> interesting to validate.

I was able to get the 8MM to work with this new driver using the uboot
branch from Code Aurora.  Could you point me to what in U-Boot needs
to be pulled forward to the mainline?  I'd be willing to help if I
can.

Thanks for your help.

adam
>
> --
> Regards,
> Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2020-01-15 20:09 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 21:44 [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Leonard Crestez
2019-11-22 21:45 ` [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks Leonard Crestez
2019-11-25  1:25   ` Stephen Boyd
2019-12-09  1:15   ` Shawn Guo
2019-11-22 21:45 ` [PATCH v7 2/5] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE Leonard Crestez
2019-11-25  1:26   ` Stephen Boyd
2019-12-09  1:16   ` Shawn Guo
2019-11-22 21:45 ` [PATCH v7 3/5] dt-bindings: memory: Add bindings for imx8m ddr controller Leonard Crestez
2019-11-22 21:45 ` [PATCH v7 4/5] PM / devfreq: Add dynamic scaling " Leonard Crestez
2019-11-24 23:59   ` Chanwoo Choi
2019-11-26 19:44     ` Rob Herring
2019-11-26 23:25       ` Chanwoo Choi
2019-11-22 21:45 ` [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes Leonard Crestez
2019-11-28 14:43   ` Adam Ford
2019-11-29  5:33     ` Leonard Crestez
2019-12-09  1:34   ` Shawn Guo
2019-12-18 13:35 ` [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller Adam Ford
2019-12-18 14:44   ` Leonard Crestez
2019-12-18 15:05     ` Adam Ford
2019-12-18 15:16       ` Leonard Crestez
2019-12-18 15:37         ` Adam Ford
2019-12-18 16:22           ` Leonard Crestez
2019-12-18 16:42             ` Adam Ford
     [not found]               ` <CAHCN7xKjpN_XEGLj-1jMG5mBbF=su67k+10frheLt+L1XaR0-g@mail.gmail.com>
2020-01-13 23:36                 ` Leonard Crestez
2020-01-15 20:09                   ` Adam Ford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).