From: Philipp Rossak <embed3d@gmail.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Paul Burton" <paulburton@kernel.org>,
"James Hogan" <jhogan@kernel.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: devicetree@vger.kernel.org, letux-kernel@openphoenux.org,
Jonathan Bakker <xc-racer2@live.ca>,
openpvrsgx-devgroup@letux.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, kernel@pyra-handheld.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs
Date: Sun, 26 Apr 2020 21:36:58 +0200 [thread overview]
Message-ID: <9d9998cc-33bf-7d8f-658b-8d6218338135@gmail.com> (raw)
In-Reply-To: <3a451e360fed84bc40287678b4d6be13821cfbc0.1587760454.git.hns@goldelico.com>
Hi Nikolaus,
On 24.04.20 22:34, H. Nikolaus Schaller wrote:
> The Imagination PVR/SGX GPU is part of several SoC from
> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo,
> Allwinner A83 and others.
>
> With this binding, we describe how the SGX processor is
> interfaced to the SoC (registers and interrupt).
>
> The interface also consists of clocks, reset, power but
> information from data sheets is vague and some SoC integrators
> (TI) deciced to use a PRCM wrapper (ti,sysc) which does
> all clock, reset and power-management through registers
> outside of the sgx register block.
>
> Therefore all these properties are optional.
>
> Tested by make dt_binding_check
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> .../devicetree/bindings/gpu/img,pvrsgx.yaml | 150 ++++++++++++++++++
> 1 file changed, 150 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpu/img,pvrsgx.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpu/img,pvrsgx.yaml b/Documentation/devicetree/bindings/gpu/img,pvrsgx.yaml
> new file mode 100644
> index 000000000000..33a9c4c6e784
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/img,pvrsgx.yaml
> @@ -0,0 +1,150 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpu/img,pvrsgx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Imagination PVR/SGX GPU
> +
> +maintainers:
> + - H. Nikolaus Schaller <hns@goldelico.com>
> +
> +description: |+
> + This binding describes the Imagination SGX5 series of 3D accelerators which
> + are found in several different SoC like TI OMAP, Sitara, Ingenic JZ4780,
> + Allwinner A83, and Intel Poulsbo and CedarView and more.
> +
> + For an extensive list see: https://en.wikipedia.org/wiki/PowerVR#Implementations
> +
> + The SGX node is usually a child node of some DT node belonging to the SoC
> + which handles clocks, reset and general address space mapping of the SGX
> + register area. If not, an optional clock can be specified here.
> +
> +properties:
> + $nodename:
> + pattern: '^gpu@[a-f0-9]+$'
> + compatible:
> + oneOf:
> + - description: SGX530-121 based SoC
> + items:
> + - enum:
> + - ti,omap3-sgx530-121 # BeagleBoard A/B/C, OpenPandora 600MHz and similar
> + - const: img,sgx530-121
> + - const: img,sgx530
> +
> + - description: SGX530-125 based SoC
> + items:
> + - enum:
> + - ti,am3352-sgx530-125 # BeagleBone Black
> + - ti,am3517-sgx530-125
> + - ti,am4-sgx530-125
> + - ti,omap3-sgx530-125 # BeagleBoard XM, GTA04, OpenPandora 1GHz and similar
> + - ti,ti81xx-sgx530-125
> + - const: ti,omap3-sgx530-125
> + - const: img,sgx530-125
> + - const: img,sgx530
> +
> + - description: SGX535-116 based SoC
> + items:
> + - const: intel,poulsbo-gma500-sgx535 # Atom Z5xx
> + - const: img,sgx535-116
> + - const: img,sgx535
> +
> + - description: SGX540-116 based SoC
> + items:
> + - const: intel,medfield-gma-sgx540 # Atom Z24xx
> + - const: img,sgx540-116
> + - const: img,sgx540
> +
> + - description: SGX540-120 based SoC
> + items:
> + - enum:
> + - samsung,s5pv210-sgx540-120
> + - ti,omap4-sgx540-120 # Pandaboard, Pandaboard ES and similar
> + - const: img,sgx540-120
> + - const: img,sgx540
> +
> + - description: SGX540-130 based SoC
> + items:
> + - enum:
> + - ingenic,jz4780-sgx540-130 # CI20
> + - const: img,sgx540-130
> + - const: img,sgx540
> +
> + - description: SGX544-112 based SoC
> + items:
> + - const: ti,omap4470-sgx544-112
> + - const: img,sgx544-112
> + - const: img,sgx544
> +
> + - description: SGX544-115 based SoC
> + items:
> + - enum:
> + - allwinner,sun8i-a31-sgx544-115
> + - allwinner,sun8i-a31s-sgx544-115
those two bindings are wrong.
It should be allwinner,sun6i-a31-sgx544-115 and
allwinner,sun6i-a31s-sgx544-115. I did a copy paste error in the patches
that I provided for this series.
Cheers,
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-26 19:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 20:34 [PATCH v7 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more) H. Nikolaus Schaller
2020-04-24 20:34 ` [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs H. Nikolaus Schaller
2020-04-24 20:43 ` H. Nikolaus Schaller
2020-04-26 13:11 ` Paul Cercueil
2020-05-02 20:26 ` H. Nikolaus Schaller
2020-05-03 12:52 ` Paul Cercueil
2020-05-03 13:31 ` H. Nikolaus Schaller
2020-05-03 14:18 ` Paul Cercueil
2020-05-03 15:01 ` [PATCH v7 01/12] dt-bindings: add img,pvrsgx.yaml " Tony Lindgren
2020-05-15 7:58 ` [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml " H. Nikolaus Schaller
2020-05-03 16:41 ` H. Nikolaus Schaller
2020-05-15 7:18 ` H. Nikolaus Schaller
2020-04-26 19:36 ` Philipp Rossak [this message]
2020-04-26 20:59 ` H. Nikolaus Schaller
2020-05-05 15:53 ` [PATCH v7 01/12] dt-bindings: add img,pvrsgx.yaml " Rob Herring
2020-05-15 7:59 ` [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml " H. Nikolaus Schaller
2020-04-24 20:34 ` [PATCH v7 02/12] ARM: DTS: am33xx: add sgx gpu child node H. Nikolaus Schaller
2020-04-24 20:34 ` [PATCH v7 03/12] ARM: DTS: am3517: " H. Nikolaus Schaller
2020-04-24 20:34 ` [PATCH v7 04/12] ARM: DTS: omap34xx: " H. Nikolaus Schaller
2020-04-24 20:34 ` [PATCH v7 05/12] ARM: DTS: omap36xx: " H. Nikolaus Schaller
2020-04-24 20:34 ` [PATCH v7 06/12] ARM: DTS: omap4: " H. Nikolaus Schaller
2020-04-26 12:50 ` Paul Cercueil
2020-04-28 7:59 ` H. Nikolaus Schaller
2020-04-24 20:34 ` [PATCH v7 07/12] ARM: DTS: omap5: " H. Nikolaus Schaller
2020-04-24 20:34 ` [PATCH v7 08/12] arm: dts: s5pv210: Add node for SGX 540 H. Nikolaus Schaller
2020-04-26 12:56 ` Paul Cercueil
2020-04-26 14:57 ` Jonathan Bakker
2020-04-27 15:46 ` Krzysztof Kozlowski
2020-04-28 21:39 ` Jonathan Bakker
2020-04-28 22:58 ` Jonathan Bakker
2020-04-29 8:47 ` Maxime Ripard
2020-04-29 12:26 ` Paul Cercueil
2020-04-24 20:34 ` [PATCH v7 09/12] ARM: dts: sun6i: a31: add sgx gpu child node H. Nikolaus Schaller
2020-04-26 12:53 ` Paul Cercueil
2020-04-26 19:31 ` Philipp Rossak
2020-04-24 20:34 ` [PATCH v7 10/12] ARM: dts: sun6i: a31s: " H. Nikolaus Schaller
2020-04-24 20:34 ` [PATCH v7 11/12] ARM: dts: sun8i: a83t: " H. Nikolaus Schaller
2020-04-24 20:34 ` [PATCH v7 12/12] MIPS: DTS: jz4780: add sgx gpu node H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d9998cc-33bf-7d8f-658b-8d6218338135@gmail.com \
--to=embed3d@gmail.com \
--cc=airlied@linux.ie \
--cc=bcousson@baylibre.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=jhogan@kernel.org \
--cc=kernel@pyra-handheld.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=openpvrsgx-devgroup@letux.org \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=tsbogend@alpha.franken.de \
--cc=wens@csie.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).