From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7697AC433F5 for ; Tue, 7 Dec 2021 02:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a2hqycWAExmf63FofOFHUkfZEEpSDOZChLMN0mtSf/g=; b=1h3ia33BUoD/HC 8mqO/cA1aceR9hIEvMGE8ak0ENGblLmhhEM7icEw8dk85uVmGi4SSbYp1PTV6bFjJBbUUcVTQY9PH B6mWhM14z/o2O93N+0BLmciUYLyKUwT/qqX4Sq166fqQLYnm5gSIUT8v96NkiyKRTAQd7sZ+lkQHb 2f+ysxCmSeHUI1/xSCeJstqRjYz+Lxu6rgORrmAqvlbkA5zo5ODEAyAt7/G9/YrdDadA3/VTPIezi 83Tu02gaHpRHT7A1isnIdOXC0iiYvCyGNGKdpjmnDNus7GQPfkOGGAGeLVXlPCqbj5FI0WgB5yiku banYT9D0yhFG349SUuKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muQHv-006muM-2H; Tue, 07 Dec 2021 02:33:03 +0000 Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muQHp-006mtS-1X for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 02:33:00 +0000 Received: by mail-qt1-x82e.google.com with SMTP id q14so12903537qtx.10 for ; Mon, 06 Dec 2021 18:32:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=QQzMbHoCIHQcabSUmv+A+cuD+7qIgSkwyMRvoh0L3Gs=; b=h7KB6b3EX6ARdK4WUecjmEHeiKvtwdiOJ7RqH4PFeXYLLgP5MFzWNcJCmTMsW2Qo9e CxdPOqBqWoCHISCIxvSQ0ZrXeU25dZarYGcdEbiNY3YIS7IRhpvfPclamQsoo72hliNM +Sf+15JVxmE7F4MdCgG+wpcrZYcyr+er6kzGOCYufjK8QdcK1QuGeKaeK7+Rl6/hoFYn Zx9vsSuzXJGAnzjB4Up5+6FxQ/U6XwLVENAv2jdmqWeuqqGNg9lTY7V2yNtCAJYSXWu5 f9mlC+tPdrnFk+OSsHHemX5Z6RX15/hRvxG4cphtCyNBmT758Co+yb2EabAy2C14lxym TVwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=QQzMbHoCIHQcabSUmv+A+cuD+7qIgSkwyMRvoh0L3Gs=; b=i4BPr5m4QEQfyK0v7C3dLQ6XAGHFJY6S8CPBOxNks87clOcA5smOBRaSfZw3GMOXk0 pWymADiTxuhtK/2uALI+yfzyCzTB4wRWtsvIAC6bJJbNtVrulvz/Zb1WIZgsq4RdPSHA Xmmgf+a/vb/N6A3UP77ZviPY3UQK+aIUUDB+x3LzqrsPU+68/xgP6illnMZxPq/5aQsm QtIPUzHP+gaMffMhT1BadtIRBNcE4F72W+KDI1m2QEop/v3Xv7mxbxBRg6IFqfVy1gQm w4I37wGtiG8yYwHUlFbvslFANH6ptuXtlvfrqFRXaeGJ3ER/AdeqiGsP/QL6CTVyT0TL DIkA== X-Gm-Message-State: AOAM531UnGgn5tJJgTM5GPvjCwBrUtRTvI4If+DbWhUptko+qbAK6M2b Zk1SB4+ypUbLD6dI9PwYy3o= X-Google-Smtp-Source: ABdhPJz9gAnjJaTSLqSBU8V1XbG1Ba11WfK8eAbaVVjxdKkz3fPB9mJLRZ4pHrpc7sQIC5T8EkI3Mg== X-Received: by 2002:ac8:4a0e:: with SMTP id x14mr45094726qtq.345.1638844375373; Mon, 06 Dec 2021 18:32:55 -0800 (PST) Received: from [10.4.10.38] (146-115-144-188.s4282.c3-0.nwt-cbr1.sbo-nwt.ma.cable.rcncustomer.com. [146.115.144.188]) by smtp.gmail.com with ESMTPSA id t9sm7520523qkp.110.2021.12.06.18.32.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Dec 2021 18:32:54 -0800 (PST) Message-ID: <9dab64ca-0d91-3bea-f873-3c2da6ef1645@gmail.com> Date: Mon, 6 Dec 2021 21:32:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v4 06/13] dt-bindings: clock: imx: Add documentation for i.MXRT clock Content-Language: en-US To: Stephen Boyd , linux-imx@nxp.com Cc: mturquette@baylibre.com, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch, linus.walleij@linaro.org, gregkh@linuxfoundation.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, abel.vesa@nxp.com, adrian.hunter@intel.com, jirislaby@kernel.org, giulio.benetti@benettiengineering.com, nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, Rob Herring References: <20211204061042.1248028-1-Mr.Bossman075@gmail.com> <20211204061042.1248028-7-Mr.Bossman075@gmail.com> <20211206223849.554F6C341C6@smtp.kernel.org> From: Jesse Taube In-Reply-To: <20211206223849.554F6C341C6@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_183257_158155_7E871614 X-CRM114-Status: GOOD ( 13.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/6/21 17:38, Stephen Boyd wrote: > Quoting Jesse Taube (2021-12-03 22:10:35) >> diff --git a/Documentation/devicetree/bindings/clock/imxrt-clock.yaml b/Documentation/devicetree/bindings/clock/imxrt-clock.yaml >> new file mode 100644 >> index 000000000000..8af48c59ff99 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/imxrt-clock.yaml >> @@ -0,0 +1,67 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/imxrt-clock.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Clock bindings for Freescale i.MXRT >> + >> +maintainers: >> + - Giulio Benetti >> + - Jesse Taube >> + >> +description: | >> + The clock consumer should specify the desired clock by having the clock >> + ID in its "clocks" phandle cell. See include/dt-bindings/clock/imxrt*-clock.h >> + for the full list of i.MXRT clock IDs. >> + >> +properties: >> + compatible: >> + const: fsl,imxrt1050-ccm >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 2 >> + >> + clocks: >> + minItems: 1 >> + >> + clock-names: >> + minItems: 1 > > Why minitems vs. exactly 1 for osc? because i don't understand yaml yet. I'll look into this. >> + >> + '#clock-cells': >> + const: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + - clock-names >> + - '#clock-cells' >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + ccm@400fc000 { > > s/ccm/clock-controller/ This made my day! > >> + compatible = "fsl,imxrt1050-ccm"; >> + reg = <0x400fc000 0x4000>; >> + interrupts = <95>, <96>; >> + clocks = <&osc>; >> + clock-names = "osc"; >> + #clock-cells = <1>; >> + }; >> + >> + > > Nitpick: Drop extra newline sorry will fix. > >> + lpuart1: serial@40184000 { >> + compatible = "fsl,imxrt1050-lpuart"; >> + reg = <0x40184000 0x4000>; >> + interrupts = <20>; >> + clocks = <&clks IMXRT1050_CLK_LPUART1>; >> + clock-names = "ipg"; >> + }; >> -- >> 2.34.0 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel