From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 4/9] usb: gadget: udc: s3c2410: add IRQ check
Date: Tue, 10 Aug 2021 08:53:52 +0200 [thread overview]
Message-ID: <9db78434-6eb0-0094-3ed6-9b355eb923dc@canonical.com> (raw)
In-Reply-To: <bd69b22c-b484-5a1f-c798-78d4b78405f2@omp.ru>
On 09/08/2021 22:35, Sergey Shtylyov wrote:
> The driver neglects to check the result of platform_get_irq()'s call and
> blithely passes the negative error codes to request_irq() (which takes
> *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original
> error code. Stop calling request_irq() with the invalid IRQ #s.
>
> Fixes: 188db4435ac6 ("usb: gadget: s3c: use platform resources")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
> ---
> drivers/usb/gadget/udc/s3c2410_udc.c | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-10 6:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47bacc02-4e34-3208-779c-7072a6261782@omp.ru>
2021-08-09 20:21 ` [PATCH v2 1/9] usb: dwc3: meson-g12a: add IRQ check Sergey Shtylyov
2021-08-09 20:27 ` [PATCH v2 3/6] usb: gadget: udc: at91: " Sergey Shtylyov
2021-08-09 20:35 ` [PATCH v2 4/9] usb: gadget: udc: s3c2410: " Sergey Shtylyov
2021-08-10 6:53 ` Krzysztof Kozlowski [this message]
2021-08-12 5:40 ` Felipe Balbi
2021-08-09 20:45 ` [PATCH v2 6/9] usb: misc: brcmstb-usb-pinmap: " Sergey Shtylyov
2021-08-10 9:51 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9db78434-6eb0-0094-3ed6-9b355eb923dc@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).