From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C19CA9EAE for ; Tue, 29 Oct 2019 17:25:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE356208E3 for ; Tue, 29 Oct 2019 17:25:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TKqNQNaN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE356208E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CJcSlacNma6SGLzXT2q1KPivmIJWsH/UE9IErPKSnYU=; b=TKqNQNaNvMLG29 6LoLlMHgi+Gd/lvWUKnaYCuI0gNftrq42Y/Sdfxjk6SGA0EZmlz93znQsaz5ctDvIwjHnzd3lbeky LD9RQxjl0RRtPH7KOA8/hXwbu9eZqMaYmdCdaeRTM1TfKzk4VBP1gV+pLQtqxduEkYm2okD+dlHGf KJUECXs4ixdo6i1aRX8IK84HtFj1j4ZRu0ImyQLk2/BRflC4vvoGWwt4d86nQwVeeV+ABIN6ErYT/ 110qfndXJJDntQ+oi024qShPfqc/QfbavUhQLZ1sS0vuSj7YPAHTUcvhdFI17ERb9AG8NDK42JN+y NA0Ka2Q3woo+eBfCdo5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPVEy-0005Zz-C3; Tue, 29 Oct 2019 17:25:08 +0000 Received: from smtprelay0158.hostedemail.com ([216.40.44.158] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPVEt-0004zK-RV for linux-arm-kernel@lists.infradead.org; Tue, 29 Oct 2019 17:25:05 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id C4978181D3039; Tue, 29 Oct 2019 17:24:59 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: honey62_829271995af5b X-Filterd-Recvd-Size: 2690 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA; Tue, 29 Oct 2019 17:24:57 +0000 (UTC) Message-ID: <9dd814577107edc42c4469ee7c923e062a2b5368.camel@perches.com> Subject: Re: [PATCH 2/4] thermal: stm32: fix IRQ flood on low threshold From: Joe Perches To: Daniel Lezcano , Pascal Paillet , mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, robh+dt@kernel.org, mark.rutland@arm.com, rui.zhang@intel.com, edubezval@gmail.com, amit.kucheria@verdurent.com, david.hernandezsanchez@st.com, wsa+renesas@sang-engineering.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Andy Whitcroft Date: Tue, 29 Oct 2019 10:24:50 -0700 In-Reply-To: <026e676e-0a6c-81ca-3af4-2832118b9ddf@linaro.org> References: <20191029164537.1561-1-p.paillet@st.com> <20191029164537.1561-3-p.paillet@st.com> <8952e975-3bad-4b7d-49ff-b74af942008c@linaro.org> <026e676e-0a6c-81ca-3af4-2832118b9ddf@linaro.org> User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191029_102503_977599_108CF584 X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2019-10-29 at 18:21 +0100, Daniel Lezcano wrote: > On 29/10/2019 18:15, Joe Perches wrote: > > On Tue, 2019-10-29 at 18:11 +0100, Daniel Lezcano wrote: > > > On 29/10/2019 17:45, Pascal Paillet wrote: > > > > Fix IRQ flood on low threshold by too ways: > > > > > > Can you state the issue first ? > > > > > > > - improve temperature reading resolution, > > > > - add an hysteresis to the low threshold: on low threshold interrupt, > > > > it is not possible to get the temperature value that has fired the > > > > interrupt. The time to acquire a new value is enough for the CPU to > > > > become hotter than the current low threshold. > > [] > > > > Signed-off-by: Pascal Paillet > > > > Change-Id: I3b63b8aab38fd651a165c4e69a2d090b3c6f5db3 > > > > > > Please remove the Change-Id tag. > > > > > > Joe, Andy? checkpatch does not see the Change-Id, is it the expected > > > behavior? > > > > Yes. It's after a sign-off so checkpatch doesn't care. > > Ah, I guess it is for Gerrit but we don't want those Change-Id in the > kernel history, right? So remove it from the patch. checkpatch is not a perfect tool. checkpatch will never be a perfect tool. It's not possible for checkpatch to be a perfect tool. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel