From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2693BC0650E for ; Wed, 3 Jul 2019 13:01:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8DFD218A3 for ; Wed, 3 Jul 2019 13:01:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="me6rpnX/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="nHY7Db9T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8DFD218A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:From:Date: MIME-Version:Subject:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IiOK4/iAGeH3gdChTRXq3Kn94CNfvE+b14MF9uMCBK4=; b=me6rpnX/sZPJ6BUQAIWZ1cCD2 izOCvdYnXsIfvcshN93ihAN+4rH0bu+Dw50GiOMRRyrp+tnn/yCJ3COkLLGNkswJa/fiil/ayKGkX +jek67wo9gF5EoD8kH/p99qkwGxC4lxdgp4A5NR+AqNGqwdRs3chPsEa1hFU9ppvVUOU8O4JoQX0t L7PFBD/Opu4uCz+0wVZQuHzDCHnSTSy0Ntsp291VA41pmeuoM5oUmwSWEG9fPtO4QQlZNzgIXw35H DbHyFey5oD03D+Vw49WiZ0zHVZDk4Ie8C8UZIprjGssggpoiBclbokb7w/VQkU/4S5hoVtU3jlDhD 7NnbXhlIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hietX-0007Fl-0a; Wed, 03 Jul 2019 13:01:55 +0000 Received: from node.akkea.ca ([192.155.83.177]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hiesT-0006ah-2p for linux-arm-kernel@lists.infradead.org; Wed, 03 Jul 2019 13:00:51 +0000 Received: by node.akkea.ca (Postfix, from userid 33) id BC92D4E204B; Wed, 3 Jul 2019 13:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1562158846; bh=jfEnQz6Z7lDitZDfZEU5tHLgi5WtCywGyso2NpbD6yM=; h=To:Subject:Date:From:Cc:In-Reply-To:References; b=nHY7Db9TTbezNC91mUbwu6U9bjG3WAnn/Vj2i/HuvYVxqG55+k/M/yHfQaRKCevGh 3gFNdY/MIMR/QthhXFfVDa7O2uYz6nSZ3Iz73qCjR3tpEJR21kbtwmGf4EUHZylfde blLDPH5clasanypevgikazHmk+IrIti1LuSXTjuE= To: Andra Danciu Subject: Re: [PATCH v3] arm64: dts: imx8mq: Add sai3 and sai6 nodes X-PHP-Originating-Script: 1000:rcube.php MIME-Version: 1.0 Date: Wed, 03 Jul 2019 07:00:46 -0600 From: Angus Ainslie In-Reply-To: <20190702132353.18632-1-andradanciu1997@gmail.com> References: <20190702132353.18632-1-andradanciu1997@gmail.com> Message-ID: <9ea5109f8645c3f27a9e350c5f9b2d4c@www.akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190703_060049_307713_8B8F2FFF X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, abel.vesa@nxp.com, Anson.Huang@nxp.com, ccaione@baylibre.com, andrew.smirnov@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, agx@sigxcpu.org, linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andra, I tried this out on linux-next and I'm not able to record or play sound. I also added the sai2 entry to test out our devkit and get a PCM timeout with that. On 2019-07-02 07:23, Andra Danciu wrote: > SAI3 and SAI6 nodes are used to connect to an external codec. > They have 1 Tx and 1 Rx dataline. > > Cc: Daniel Baluta > Signed-off-by: Andra Danciu > --- > Changes since v2: > - removed multiple new lines > > Changes since v1: > - Added sai3 node because we need it to enable audio on pico-pi-8m > - Added commit description > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 29 > +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index d09b808eff87..736cf81b695e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -278,6 +278,20 @@ > #size-cells = <1>; > ranges = <0x30000000 0x30000000 0x400000>; > > + sai6: sai@30030000 { > + compatible = "fsl,imx8mq-sai", I don't find this compatible string in sound/soc/fsl/fsl_sai.c. Aren't the registers at a different offset from "fsl,imx6sx-sai". How is this supposed to work ? Thanks Angus > + "fsl,imx6sx-sai"; > + reg = <0x30030000 0x10000>; > + interrupts = ; > + clocks = <&clk IMX8MQ_CLK_SAI6_IPG>, > + <&clk IMX8MQ_CLK_SAI6_ROOT>, > + <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>; > + clock-names = "bus", "mclk1", "mclk2", "mclk3"; > + dmas = <&sdma2 4 24 0>, <&sdma2 5 24 0>; > + dma-names = "rx", "tx"; > + status = "disabled"; > + }; > + > gpio1: gpio@30200000 { > compatible = "fsl,imx8mq-gpio", "fsl,imx35-gpio"; > reg = <0x30200000 0x10000>; > @@ -728,6 +742,21 @@ > status = "disabled"; > }; > > + sai3: sai@308c0000 { > + compatible = "fsl,imx8mq-sai", > + "fsl,imx6sx-sai"; > + reg = <0x308c0000 0x10000>; > + interrupts = ; > + clocks = <&clk IMX8MQ_CLK_SAI3_IPG>, > + <&clk IMX8MQ_CLK_DUMMY>, > + <&clk IMX8MQ_CLK_SAI3_ROOT>, > + <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>; > + clock-names = "bus", "mclk1", "mclk2", "mclk3"; > + dmas = <&sdma1 12 24 0>, <&sdma1 13 24 0>; > + dma-names = "rx", "tx"; > + status = "disabled"; > + }; > + > i2c1: i2c@30a20000 { > compatible = "fsl,imx8mq-i2c", "fsl,imx21-i2c"; > reg = <0x30a20000 0x10000>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel