From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA62BC282CE for ; Mon, 8 Apr 2019 20:23:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A4E521841 for ; Mon, 8 Apr 2019 20:23:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HJwNUS5D"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="zneMl3IM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A4E521841 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To: Subject:To:From:Date:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ekGkbuuZ0L5HoRifVX0QG6c3lM12GuVzv3CznutmHqk=; b=HJwNUS5DpVuJI2 6e9kg57Kmc4cP0dkOBtVUw4ToykFFjNefuUvcxDZO4sUKtQQEDqM5tCKOw8/4DfLGqr99fCM6Dt1B yt/fLp0IhRYxlSgVELQywG+arhZaQ0Yto4T6/sHLPZcG7zUjadmT1T0gJixlLbJvoi2sdWLC9pqFN 97DySUPdNzU3tlPzwbWydWcp1ec+Mh81n4Z63usSSb6LE9qjI4q1Cha8Thf0Z/IyMRooCCiQCrSZp bWfgFq0PzsYkSOaSuQ/ZWQTQ4+u96o7PqEhFjRw1UdIqlguQgtWKTKqmcK9q47BoyaSVTS7xcQgsZ umEOOipeBPwlk34KTN5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDand-0000Se-CJ; Mon, 08 Apr 2019 20:23:25 +0000 Received: from mail.kmu-office.ch ([2a02:418:6a02::a2]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDanZ-0000SK-7f for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2019 20:23:23 +0000 Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 1F8655C2195; Mon, 8 Apr 2019 22:23:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1554754999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fd9cqQpgmw1YMQRwCVrRDyhsvJhdRm4FEyT2RUx8Duo=; b=zneMl3IMwjWBXBdKHRtGlFyAsEGYhQJ8E5rVPIh4gPJlbWpj7Ijt1W/AUHdmFw1Qod91mw y4y/V1RFJpMBGMZAuN7W6VlqAP6XCiUsXjVvIiWMIOFQVWAhaUlJIQlhZzVyNA/GlNc4tJ tgsA1us3K2Ebuy6AwTycBrq61bj1l+c= MIME-Version: 1.0 Date: Mon, 08 Apr 2019 22:23:19 +0200 From: Stefan Agner To: Arnd Bergmann Subject: Re: [PATCH 1/3] ARM: use arch_extension directive instead of arch argument In-Reply-To: References: <9641c58c03720104186a797a96e30a52ae9805e4.1553356359.git.stefan@agner.ch> Message-ID: <9ee2272ec522bcd99e29ae5ac91880ba@agner.ch> X-Sender: stefan@agner.ch User-Agent: Roundcube Webmail/1.3.7 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_132321_574249_8EA5CE0B X-CRM114-Status: GOOD ( 24.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Pitre , Andrew Lunn , Mans Rullgard , Tony Lindgren , Rob Herring , Florian Fainelli , Gregory CLEMENT , Russell King - ARM Linux , Krzysztof Kozlowski , Kukjin Kim , bcm-kernel-feedback-list , Sebastian Hesselbarth , Jason Cooper , Marc Gonzalez , Ray Jui , Santosh Shilimkar , Linux ARM , Scott Branden , Ard Biesheuvel , Nick Desaulniers , Linux Kernel Mailing List , Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31.03.2019 19:34, Arnd Bergmann wrote: > On Sun, Mar 24, 2019 at 3:06 AM Arnd Bergmann wrote: >> >> On Sat, Mar 23, 2019 at 4:52 PM Stefan Agner wrote: >> > >> > The LLVM Target parser currently does not allow to specify the security >> > extension as part of -march (see also LLVM Bug 40186 [0]). When trying >> > to use Clang with LLVM's integrated assembler, this leads to a build >> > errors such as this: >> > clang-8: error: the clang compiler does not support '-Wa,-march=armv7-a+sec' >> > >> > Use ".arch_extension sec" to enable the security extension in a more >> > portable fasion. >> > >> > Note that this is technically not exactly the same as the old code >> > checked for availabilty of the security extension by calling as-instr. >> > However, there are already other sites which use ".arch_extension sec" >> > unconditionally, hence de-facto we need an assembler capable of >> > ".arch_extension sec" already today (arch/arm/mm/proc-v7.S). The >> > arch extension "sec" is available since binutils 2.21 according to >> > its documentation [1]. >> > >> > [0] https://bugs.llvm.org/show_bug.cgi?id=40186 >> > [1] https://sourceware.org/binutils/docs-2.21/as/ARM-Options.html >> > >> > Signed-off-by: Stefan Agner >> >> This sounds like a good idea. I think we have platform specific >> minimum toolchain versions elsewhere, but I don't see a problem >> with raising the minimum version for all the armv7ve platforms. >> >> I've added this patch to my randconfig test queue, but please >> send it to arm@kernel.org for inclusion when you have >> collected more Acks. >> >> Do you have a git tree with other patches required for the >> integrated assembler? I might try that out as well with >> my randconfig tree. At the moment I'm building with >> clang-8 and a small number of patches on top. >> >> Acked-by: Arnd Bergmann > > I only now looked at the results and found a problem: > In a mixed v6/v7 configuration, the arch_extension flag > is not sufficient, and for armv6+sec, we get failures like > > /git/arm-soc/arch/arm/mach-omap2/sleep44xx.S: Assembler messages: > /git/arm-soc/arch/arm/mach-omap2/sleep44xx.S:343: Error: selected > processor does not support `isb' in ARM mode > /git/arm-soc/arch/arm/mach-omap2/sleep44xx.S:350: Error: selected > processor does not support `dsb' in ARM mode > /git/arm-soc/arch/arm/mach-omap2/sleep44xx.S:351: Error: selected > processor does not support `dmb' in ARM mode > clang: error: assembler command failed with exit code 1 (use -v to see > invocation) > /git/arm-soc/scripts/Makefile.build:369: recipe for target > 'arch/arm/mach-omap2/sleep44xx.o' failed > make[3]: *** [arch/arm/mach-omap2/sleep44xx.o] Error 1 > > ==> build/arm/0x64728DCE_defconfig/log <== > /git/arm-soc/arch/arm/mach-omap2/omap-smc.S: Assembler messages: > /git/arm-soc/arch/arm/mach-omap2/omap-smc.S:31: Error: selected > processor does not support `dsb' in ARM mode > /git/arm-soc/arch/arm/mach-omap2/omap-smc.S:53: Error: selected > processor does not support `dsb' in ARM mode > /git/arm-soc/arch/arm/mach-omap2/omap-smc.S:54: Error: selected > processor does not support `dmb' in ARM mode Hm, I guess I can just use .arch armv7-a in those cases, as we use in other places. Thanks for testing! Will send a v2. -- Stefan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel