From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E520C43603 for ; Fri, 6 Dec 2019 18:35:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9B7C21835 for ; Fri, 6 Dec 2019 18:35:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FFCunizn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="FypCstUL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9B7C21835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goldelico.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EQ/jdE62Sz2WpU7Upbal7Y+qmIkgxzxH0J+Lr2UI5Kg=; b=FFCuniznP9kyL0 bsJQ2vBOusk6wajCSmOzwEWXRnzk5/0r3+Be7bFcUI6YGLVqFyzuJq4HMXd7/LetT4cNwkeJjNGl/ mHJi+mYymMOdrK04j4HPSb74E4slYnOpXKRIiDCJoEQpy7qnUBHNOwffpPM/n0WoM8Sn2yWZ59Izr L41Z5Lp6vi+3KP1vF8h388HtBGycU4rp+x5PaA2D0LdZfNo96evDPTyL8tt/s7vQ9wgM3dhGztMGX YKUatnylADO6bIBj0Y1dtwi4kjk6V9mZ5W9aWbLOFQ6aAJG0wq2syL3j9yp/Yw9Ep6/u3y+Pz2u2d TO7edxAOrBWFfNxlZcrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1idIRS-00074K-03; Fri, 06 Dec 2019 18:35:02 +0000 Received: from mo6-p01-ob.smtp.rzone.de ([2a01:238:20a:202:5301::5]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1idIRO-00073l-2N for linux-arm-kernel@lists.infradead.org; Fri, 06 Dec 2019 18:35:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1575657292; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=8xcPnshoEvqmpl8Ihb0gwyd1N4JC6oPtQIQeUEG485c=; b=FypCstULfGixPqXwD962BjcT2n3tgPOo6mWf8U6ybLQEfNin/ZNLphdmIBEmRCn6Ve kDfclcYANqJ+6nbnVp7cZQ0ujrwCEoDtDVIvy2x4I+6XqZbEHH4uhlWf35otgZvIUQbO tMOBTjSmibu5ISO9EURe4/FZxV0pNF9iT0NiD2iCvtfasCDQ9H9XeIgy3ZTWiPHCrBER pU2MBQABfGcl4GN4/RzUSEBdwEfeNs14diyv5B7c5m91uUBv92m29RGZe13KHgemX0te PwbtdiR7t1Knd1b9xWBAmcBJYJUgUmK8sUVWp1JmPqlt67H4JhkdHdkKLprrlJx4qQaI zGgA== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NMGH/vgwDOprHg=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 46.0.2 DYNA|AUTH) with ESMTPSA id 6067eavB6IYjLOv (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Fri, 6 Dec 2019 19:34:45 +0100 (CET) Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH] ARM: OMAP2+: Fix warnings with broken omap2_set_init_voltage() From: "H. Nikolaus Schaller" In-Reply-To: <20191206182040.GH35479@atomide.com> Date: Fri, 6 Dec 2019 19:34:44 +0100 Message-Id: References: <20190924233222.52757-1-tony@atomide.com> <8FFD44DB-73F8-4807-91E1-C97DA8F781BA@goldelico.com> <20191202213929.GB35479@atomide.com> <20191203154447.GC35479@atomide.com> <5F430C0D-7F25-4680-87B9-2D65A08A9F83@goldelico.com> <20191206182040.GH35479@atomide.com> To: Tony Lindgren X-Mailer: Apple Mail (2.3124) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191206_103458_708673_214BFD2D X-CRM114-Status: UNSURE ( 9.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Discussions about the Letux Kernel , Linux Kernel Mailing List , Tero Kristo , =?utf-8?Q?Andr=C3=A9_Roth?= , Linux-OMAP , Adam Ford , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Am 06.12.2019 um 19:20 schrieb Tony Lindgren : > > * H. Nikolaus Schaller [191203 16:55]: >>> What we could do is augment the printk (or dev_err) to tell >>> in these warnings what it is looking for... >>> >>> opp = dev_pm_opp_find_freq_ceil(dev, &freq); >>> if (IS_ERR(opp)) { >>> pr_err("%s: unable to find boot up OPP for vdd_%s freq %ulHz\n", >>> __func__, vdd_name, freq); >>> goto exit; >>> } >> >> Easier and always prints info: >> >> freq = clk_get_rate(clk); >> clk_put(clk); >> >> pr_info("%s: vdd=%s clk=%s %luHz oh=%s\n", __func__, vdd_name, clk_name, freq, oh_name); >> >> opp = dev_pm_opp_find_freq_ceil(dev, &freq); >> >> I get this: >> >> [ 2.908142] omap2_set_init_voltage: vdd=mpu_iva clk=dpll1_ck 1000000000Hz oh=mpu >> [ 2.930816] omap2_set_init_voltage: vdd=core clk=l3_ick 200000000Hz oh=l3_main >> [ 2.946228] omap2_set_init_voltage: unable to find boot up OPP for vdd_core >> [ 2.953460] omap2_set_init_voltage: unable to set vdd_core > > OK yeah that's more descriptive. So what does your board say as it is also unable to find the initial mpu_iva? And/or does it show a different core clock? > >> Which means that cpufreq already has increased dpll1_ck to 1 GHz >> (I have removed the turbo-mode tags so that it already boots at >> full speed) and l3_ick runs at initial 200 MHz. > > OK. I wonder where this initial code should live though.. Well, we all agree that it should live in deserved retirement :) But it has some positive effect and maybe "fixes" a bug in cpufreq-only setup. BR, Nikolaus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel