From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CE5EC2BA19 for ; Wed, 15 Apr 2020 12:51:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1745F20767 for ; Wed, 15 Apr 2020 12:51:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cN9O6J2W"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="G5jhLsHc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1745F20767 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goldelico.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Date: In-Reply-To:From:Mime-Version:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=skhy6JfV4EcORwM9HLmEvy814zdrEENHQLk4Pc65rfE=; b=cN9O6J2WD7SRAd nZTG5hKki6lpdCCLZiux39OWxdHj6ZRAKcaW0ji/rSbMiFbDzszPK/bgm5IMBRASE+fjTHuS+wpwi YYKDpMLRoIk28gb5vkrFtrrgKgWG+F9fpZ1HJpAU8QWOdctytFc1eBLeGCArVzLcSRuXw+doRbPKf 4LW7MgIjK9AzQHbdocxZlTJEfckc1I7o7OkiVMzI7TfPfb3Twdm9E0fkybRqh/VjOh4v6OuNUFrtu HTTzdtKdtW2XScutgvBmtN+db/DzzIK6GU1h16pTJ5O8pqiodQxdMZovCgpv/klALma4fxuidygum bMjSraVOe6f0BIy3z51w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOhVW-0007KJ-Ea; Wed, 15 Apr 2020 12:51:10 +0000 Received: from mo6-p03-ob.smtp.rzone.de ([2a01:238:20a:202:5303::2]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOhUx-0006iR-Ak for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2020 12:50:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1586955033; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=ZWPeQuNZym8qIi2cOZDzlHwaDAs+LcskJtN8sCgQ/rk=; b=G5jhLsHcdYx7caZ+OG6N6OV6aFen4jS1w6N8QOyBetugrsoukTRmPn68RmeqK1Opba D4AoFQ+QYvj0Vgzv/isZEr7sK5jQwK78T8ILG+DoCRjV8MOwtou1/1wKzlp9hcWwVgYk RBSfKdUQNiqqrQb+k0J9ylv2gSRVEClvzNVL5+IA8GTrqbCgq05QqfmClzEmz/i5Enso BgQmsblbOcykYkRoolp7nhp8AmCrp60kLIh5bMArtVs72zNEWUTBIFZFbHeFWaxbBB2e /j0JTklJ7nfbFXgN1Y5qwc2bTJoXz/sJf+6qO7ID9kGOonh19XrV/5LL+SfIIoisK3Ch dgZg== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NMGH/PtwDConyM=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 46.4.0 DYNA|AUTH) with ESMTPSA id 6028a2w3FCoV1xp (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 15 Apr 2020 14:50:31 +0200 (CEST) Subject: Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 15 Apr 2020 14:50:31 +0200 Message-Id: References: To: Krzysztof Kozlowski , Jonathan Bakker X-Mailer: Apple Mail (2.3124) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_055036_325384_0EEFCC50 X-CRM114-Status: GOOD ( 15.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , James Hogan , Jonathan Bakker , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , "linux-samsung-soc@vger.kernel.org" , linux-omap@vger.kernel.org, Paul Burton , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , devicetree@vger.kernel.org, =?utf-8?Q?Beno=C3=AEt_Cousson?= , Maxime Ripard , Rob Herring , letux-kernel@openphoenux.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, "linux-kernel@vger.kernel.org" , Ralf Baechle , Daniel Vetter , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Am 15.04.2020 um 13:49 schrieb Krzysztof Kozlowski : > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: >> >> From: Jonathan Bakker >> >> to add support for SGX540 GPU. > > Do not continue the subject in commit msg like it is one sentence. > These are two separate sentences, so commit msg starts with capital > letter and it is sentence by itself. > >> Signed-off-by: Jonathan Bakker >> Signed-off-by: H. Nikolaus Schaller >> --- >> arch/arm/boot/dts/s5pv210.dtsi | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi >> index 2ad642f51fd9..e7fc709c0cca 100644 >> --- a/arch/arm/boot/dts/s5pv210.dtsi >> +++ b/arch/arm/boot/dts/s5pv210.dtsi >> @@ -512,6 +512,21 @@ vic3: interrupt-controller@f2300000 { >> #interrupt-cells = <1>; >> }; >> >> + g3d: g3d@f3000000 { >> + compatible = "samsung,s5pv210-sgx540-120"; >> + reg = <0xf3000000 0x10000>; >> + interrupt-parent = <&vic2>; >> + interrupts = <10>; >> + clock-names = "sclk"; >> + clocks = <&clocks CLK_G3D>; > > Not part of bindings, please remove or add to the bindings. Well, the bindings should describe what is common for all SoC and they are quite different in what they need in addition. Thererfore we have no "additionalProperties: false" in the bindings [PATCH v6 01/12]. > >> + >> + power-domains = <&pd S5PV210_PD_G3D>; > > Ditto In this case it might be possible to add the clock/power-domains etc. to a wrapper node compatible to "simple-pm-bus" or similar and make the gpu a child of it. @Jontahan: can you please give it a try? > >> + >> + assigned-clocks = <&clocks MOUT_G3D>, <&clocks DOUT_G3D>; >> + assigned-clock-rates = <0>, <66700000>; >> + assigned-clock-parents = <&clocks MOUT_MPLL>; > > Probably this should have status disabled because you do not set > regulator supply. > > Best regards, > Krzysztof BR and thanks, Nikolaus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel