From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA47C10F14 for ; Tue, 9 Apr 2019 03:36:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6253213F2 for ; Tue, 9 Apr 2019 03:36:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YDhex9uk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="fjahxyfH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6253213F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yLHeLV5txx4LtyUqkd3IgRAmCsBUozKBkpMyvzOqk58=; b=YDhex9ukyYYhxo 2LjFj98bFiquVIruD1D6eKIFkCKGQGapBhprApYad2qUFAE6ONDC2BQVKEP7EYC9p1wY+LXLx+hCf Kxgd12saa7A3DgM2VdD7So4CLYqicSCJNBJb1B0YGBN0lEOQurNSvhMNyQ93ojTX4lFVVtPavtMDk qu6BFAoEdJjuNUt3saHAI8p6dlD5Zpxg0jPcaaHgyv53ZdqA4Fy3bk9hgH8eDuaDGiLqa5s5HqMZa esaAlVcxLx7I/b5KNqin6H52PGwkGSwcxTY7NhzZGrpTtnJiZvFiuZEHdIQdgJaU79l12Xb4pGrWV 8T1tQKgKtLf1lgKo6NLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDhYL-0003qA-TQ; Tue, 09 Apr 2019 03:36:05 +0000 Received: from mail-eopbgr30063.outbound.protection.outlook.com ([40.107.3.63] helo=EUR03-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDhYJ-0003pg-9G for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 03:36:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xiboL5DFU1frlvmKdtgzRMcGtQOUNZRuntmlCvjbNaQ=; b=fjahxyfHYd9unyZgrHVSnbrjJ3QFjdmPxgwictRblDdciy7VqhS4JDql0vtMJsQQjre2xqK3FUurdcLwsjLromnyXuZ90cDn40z8la5JEpsTM8/V2CICjVrMVIo0p3pTsU+RDfUEt1N1gT1pHCCMdLSTDO4fTmM8ypH/SW0YyoI= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5252.eurprd04.prod.outlook.com (20.177.42.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.19; Tue, 9 Apr 2019 03:35:59 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::8cda:4e52:8e87:8f0e]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::8cda:4e52:8e87:8f0e%2]) with mapi id 15.20.1771.016; Tue, 9 Apr 2019 03:35:59 +0000 From: Aisheng Dong To: Anson Huang , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "a.zummo@towertech.it" , "alexandre.belloni@bootlin.com" , "ulf.hansson@linaro.org" , "sboyd@kernel.org" , Peng Fan , Daniel Baluta , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rtc@vger.kernel.org" Subject: RE: [PATCH V6 4/4] rtc: imx-sc: add rtc alarm support Thread-Topic: [PATCH V6 4/4] rtc: imx-sc: add rtc alarm support Thread-Index: AQHU7n4FMdKcp4NQJ0ukn8zURCHpWaYzKXfggAADpACAAABHMA== Date: Tue, 9 Apr 2019 03:35:59 +0000 Message-ID: References: <1554777487-31075-1-git-send-email-Anson.Huang@nxp.com> <1554777487-31075-4-git-send-email-Anson.Huang@nxp.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b2eaa99d-18ef-40ae-1057-08d6bc9c7b7e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR04MB5252; x-ms-traffictypediagnostic: AM0PR04MB5252: x-microsoft-antispam-prvs: x-forefront-prvs: 000227DA0C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(376002)(39860400002)(396003)(346002)(189003)(199004)(86362001)(68736007)(229853002)(6506007)(4744005)(66066001)(6436002)(478600001)(6116002)(71190400001)(4326008)(3846002)(186003)(25786009)(9686003)(2906002)(106356001)(102836004)(97736004)(26005)(53936002)(105586002)(6246003)(71200400001)(2201001)(5660300002)(81166006)(8676002)(55016002)(110136005)(76176011)(11346002)(52536014)(305945005)(476003)(446003)(74316002)(7736002)(316002)(33656002)(256004)(81156014)(7696005)(2501003)(99286004)(93886005)(44832011)(486006)(14454004)(7416002)(8936002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB5252; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5nAaJhxwmSUGmfC6Djqk2nXJRCYh0SzAUm4fGMUkilB83of4vX9mwfX62Mv7p+1qMsuht/BmxSZeHNbaufTTjC7R6JCWxpZ28NwBeqtojUAuPqSJtGEkAgIC3EEu5Cg+VrIkJvXRjXxiIOg6ekaEkYNPuZlcnxLXA2kBPoknkcSxhU+8OY8gONaXq/a4ZwqCtRogT9XYhBgLC5WIiOttOMh2gv3hLDV2WB5hKIfdZtSJzCa4pBGZ7Pw2hCkIpfyA4o1Tf/ZiAcRhN/U+VWBvBvcfVxn/0OSeyyR7srw5iTjRnxH0a5NQmrNj2TwDOeUNbjnT63ohuo+jc63lIqGlxBfAGgozWMbxKOOJr3z3w0/5UBkjr/3wlFiBRz9j/ZYtBYVYIZ/Cb4D88ca92kcdzIACTH09wNDzAsoaDP9cOBM= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2eaa99d-18ef-40ae-1057-08d6bc9c7b7e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2019 03:35:59.1362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5252 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_203603_357117_67864583 X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dl-linux-imx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org [...] > > > +static int imx_sc_rtc_alarm_irq_enable(struct device *dev, unsigned > > > +int > > > +enable) { > > > + imx_scu_irq_enable(SC_IRQ_GROUP_RTC, SC_IRQ_RTC, enable); > > > + > > > + return 0; > > > +} > > > + > > > +static int imx_sc_rtc_read_alarm(struct device *dev, struct > > > +rtc_wkalrm > > > +*alrm) { > > > > I still think here needs a doc explain why needs this and why it's > > safe to do that. > > I will add a comment here, for the doc, it should be another topic of RTC > framework, we can do it later. I'm fine with it. BTW, don't miss the next minor comments when you resend. Regards Dong Aisheng > > > + .set_alarm = imx_sc_rtc_set_alarm, > > > + .alarm_irq_enable = imx_sc_rtc_alarm_irq_enable, }; > > > + > > > +static int imx_sc_rtc_alarm_sc_notify(struct notifier_block *nb, > > > + unsigned long event, void *group) > > > > Not necessary to have such a long function name. > > Imx_sc_rtc_alarm_notify() should be ok > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel