Linux-ARM-Kernel Archive on lore.kernel.org
 help / Atom feed
* [PATCH v2] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2
@ 2018-12-23 13:20 Abel Vesa
  2019-01-12  3:08 ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Abel Vesa @ 2018-12-23 13:20 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Fabio Estevam
  Cc: Abel Vesa, dl-linux-imx, linux-arm-kernel, Linux Kernel Mailing List

Since this is going to be used on more SoCs than just i.MX8MQ,
make the dependency here more generic.

Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
---
Changes since v1:
 * removed the SOC_IMX7D since it's included by ARCH_MXC
   as suggested by Dong Aisheng.

 drivers/soc/imx/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 2112d18..d80f899 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -2,7 +2,7 @@ menu "i.MX SoC drivers"
 
 config IMX_GPCV2_PM_DOMAINS
 	bool "i.MX GPCv2 PM domains"
-	depends on SOC_IMX7D || SOC_IMX8MQ || (COMPILE_TEST && OF)
+	depends on ARCH_MXC || (COMPILE_TEST && OF)
 	depends on PM
 	select PM_GENERIC_DOMAINS
 	default y if SOC_IMX7D
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2
  2018-12-23 13:20 [PATCH v2] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2 Abel Vesa
@ 2019-01-12  3:08 ` Shawn Guo
  2019-01-12  3:14   ` Aisheng Dong
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2019-01-12  3:08 UTC (permalink / raw)
  To: Abel Vesa
  Cc: Fabio Estevam, Linux Kernel Mailing List, dl-linux-imx,
	Sascha Hauer, linux-arm-kernel

On Sun, Dec 23, 2018 at 01:20:34PM +0000, Abel Vesa wrote:
> Since this is going to be used on more SoCs than just i.MX8MQ,
> make the dependency here more generic.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> Changes since v1:
>  * removed the SOC_IMX7D since it's included by ARCH_MXC

This should really be mentioned in the commit log.

Shawn

>    as suggested by Dong Aisheng.
> 
>  drivers/soc/imx/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
> index 2112d18..d80f899 100644
> --- a/drivers/soc/imx/Kconfig
> +++ b/drivers/soc/imx/Kconfig
> @@ -2,7 +2,7 @@ menu "i.MX SoC drivers"
>  
>  config IMX_GPCV2_PM_DOMAINS
>  	bool "i.MX GPCv2 PM domains"
> -	depends on SOC_IMX7D || SOC_IMX8MQ || (COMPILE_TEST && OF)
> +	depends on ARCH_MXC || (COMPILE_TEST && OF)
>  	depends on PM
>  	select PM_GENERIC_DOMAINS
>  	default y if SOC_IMX7D
> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH v2] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2
  2019-01-12  3:08 ` Shawn Guo
@ 2019-01-12  3:14   ` Aisheng Dong
  0 siblings, 0 replies; 3+ messages in thread
From: Aisheng Dong @ 2019-01-12  3:14 UTC (permalink / raw)
  To: Shawn Guo, Abel Vesa
  Cc: Fabio Estevam, Linux Kernel Mailing List, dl-linux-imx,
	Sascha Hauer, linux-arm-kernel

> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Saturday, January 12, 2019 11:09 AM
> On Sun, Dec 23, 2018 at 01:20:34PM +0000, Abel Vesa wrote:
> > Since this is going to be used on more SoCs than just i.MX8MQ, make
> > the dependency here more generic.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> > Changes since v1:
> >  * removed the SOC_IMX7D since it's included by ARCH_MXC
> 
> This should really be mentioned in the commit log.
> 

Yes, you're right. We should put it in commit log.

Abel,
Would you resend with this updated?

Regards
Dong Aisheng

> Shawn
> 
> >    as suggested by Dong Aisheng.
> >
> >  drivers/soc/imx/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig index
> > 2112d18..d80f899 100644
> > --- a/drivers/soc/imx/Kconfig
> > +++ b/drivers/soc/imx/Kconfig
> > @@ -2,7 +2,7 @@ menu "i.MX SoC drivers"
> >
> >  config IMX_GPCV2_PM_DOMAINS
> >  	bool "i.MX GPCv2 PM domains"
> > -	depends on SOC_IMX7D || SOC_IMX8MQ || (COMPILE_TEST && OF)
> > +	depends on ARCH_MXC || (COMPILE_TEST && OF)
> >  	depends on PM
> >  	select PM_GENERIC_DOMAINS
> >  	default y if SOC_IMX7D
> > --
> > 2.7.4
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-23 13:20 [PATCH v2] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2 Abel Vesa
2019-01-12  3:08 ` Shawn Guo
2019-01-12  3:14   ` Aisheng Dong

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox