From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 914A0C18E7C for ; Wed, 22 May 2019 01:48:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 675C5217F9 for ; Wed, 22 May 2019 01:48:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jF2AWU5v"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="qATQtGon" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 675C5217F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sbjzIaXhfiWSeyCyNesHV9/IPa+QlmYCrhkJu1k7oQ4=; b=jF2AWU5vdYfgWw YVV9vGq3fVpNpS8VMhPy/QUeM6cVsm9QTaVZ7u4dOHg1w0pWrSofEy5r/4mfO4V1AahFYTEuxK+sv IOcJ+el7v9rJgr1NJYOyCU6RsiJTjClgB9xcdobFAmkjnC+llplEA4RJ52V34OAgTDVO8nmG1o9u8 CNXhlIAuQhRRNtmZNFJZq+mLtBC9cgkeI8gxxVeuJ+bItBJwrKoSf7oVUbolK+1mOP+uWOZG+xkV8 kqfs+ZGDmYHFwApZ0ewYmWjLa9SHaCocGbPpz4KH6qYtedwvw68Zs3kgYs/ODOBkSRUDK2nGzPI5Z rLBllzG1i3wpFHujCG3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTGN4-0006RU-N0; Wed, 22 May 2019 01:48:46 +0000 Received: from mail-eopbgr20052.outbound.protection.outlook.com ([40.107.2.52] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTGN1-0006QD-FW for linux-arm-kernel@lists.infradead.org; Wed, 22 May 2019 01:48:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=18GXoO6jzqqNG7zd7I6Rm5/+IV8DNRErtH0K25K7+UU=; b=qATQtGonRYqF9KRDv8CMQhOmc6uEjrEdivGmJy8obMFXGbJuhXFyqCz7VE3rbltZvM0FGG9iKdzI/Zp4IsC8rC+hjViHxGyiUKnraVdJa3Ry9MHDDu9WfUkxo+guhnQdWDCGsdNKYsJaiiZmTDwafOeaIG+hdu+/LcB5wcU57OA= Received: from AM0PR04MB4481.eurprd04.prod.outlook.com (52.135.147.15) by AM0PR04MB5954.eurprd04.prod.outlook.com (20.178.115.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.15; Wed, 22 May 2019 01:48:39 +0000 Received: from AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::3173:24:d401:2378]) by AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::3173:24:d401:2378%6]) with mapi id 15.20.1900.020; Wed, 22 May 2019 01:48:39 +0000 From: Peng Fan To: Srinivas Kandagatla , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , Aisheng Dong Subject: RE: [PATCH V3 2/4] nvmem: imx: add i.MX8 nvmem driver Thread-Topic: [PATCH V3 2/4] nvmem: imx: add i.MX8 nvmem driver Thread-Index: AQHVCvNIvY47qD01X0W2BY2Hg3O+1qZ1SaKAgAEg9IA= Date: Wed, 22 May 2019 01:48:39 +0000 Message-ID: References: <20190515080703.19147-1-peng.fan@nxp.com> <20190515080703.19147-2-peng.fan@nxp.com> <36036b4c-c154-d987-ffff-06f61005120c@linaro.org> In-Reply-To: <36036b4c-c154-d987-ffff-06f61005120c@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=peng.fan@nxp.com; x-originating-ip: [119.31.174.71] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b9663c0d-dd12-4ee2-e746-08d6de579d05 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR04MB5954; x-ms-traffictypediagnostic: AM0PR04MB5954: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0045236D47 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(189003)(199004)(44832011)(486006)(2501003)(186003)(305945005)(11346002)(446003)(476003)(2906002)(14444005)(76176011)(71190400001)(71200400001)(14454004)(7696005)(99286004)(256004)(102836004)(26005)(6116002)(3846002)(6506007)(53546011)(68736007)(6636002)(498600001)(5660300002)(33656002)(54906003)(110136005)(74316002)(9686003)(55016002)(4326008)(66066001)(229853002)(25786009)(6436002)(53936002)(6246003)(2201001)(76116006)(8676002)(8936002)(81166006)(81156014)(73956011)(66946007)(86362001)(66476007)(66556008)(64756008)(66446008)(7416002)(7736002)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB5954; H:AM0PR04MB4481.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: irBoo2L99Amu1O6IwRgm+0bM/Y4TAaHlYx0UYPhhwF1Cla+cH78GHz7I5TDcQrZ4yrPMdVklfnwWBvBw65B7GQCSnhEEKkhyIllXDXTzDOwqdUQX2TQSLpje4Ck8pJzBq+62R5k1HzNTgHiWm52UUC3qhwMI1nKW/veMyg0EDasSY0cYM4x0FjMRHu4jyZZZ8xSvK2kCyzfiAEkBg7n7EWUBhEe38PuES3BAnDxUu8iT/ADafiNXlsQROihGdXAeA+0WrYhDyZQo9Sa2KqTqUS8i0cnpsRK19TqqSX14cI1DIyNwuHGLiPgl5OQhujUmGvLmaxi8UULykBymWtIYP4pYAHBlWuVMUqESSljvjBwCZJ31T6COjdJkfLDJbUHXRA5qt3NR79FoHiPt7CweNNn8c+zTB71BCU8g3kM8TQI= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9663c0d-dd12-4ee2-e746-08d6de579d05 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2019 01:48:39.6175 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5954 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190521_184843_526781_8CC2E3AA X-CRM114-Status: GOOD ( 27.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx , Pengutronix Kernel Team , "van.freenix@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Srinivas, > Subject: Re: [PATCH V3 2/4] nvmem: imx: add i.MX8 nvmem driver > > > > On 15/05/2019 08:53, Peng Fan wrote: > > This patch adds i.MX8 nvmem ocotp driver to access fuse via RPC to > > i.MX8 system controller. > > > > Cc: Srinivas Kandagatla > > Cc: Shawn Guo > > Cc: Sascha Hauer > > Cc: Pengutronix Kernel Team > > Cc: Fabio Estevam > > Cc: NXP Linux Team > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Peng Fan > > I don't see any dt-binding patches in my list. May be you forgot to add me in > CC. > > Can You please make sure that you add me to the cc of the dt-bindings patch > so that I can take the driver and dt-bindings together via nvmem tree. > I will not be able to apply any driver patches without dt-bindings. Sorry. Forgot to add you in that patch. Resent the whole v3 patchset with you in To list just now. Thanks, Peng. > > Thanks, > srini > > --- > > > > V3: > > Use imx_sc_msg_misc_fuse_read for req/resp > > Drop uneccessary check > > Drop the unnecessary type conversion > > Minor fixes according to v2 comments > > > > V2: > > Add "scu" or "SCU", Add imx_sc_misc_otp_fuse_read, minor fixes > > > > drivers/nvmem/Kconfig | 7 ++ > > drivers/nvmem/Makefile | 2 + > > drivers/nvmem/imx-ocotp-scu.c | 161 > ++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 170 insertions(+) > > create mode 100644 drivers/nvmem/imx-ocotp-scu.c > > > > diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index > > 530d570724c9..79afe44195a1 100644 > > --- a/drivers/nvmem/Kconfig > > +++ b/drivers/nvmem/Kconfig > > @@ -36,6 +36,13 @@ config NVMEM_IMX_OCOTP > > This driver can also be built as a module. If so, the module > > will be called nvmem-imx-ocotp. > > > > +config NVMEM_IMX_OCOTP_SCU > > + tristate "i.MX8 SCU On-Chip OTP Controller support" > > + depends on IMX_SCU > > + help > > + This is a driver for the SCU On-Chip OTP Controller (OCOTP) > > + available on i.MX8 SoCs. > > + > > config NVMEM_LPC18XX_EEPROM > > tristate "NXP LPC18XX EEPROM Memory Support" > > depends on ARCH_LPC18XX || COMPILE_TEST diff --git > > a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile index > > 2ece8ffffdda..30d653d34e57 100644 > > --- a/drivers/nvmem/Makefile > > +++ b/drivers/nvmem/Makefile > > @@ -13,6 +13,8 @@ obj-$(CONFIG_NVMEM_IMX_IIM) += > nvmem-imx-iim.o > > nvmem-imx-iim-y := imx-iim.o > > obj-$(CONFIG_NVMEM_IMX_OCOTP) += nvmem-imx-ocotp.o > > nvmem-imx-ocotp-y := imx-ocotp.o > > +obj-$(CONFIG_NVMEM_IMX_OCOTP_SCU) += nvmem-imx-ocotp-scu.o > > +nvmem-imx-ocotp-scu-y := imx-ocotp-scu.o > > obj-$(CONFIG_NVMEM_LPC18XX_EEPROM) += > nvmem_lpc18xx_eeprom.o > > nvmem_lpc18xx_eeprom-y := lpc18xx_eeprom.o > > obj-$(CONFIG_NVMEM_LPC18XX_OTP) += nvmem_lpc18xx_otp.o > > diff --git a/drivers/nvmem/imx-ocotp-scu.c > > b/drivers/nvmem/imx-ocotp-scu.c new file mode 100644 index > > 000000000000..d9dc482ecb2f > > --- /dev/null > > +++ b/drivers/nvmem/imx-ocotp-scu.c > > @@ -0,0 +1,161 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * i.MX8 OCOTP fusebox driver > > + * > > + * Copyright 2019 NXP > > + * > > + * Peng Fan > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +enum ocotp_devtype { > > + IMX8QXP, > > +}; > > + > > +struct ocotp_devtype_data { > > + int devtype; > > + int nregs; > > +}; > > + > > +struct ocotp_priv { > > + struct device *dev; > > + const struct ocotp_devtype_data *data; > > + struct imx_sc_ipc *nvmem_ipc; > > +}; > > + > > +struct imx_sc_msg_misc_fuse_read { > > + struct imx_sc_rpc_msg hdr; > > + u32 word; > > +} __packed; > > + > > +static struct ocotp_devtype_data imx8qxp_data = { > > + .devtype = IMX8QXP, > > + .nregs = 800, > > +}; > > + > > +static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word, > > + u32 *val) > > +{ > > + struct imx_sc_msg_misc_fuse_read msg; > > + struct imx_sc_rpc_msg *hdr = &msg.hdr; > > + int ret; > > + > > + hdr->ver = IMX_SC_RPC_VERSION; > > + hdr->svc = IMX_SC_RPC_SVC_MISC; > > + hdr->func = IMX_SC_MISC_FUNC_OTP_FUSE_READ; > > + hdr->size = 2; > > + > > + msg.word = word; > > + > > + ret = imx_scu_call_rpc(ipc, &msg, true); > > + if (ret) > > + return ret; > > + > > + *val = msg.word; > > + > > + return 0; > > +} > > + > > +static int imx_scu_ocotp_read(void *context, unsigned int offset, > > + void *val, size_t bytes) > > +{ > > + struct ocotp_priv *priv = context; > > + u32 count, index, num_bytes; > > + u32 *buf; > > + void *p; > > + int i, ret; > > + > > + index = offset >> 2; > > + num_bytes = round_up((offset % 4) + bytes, 4); > > + count = num_bytes >> 2; > > + > > + if (count > (priv->data->nregs - index)) > > + count = priv->data->nregs - index; > > + > > + p = kzalloc(num_bytes, GFP_KERNEL); > > + if (!p) > > + return -ENOMEM; > > + > > + buf = p; > > + > > + for (i = index; i < (index + count); i++) { > > + if (priv->data->devtype == IMX8QXP) { > > + if ((i > 271) && (i < 544)) { > > + *buf++ = 0; > > + continue; > > + } > > + } > > + > > + ret = imx_sc_misc_otp_fuse_read(priv->nvmem_ipc, i, buf); > > + if (ret) { > > + kfree(p); > > + return ret; > > + } > > + buf++; > > + } > > + > > + memcpy(val, (u8 *)p + offset % 4, bytes); > > + > > + kfree(p); > > + > > + return 0; > > +} > > + > > +static struct nvmem_config imx_scu_ocotp_nvmem_config = { > > + .name = "imx-scu-ocotp", > > + .read_only = true, > > + .word_size = 4, > > + .stride = 1, > > + .owner = THIS_MODULE, > > + .reg_read = imx_scu_ocotp_read, > > +}; > > + > > +static const struct of_device_id imx_scu_ocotp_dt_ids[] = { > > + { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data }, > > + { }, > > +}; > > +MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids); > > + > > +static int imx_scu_ocotp_probe(struct platform_device *pdev) { > > + struct device *dev = &pdev->dev; > > + struct ocotp_priv *priv; > > + struct nvmem_device *nvmem; > > + int ret; > > + > > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > + if (!priv) > > + return -ENOMEM; > > + > > + ret = imx_scu_get_handle(&priv->nvmem_ipc); > > + if (ret) > > + return ret; > > + > > + priv->data = of_device_get_match_data(dev); > > + priv->dev = dev; > > + imx_scu_ocotp_nvmem_config.size = 4 * priv->data->nregs; > > + imx_scu_ocotp_nvmem_config.dev = dev; > > + imx_scu_ocotp_nvmem_config.priv = priv; > > + nvmem = devm_nvmem_register(dev, &imx_scu_ocotp_nvmem_config); > > + > > + return PTR_ERR_OR_ZERO(nvmem); > > +} > > + > > +static struct platform_driver imx_scu_ocotp_driver = { > > + .probe = imx_scu_ocotp_probe, > > + .driver = { > > + .name = "imx_scu_ocotp", > > + .of_match_table = imx_scu_ocotp_dt_ids, > > + }, > > +}; > > +module_platform_driver(imx_scu_ocotp_driver); > > + > > +MODULE_AUTHOR("Peng Fan "); > > +MODULE_DESCRIPTION("i.MX8 SCU OCOTP fuse box driver"); > > +MODULE_LICENSE("GPL v2"); > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel