From: Peng Fan <peng.fan@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Jacky Bai <ping.bai@nxp.com>, Anson Huang <anson.huang@nxp.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"info@metux.net" <info@metux.net>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"git@andred.net" <git@andred.net>,
Leonard Crestez <leonard.crestez@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"allison@lohutok.net" <allison@lohutok.net>,
Abel Vesa <abel.vesa@nxp.com>
Subject: RE: [RFC 1/4] ARM: imx: use device_initcall for imx_soc_device_init
Date: Thu, 13 Feb 2020 05:47:41 +0000 [thread overview]
Message-ID: <AM0PR04MB448134507B4F957C06F1315A881A0@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200213054344.GM11096@dragon>
> Subject: Re: [RFC 1/4] ARM: imx: use device_initcall for imx_soc_device_init
>
> On Fri, Jan 17, 2020 at 08:15:54AM +0000, Peng Fan wrote:
> > > > Subject: [RFC 1/4] ARM: imx: use device_initcall for
> > > > imx_soc_device_init
> > > >
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > This is preparation to move imx_soc_device_init to
> > > > drivers/soc/imx/
> > > >
> > > > There is no reason to must put dt devices under /sys/devices/soc0,
> > > > they could also be under /sys/devices/platform, so we could pass
> > > > NULL as parent when calling of_platform_default_populate.
> > > >
> > >
> > > This change will impact various internal test case & userspace lib, I think.
> > > Need to ask test team & other developer to double check the impact.
> >
> > /sys/devices/soc0 is still there, the patchset only moves the platform
> > devices which under /sys/devices/soc0 to /sys/devices/platform
>
> Jacky's concern still stands, as there are many user spaces which will be
> broken and need update.
The soc device itself still under /sys/devices/soc0, the soc_id/revision still there.
It is just the platform devices moved to /sys/devices/platform.
When I confirm with Jacky before, his concern is soc_id/revision will be
moved. But this is not true, they are still there as before.
>
> > In this way, we aligned with ARM64. And simplify arch code by moving
> > the code to drivers/soc/imx. In future, considering more cleanup, we
> > could merge the code to soc-imx8.c, since they share similar silicon
> > rev ocotp logic.
>
> Though this is a good thing from maintenance point of view, we do not want
> to break user spaces.
Actually not break user spaces, since this is RFC, I not expect this be merged.
If you agree, I could post normal V1 patchset.
Thanks,
Peng.
>
> Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-13 5:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 9:36 [RFC 0/4] ARM: imx: move cpu code to drivers/soc/imx Peng Fan
2020-01-16 9:36 ` [RFC 1/4] ARM: imx: use device_initcall for imx_soc_device_init Peng Fan
2020-01-17 2:04 ` Jacky Bai
2020-01-17 8:15 ` Peng Fan
2020-02-13 5:43 ` Shawn Guo
2020-02-13 5:47 ` Peng Fan [this message]
2020-02-13 5:55 ` Shawn Guo
2020-01-16 9:36 ` [RFC 2/4] ARM: imx: cpu: drop dead code Peng Fan
2020-01-16 9:36 ` [RFC 3/4] ARM: imx: move cpu definitions into a header Peng Fan
2020-01-16 9:37 ` [RFC 4/4] soc: imx: move cpu code to drivers/soc/imx Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB448134507B4F957C06F1315A881A0@AM0PR04MB4481.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=allison@lohutok.net \
--cc=anson.huang@nxp.com \
--cc=ard.biesheuvel@linaro.org \
--cc=festevam@gmail.com \
--cc=git@andred.net \
--cc=info@metux.net \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).