From: Anson Huang <anson.huang@nxp.com>
To: Aisheng Dong <aisheng.dong@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
Peng Fan <peng.fan@nxp.com>, "arnd@arndb.de" <arnd@arndb.de>,
Leonard Crestez <leonard.crestez@nxp.com>,
"krzk@kernel.org" <krzk@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH] soc: imx-scu: Support module build
Date: Wed, 17 Jun 2020 08:00:33 +0000 [thread overview]
Message-ID: <AM6PR0402MB3911B852B49E194E5FE84505F59A0@AM6PR0402MB3911.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <AM6PR04MB49667E1B41DC2A77B3E2FEBF809A0@AM6PR04MB4966.eurprd04.prod.outlook.com>
> Subject: RE: [PATCH] soc: imx-scu: Support module build
>
> > From: Anson Huang <Anson.Huang@nxp.com>
> > Sent: Wednesday, June 17, 2020 12:54 PM
> >
> > Change the configuration type to tristate, add module description,
> > author and license to support module build.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > drivers/soc/imx/Kconfig | 2 +-
> > drivers/soc/imx/soc-imx-scu.c | 5 +++++
> > 2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig index
> > d515d2c..c255acb 100644
> > --- a/drivers/soc/imx/Kconfig
> > +++ b/drivers/soc/imx/Kconfig
> > @@ -9,7 +9,7 @@ config IMX_GPCV2_PM_DOMAINS
> > default y if SOC_IMX7D
> >
> > config IMX_SCU_SOC
> > - bool "i.MX System Controller Unit SoC info support"
> > + tristate "i.MX System Controller Unit SoC info support"
> > depends on IMX_SCU
> > select SOC_BUS
> > help
> > diff --git a/drivers/soc/imx/soc-imx-scu.c
> > b/drivers/soc/imx/soc-imx-scu.c index 20d37ea..bdd43ed 100644
> > --- a/drivers/soc/imx/soc-imx-scu.c
> > +++ b/drivers/soc/imx/soc-imx-scu.c
> > @@ -5,6 +5,7 @@
> >
> > #include <dt-bindings/firmware/imx/rsrc.h> #include
> > <linux/firmware/imx/sci.h>
> > +#include <linux/module.h>
> > #include <linux/slab.h>
> > #include <linux/sys_soc.h>
> > #include <linux/platform_device.h>
> > @@ -185,3 +186,7 @@ static int __init imx_scu_soc_init(void)
> > return PTR_ERR_OR_ZERO(pdev);
> > }
> > device_initcall(imx_scu_soc_init);
> > +
> > +MODULE_AUTHOR("Anson Huang <anson.huang@nxp.com>");
> > +MODULE_DESCRIPTION("NXP i.MX SCU SoC driver");
> MODULE_LICENSE("GPL
> > +v2");
>
> I'm ok with the change. But I'm curious how can this module be autoloaded
> without MODULE_DEVICE_TABLE.
> Have you tested if it can work?
>
I ONLY tested the manual insmod, if want to support auto load, may need some more
change, will try it later and send out a V2 if needed.
Anson
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-17 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 4:53 [PATCH] soc: imx-scu: Support module build Anson Huang
2020-06-17 7:57 ` Aisheng Dong
2020-06-17 8:00 ` Anson Huang [this message]
2020-06-17 9:41 ` Anson Huang
2020-06-18 7:20 ` Arnd Bergmann
2020-06-19 6:20 ` Aisheng Dong
2020-06-19 7:39 ` Anson Huang
2020-06-19 12:09 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR0402MB3911B852B49E194E5FE84505F59A0@AM6PR0402MB3911.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).