From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F426C433DB for ; Fri, 19 Mar 2021 04:27:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78EBF64EF2 for ; Fri, 19 Mar 2021 04:27:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78EBF64EF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QVqhdFbvFrqGlCznGXrb0YwF3xhUSq9MhsABm62P+ic=; b=QE6Ok0DPj6nMvpHKof2mTkrdF nMfADm8vViAOsXUNpJ8SyxkMtljfyMh+5CI+bQsUGzW1navNkBIFAf9QLSqc9geU++6bNI5UQ/ke7 1PTH0GVc8B2OoEkCZOPpSUfJzIt+yp3+4eW25Qm0ujtootkGtXOHee6rbvYWxRhb+doFfaV1TJXiV tbbumegPUr2RGexbGQhR3xoH2u22StyBf7xmP33ME5E/JQjtbvfuD94o9YaGIktCPcq4fzewBHs+n lL6ucMVECtN/vZKEQbsLq356j42p4MUAlFrtkhS661hDZBQvNlOXh50H0IVduVFGG8MENSMlyTr0h lkXEl8mPw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lN6hy-006Tav-Nv; Fri, 19 Mar 2021 04:25:58 +0000 Received: from mail-eopbgr150080.outbound.protection.outlook.com ([40.107.15.80] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lN6ht-006Ta2-Jl for linux-arm-kernel@lists.infradead.org; Fri, 19 Mar 2021 04:25:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jjwUFerFewnRf1DTQzUbVlA5LkmRksgwRLxmAVX5XfNn8f11DpytpyNS31yfUYT/GPh15S8YPLlJx6IfyS24lX6SoSO742TVW16vCNQlR+QAPSv4Yq+/9ocjXcwc8rrqnfs1sBA7bsZ9MVD2rJIVZmTezlUdyDE4VrOm63AKHzugYlt7CyS+4hyFwfqHUw6cjepo/80LlpusNB9Npkn2CdxM6m7FNG42pgt5CgM98j1zdkYFnxHEbbh9tdMAxZmNSMWuXh8hKOcVoJsvY2xXoL2tMSvc/bhP3x4kfiYCi6tczYEtn9/nwIZKr3pp2zdOlypppWnneoOtxvkoBHwNfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ktTepAU7vxbap7SbPXM1C3OkBEJu6LQPe17SBJmBdRo=; b=VtDMW053shIs9mVUxRrApfh+OIJdxcRKr62esRskCoFkGzxpobiv+YmEJAWtdKCGTBugd7ndCeGM/w0TndtquzKZVHZ+uuJrezNs2vw9Mu2EG9Bthua4gkoyIqqL7xIDWk1w6iid+5jaXJs2nga4ukRuKK02cDeCFf0pLj2gNubEvON+I/FKPL8/k65Uw2PpzoQr70oA/lKfT67qktjyiq00IXcDg2LwNMuIMXJ1QwsKdSKuxoiLRK/G7Dn79E/Yko7CJkdFgDwGezCDLOOxB8po+y73Z+Uetgy+hIq59kfaz4R7jsrKhX67pnaN1rQligqaptvJGNKbv+0kK0svzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ktTepAU7vxbap7SbPXM1C3OkBEJu6LQPe17SBJmBdRo=; b=cEDqmVvsjsp65bjATkVJdRPZbWjDW8LqAdXy7cUxwFZw63RBzAWDYGHbOOg/w0GJvUOL3TyW4cpBrjM0rru1ur/iRMXa0MZTpy/KpX0BvHhKYfIF9ncWtcQKeDJcfWpKdGIkmGH8lnw1OiqVwqJHYN7fZxcRUO029bBJUsqCsE0= Received: from AM6PR04MB4966.eurprd04.prod.outlook.com (2603:10a6:20b:2::14) by AM6PR04MB6519.eurprd04.prod.outlook.com (2603:10a6:20b:fb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Fri, 19 Mar 2021 04:25:50 +0000 Received: from AM6PR04MB4966.eurprd04.prod.outlook.com ([fe80::ecad:ebb8:8eb0:d359]) by AM6PR04MB4966.eurprd04.prod.outlook.com ([fe80::ecad:ebb8:8eb0:d359%7]) with mapi id 15.20.3955.023; Fri, 19 Mar 2021 04:25:44 +0000 From: Aisheng Dong To: Clark Wang , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" CC: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "sumit.semwal@linaro.org" , "christian.koenig@amd.com" , "linux-i2c@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 01/11] i2c: imx-lpi2c: directly retrun ISR when detect a NACK Thread-Topic: [PATCH 01/11] i2c: imx-lpi2c: directly retrun ISR when detect a NACK Thread-Index: AQHXGvpKg3KDixpkSEiRTXuv/sBkJKqKt+IQ Date: Fri, 19 Mar 2021 04:25:44 +0000 Message-ID: References: <20210317065359.3109394-1-xiaoning.wang@nxp.com> <20210317065359.3109394-2-xiaoning.wang@nxp.com> In-Reply-To: <20210317065359.3109394-2-xiaoning.wang@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.67] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 102d5ec6-1f99-4a07-f249-08d8ea8f1035 x-ms-traffictypediagnostic: AM6PR04MB6519: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:741; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fyGTEOYTAlcK8eurKq4kjDBM9rHDVEkHaK/XiAUzdq8oC2qt/VJ7Niy04xzTCjwqnuZPMyyBFR//a5GHnbpqOOgHHxoZbMa1tC0EIXkzVbnN6wVmjFaBe0eeIVYEU7LD6ynGvRIaKhR+xX8AcJPKHOiH/M8fKnuXO/i8OiCRz05CO5sSxTmurRerwcWwESXq0f8FP2kKY0lfF7OzhmUWIAXRkcwN08RQzPB9D4mjkMvxGKnyt/QQgau+uItDV1LlbrU4Ary/Tf001PdgAHLUt25xP4e80bJSL5R5be0y1vsx5GR1puRzdxU4Vc9XAVNsDX20kIFpF/RCBW+XtWJoGJg7sgYMrmsIPSWIBTi2HS7Oa71aQtDk5TxVpVqP/GyIa91YFGk82ShvB2i4PDqRi41V+XUplemIhmMMvRXwQ+fh/viF+0pTAUvzZO7+U24KxXYA0lZON5zKtY9CEt3p4Fgf6dGFI/MHi/B3cu0C94JnhVSL+uIZSHiuH41NeGdPI+GPUqzBV96rqkFMr1alF2VOdanXr7aEzibhaOasAU/2MHmNXLQ0ryic0UMKNxQoUIuOI5nIjGZ4FTrYbfrH/H92LHioslHqKzAd7CfMByk3QOSgkR0QLCZ5rGec715namyKbDem7mfTQsJR/KtFgfkz3zjnXBzdlpvXr2IGKQc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4966.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(396003)(39860400002)(346002)(366004)(71200400001)(86362001)(2906002)(4326008)(8936002)(9686003)(55016002)(8676002)(478600001)(64756008)(44832011)(66446008)(66556008)(186003)(26005)(54906003)(110136005)(38100700001)(316002)(66946007)(33656002)(76116006)(5660300002)(52536014)(7696005)(6506007)(66476007)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?dWhLT0lnOHdQRkFpZnBSY2xLRzZDcVUrdHU0OGdocGwvSEhrYW10Z3FEVlp4?= =?utf-8?B?T0JIUVIwSnRjaTh3TGdWMjJodlZiS3ZiUVRlRUZmTS93Tjd1bCtxZ0V0eTZr?= =?utf-8?B?dWdwWCtTNGVUOFNkcDlEVGpuQi9RblY5TndDV09VMEZSUW9Pa1lUWEZTcHZY?= =?utf-8?B?YmkxTEpFaGM0SGcwYzRYV3hsdnBiM2J5ZHhGMGV4QUdOZ25UcDNJUkdWTHZu?= =?utf-8?B?QTBvSkdNSEhYSGNmTGxtSWhYYU9vbkI4RWxUQ01wNzQ3UWpWQzJ6TzVkVUkv?= =?utf-8?B?ZEw0K2lxc09uWUZnek80UnQ0eDBQSGx0Wml1cXlZRFNZVVJWazRkc0xiNk1W?= =?utf-8?B?VGlIMXFQY2k5K2dNM0FNcHZUWWNLYlpiQldJekRTL2pZUjgxN3RoeW9hRmVi?= =?utf-8?B?YWpDbVI0UjBLL3hsR1RrdGhVS0R6MjNNOVY0aFBYMWdlRFJhQlpyZGJXTDN2?= =?utf-8?B?TFh6Z21Zc0R3Y2xTVFVYank2L2p6QjNLVkJIbVUwUmVKSHZLWnRtN2ZuQzl1?= =?utf-8?B?QW9oUjdLYkZydHk4WUVlUktqNkhEeUI3b0ptU2hNTEZUOXV0QXVYaythYU5X?= =?utf-8?B?QWVSS242cUxhcmY5WWxQcXcyVEJjWWVNM3VQdmdlL3RVZHBGTlJPQ05UekEv?= =?utf-8?B?eWNId2JQbURhYWFxMnBFUHh4WGU5aVVkVWk3bmtnMWY2dkFFdEJmVzNmck1V?= =?utf-8?B?dGdSamlWS2JwU2k5bHFSRk5zckdqZzdYNWhXaEVmSy9XNVc3WWo3ZUJBMVZR?= =?utf-8?B?cWtGbGZSelg0SDE0U0hPNnFDZCtXYlRDdjVLbHgyYXhzS1pNakxTQUg1N3l1?= =?utf-8?B?LzV5K2ZXZ1hSMjFtUXBxZHRsVFYyNFYvN1h5TVBNYmh4aHB4SUhVOUJDWHp3?= =?utf-8?B?VmFvNXBOakFIK1hTSjd1SE53ZEN5bmhTQWZFWjM2NXNGMHhZUWUxdndYcVo0?= =?utf-8?B?VGdRK2ZHNWdnMkJmU3U1YmMrU3NUc1pLRFdtaE5HNkRrUVFHVVZnR0V5bTR0?= =?utf-8?B?Z2hjeVhjQlhTVmFjMWpRb1JVNy9IR1piMXYzMzJJay9iK2FCOEV1VXR0Q05t?= =?utf-8?B?eTVkclk5azdxQ0tBOEZJMERPUngrUnNOTDQxTmx1Snh5bUMyV21DazFtYlBP?= =?utf-8?B?OS95YUhmYVYzZ0taRTJrWkhXUDc1V3czSFJDc01vRUdOajNSR0YxUzhucTZL?= =?utf-8?B?aXVScUZnWFVaL0tpVjhGaDRiUkF4eEJOQ3Z3ZFppMGI5OWJsSk5kbk9EOWJt?= =?utf-8?B?eWxvc2U5dUlhcVZicGlxY2xuQ3J1bkZFcDlNQ0sxbEkrQ09FSnFsN1E5TzF3?= =?utf-8?B?Y3BHSDBSc2FQNFVmVVdYR0dXTzJDUFJlQnRJMytkSUhkQld4VHVXYVRuZmE2?= =?utf-8?B?ZEJJaFQxQ0g3MG43aHNvRSsrZjNoSmd2TnBMLzg1N1I3Wm9xMG5XL1pEZ3Ju?= =?utf-8?B?WVV6dFBVLzlCUWl1dlJXQldoa1BnM0VFUzc5NHFKRUZJSStFR0tqOE1QekF0?= =?utf-8?B?d0Mrakx2WWVMMllHUGV1UTV1aCt2WHhNVUw1MjFjL2pDaGRTU3N6RlVnbjZP?= =?utf-8?B?VU5CTmZKaTZkckRRODFEbThCMkNFWlByQ1NLc29TTXQrcHpMeHovU1pSV25a?= =?utf-8?B?Z0VYemRtUmFRUVlLMDJzWExXRUJITWhNbjhkMGVnV09yZzdheFFYYW0yanBu?= =?utf-8?B?YndBZEZXVS9xNnFjQ3lmaW5BNlgyNG1sVVVRenA3eWg4ZkUxRlhNWTlVbXlj?= =?utf-8?Q?cEeeNXR7cuHcpIFc+8Jji+FO//Qmqd+ipbx+wR8?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4966.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 102d5ec6-1f99-4a07-f249-08d8ea8f1035 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2021 04:25:44.4162 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SPpL839eGV+gSi/a/ARtpzFTojZ7LM1IMScQNM7+zi1VKVLmm3ZZ/4Gf/5HSaYCUhSal8pkRKauwTxX7htRPsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6519 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210319_042553_699395_D4CC058C X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > From: Clark Wang > Sent: Wednesday, March 17, 2021 2:54 PM > > A NACK flag in ISR means i2c bus error. In such codition, there is no need to do > read/write operation. It's better to return ISR directly and then stop i2c > transfer. > > Signed-off-by: Gao Pan > Signed-off-by: Clark Wang Reviewed-by: Dong Aisheng Regards Aisheng > --- > drivers/i2c/busses/i2c-imx-lpi2c.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c > b/drivers/i2c/busses/i2c-imx-lpi2c.c > index 9db6ccded5e9..bbf44ac95021 100644 > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c > @@ -507,15 +507,17 @@ static irqreturn_t lpi2c_imx_isr(int irq, void *dev_id) > lpi2c_imx_intctrl(lpi2c_imx, 0); > temp = readl(lpi2c_imx->base + LPI2C_MSR); > > + if (temp & MSR_NDF) { > + complete(&lpi2c_imx->complete); > + goto ret; > + } > + > if (temp & MSR_RDF) > lpi2c_imx_read_rxfifo(lpi2c_imx); > - > - if (temp & MSR_TDF) > + else if (temp & MSR_TDF) > lpi2c_imx_write_txfifo(lpi2c_imx); > > - if (temp & MSR_NDF) > - complete(&lpi2c_imx->complete); > - > +ret: > return IRQ_HANDLED; > } > > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel