linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Aisheng Dong <aisheng.dong@nxp.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"dongas86@gmail.com" <dongas86@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
	"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	Abel Vesa <abel.vesa@nxp.com>
Subject: RE: [PATCH 2/2] devfreq: imx8m-ddrc: de-select DEVFREQ_GOV_SIMPLE_ONDEMAND
Date: Fri, 21 May 2021 03:04:48 +0000	[thread overview]
Message-ID: <AM6PR04MB4966B0755DA727E1B477C25780299@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <a6f61bf1-b1c3-692a-608c-fe5486a77e52@samsung.com>

> From: Chanwoo Choi <cw00.choi@samsung.com>
> Sent: Thursday, May 20, 2021 11:10 AM
> 
> On 5/19/21 4:05 PM, Dong Aisheng wrote:
> > The driver can't support simple ondemand governor due to missing
> > .get_dev_status() capability.
> >
> > Cc: Chanwoo Choi <cw00.choi@samsung.com>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> >  drivers/devfreq/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index
> > 20373a893b44..e87d01c0b76a 100644
> > --- a/drivers/devfreq/Kconfig
> > +++ b/drivers/devfreq/Kconfig
> > @@ -103,7 +103,6 @@ config ARM_IMX8M_DDRC_DEVFREQ
> >  	tristate "i.MX8M DDRC DEVFREQ Driver"
> >  	depends on (ARCH_MXC && HAVE_ARM_SMCCC) || \
> >  		(COMPILE_TEST && HAVE_ARM_SMCCC)
> > -	select DEVFREQ_GOV_SIMPLE_ONDEMAND
> >  	select DEVFREQ_GOV_USERSPACE
> >  	help
> >  	  This adds the DEVFREQ driver for the i.MX8M DDR Controller. It
> > allows
> >
> 
> Looks good to me. But, How about changing the patch title as following?
> - PM / devfreq: imx8m-ddrc: Remove DEVFREQ_GOV_SIMPLE_ONDEMAND
> dependency

Yes, good suggestion. Thanks
I will resend v2.

Regards
Aisheng

> 
> 
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-21  3:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210519070646epcas1p278827601f2ce81e96e088f8fcac31d32@epcas1p2.samsung.com>
2021-05-19  7:05 ` [PATCH 1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status Dong Aisheng
2021-05-19  7:05   ` [PATCH 2/2] devfreq: imx8m-ddrc: de-select DEVFREQ_GOV_SIMPLE_ONDEMAND Dong Aisheng
2021-05-20  3:10     ` Chanwoo Choi
2021-05-21  3:04       ` Aisheng Dong [this message]
2021-05-20  2:51   ` [PATCH 1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR04MB4966B0755DA727E1B477C25780299@AM6PR04MB4966.eurprd04.prod.outlook.com \
    --to=aisheng.dong@nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=cw00.choi@samsung.com \
    --cc=dongas86@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).