From: Aisheng Dong <aisheng.dong@nxp.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Peng Fan <peng.fan@nxp.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
Abel Vesa <abel.vesa@nxp.com>, Anson Huang <anson.huang@nxp.com>,
"yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"allison@lohutok.net" <allison@lohutok.net>,
dl-linux-imx <linux-imx@nxp.com>,
Stefan Agner <stefan.agner@toradex.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
Daniel Baluta <daniel.baluta@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Andy Duan <fugang.duan@nxp.com>, Stephen Boyd <sboyd@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"info@metux.net" <info@metux.net>
Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module
Date: Wed, 24 Jun 2020 09:18:29 +0000 [thread overview]
Message-ID: <AM6PR04MB4966D2D5DBA5DEB0E0DEA51380950@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAK8P3a21gJg-iVNupx94WZjcpNtHPLJhDM_Uh7E_4yGjSH_pJg@mail.gmail.com>
> From: Arnd Bergmann <arnd@arndb.de>
> Sent: Wednesday, June 24, 2020 3:47 PM
>
> On Wed, Jun 24, 2020 at 4:19 AM Aisheng Dong <aisheng.dong@nxp.com>
> wrote:
> > > Isn't that what we want?
> >
> > No, if user set MXC_CLK to m, the build will break for i.MX6&7.
> >
> > > Why does ARCH_MXC being enabled mandate that it is builtin? Is some
> > > architecture level code calling into the clk driver?
> >
> >
> > It's mainly because there's no Kconfig options for i.MX6 &7 clock drivers.
> > It just reuses ARCH config CONFIG_SOC_XXX which can only be y.
> > e.g.
> > obj-$(CONFIG_SOC_IMX6Q) += clk-imx6q.o
> > obj-$(CONFIG_SOC_IMX6SL) += clk-imx6sl.o
> > obj-$(CONFIG_SOC_IMX7ULP) += clk-imx7ulp.o
> > obj-$(CONFIG_SOC_VF610) += clk-vf610.o ..
> >
> > If setting MXC_CLK to m, the platform clock drivers will fail to build
> > due to miss to find symbols defined in the common clock library by
> CONFIG_MXC_CLK.
> > So we have to avoid users to be able to config MXC_CLK to m for i.MX6&7.
> > Only depends on ARCH_MXC mean user still can set it to m.
>
> The link error can be easily avoided by building all the clk support into a single
> loadable module like below.
>
> Hower this only works if all drivers that have a runtime dependency on the clk
> driver support deferred probing or are built as loadable modules as well and get
> loaded after the clk driver.
>
Thanks for the info.
Currently all i.MX6&7/VF clocks driver are not loadable modules (they're using CLK_OF_DECLARE),
so can't be built as m.
If we really want to build i.MX common clock libraries into module, I guess the easiest way
Is as what Patch [2/9] does, select it by ARCH_MXC.
Then users have no chance to build it as module, so no build issues.
Regards
Aisheng
> Arnd
>
> 8<---
> diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile index
> 928f874c73d2..638bc00f5731 100644
> --- a/drivers/clk/imx/Makefile
> +++ b/drivers/clk/imx/Makefile
> @@ -1,6 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0
>
> -obj-$(CONFIG_MXC_CLK) += \
> +obj-$(CONFIG_MXC_CLK) := clk-imx.ko
> +
> +clk-imx-y += \
> clk.o \
> clk-busy.o \
> clk-composite-8m.o \
> @@ -25,24 +27,24 @@ obj-$(CONFIG_MXC_CLK_SCU) += \
> clk-scu.o \
> clk-lpcg-scu.o
>
> -obj-$(CONFIG_CLK_IMX8MM) += clk-imx8mm.o
> -obj-$(CONFIG_CLK_IMX8MN) += clk-imx8mn.o
> -obj-$(CONFIG_CLK_IMX8MP) += clk-imx8mp.o
> -obj-$(CONFIG_CLK_IMX8MQ) += clk-imx8mq.o
> -obj-$(CONFIG_CLK_IMX8QXP) += clk-imx8qxp.o clk-imx8qxp-lpcg.o
> +clk-imx-$(CONFIG_CLK_IMX8MM) += clk-imx8mm.o
> +clk-imx-$(CONFIG_CLK_IMX8MN) += clk-imx8mn.o
> +clk-imx-$(CONFIG_CLK_IMX8MP) += clk-imx8mp.o
> +clk-imx-$(CONFIG_CLK_IMX8MQ) += clk-imx8mq.o
> +clk-imx-$(CONFIG_CLK_IMX8QXP) += clk-imx8qxp.o clk-imx8qxp-lpcg.o
>
> -obj-$(CONFIG_SOC_IMX1) += clk-imx1.o
> -obj-$(CONFIG_SOC_IMX21) += clk-imx21.o
> -obj-$(CONFIG_SOC_IMX25) += clk-imx25.o
> -obj-$(CONFIG_SOC_IMX27) += clk-imx27.o
> -obj-$(CONFIG_SOC_IMX31) += clk-imx31.o
> -obj-$(CONFIG_SOC_IMX35) += clk-imx35.o
> -obj-$(CONFIG_SOC_IMX5) += clk-imx5.o
> -obj-$(CONFIG_SOC_IMX6Q) += clk-imx6q.o
> -obj-$(CONFIG_SOC_IMX6SL) += clk-imx6sl.o
> -obj-$(CONFIG_SOC_IMX6SLL) += clk-imx6sll.o
> -obj-$(CONFIG_SOC_IMX6SX) += clk-imx6sx.o
> -obj-$(CONFIG_SOC_IMX6UL) += clk-imx6ul.o
> -obj-$(CONFIG_SOC_IMX7D) += clk-imx7d.o
> -obj-$(CONFIG_SOC_IMX7ULP) += clk-imx7ulp.o
> -obj-$(CONFIG_SOC_VF610) += clk-vf610.o
> +clk-imx-$(CONFIG_SOC_IMX1) += clk-imx1.o
> +clk-imx-$(CONFIG_SOC_IMX21) += clk-imx21.o
> +clk-imx-$(CONFIG_SOC_IMX25) += clk-imx25.o
> +clk-imx-$(CONFIG_SOC_IMX27) += clk-imx27.o
> +clk-imx-$(CONFIG_SOC_IMX31) += clk-imx31.o
> +clk-imx-$(CONFIG_SOC_IMX35) += clk-imx35.o
> +clk-imx-$(CONFIG_SOC_IMX5) += clk-imx5.o
> +clk-imx-$(CONFIG_SOC_IMX6Q) += clk-imx6q.o
> +clk-imx-$(CONFIG_SOC_IMX6SL) += clk-imx6sl.o
> +clk-imx-$(CONFIG_SOC_IMX6SLL) += clk-imx6sll.o
> +clk-imx-$(CONFIG_SOC_IMX6SX) += clk-imx6sx.o
> +clk-imx-$(CONFIG_SOC_IMX6UL) += clk-imx6ul.o
> +clk-imx-$(CONFIG_SOC_IMX7D) += clk-imx7d.o
> +clk-imx-$(CONFIG_SOC_IMX7ULP) += clk-imx7ulp.o
> +clk-imx-$(CONFIG_SOC_VF610) += clk-vf610.o
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-24 9:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 7:32 [PATCH V2 0/9] Support building i.MX8 SoCs clock driver as module Anson Huang
2020-06-09 7:32 ` [PATCH V2 1/9] clk: composite: Export clk_hw_register_composite() Anson Huang
2020-06-17 10:10 ` Aisheng Dong
2020-06-17 12:31 ` Anson Huang
2020-06-18 2:05 ` Aisheng Dong
2020-06-20 3:22 ` Stephen Boyd
2020-06-09 7:32 ` [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC Anson Huang
2020-06-17 10:34 ` Aisheng Dong
2020-06-17 12:36 ` Anson Huang
2020-06-18 3:09 ` Aisheng Dong
2020-06-18 3:18 ` Anson Huang
2020-06-18 3:58 ` Aisheng Dong
2020-06-09 7:32 ` [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module Anson Huang
2020-06-17 10:44 ` Aisheng Dong
2020-06-17 12:26 ` Anson Huang
2020-06-18 1:58 ` Aisheng Dong
2020-06-20 3:27 ` Stephen Boyd
[not found] ` <AM6PR04MB496690A045E0BFFF3D03AE0380940@AM6PR04MB4966.eurprd04.prod.outlook.com>
[not found] ` <159290125202.62212.13172213909023205615@swboyd.mtv.corp.google.com>
[not found] ` <AM6PR04MB49664A8400CA0B0F7321EDDE80940@AM6PR04MB4966.eurprd04.prod.outlook.com>
2020-06-24 0:57 ` Stephen Boyd
2020-06-24 2:19 ` Aisheng Dong
2020-06-24 2:36 ` Anson Huang
2020-06-24 2:59 ` Aisheng Dong
2020-06-24 22:43 ` Stephen Boyd
2020-06-29 7:04 ` Dong Aisheng
2020-06-29 8:19 ` Arnd Bergmann
2020-06-29 21:05 ` Stephen Boyd
2020-07-02 6:15 ` Anson Huang
2020-06-30 3:01 ` Aisheng Dong
2020-06-30 4:41 ` Anson Huang
2020-06-24 7:46 ` Arnd Bergmann
2020-06-24 9:18 ` Aisheng Dong [this message]
2020-06-09 7:32 ` [PATCH V2 4/9] clk: imx: Support building i.MX common " Anson Huang
2020-06-09 7:32 ` [PATCH V2 5/9] clk: imx8mm: Support module build Anson Huang
2020-06-09 7:32 ` [PATCH V2 6/9] clk: imx8mn: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 7/9] clk: imx8mp: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 8/9] clk: imx8mq: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 9/9] clk: imx8qxp: " Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB4966D2D5DBA5DEB0E0DEA51380950@AM6PR04MB4966.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=allison@lohutok.net \
--cc=anson.huang@nxp.com \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=shawnguo@kernel.org \
--cc=stefan.agner@toradex.com \
--cc=tglx@linutronix.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).