From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF9FC433ED for ; Fri, 21 May 2021 06:19:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E92746108B for ; Fri, 21 May 2021 06:19:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E92746108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XT2Cn4+3UhDHuP501OlAIALrlVaovLVQ3hkNaQxPTmE=; b=VQz4siuZYJWgHEeCeV/TkxVwi5 vmHrMHbbYmHMGCXGcRvv2O36f4QcwgfReQl9oifkSe7RAjy8R8TeihjIdc3eLrMFFK2gngNNTvi7t aXoFL/QvpubOtkHwuhEZzVX90hnxX+5p7eW1FHhg/8GkFzw/BTvUXmihjDE/+14D8vG4SlrHo86Uy mVqfMtXOSsTAx7ghJ9eumNlvi3Q9iZOIWOFo2JwGYGTGWZecdC/QCo9WjqjqANZ7uNo5FQPdlrQBp PQsW+dpC/zuk0CK2+rLd67Spa2NHozrXVs1c5OUKREfvcRhAFcFyV2+VPxWIxIUvO+X/3rc6CBof2 4mXHpAqQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljyU5-003xer-KT; Fri, 21 May 2021 06:18:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljyTz-003xdy-FL for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 06:18:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=2xOXkn81lpzBY4pUl+Ur44tSfw0c6XWK/cspDhhJL0A=; b=RVqHX5zo1BEl5L0d/kv3qcf3WR Abpw0hIPWf/leFH6Ig/gjpaw7tU8hFqj7x6SnwTiv7oUK0t66gbypw5VyAX4lfgwG2nrR49L9DOZ3 f/WUaJMGt/hVXktdkgwSJ5iXdMwWepoPVduLHEY2rcRN19gwsAm6cbZYQ0TGfNw6OLSfEGsDrIxTJ j0zkTrMgtCb2L3H41W08nZtQRmf6dZJCW+inRol4y8jo6qBdO5xaZX4Yb8MPFq7yvVU/eHd1ASM4B zuu6jJmIk229hnDOpw/DzoeI3LDPfFPHsV27JvYwU+WWGosZwGKl4VEHtdRh3ynZ2337qMdFvVZrz Of9B3+tA==; Received: from mail-eopbgr80075.outbound.protection.outlook.com ([40.107.8.75] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljyTw-00Grgp-Mq for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 06:18:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G5uqWx4HolWTSc5wQvkH10dxIXlYmPsAGdqebioSM3dbObSW1Q/CuS6YkoAmiT3w/GSPvtdicMLwN9kU0W52kjeH8yJyA0GOD4ROjSX79ZmlJzMEUo+5tXiFqACws1q3P3PI5kvIeOdKAtRrLC5hiO9JTRkKgOE1zUJY/kr17K+O91Ffk06nJ0ZG0vwSPMtkoGwsuxrIto8MGqB21PJHahu8SYIDn8LJy8S/ia+D7S4q8pdqyihN/H15HC0Mw1gxENylvHpEBxww99l2KIZD9PPDz1e9K4UmD2eEF8Nwnoj5c6KcmNoJHsIT5Fxll1oHQpfrriY6pcq7ttTkSsuHsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xOXkn81lpzBY4pUl+Ur44tSfw0c6XWK/cspDhhJL0A=; b=WpCMOtWjfM0LlFU3WA5FCGyD18wl9dp93eInnQ/UVxGPIwFa61lmwqiWzF2pnq16+0GKBXTGeYLucuQ9bYww+MPYiPy3pGl1TRUbZuD487BfLKtbYv3AAg40bLzNQ4ag6gtkeI3OLhCz3pH3pDOmDktQTVoNp1qR+1qmSHFrUZrQOULrsjK2CK0e4ywVeLrryX4LIuz365lxsODyzMBMZDloosoi7uMGWh/y7iFsFs+Y8fu03GPE36rFtGwV0fQJSIj6yLvk7wLzpszqckz8osvcsttwZHWQc/W7g08Y9+hcOgkko6ej0ieJ6VFbkqsM0ZpGWNsJsxzRQPgi7wg3/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xOXkn81lpzBY4pUl+Ur44tSfw0c6XWK/cspDhhJL0A=; b=NR7Rhvf1ZYvnSAceXlGRze54Aqjrn57DqBIXUTARKvj+OmxbAudDmO9NcvVoWrw0+c2UgejmHuisdHgi1Ek2+v1qoqviDrNBCv9b6lf/HfP0A8l+S3S0EU0yOnRrpdeuOte8IoV0khwkwW7z5q6DnW3PQuTV0jSA8r5nyLmhAIs= Received: from AM6PR04MB4966.eurprd04.prod.outlook.com (2603:10a6:20b:2::14) by AM7PR04MB6870.eurprd04.prod.outlook.com (2603:10a6:20b:107::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23; Fri, 21 May 2021 06:17:57 +0000 Received: from AM6PR04MB4966.eurprd04.prod.outlook.com ([fe80::b10a:ad0:a6f5:db9b]) by AM6PR04MB4966.eurprd04.prod.outlook.com ([fe80::b10a:ad0:a6f5:db9b%2]) with mapi id 15.20.4129.034; Fri, 21 May 2021 06:17:57 +0000 From: Aisheng Dong To: Clark Wang , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" CC: "kernel@pengutronix.de" , dl-linux-imx , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH V2 03/18] ARM: dts: imx7ulp: add the missing lpi2c ipg clock Thread-Topic: [PATCH V2 03/18] ARM: dts: imx7ulp: add the missing lpi2c ipg clock Thread-Index: AQHXKtieYiSeX4oQpkyqDToh9iLvnqrtu25g Date: Fri, 21 May 2021 06:17:57 +0000 Message-ID: References: <20210406113306.2633595-1-xiaoning.wang@nxp.com> <20210406113306.2633595-4-xiaoning.wang@nxp.com> In-Reply-To: <20210406113306.2633595-4-xiaoning.wang@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.67] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49398be6-7f7e-4985-80ff-08d91c202d45 x-ms-traffictypediagnostic: AM7PR04MB6870: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: foBiMUhbjh0JakAfU66sWWb7VX0yQcUs9/hGg154fXNN35exddcvr2QzBKCwJYyBr9hKwfAHwGU9K1heDRIT98WQ/YRcuWYWfA5FuEbOGmk2j2speGgq4L9G9xGdfjiLwOBUbLsSlYUCH81HbUHpmpzZxmgistDLGUinpS0i+CX0CIq4dZAK9EVPNcu9ytpRaxFXpqBhl+scIWud4BNBKa7waNthktMACfxxsujwzLSB0WaTbpVmemMYDHxcR37+Pmb0PAuMuM61aDeVt3V8UW4rDczZWWpBn5o5y+O2QqDVW+Z8UPZxHlx8ppDj+Ims4t4hnhZDLaE9Ad2AZXsQA0KKF+8lZSTOGG+7NvLCuEi/Rogyxidcuu9BbX4nI+tNWueZDMq0b+NvHyNwvr7JGLxUtWGdKm3KJ4I1oHvCxKNUNwB6UaU1tCdZyYBuX4JclqlAhibcN/aIjBJIgJ8sj5PwaVTuT6MpCxqwX37Vgh693oRY+d8ZOvIHr1zxWTNa8oyobJ87+DdXW6JOyP0igH8C5+oDyQnMaO7ku+ZqAYwxfa0b/3rHOmoyFrE+PUqBHzjHzOJEq5noZFrVsFEe459zSHsSIZoq+CAtvGRnjfQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4966.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(346002)(376002)(39860400002)(396003)(66476007)(76116006)(64756008)(55016002)(2906002)(44832011)(71200400001)(186003)(66556008)(66446008)(33656002)(66946007)(8676002)(6506007)(26005)(110136005)(5660300002)(122000001)(9686003)(52536014)(38100700002)(83380400001)(8936002)(478600001)(4326008)(7696005)(316002)(86362001)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?SmZZZ3ZMaXk0L1BzbEV4S1pYVWFOaG0zTWFkTGFIRFlNRjVKNnNYS2tUR2ZH?= =?utf-8?B?SXdGRkR0QTVpMi9UT3FBZEpwYldyTXUxMnYyRVBmN0tBWG9EdmkwTE9XUzls?= =?utf-8?B?Nmx3SnBOVklQVWRGeCszUWhEeTE5MlFhRE5VaFVzNW1iN203VC9WOTQ1MmJH?= =?utf-8?B?RTVqcC91QzJRMGFlQk1LRjFsNkdxMEM4d1daN3kyZ3JiY0k4UjJ2RGZCSTdP?= =?utf-8?B?OWJQczhyeFF0OGlPQXJWSzBTMWVOS2VnaVN4blFxVlhjb2ZtTk5PRW4rd2Vi?= =?utf-8?B?Y3hVekVnYU4xeVlEYUtlUWdndTY2dHhjT2t3cCtKcHBSNUozM0ZCTUpyTXhq?= =?utf-8?B?QXkzNjVQOHZEUUIvWTJ4aTc3LzJZNkxSU0xjWHdIVnZyYUl1UjhwNDdNZU5C?= =?utf-8?B?RkI4MFZQWW10QUNwSFI2alNwUytPeFk4cHJjRmtqNDJUWnZ4Q1Z4VUluU0RE?= =?utf-8?B?anFCRklvM2RDT1dpdXdiYUZYaFJvNDZ0UTZRS3k1NzRNVFZtWHlJN2dudXdR?= =?utf-8?B?b21SaEpTN2UyUG4ydHZKbzlYbTRkb2JDN1d3NWZWWk1qK01VcytsWTBaQmdQ?= =?utf-8?B?S1dMZTF2WnRMWFVIMlE1dm41UHZKWmo0eG9iaUZMVm1mMitkSW9QeUZmcTRk?= =?utf-8?B?K1lNQ21zRnA4ems0YnlVaWRkbHdWdENMYUdVU2gxMW9VWnU4bzhlSFBIbnM2?= =?utf-8?B?ekI1U0pkdjJnTG9kQkFkUEdiZnBIcld1Z3J2SlBLY0Nrb0JBWUtpZG8yeTdT?= =?utf-8?B?MGdSaEZuSVJmTStOdG9wdjFIakR2NEVFOGYzekFKSUp0UGQxK3Y4ODBqNFVM?= =?utf-8?B?L1A5NDNraVNkVVZhb0hEalQ1Mlk4WCtoeWlFYmNBT1pGQ3VMWFhBWG9tcElV?= =?utf-8?B?NGt1bnJwM2o5bWRLd1BEYzc3cUhSN0w2TVhNVU1xZm5RdWVjblN0b3BEVG1l?= =?utf-8?B?U0ZWM1BETXBjNXIxdmtUTFBCWnRyMExlaDgxaDZyeTV2dHdLRWNWZDFpZlRi?= =?utf-8?B?Vy9abXNUMi9WdlYzWTMzTTh5MGlsL2d3eC8xQTdxOENPeGxjcGVBODYyQk1C?= =?utf-8?B?WnFNUWRJczJJVjRLdWpETmFRV2FLZDNPTU9xNFlXSnBWSmdmbTI2SFN5ZUJX?= =?utf-8?B?dVVzZ3AzTWlyQTJOajRzTzFia1gzSlFNUE5SK3ZDeGJJY0V4YjAvS0hQaW85?= =?utf-8?B?Nm1Iem9Zd0pneHNNTmhjZllUS3hEWjVYMFVYdGhPSSttSE5zdTZ0Z25BVk15?= =?utf-8?B?b3JpTnd6VUJrOCt4Q2FFQ09JM3lGR2c0Nm5RZ0lmb0Z5aDc4U3orZUJiZzZY?= =?utf-8?B?ZWV6UFpqQ2dFZHZRR0FPazZxUnhQU1Ivcys1TVA3aFNxak5TR2c2L0Q2cU42?= =?utf-8?B?SVVjMUtsWnlLYzF3QWppaGVtSmM1TFREbTBHZzhuUWRzUGdlTTJhWGNNaEF5?= =?utf-8?B?TTI0UkViQm4yR2Z3eWxkMmhwTUtQRGt3dDhUdWlNUk43NjQ5UTR2L282TVND?= =?utf-8?B?SHl1bzl0NjJLT2lHb0prREhPYmp0QnE1Wk14SUtMSUtyd1NZMjhnOUZoSGEr?= =?utf-8?B?TGthcHhtSHQwMThuNU5yc3VUQ2dpVXY2L1dMK0VmQUhrTkwzS1NVL25ueUVV?= =?utf-8?B?N3ZieG1JamVvYjBHQWt5Nmc3UWZ3TjRudDBZSi9lcWRDa2VXNzZaRWJGOWcx?= =?utf-8?B?SHpqeW9LM09BUTVoLzRPdy9JSVRmSWdKN1lEYkVMUStMNGhqc2RXbFVoN2w2?= =?utf-8?Q?7VcyMH0PeU2Q1/7lUGl7cnfyT0PSAvwARmthJ4e?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4966.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49398be6-7f7e-4985-80ff-08d91c202d45 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2021 06:17:57.2517 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aUvMSJaZePSkPVfKCW5eLkVz1LpLdbIMNmDZ6gxlEx5bKmR3AF9d+Y0j7oU+x5Z2FpCvLt89DO97cGAdCe+kYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6870 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_231800_773343_616FD0C6 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > From: Clark Wang > Sent: Tuesday, April 6, 2021 7:33 PM > > The lpi2c driver has add the missing ipg clock. Pls drop this line as binding is not decided by driver > So add the ipg clock here for all lpi2c nodes. Per clock? Maybe better refined as add the missing per clock .... > > Signed-off-by: Clark Wang > --- > V2 changes: > - New patch added in V2 > --- > arch/arm/boot/dts/imx7ulp.dtsi | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi > index b7ea37ad4e55..eb0d4b8f624d 100644 > --- a/arch/arm/boot/dts/imx7ulp.dtsi > +++ b/arch/arm/boot/dts/imx7ulp.dtsi > @@ -328,8 +328,9 @@ lpi2c6: i2c@40a40000 { > compatible = "fsl,imx7ulp-lpi2c"; > reg = <0x40a40000 0x10000>; > interrupts = ; > - clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>; > - clock-names = "ipg"; > + clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>, > + <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>; > + clock-names = "per", "ipg"; > assigned-clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>; > assigned-clock-parents = <&scg1 IMX7ULP_CLK_FIRC>; > assigned-clock-rates = <48000000>; > @@ -340,8 +341,9 @@ lpi2c7: i2c@40a50000 { > compatible = "fsl,imx7ulp-lpi2c"; > reg = <0x40a50000 0x10000>; > interrupts = ; > - clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>; > - clock-names = "ipg"; > + clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>, > + <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>; > + clock-names = "per", "ipg"; > assigned-clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>; > assigned-clock-parents = <&scg1 IMX7ULP_CLK_FIRC>; > assigned-clock-rates = <48000000>; > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel