From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A71BC433B4 for ; Wed, 7 Apr 2021 01:34:56 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4F6E6124C for ; Wed, 7 Apr 2021 01:34:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4F6E6124C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l/aOv6EiHFdmxTuSGLqV9KvKN8B2t7nhFfYIkwpe0q8=; b=aZkSB7zqLcUmj1xSO+WwbHQ1X TtK9i/HYXmuenVU8pMiM8N5l65vhYtqCB8NmDYAneYVcjuctRKBZ5qw6FRlvvYB1kTsjUX9fl5M3T jq8Z9ZkHXDjg9We0kRX9reaXWG+3oiccGz8r7z+u+vuJ4rCKz8YkBjSa4oIpTXzpzMsGzsPlVQOyJ 5k1LMvGH1/lAwu6h+f+QUuFRgSH9byNAptjJIsqUpdRJ7to7hopYXUsPSewZSrolsPtGTVgVz0zQR gupC2DJ+bl9I31bCLJivBOsZHsC0CFn7ckElMRS3zorNJ2IomRXarXaYUQcUnUaSaWtbw4KWRSKtx 1+i7gpnZA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTx2r-003l9o-G8; Wed, 07 Apr 2021 01:31:49 +0000 Received: from mail-eopbgr10079.outbound.protection.outlook.com ([40.107.1.79] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTx2k-003l7n-DN for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 01:31:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kg7/oovfrzdnR8t18JcAZfAefPkwUcmPbCNzfHKD9c9/MDGwf6Crrak78qCfYOF6iXthC3PKt+OhEEwig1lnhTtMhhrK6U54npgU3C/XFJy5McuALxEnbDiYu7wdrCZIVQO0sT6qNPo+Pvv38mm6VsmkZwRhwvkCA0NhGSijqMkms1CXUwR0ZXGOcF5vZY6lISLXY+tt3F6zEjnGrHQZTm5JZRsA9b8ad2pE31Jupwv3Z5ngxmv3QFAqdNz5QPvqPyvYs6uP9XUvMAy0HYnNNvw3SxoML0EWRYCOgWWIphTn48TKyW91QzkMXMZRasLRqv4b0v1f8VuyqZFUOUa6wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5oJ+YRavceubpdba8/eD8i9CW5rpk51o1RrzM579DfM=; b=ToF5kpBKYdM9b3hjqDIBOiPX54xRuc/xP4S0e5exkdXylIGPBdWqjTKj6fz+J/GbBdxm7yRle/4xl6wDNPt75fg1Nle2vpWW1VucSUztYtww3yRFlcRyL6o3xZo3+QY//H2so/FMN4Lg90d4VYvuSehD3PeAj14RNhi0vN733NLyFMCGEL6clnlm26u0zIVBUJPdL46aTNSaBahc9V5dgqOykdDvjFKqWUuNGl3pARPll9suEf0w130SVkA5AMinTNao6k4hwm2/j+u2T+CBODncvhP6JWFQ9AGL2zIzM3Y8a6rmTq1d3auZ3ASkYrst7s0JnGQ9n14nLdnVI7fswQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5oJ+YRavceubpdba8/eD8i9CW5rpk51o1RrzM579DfM=; b=TCxt5FBwwB/i/YYM1LuRAhAqG9WeKxDvXcoazQZoIQG9G0O/BSFerj5MWdpghse19+sY7gQ+b84bM+Za8wOz3rn+s16XkymYqK4ssrCoR2BEbN/8EpXmtNlu1NTAkvP+aPzRC7Ic5AV41+4b+tr0wUYcdgHmFnT5X2Z9q+pOp9U= Received: from AM6PR04MB5413.eurprd04.prod.outlook.com (2603:10a6:20b:96::28) by AM5PR0402MB2787.eurprd04.prod.outlook.com (2603:10a6:203:a2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Wed, 7 Apr 2021 01:31:38 +0000 Received: from AM6PR04MB5413.eurprd04.prod.outlook.com ([fe80::2c18:5961:ebca:dfaa]) by AM6PR04MB5413.eurprd04.prod.outlook.com ([fe80::2c18:5961:ebca:dfaa%2]) with mapi id 15.20.3999.032; Wed, 7 Apr 2021 01:31:38 +0000 From: Ran Wang To: Leo Li CC: Christophe Leroy , linuxppc-dev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , lkml Subject: RE: [PATCH v6] soc: fsl: enable acpi support in RCPM driver Thread-Topic: [PATCH v6] soc: fsl: enable acpi support in RCPM driver Thread-Index: AQHXFxzh8ouwdY1weE2tXT45hbmJ7aqoLhiAgAA4tzA= Date: Wed, 7 Apr 2021 01:31:38 +0000 Message-ID: References: <20210312085822.12136-1-ran.wang_1@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d13f1280-8415-4a24-e72c-08d8f964e3b4 x-ms-traffictypediagnostic: AM5PR0402MB2787: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:901; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FqGSGTkxHSttpLMsoFNGk5WgVyOQhC05AW16dOYJoGfeokoyhEBz65QcSjDNcRWzIY0mTzTE0HpmMjKghVEqRJ76PG+wFJnP0I2RsaXq7P3Xhzl/1O17gCGP7ANCbumIkn07un0/51Zf83ucg6EybuApQgxqCkMsvEhp3eovLyeO5kKjADG89YokJPq1sinuPlBmWlsX2kiQ6AodhI9cMYRsINsy5y2DEY+5oWCOuBEBnDkFybZkvKoQjrZzgTk0mqd+sfVhN8D8w2uN+4O8qT1hgFtjmdIVnz5S+nYWhPZX003VxkUyza0s/1m3XDbDzj2Tf6N2WVhvfXqdaQbfx7lxLQznbacNMhA2UK8FAO0ReevSskOhis4tWwlccF28vcc2OT9SmIJ0ex89uvPJ/qjJlBLNIQFgqernPJN02k+Q+NwhheY+wD3PHSh76wADydlk7q1xshgXNrPbPNQWWVCSH/jhG+unhSNZ2euq1DcjigQcGafY8n+JaSUjaxE6FrigSEuACy0RthJjPpoEGrthfQiqVOpLRrzt4AmAc9K5nM3Vcl1+kmZWlPfxVrALeSd6mwN+FH+OW53zAulmzw5yFinQURhIalyr6yBjCHD1yHarYOHTbbXxagwPgAPpQzQWWQawTXz5ZsAqU1z0SvNVg4kwolkMrqGmLmW/eiY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB5413.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(376002)(366004)(396003)(346002)(136003)(9686003)(26005)(55016002)(86362001)(38100700001)(8676002)(478600001)(316002)(6636002)(186003)(6862004)(66446008)(71200400001)(54906003)(83380400001)(66556008)(64756008)(76116006)(5660300002)(8936002)(66476007)(52536014)(6506007)(53546011)(66946007)(4326008)(2906002)(7696005)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?VkhpRmRWMkFuZjRtTFRjU3BTVm9pVU1heXlpeU5aQnpOMTdDbktSUjNwR290?= =?utf-8?B?cEJ5ZTFQZURXcm9hM0lvVy8wTm1kMHk5RFVvckpPc3d1MlFyUGRuM2wyT3FP?= =?utf-8?B?WE1qaVRxSVVDM2R5dXdQSDM4amxLYUlzT0lDS3hFSFlCSExZelpBejFIRk1z?= =?utf-8?B?WTR4d3dGaGN6eEZBZk9oY1ZURnJFU0RCRHM2cmVWdkJxQXZibERpdzdtUXhT?= =?utf-8?B?bUt2N0JaNXN4eFlva2phZnNweWJZMGNoZldzT3B0UkFrUC9IUlIwaEgzSzhv?= =?utf-8?B?cUQ0cVd1Y2xudFFGZnhEa3FHSFFwdmpwV3NxY1U4OTFWaFNtQlVUSnN6UVd0?= =?utf-8?B?Z3IrcjRSMlJSbndlcy9zVjNpdnplU1JnMmJrOVFZeEpwVzljWU9xY2hHL1lS?= =?utf-8?B?ZmxmSm02Tk4wRm1BMk5rK1RoQStUcnIycEhSZzJ1eDZaTWFpN2c2Z3pFd0ZR?= =?utf-8?B?NVdJTm9XdUdwU2FXQk9rSjFKRTRLV25Na0FmdnkyUUIyelNiNmVXRjJVNHZv?= =?utf-8?B?aVVxK2RIODUybDJDVWtLYzJYQUQ2Q21hd3k5c0NxdlJEM2EvTjRuaHFxZ2dH?= =?utf-8?B?L0hNQWZWT3dXdis3Z0tobHp3NmxvNzdZN3kvQTNDYytCamc0NUMwRHJtUE5T?= =?utf-8?B?NVVpaGJTRzgxdXpUZU9QQ0o1RVV2eGl5eWZUNlM2Y3JsTEtxeUlINTVyWXhV?= =?utf-8?B?WXBNMG9uMU1mZXpsa295M0tsY0tBODMvQXZXd2tMM3hBUFJmOFJLVngwd0FK?= =?utf-8?B?aDk0R0orNDVMdlhXQ2lwTVBhQlFsY21wTE9qQ1loejc1K3VMcURNZWM2K3Y1?= =?utf-8?B?K3NQZ0F3K3dUaFB2aWVDYitKejg0ZkhJWTVrRzRIWTFFMkZXTFdSMHpKUGVU?= =?utf-8?B?b0laaUJmM1ZwTEpSSG52SWZVdGRXMm5wKzlnT1ZJb1hLQ2poaVRrNkt1WUJJ?= =?utf-8?B?SHZkZGx1QTNVVXpJM2JRRW9WejFjYlZWRjRqN05mUDEvVFJZNGxleHNNZmpI?= =?utf-8?B?TFYyL080TkN6SEdFZXI3UTVsaGgzNWJoUWYxY1BaSGJHdXV4Uk5ZL21ndVdM?= =?utf-8?B?UW1wR2lHaSt2U0VCc0oxZDdFT3ZKbXg2c3JydXdhS3ZDVDBXdUlXQkV6dGs4?= =?utf-8?B?Mmd0QnFXRzhHWHRwNU9Tc3YwMlBEOXNyYWJsNTFWc1JkTTZTcU9BZS9waHZC?= =?utf-8?B?T3dGSys1OGVZQ1oyNTJGRFBjZG45cHkzNm9mdWtNWDFzNllxdFdrUUc1b1ZY?= =?utf-8?B?N29FYWZPNDBRdE9iVVZtVE43cXUycE13T0VrME9OcVVHbzJ0dWVoUUxFY3lG?= =?utf-8?B?aW9wM01BZjU1TEtWUmtlbStNanRqUTV3TzNkdSt3V3d4N08xdmdXU2kreVh4?= =?utf-8?B?b243Z2Raand5d2VzNmI1ejNWSEU3ZUFZNWwvMHpjeXhvL0tiaFJXa0trVUli?= =?utf-8?B?dHJxT3JldDhYSDRCSDA2SHpJcEczdnNtdXBpZW1ZbW80VFVCYWllTjYrekJr?= =?utf-8?B?YTdWMklBQ3c1aWVyMDNkOXgrREh6NGtzS1I5S1EweXIwS00zT000S3ZIeXZE?= =?utf-8?B?empkV1lNUFFjeWUzajUxZEZyZ2dwL0lPLzViR2ZLdEZhQjVYSTlyYXNBOEVG?= =?utf-8?B?ZW5OalhLOGpyZzlGejVQWWpoclMzY0ZmaHNyVnpnYjFwNTBQNnh5eS93czZp?= =?utf-8?B?RXVnV2t3WE9vb0w4aHJyakVEeWkwdFEwTjhKcDVnRUpvTzBaS2psVnFtT2VE?= =?utf-8?Q?Jo9TovGSqSg+ZO7zeAf9r0i1v9hsVgh6CLxap8F?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5413.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d13f1280-8415-4a24-e72c-08d8f964e3b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2021 01:31:38.4505 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x3BlUQaDBO2loXYUYAhWFpwql+ljIWo6dvfSbUL5w2TQFfp/APAIHFHDjMyiLv8ifQWcpIbHE31n9iJgJFJAjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2787 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_023142_899242_3E015BF0 X-CRM114-Status: GOOD ( 35.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Leo, On Wednesday, April 7, 2021 5:45 AM, Li Yang wrote: > > On Fri, Mar 12, 2021 at 2:56 AM Ran Wang wrote: > > > > From: Peng Ma > > > > This patch enables ACPI support in RCPM driver. > > > > Signed-off-by: Peng Ma > > Signed-off-by: Ran Wang > > --- > > Change in v6: > > - Remove copyright udpate to rebase on latest mainline > > > > Change in v5: > > - Fix panic when dev->of_node is null > > > > Change in v4: > > - Make commit subject more accurate > > - Remove unrelated new blank line > > > > Change in v3: > > - Add #ifdef CONFIG_ACPI for acpi_device_id > > - Rename rcpm_acpi_imx_ids to rcpm_acpi_ids > > > > Change in v2: > > - Update acpi_device_id to fix conflict with other driver > > > > drivers/soc/fsl/rcpm.c | 18 ++++++++++++++++-- > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/soc/fsl/rcpm.c b/drivers/soc/fsl/rcpm.c index > > 4ace28cab314..7aa997b932d1 100644 > > --- a/drivers/soc/fsl/rcpm.c > > +++ b/drivers/soc/fsl/rcpm.c > > @@ -13,6 +13,7 @@ > > #include > > #include > > #include > > +#include > > > > #define RCPM_WAKEUP_CELL_MAX_SIZE 7 > > > > @@ -78,10 +79,14 @@ static int rcpm_pm_prepare(struct device *dev) > > "fsl,rcpm-wakeup", value, > > rcpm->wakeup_cells + 1); > > > > - /* Wakeup source should refer to current rcpm device */ > > - if (ret || (np->phandle != value[0])) > > + if (ret) > > continue; > > > > + if (is_of_node(dev->fwnode)) > > + /* Should refer to current rcpm device */ > > + if (np->phandle != value[0]) > > + continue; > > It looks like that we assume that in the ACPI scenario there will only be one RCPM controller and all devices are controlled by this single > PM controller. This probably is true for all existing SoCs with a RCPM. But since the driver tried to support multiple RCPMs, maybe we > should continue to support multiple RCPM controllers or at least mention that in the comment. How about adding some comment as below: /* For ACPI mode, currently we assume there is only one RCPM controller existing */ Regards, Ran > > > + > > /* Property "#fsl,rcpm-wakeup-cells" of rcpm node defines the > > * number of IPPDEXPCR register cells, and "fsl,rcpm-wakeup" > > * of wakeup source IP contains an integer array: > > > rcpm_of_match[] = { }; MODULE_DEVICE_TABLE(of, rcpm_of_match); > > > > +#ifdef CONFIG_ACPI > > +static const struct acpi_device_id rcpm_acpi_ids[] = { > > + {"NXP0015",}, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(acpi, rcpm_acpi_ids); #endif > > + > > static struct platform_driver rcpm_driver = { > > .driver = { > > .name = "rcpm", > > .of_match_table = rcpm_of_match, > > + .acpi_match_table = ACPI_PTR(rcpm_acpi_ids), > > .pm = &rcpm_pm_ops, > > }, > > .probe = rcpm_probe, > > -- > > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel