Re: Re: [PATCH] spi: imx: add a check for speed_hz before calculating the clock

Re: Re: [PATCH] spi: imx: add a check for speed_hz before calculating the clock

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 1330 bytes --]

On Tue, Apr 27, 2021 at 08:33:06AM +0000, Clark Wang wrote:

> However, I notice that you have applied this patch to the next branch?
> Will you revert this patch?

Well, it's redundant but not harmful.

> I think you may want to apply this patch I sent before.
> 
> Author: Clark Wang <xiaoning.wang@nxp.com>
> Date:   Mon Dec 14 17:05:04 2020 +0800
> 
>     spi: imx: add 16/32 bits per word support for slave mode
>     
>     Enable 16/32 bits per word support for spi-imx slave mode.
>     It only support 8 bits per word in slave mode before.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: Re: [PATCH] spi: imx: add a check for speed_hz before calculating the clock

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 580 bytes --]

On Tue, Apr 27, 2021 at 08:33:06AM +0000, Clark Wang wrote:

> However, I notice that you have applied this patch to the next branch?
> Will you revert this patch?
> I think you may want to apply this patch I sent before.
> 
> Author: Clark Wang <xiaoning.wang@nxp.com>
> Date:   Mon Dec 14 17:05:04 2020 +0800
> 
>     spi: imx: add 16/32 bits per word support for slave mode

Oh, in this case what happened is that you sent your speed_hz patch as a
reply to this patch so the speed_hz patch looked like a replacement for
it which confused both me and the tooling.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [EXT] Re: Re: [PATCH] spi: imx: add a check for speed_hz before calculating the clock

[Clark Wang]

[-- Attachment #1.1: Type: text/plain, Size: 1474 bytes --]


> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Tuesday, April 27, 2021 19:19
> To: Clark Wang <xiaoning.wang@nxp.com>
> Cc: shawnguo@kernel.org; s.hauer@pengutronix.de; festevam@gmail.com;
> kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>; linux-
> spi@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: [EXT] Re: Re: [PATCH] spi: imx: add a check for speed_hz before
> calculating the clock
> 
> On Tue, Apr 27, 2021 at 08:33:06AM +0000, Clark Wang wrote:
> 
> > However, I notice that you have applied this patch to the next branch?
> > Will you revert this patch?
> > I think you may want to apply this patch I sent before.
> >
> > Author: Clark Wang <xiaoning.wang@nxp.com>
> > Date:   Mon Dec 14 17:05:04 2020 +0800
> >
> >     spi: imx: add 16/32 bits per word support for slave mode
> 
> Oh, in this case what happened is that you sent your speed_hz patch as a
> reply to this patch so the speed_hz patch looked like a replacement for it
> which confused both me and the tooling.

I'm sorry to cause you confusion.
 1) spi: imx: add 16/32 bits per word support for slave mode and B 
 2) spi: imx: add a check for speed_hz before calculating the clock
These two patch above are two independent patches.
Now 2) is no longer needed, I just sent 3) to fix the real problem.
 3) spi: imx: remove CLK calculation and divider in slave mode

Thank you very much!

Best Regards,
Clark Wang

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 9583 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel