Linux-ARM-Kernel Archive on lore.kernel.org
 help / Atom feed
From: Leo Li <leoyang.li@nxp.com>
To: Chuanhua Han <chuanhua.han@nxp.com>, Shawn Guo <shawnguo@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Ying Zhang <ying.zhang22455@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
Date: Fri, 17 May 2019 22:01:03 +0000
Message-ID: <AM6PR04MB586341334E62A663EE5E8BD18F0B0@AM6PR04MB5863.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <AM6PR04MB4357C78FCEBA1B00AA42ED2E970B0@AM6PR04MB4357.eurprd04.prod.outlook.com>



> -----Original Message-----
> From: Chuanhua Han
> Sent: Friday, May 17, 2019 1:11 AM
> To: Shawn Guo <shawnguo@kernel.org>
> Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com>
> Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
> 
> 
> 
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: 2019Äê5ÔÂ17ÈÕ 10:38
> > To: Chuanhua Han <chuanhua.han@nxp.com>
> > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com>
> > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device
> > node
> >
> > Caution: EXT Email
> >
> > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote:
> > > ls1028a platform uses sp805 watchdog, and use 1/16 platform clock as
> > > timer clock, this patch fix device tree node.
> > >
> > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > > ---
> > >  .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19
> > > ++++++++++++-------
> > >  1 file changed, 12 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > index b04581249f0b..1510b1858246 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > @@ -285,13 +285,18 @@
> > >                       #interrupt-cells = <2>;
> > >               };
> > >
> > > -             wdog0: watchdog@23c0000 {
> > > -                     compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt";
> > > -                     reg = <0x0 0x23c0000 0x0 0x10000>;
> > > -                     interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
> > > -                     clocks = <&clockgen 4 1>;
> > > -                     big-endian;
> > > -                     status = "disabled";
> > > +             cluster1_core0_watchdog: wdt@c000000 {
> >
> > Keep 'watchdog' as the node name,
> Thanks for your replay
> Do you mean replace the ¡®wdt¡¯ with ¡®watchdog¡¯?
> and keep nodes sort in unit-address.
> What does this mean?

That means order the nodes by the addresses (e.g. c000000, c010000)

> >
> > Shawn
> >
> > > +                     compatible = "arm,sp805", "arm,primecell";
> > > +                     reg = <0x0 0xc000000 0x0 0x1000>;
> > > +                     clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> > > +                     clock-names = "apb_pclk", "wdog_clk";
> > > +             };
> > > +
> > > +             cluster1_core1_watchdog: wdt@c010000 {
> > > +                     compatible = "arm,sp805", "arm,primecell";
> > > +                     reg = <0x0 0xc010000 0x0 0x1000>;
> > > +                     clocks = <&clockgen 4 15>, <&clockgen 4 15>;
> > > +                     clock-names = "apb_pclk", "wdog_clk";
> > >               };
> > >
> > >               sata: sata@3200000 {
> > > --
> > > 2.17.1
> > >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09  7:06 Chuanhua Han
2019-05-17  2:37 ` Shawn Guo
2019-05-17  6:10   ` [EXT] " Chuanhua Han
2019-05-17 22:01     ` Leo Li [this message]
2019-05-21 13:00       ` Chuanhua Han
2019-05-21 20:14         ` Leo Li
2019-05-22  6:26           ` Chuanhua Han
2019-05-22  6:50             ` Leo Li

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR04MB586341334E62A663EE5E8BD18F0B0@AM6PR04MB5863.eurprd04.prod.outlook.com \
    --to=leoyang.li@nxp.com \
    --cc=chuanhua.han@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=shawnguo@kernel.org \
    --cc=ying.zhang22455@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox