From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD0BC433DF for ; Wed, 8 Jul 2020 02:23:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A076E206DF for ; Wed, 8 Jul 2020 02:23:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DLlGvG2K"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="KOkAXUoK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="KOkAXUoK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A076E206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z15JPqMcPTw2x5lN7YsXuV1WVUKb5yZCNlyNtAnNSlQ=; b=DLlGvG2KDIQ2JoNbqIYwH5eI1 eYqbnh9cLWBKl2wIcnkc027iPCo4qTfnwebIq69fuEULs51gU7zrX5sAQGBh11EIipVCuCG6lHT60 N+8N2vvQ2JzzM7h7KeclBAvoxCgqsMAlJbGR38BV8SEnLfoLEHAD1mr82Q5o+f/pg5tVpnbBL0r8N laqEuKRegu99YDOBVYi3jubJpCyu5CUOsT/GA9KB/DMx/oYpdPnWbFE2tPDd7JE7E+OBMwHVKD4K0 CQILN8S97KkVOc7jRUl9WI1xWCPf1Kb93wzL6dx3MKGGFEcxdtd+GlI16UQZbx/X0w/I2UtgJ3gmf P7y5ryxWQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jszhM-0003zl-2U; Wed, 08 Jul 2020 02:20:36 +0000 Received: from mail-eopbgr140084.outbound.protection.outlook.com ([40.107.14.84] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jszhJ-0003yn-IN for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 02:20:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mNaSRtwXz1ZMLKUafvsJ0kItmonn/pN6p8VfFC+kDTc=; b=KOkAXUoKBM/TZX8l27jabXRSAa8KKv9LZQ+XHo+iQXdeR3HDW3zLPQ+2T9Wo0Pj7/0p+Gs7A7N4Vvlsloh8JEqImNE1YwieOPanq6sAzXc7d93vmlMNV3CZGS/NFukMXXCJmodwTdW/CvapObsxLmE9bchY8HsLX8ekW6qLqJWQ= Received: from MR2P264CA0038.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::26) by VI1PR08MB3005.eurprd08.prod.outlook.com (2603:10a6:803:44::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.28; Wed, 8 Jul 2020 02:20:26 +0000 Received: from VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:0:cafe::6b) by MR2P264CA0038.outlook.office365.com (2603:10a6:500::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Wed, 8 Jul 2020 02:20:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT057.mail.protection.outlook.com (10.152.19.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.24 via Frontend Transport; Wed, 8 Jul 2020 02:20:26 +0000 Received: ("Tessian outbound e44de778b77e:v62"); Wed, 08 Jul 2020 02:20:25 +0000 X-CR-MTA-TID: 64aa7808 Received: from e1e3968f74fc.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3260E18E-0ACF-4871-87BB-CC22D4CBE4B4.1; Wed, 08 Jul 2020 02:20:20 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e1e3968f74fc.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Jul 2020 02:20:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nlfRN2jqiTGixdwdtZLObFYaZUK4OLzJ+mBl3ygCUaUoSZer/j+ZzQEZsxJD3igBlj4L6/zsZ4W9uM/2SyO+kj/TixMqp8LAhIbqm5d4cq24LgdPsa6S3hvqOoEYa5b8Aq+rzthdVHLFkCXK/XxPQMofKdg8aLsO+rux4ngDMLHi42QFsz0wJgz+ooMqvGxD/a3PvyZ1+puPkuErKtaBQ/Kxiz18nbDX9ExQsPuezIfvjf9ezbS41qgIPkHK/7iDTCHFaZQ2El5g0dXWtnJnTuaJH5vLkxtLgKCMf7ogp6rZ+pF56zQKZAgOFB5F0TSnAmmYOf/vXXH25gkiQFJ0jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mNaSRtwXz1ZMLKUafvsJ0kItmonn/pN6p8VfFC+kDTc=; b=SIy51Z0zs/df1iIjlspK1BdCzNvttA3Y1YprGahLbwRuP5l4sPtdadOTooUQimgebo1phTySeaCgbb8neafCDbAW9vY6xsvmdWVDpRC2we5jlYEuCZZaUFLx3gmf5DUCx2vEmfFkxv0FAvYyhnZ68boWAcPYI/CjpDDJK0P7TITwHojNrN5EXjVY8LBqgE7b6jjrNHnrh7eLnAH7CviY1Aus4y9MTVtpuhH3q8Gcuv4kMWrdxdfxf05GQp9riNS6lkOCVCLuMdGC/Kv8y0dMLZeuIfWKkl9NOA1aUJYWb7BG10It28WAjHoxOdPVX2OUIRTfUoqoE/4BwwAamcp86A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mNaSRtwXz1ZMLKUafvsJ0kItmonn/pN6p8VfFC+kDTc=; b=KOkAXUoKBM/TZX8l27jabXRSAa8KKv9LZQ+XHo+iQXdeR3HDW3zLPQ+2T9Wo0Pj7/0p+Gs7A7N4Vvlsloh8JEqImNE1YwieOPanq6sAzXc7d93vmlMNV3CZGS/NFukMXXCJmodwTdW/CvapObsxLmE9bchY8HsLX8ekW6qLqJWQ= Received: from AM6PR08MB4069.eurprd08.prod.outlook.com (2603:10a6:20b:af::32) by AM6PR08MB4689.eurprd08.prod.outlook.com (2603:10a6:20b:c3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.22; Wed, 8 Jul 2020 02:20:18 +0000 Received: from AM6PR08MB4069.eurprd08.prod.outlook.com ([fe80::8c97:9695:2f8d:3ae0]) by AM6PR08MB4069.eurprd08.prod.outlook.com ([fe80::8c97:9695:2f8d:3ae0%5]) with mapi id 15.20.3174.021; Wed, 8 Jul 2020 02:20:18 +0000 From: Justin He To: Michal Hocko , David Hildenbrand Subject: RE: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL Thread-Topic: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL Thread-Index: AQHWVCPSGGxRNvjq20KjOcC2mjPWIqj8ApMAgADwVZA= Date: Wed, 8 Jul 2020 02:20:17 +0000 Message-ID: References: <20200707055917.143653-1-justin.he@arm.com> <20200707055917.143653-2-justin.he@arm.com> <20200707115454.GN5913@dhcp22.suse.cz> In-Reply-To: <20200707115454.GN5913@dhcp22.suse.cz> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 22d41742-0986-422f-8b83-3acf44cdcbab.0 x-checkrecipientchecked: true Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.112] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2266fe7e-2538-4f48-a8ee-08d822e57a21 x-ms-traffictypediagnostic: AM6PR08MB4689:|VI1PR08MB3005: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 04583CED1A X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iqokAUQL/G50BtDL2TuIGlrJOGKByIF5jzP6/fG59bN9ap4qwtLiTF9QLhexXvGftYT55H0jadEQrsOY4UUGxcMA1K2tLIGhMgFLvhm8STAIgB8lHdYjdVTKn24rFcxFyn4mV9QSX0wxlxyGgb8Uy7ezDH9dA+ULcgfOUQBOedv+LgtAWbnAyl1dSMnoTejIlROE7aFyqkQ9bQJJPN/fQiAGB666LYOkXz38XC57pErrUWZWId8DQFEPgMcDIAj3WI84B0asOWb37qev8lEceRKQMBHfOUYgGaMD9WE3AR8p+O+aYJtti5b4i/eLwS32LJZy/rr7BnhCRbdr4iuL6Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4069.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(396003)(39850400004)(346002)(136003)(366004)(2906002)(52536014)(86362001)(5660300002)(76116006)(66476007)(66946007)(66446008)(66556008)(110136005)(64756008)(8676002)(6506007)(8936002)(53546011)(7696005)(54906003)(4326008)(316002)(33656002)(71200400001)(478600001)(55016002)(26005)(9686003)(7416002)(186003)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: zeR7jallz/SMaiTB4kHQ4s+nP0QXiKeVwrEscnB6Tbnd/Tp+3tc5/wG8lO+Yw0p80HYaEBkHhHnRaXll5rnNTi3j4cscNAUaLdDK88xwWFiHogPxCC04IeBA3CUQlfk/WcKwQc26kMHMHsHcy4vgW+LUaqFyRvqrnUEy490ady+7+UPjIyzkawbkL4aplrDBBUHSMKw054P/2yD51YX+LZO15PvM2FvUTAJzZJcW6uzdwEg8ClOQw8RNDmaoraO1exGorszFPisJFjYeZvYvWPDMX9gnXyxWlqibm5U4K9mSfpop3DD+ztnEDT9qcvvktQlDi/k4vgtxSmLq+2S31IXeQf78wB/BJ7n002Njqwvwcm/RXnZWbeCjQi7un8tPmOP6jfytKgjlFuD6KBV+rdTvJ+FJtotn6AoqMZ6ydS2TwfwCDnKPZGy6dUjFA2rcmO056RZuTFvMKCkzqDnYJFWVB0DtNHDaZZOn7AVxub0= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4689 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(39850400004)(396003)(136003)(46966005)(7696005)(8936002)(478600001)(186003)(26005)(356005)(55016002)(81166007)(9686003)(82310400002)(86362001)(47076004)(82740400003)(53546011)(6506007)(54906003)(2906002)(5660300002)(83380400001)(8676002)(316002)(52536014)(110136005)(36906005)(4326008)(70206006)(33656002)(70586007)(336012); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 270ccc62-11ed-468f-0502-08d822e5752f X-Forefront-PRVS: 04583CED1A X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tr4wLQKPBltYFdgzO2W4ExSc/kCDnY8P+W7PSP+6FQSCHzMSqqaS6/ev5EcLDqquYKccwwrb1CVlwcOtGMhjCZ1Xe2a1R2GtkLi0K1BmM7n79MmfNIomHbFgZVrjZNf2+d2jw612cPD0RUKNquXJhKWgl63jEfzgpDpv6Ei02V5tkaMq0RvgdElvcP+2whDjKTwQFglsyib4zp3b2mK5q4ZkbA0MDE3hPbvVzpMsBURB843gPuDFmhQtnrOrlGkdKpLNYfdMS7KIKFnAKawwvnf86SIZCTF+pHiE58gsCduHK3I9apiV+6cW5FfCnd02OIFSnd0oqgBPcYT2YQvciR5KWP9rBTAmXCD3V4rF12gnV8Qc7U49n5tNwK5Y2uKQQDAPi9OkqIbaZw7ZguADuw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2020 02:20:26.3657 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2266fe7e-2538-4f48-a8ee-08d822e57a21 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3005 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_222033_649767_ABCB5080 X-CRM114-Status: GOOD ( 24.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kaly Xin , Dave Jiang , Baoquan He , "linux-nvdimm@lists.01.org" , Catalin Marinas , Chuhong Yuan , "linux-kernel@vger.kernel.org" , Mike Rapoport , "linux-mm@kvack.org" , Vishal Verma , Dan Williams , Will Deacon , Andrew Morton , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal and David > -----Original Message----- > From: Michal Hocko > Sent: Tuesday, July 7, 2020 7:55 PM > To: Justin He > Cc: Catalin Marinas ; Will Deacon > ; Dan Williams ; Vishal Verma > ; Dave Jiang ; Andrew > Morton ; Mike Rapoport ; > Baoquan He ; Chuhong Yuan ; linux- > arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > mm@kvack.org; linux-nvdimm@lists.01.org; Kaly Xin > Subject: Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid > as EXPORT_SYMBOL_GPL > > On Tue 07-07-20 13:59:15, Jia He wrote: > > This exports memory_add_physaddr_to_nid() for module driver to use. > > > > memory_add_physaddr_to_nid() is a fallback option to get the nid in case > > NUMA_NO_NID is detected. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: Jia He > > --- > > arch/arm64/mm/numa.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c > > index aafcee3e3f7e..7eeb31740248 100644 > > --- a/arch/arm64/mm/numa.c > > +++ b/arch/arm64/mm/numa.c > > @@ -464,10 +464,11 @@ void __init arm64_numa_init(void) > > > > /* > > * We hope that we will be hotplugging memory on nodes we already know > about, > > - * such that acpi_get_node() succeeds and we never fall back to this... > > + * such that acpi_get_node() succeeds. But when SRAT is not present, > the node > > + * id may be probed as NUMA_NO_NODE by acpi, Here provide a fallback > option. > > */ > > int memory_add_physaddr_to_nid(u64 addr) > > { > > - pr_warn("Unknown node for memory at 0x%llx, assuming node 0\n", > addr); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); > > Does it make sense to export a noop function? Wouldn't make more sense > to simply make it static inline somewhere in a header? I haven't checked > whether there is an easy way to do that sanely bu this just hit my eyes. Okay, I can make a change in memory_hotplug.h, sth like: --- a/include/linux/memory_hotplug.h +++ b/include/linux/memory_hotplug.h @@ -149,13 +149,13 @@ int add_pages(int nid, unsigned long start_pfn, unsigned long nr_pages, struct mhp_params *params); #endif /* ARCH_HAS_ADD_PAGES */ -#ifdef CONFIG_NUMA -extern int memory_add_physaddr_to_nid(u64 start); -#else +#if !defined(CONFIG_NUMA) || !defined(memory_add_physaddr_to_nid) static inline int memory_add_physaddr_to_nid(u64 start) { return 0; } +#else +extern int memory_add_physaddr_to_nid(u64 start); #endif And then check the memory_add_physaddr_to_nid() helper on all arches, if it is noop(return 0), I can simply remove it. if it is not noop, after the helper, #define memory_add_physaddr_to_nid What do you think of this proposal? -- Cheers, Justin (Jia He) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel