From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 216BCC433E0 for ; Thu, 9 Jul 2020 09:38:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAFD3206C3 for ; Thu, 9 Jul 2020 09:38:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ydrbXa2Q"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="xQRmKImm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="xQRmKImm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAFD3206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8raj2ZLR5CK0Pv/3/QgYtmUzgIsexisFg5EPGpTKXIc=; b=ydrbXa2Q9bjS34BKYyrydvRb0 JbbWBGRJowDcWDhSOtnmUY0+5ATwpvTXj24kzer4ZBrU1u5jRGluybGtHo/u0Sk+vdGLP+k/pYYT4 mlugNuVLiHrGGz2kstAkxzrkYA2/hGxOjwb1JRq+jib9X6EWrX9w7eQ8rwVLepvsNhkFw0vUxsFgb wN76qpOWHNCodNgB+NHoEndMFQaHlWrwRJULW05sglCSyMQq69CodP5iKUdvHHcyKOnj3iT71NYcn t5qEO95EEklPBW43o2w4EiM2wdBXRbbxUCMVvpOhg9eUnMJdbEqRgnlGmuoLs6UICt8tQT+kadALT 3WbgCzSPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtSzG-0007fG-Ag; Thu, 09 Jul 2020 09:37:02 +0000 Received: from mail-eopbgr40068.outbound.protection.outlook.com ([40.107.4.68] helo=EUR03-DB5-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtSzC-0007d0-PS for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2020 09:37:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UNkJ1GT23bvVx7BKqyG/rMU6wJA3ldpjaggg8j/RWz4=; b=xQRmKImmnytsy8+mYv45XybSb71RGGbGRoDBT+mv6eeyfvUEKVaKSnZdr7SM5GSDdQffCbZB7YtTONS2sDpc6hVbcv1XqoXx8Fck4qs5/FIAAB4GOrYorFSrtdvxqiSc/IacUxm4qJ0S6K7xqMEifEAQOWQWLps35n95aliox2o= Received: from MR2P264CA0109.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::25) by DB6PR08MB2760.eurprd08.prod.outlook.com (2603:10a6:6:24::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Thu, 9 Jul 2020 09:36:53 +0000 Received: from VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:33:cafe::2b) by MR2P264CA0109.outlook.office365.com (2603:10a6:500:33::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Thu, 9 Jul 2020 09:36:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT046.mail.protection.outlook.com (10.152.19.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Thu, 9 Jul 2020 09:36:52 +0000 Received: ("Tessian outbound 73b502bf693a:v62"); Thu, 09 Jul 2020 09:36:51 +0000 X-CR-MTA-TID: 64aa7808 Received: from e4cf6cc6711d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8C2728F8-1433-4020-A5A6-DB44C55AFBD7.1; Thu, 09 Jul 2020 09:36:46 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e4cf6cc6711d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 09 Jul 2020 09:36:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gJLfq9G1JAhsSfpJYU8hZVWH2i6OpreXtBVmZSh9ht9Gvpeic7CDSKSOO/5UpKsGGdYHn9W7tKfbnPP5rdYKsBBRUqh6ERaZxNKDpxyLnAU/6HjFemjbr+I7XJC2cA9YDx8gLUAVI+nN0uautfgJtdmseJvHTvOqiMW0WRezeJibtSsqL527VdfVyo+Q6PuKGyBsy4jmLPv51xS0Eu2Yz/g2BK37RQfzkMOJ3m8+3pYyr0z0NwYGGhaIXdLdqsdN+hLUt1bvFf4yot7/T3ezqEpuzcuQ9cILvizDzxUrwyT/MwULJdZ/ya6M/IJLtaYXLwCW9fNW7JIeiKI7b2EumQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UNkJ1GT23bvVx7BKqyG/rMU6wJA3ldpjaggg8j/RWz4=; b=SGuJPa/tEUGBQQv2sbwMUSyTnadicyNAR/QYtdK3p/WFV3aErkn+ep/VUaRpJvt0PMQAXslImDmK8Yfn0yaIczqXVB7L7QtYpipUGI/0mBlhzk4lqD9Qvaah5AyXuT7w7he6xFWDLRKjhq8gXVBVZvqoqTNYYOy5wlskJpKBOyP9XYtqZ8oswiV4iuOeV5YIHwasCni/3fPuXKpeO25erjR6TXWzs/AGC4OjktDa/xEuBMdOsuGhx8YZTrrdDHujgMqBJJ5hpMolqFrQrbILOr3Bz5cLv4Zu+/RQmqrmPfXRppZayyD42gF++Vf85Z5mNCq5BarhBvpXqIVQJSHaIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UNkJ1GT23bvVx7BKqyG/rMU6wJA3ldpjaggg8j/RWz4=; b=xQRmKImmnytsy8+mYv45XybSb71RGGbGRoDBT+mv6eeyfvUEKVaKSnZdr7SM5GSDdQffCbZB7YtTONS2sDpc6hVbcv1XqoXx8Fck4qs5/FIAAB4GOrYorFSrtdvxqiSc/IacUxm4qJ0S6K7xqMEifEAQOWQWLps35n95aliox2o= Received: from AM6PR08MB4069.eurprd08.prod.outlook.com (2603:10a6:20b:af::32) by AM6PR08MB4408.eurprd08.prod.outlook.com (2603:10a6:20b:be::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.24; Thu, 9 Jul 2020 09:36:43 +0000 Received: from AM6PR08MB4069.eurprd08.prod.outlook.com ([fe80::8c97:9695:2f8d:3ae0]) by AM6PR08MB4069.eurprd08.prod.outlook.com ([fe80::8c97:9695:2f8d:3ae0%5]) with mapi id 15.20.3174.021; Thu, 9 Jul 2020 09:36:43 +0000 From: Justin He To: David Hildenbrand , Mike Rapoport , Matthew Wilcox Subject: RE: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory Thread-Topic: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory Thread-Index: AQHWVZW4cB9QLv1x3USSUrS3ZjVOOaj+gToAgAB3WoCAAAAygIAABM2g Date: Thu, 9 Jul 2020 09:36:42 +0000 Message-ID: References: <20200709020629.91671-1-justin.he@arm.com> <20200709020629.91671-5-justin.he@arm.com> <20200709021104.GZ25523@casper.infradead.org> <20200709091815.GF781326@linux.ibm.com> <49a53674-f246-fdd6-009b-447a88cdb68e@redhat.com> In-Reply-To: <49a53674-f246-fdd6-009b-447a88cdb68e@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 2231c3a8-8a59-4901-a186-35c2b1673aa8.0 x-checkrecipientchecked: true Authentication-Results-Original: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.112] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ab5a6426-801d-43c9-54e4-08d823eb9ceb x-ms-traffictypediagnostic: AM6PR08MB4408:|DB6PR08MB2760: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:220;OLM:220; x-forefront-prvs: 04599F3534 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6hx1R9TLODq9DK6z3C4G5SvHatMqwOS7s7RM7Bg4GVdNU0SR+QOZ9Kr/It7d4u5QqBH1TqSHEYVM0ksIZgMarnSbxjbUwDcvHksO/3QjshScfcp5iWbc0UhMm1T0i9I2U+VNTMEwkYEw3fUQwu1ocVZ8rpB1Y9U7DHqjJdsLdRqerz7H0O92AcTU9sdgJbbCZdeYjCGZ392Uzk3xNa0m8PkBSGEljnHx0OCV/9fBb7kbWSJn4h4H7Wgnj2P7vdU2CYGq66T/AJsDz5O1g94PpP/0q4zBwOCsbQAUBGEPxAfImF49xzpADLDsf6UCDEFfagygCCaUcwiNVbNyrWeW5g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4069.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39860400002)(376002)(366004)(136003)(346002)(316002)(6506007)(54906003)(110136005)(9686003)(86362001)(8676002)(52536014)(83380400001)(53546011)(5660300002)(26005)(33656002)(2906002)(66446008)(66476007)(64756008)(66556008)(66946007)(478600001)(55016002)(4326008)(71200400001)(7696005)(7416002)(186003)(8936002)(76116006)(7406005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: LdVu64nkDjfdyPLZTLUM6C2bEskHMWCv56YV+OF7Of9zHgd9RyMCezG6mJvzV4a8PqKOR1Ld0aTUnl5d6DIk+TsjPOge5TTRWrLYC8ym1A6tYDorTXTw9o8RiPaDu2KH6uYxl4cIVtiGRAmeadOm9hPt0dy/kcUF8xZq/J6B74yHNUShv/RgWOp9yh0YiitOyG55cDurlzRxz+o3iGAiUGZlCNeyNF96vc3ZWvZiZWzO3cxIzMOJdim+caMvbSDE3hH7LGonLnZtdvSdMiI7YT/5K0Y0JKJIFDEulvXwSq0NrgIQdl8VG/QqoR9fK3aO0HKHn8/XTfEYcQIbZ+TqtyQNyZYO8Bqe61PsrC1g/vWwfdPSi8w+MbkkPOQw8aUAHPulP/TJYQIavdkXo7H+EZKVx2NfK3e16L3rKt36v6KOxa6Z+V8K2jxEqIle+uVDAH7aGPJWzKe/QQyWXdlCjgqgCxkSqwzYyQsaI2Jk8WA= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4408 Original-Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(396003)(346002)(376002)(39860400002)(136003)(46966005)(81166007)(7696005)(86362001)(55016002)(9686003)(8676002)(36906005)(52536014)(316002)(336012)(5660300002)(83380400001)(2906002)(186003)(110136005)(478600001)(54906003)(356005)(6506007)(47076004)(33656002)(70586007)(82310400002)(70206006)(53546011)(82740400003)(26005)(8936002)(4326008); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 169e7c69-2863-4e2c-df06-08d823eb971e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PLm38Py76fZdWdVwpx/ENgT89ENnrG0qWCi6SSyC9M2fHsXZWbPdYkknJgg8NPjsM7KNat7X3F/9+QeJTImvGL0dMJFRB74Bi3K9wZ7Kq0TIycmeeWLURAm5IsQXX+5nmkVsHjudMq+JeKRWsP6thlOaIY0pDNSXFxq3ENbI3z/R4gImeiv7J6o/8tNnDHsB7Nh1++SbZZNg0ENow9KpalSiyXBcMLa9YLI8LVJqErn1VAPW+wvLmc17D79/op+KHvzqf8i4VxINbqMXpemJd5yh2l5s6j9KNUWoNmEGRFzbQpJejiqPGmGs7Py+jJs5YQKzT71Xt2ogn/IrwLTfmRspl7h2XagtV6Mj1zqC1AFutvuj44Km1DUxe+B5HKAh7XrAGxMT2nM4dUUJSPQEww== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2020 09:36:52.8780 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab5a6426-801d-43c9-54e4-08d823eb9ceb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2760 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_053658_884323_813DAEEF X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , "linux-ia64@vger.kernel.org" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Catalin Marinas , Dave Hansen , "linux-mm@kvack.org" , Michal Hocko , "H. Peter Anvin" , Will Deacon , Thomas Gleixner , Dave Jiang , Yoshinori Sato , "linux-nvdimm@lists.01.org" , Vishal Verma , Masahiro Yamada , "x86@kernel.org" , Kaly Xin , Ingo Molnar , Fenghua Yu , Chuhong Yuan , Borislav Petkov , Andy Lutomirski , Jonathan Cameron , Dan Williams , "linux-arm-kernel@lists.infradead.org" , Tony Luck , Baoquan He , "linux-kernel@vger.kernel.org" , Andrew Morton , Logan Gunthorpe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi David > -----Original Message----- > From: David Hildenbrand > Sent: Thursday, July 9, 2020 5:19 PM > To: Mike Rapoport ; Matthew Wilcox > > Cc: Justin He ; Catalin Marinas > ; Will Deacon ; Tony Luck > ; Fenghua Yu ; Yoshinori Sato > ; Rich Felker ; Dave Hansen > ; Andy Lutomirski ; Peter > Zijlstra ; Thomas Gleixner ; > Ingo Molnar ; Borislav Petkov ; > x86@kernel.org; H. Peter Anvin ; Dan Williams > ; Vishal Verma ; Dave > Jiang ; Andrew Morton ; > Baoquan He ; Chuhong Yuan ; Logan > Gunthorpe ; Masahiro Yamada ; > Michal Hocko ; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-ia64@vger.kernel.org; linux- > sh@vger.kernel.org; linux-nvdimm@lists.01.org; linux-mm@kvack.org; > Jonathan Cameron ; Kaly Xin > Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in > arch specific directory > > On 09.07.20 11:18, Mike Rapoport wrote: > > On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote: > >> On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > >>> After a general version of __weak memory_add_physaddr_to_nid > implemented > >>> and exported , it is no use exporting twice in arch directory even if > >>> e,g, ia64/x86 have their specific version. > >>> > >>> This is to suppress the modpost warning: > >>> WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > >>> Previous export was in vmlinux > >> > >> It's bad form to introduce a warning and then send a follow-up patch to > >> fix the warning. Just fold this patch into patch 1/6. > > > > Moreover, I think that patches 1-4 can be merged into one. > > > > +1 Okay, will update, thanks -- Cheers, Justin (Jia He) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel