From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78346C433DF for ; Mon, 6 Jul 2020 13:47:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DE70206F5 for ; Mon, 6 Jul 2020 13:47:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xYNBNFWu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bPoWzG5b"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="7147+zT9"; dkim=neutral (0-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="7147+zT9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DE70206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uX4GOrQGSOSlEafzW1K5sgW7ZSgvKnwXzFlksJ8nSHA=; b=xYNBNFWuw6LsnBNauhUK0DWUY u9zmGgYXKsmuBoH1qacf8BqX+N1D6zdLbrMNVov5Yq8+9ar7L5HTXHzdBg4GIZap/7kEwSbukQfnz aTnqH/mPLlsUtOHsd1bNc/y8LoLIanKtFQvYhSlhCng+iCcZI084sVGXHeNs+pcOt5qPDn8Zh7aeZ aZ5GcpgoiQZ7JND+yzGtkeasXn9wmjANnaVKECcXB0Hy1MoEdMBQNYtmr2/+InMTy2c6Vwr8cjUj7 vHIuSi8ofvIFDO2DTxee+WpfVeBZned/vdNXyjfdXWluEzSDS24VR+qTYkeny+L0y5B28LzU5nZ0l N4XCWQLog==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRRE-0006NT-Rx; Mon, 06 Jul 2020 13:45:41 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRR5-0006Jn-4u for linux-arm-kernel@merlin.infradead.org; Mon, 06 Jul 2020 13:45:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=kyv4ODfLMnyiHTxTy9n4Exe0hH150b1AaEBelt13WcA=; b=bPoWzG5bmWD9+0vRV496ludvcP iXqWldXOzjG5bEBdBk5Ii7Woq9vxhQPrXVMYDNcn/5dasVXPfTKEaqVltpZ7JBX2BAoP1r9gVOmxD QXd1PriNjBkXRM6GBimKw8ZNOG6VFxXogUu+GzcXykhZj0Hv2TS7h9gLghQ5x52gYcXWIJKB/G8oA aM0gV5gBDJVsHb2pz0jdH9Go6i/cfrMriFVoJJsErZ1prEumyEuQzLO1Sw6MzlFCw1ccPmAXRlSjn RtuWn5WTbr9FQLjCeKQZO62QZlE90d9aECP9LG2p3naKd+XeY9iWWXugWzl2kGz5oEm0d3M/pdQWN 0CsSOn5A==; Received: from mail-am6eur05on2082.outbound.protection.outlook.com ([40.107.22.82] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRR0-0002UF-Tz for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:45:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kyv4ODfLMnyiHTxTy9n4Exe0hH150b1AaEBelt13WcA=; b=7147+zT9A5m7WbhipSCw65K2MN/FnuBReXL8bVrX8lu93+Mqgt51ajB74rZReZ61Ws/cGIATCU9T7ryNDffpzBqsFwwnnCY2aQKE0KnmSIcOw7iAFPp0P0Tjy0dIwhQ2cCLuGssgyF5nxZNZivuj9qdkqlYm2SYOcB3+4yvuBB0= Received: from AM5PR0601CA0037.eurprd06.prod.outlook.com (2603:10a6:203:68::23) by AM6PR08MB3495.eurprd08.prod.outlook.com (2603:10a6:20b:48::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.29; Mon, 6 Jul 2020 13:45:22 +0000 Received: from VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::bd) by AM5PR0601CA0037.outlook.office365.com (2603:10a6:203:68::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23 via Frontend Transport; Mon, 6 Jul 2020 13:45:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT007.mail.protection.outlook.com (10.152.18.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.24 via Frontend Transport; Mon, 6 Jul 2020 13:45:21 +0000 Received: ("Tessian outbound f7489b7e84a7:v62"); Mon, 06 Jul 2020 13:45:21 +0000 X-CR-MTA-TID: 64aa7808 Received: from a2876271bd5e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 61D15026-CC06-418E-B2E6-26094679476A.1; Mon, 06 Jul 2020 13:45:16 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a2876271bd5e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Jul 2020 13:45:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SaI5UFI7nJLLqxkSwmQvEBxVv10E10PkmtQ+w0Xvb2LGY37r0QIJXtfXT0Qpi39vPaRRqR3MXoGvf/c7sSOJBaRP5jX/8f3XXWrpns5ggmYXDlp4AwKrRj1EEBIrQrZsfCa7W12tnHkK2qeQINS/jcak2odWDCiMTuiKj+nrXzA+sZstaMSJcjVjgfaFErUEHgUsVfN8iIpxvf/hBlMgFc/3Xl8jlD0isYKBIOPjhVbmu4bxNJzO5GjEHdZrzy4MFGd2musu1vBAmyagD6YHn+sdqjUZKvz+uU6QZHO2XcNZnpJJbKc/h5zMj/DxkmrlBnlxY7Fi2oFTPvemxVLjSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kyv4ODfLMnyiHTxTy9n4Exe0hH150b1AaEBelt13WcA=; b=N/nG9veKm/zQ2AyezVtHfFGadrOmhuj6mYNgfF5ewSIvlVf9LKzdd3JcwU1sEVsSouuKQeGrHwABCEVO/hPRTLC3z2noG6bx6kNmzhCQlUojWS/BpVBzKG5Ckg7CGigE57beIo7WdEIfVrW4SFZK+LwduAvGWvz413oOE++JiUr8rVhtZLsn2N03v2hFuc3zzPxbEZLlaORhFvHiC0GY8D9EpcNa4QYiUEb1QXnLdlAZAKUUXzQYCNqW4LMgK3sbjWyOTNDCtijTXOeE3fVJ/jIJf3mrYsU9awk1vJGPv8nwsY/1CBvDY2RU7uDs82fyYQlGM6Mt+RnMssVsMSCF0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kyv4ODfLMnyiHTxTy9n4Exe0hH150b1AaEBelt13WcA=; b=7147+zT9A5m7WbhipSCw65K2MN/FnuBReXL8bVrX8lu93+Mqgt51ajB74rZReZ61Ws/cGIATCU9T7ryNDffpzBqsFwwnnCY2aQKE0KnmSIcOw7iAFPp0P0Tjy0dIwhQ2cCLuGssgyF5nxZNZivuj9qdkqlYm2SYOcB3+4yvuBB0= Received: from AM6PR08MB4069.eurprd08.prod.outlook.com (2603:10a6:20b:af::32) by AM7PR08MB5496.eurprd08.prod.outlook.com (2603:10a6:20b:de::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.29; Mon, 6 Jul 2020 13:45:13 +0000 Received: from AM6PR08MB4069.eurprd08.prod.outlook.com ([fe80::8c97:9695:2f8d:3ae0]) by AM6PR08MB4069.eurprd08.prod.outlook.com ([fe80::8c97:9695:2f8d:3ae0%5]) with mapi id 15.20.3153.029; Mon, 6 Jul 2020 13:45:13 +0000 From: Justin He To: David Hildenbrand Subject: RE: [PATCH 2/3] mm/memory_hotplug: harden try_offline_node against bogus nid Thread-Topic: [PATCH 2/3] mm/memory_hotplug: harden try_offline_node against bogus nid Thread-Index: AQHWUzOeeaTBJrAIHUCdKg/zGmF8B6j6L+IAgABZAEA= Date: Mon, 6 Jul 2020 13:45:13 +0000 Message-ID: References: <20200706011947.184166-1-justin.he@arm.com> <20200706011947.184166-3-justin.he@arm.com> <4b864877-1147-8336-5e9a-e89ac5c99be3@redhat.com> In-Reply-To: <4b864877-1147-8336-5e9a-e89ac5c99be3@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 85922f61-5aaf-4799-82da-de088905d144.1 x-checkrecipientchecked: true Authentication-Results-Original: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.112] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2c13cf2c-a024-469e-4bb8-08d821b2d432 x-ms-traffictypediagnostic: AM7PR08MB5496:|AM6PR08MB3495: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1728;OLM:1728; x-forefront-prvs: 04569283F9 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qyIDe3PtFE94XLNQCtJlJgumIJBb6CviidsR+mKhgEVP+mrD6e1oFPRlcR0Clbm+OV8fdV1x/FvfGEVWd/MvntYUiYj/LVljUav4zOWqySJ4vPWEH2myH41l+1v7Q3BDQPLvn9NFaFE6lTw99GUUZqW4C267CL5rKGxhSGx0xYzljGSJBIvh5jaKKJcgiXnVUboLDxtEusY/Eow5eJvK1xys46C3+dl0Tn7fmLkYKJv2Blo978cOGv6SZARt6QXfV70uvMlusWCmUTn75ugE9ETVC62yHZ5PGWHpA6h30x24w7I3FoMungNJFMPC3owllWkUFwjbUNA/cNB+8B3Qew== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4069.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(346002)(136003)(376002)(39860400002)(396003)(7696005)(478600001)(53546011)(6506007)(86362001)(5660300002)(55016002)(9686003)(83380400001)(33656002)(6916009)(8936002)(8676002)(2906002)(26005)(71200400001)(186003)(66946007)(76116006)(66476007)(316002)(66556008)(64756008)(66446008)(4326008)(54906003)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 8bBRNVyhvcPhz7TOjXMOQ93LTtFr8giUKwof7wRqXz5gTjgVsrlFx2pcM5f/ny9Zau6dUnmoUgp5paDQnIjFBYyLnMOXzjC+eboe5gd82nVRaB14+cGVLSR6fRlkol7R5AlFiyx6jN+XD3gbcUsjqjD54tv0oCEGoPGD6n+dp4VJOsCJAHWWY7RGWYFy+iH84SVFJJdY8Yi3PpVVJw1EyBdRvSkZEDOYe7yGLBT0BPDiuV/mxSLWamVLqc0brt2kyIhTCt6rU3r9xZ279mogMUoZfq4cfAODTSnCNZPiIDSpvQ9IFDPphNnBVhL+4Krbv407skjhQPQxr4N+diMX86drw/az46qckvD97IL7NxeOtnycRDfan5OOCQz6uq3zZniOTWdWHZ8m2Mkyqq/Cnl17ldzC+SHriFQ6WZr9CqqhmWRCN2jIXAtL9XZtRI847H+hQkNgcVKjYeYeGwBRJPnoJMDYfB2CP+Unwvr23jU= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5496 Original-Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(346002)(396003)(376002)(46966005)(2906002)(53546011)(6506007)(186003)(83380400001)(52536014)(70206006)(356005)(86362001)(9686003)(26005)(70586007)(8676002)(82310400002)(55016002)(107886003)(33656002)(478600001)(8936002)(336012)(7696005)(81166007)(5660300002)(36906005)(4326008)(82740400003)(47076004)(6862004)(316002)(54906003); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: c36e7fc4-f850-4e63-1d79-08d821b2cf48 X-Forefront-PRVS: 04569283F9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7x2CwvKuows6H/DtGB3DiAYLPt5vlWcBQQ4EIcQW5LxY8ntivsTPTcb5MfT6v9OBzlivaGD2PiYabGpmcgQVC0xB6Q85Jw+jPmOQkm9s6mewoiqyICmtchNpxOXBiJT3189jPGJiPiNJJ/MeD7OJe8mUvcNh4UYfOtgQpWOQEC1PoFRndCcCAqmTTwGc5tPCm+/YP6hhRRy03iwXA+DqDkfpvxtyclyiFq6eU2V54z0vXa9nJPSpLynySH/zAoqnPNu2XKY8a9TYerv05QuY2JKS8RdQgpGSxLdRgcMuvHSbtI+ew68M0pxUoXgUofzGot5kVDUnldTGKjXZ+KwVniqnaV3ZiN0PVQZ1mnfXwgi4OctyHM59XAbqPeSfQuVqhAAvAS0Id1jEATVeJOwh1Q== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2020 13:45:21.9747 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c13cf2c-a024-469e-4bb8-08d821b2d432 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3495 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_144527_192396_28425516 X-CRM114-Status: GOOD ( 21.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Baoquan He , Kaly Xin , Catalin Marinas , Chuhong Yuan , "linux-kernel@vger.kernel.org" , Mike Rapoport , "linux-mm@kvack.org" , Andrew Morton , Will Deacon , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi David > -----Original Message----- > From: David Hildenbrand > Sent: Monday, July 6, 2020 3:58 PM > To: Justin He ; Catalin Marinas > ; Will Deacon > Cc: Andrew Morton ; Mike Rapoport > ; Baoquan He ; Chuhong Yuan > ; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; linux-mm@kvack.org; Kaly Xin > Subject: Re: [PATCH 2/3] mm/memory_hotplug: harden try_offline_node > against bogus nid > > On 06.07.20 03:19, Jia He wrote: > > When testing the remove_memory path of dax pmem, there will be a panic > with > > call trace: > > try_remove_memory+0x84/0x170 > > remove_memory+0x38/0x58 > > dev_dax_kmem_remove+0x3c/0x84 [kmem] > > device_release_driver_internal+0xfc/0x1c8 > > device_release_driver+0x28/0x38 > > bus_remove_device+0xd4/0x158 > > device_del+0x160/0x3a0 > > unregister_dev_dax+0x30/0x68 > > devm_action_release+0x20/0x30 > > release_nodes+0x150/0x240 > > devres_release_all+0x6c/0x1d0 > > device_release_driver_internal+0x10c/0x1c8 > > driver_detach+0xac/0x170 > > bus_remove_driver+0x64/0x130 > > driver_unregister+0x34/0x60 > > dax_pmem_exit+0x14/0xffc4 [dax_pmem] > > __arm64_sys_delete_module+0x18c/0x2d0 > > el0_svc_common.constprop.2+0x78/0x168 > > do_el0_svc+0x34/0xa0 > > el0_sync_handler+0xe0/0x188 > > el0_sync+0x164/0x180 > > > > It is caused by the bogus nid (-1). Although the root cause is pmem dax > > translates from pxm to node_id incorrectly due to numa_off, it is worth > > hardening the codes in try_offline_node(), quiting if !pgdat. > > > > Signed-off-by: Jia He > > --- > > mm/memory_hotplug.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index da374cd3d45b..e1e290577b45 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -1680,6 +1680,9 @@ void try_offline_node(int nid) > > pg_data_t *pgdat = NODE_DATA(nid); > > int rc; > > > > + if (WARN_ON(!pgdat)) > > + return; > > + > > /* > > * If the node still spans pages (especially ZONE_DEVICE), don't > > * offline it. A node spans memory after move_pfn_range_to_zone(), > > > > Hm. If I am not wrong, somebody used add_memory() with another nid than > try_remove_memory()? > Yes after commit fa6d9ec790550, it can prevent this possibility. I will drop this single patch. Thanks -- Cheers, Justin (Jia He) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel