From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E07C8C433DF for ; Thu, 9 Jul 2020 05:15:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1CFD2053B for ; Thu, 9 Jul 2020 05:15:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Jv24ENiW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="78LAvTS6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="78LAvTS6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1CFD2053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M9im5aeWaKwXlL7KePh7jAqhLYhZ/c6ZP7Jyluguyvo=; b=Jv24ENiW4KvQq4cNdfGVwoZO0 E/cFO6e6VHUPUkGkGWbjLjg3pHQt3Fn7qek24yLBhRcrAYEtu+KDwEd6mEd6wN+UeW6X5cnYHBQ/D g+ZLnh7hq9aJeN6skCTsCv841mhFMkfbEMVr8kmBQ0jJPAggjE77s6upTZoW3KuVxqnocuVyk7Buc IE0rP4pN7VcicVk3NGupf95ZIlkagWHmyS006Dgu+I+K0LD2U/qPGzdQGdv8d7vUUVuwYHSohv5ZK 1/til0+VAOBYn6ILhjxv1FlrM15vWPBjJs7jxCdD+T3Rnj36ElcvJRc/XsmrXVdaQztpg+7JPmBA5 aHf5wKKqA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtOsM-0000kS-9Y; Thu, 09 Jul 2020 05:13:38 +0000 Received: from mail-eopbgr00062.outbound.protection.outlook.com ([40.107.0.62] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtOsI-0000jS-PE for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2020 05:13:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6sN+udc5fe7rcS4kOYX0bFZpVWtQBB+c87d5Xdiyt0Q=; b=78LAvTS6+lh3bxCxaSawrml6yAPVzm1T90ysCP68srNIeY5iPiE3WZZZRhsuzaI2jkcSqm+cbhIskFWcoNr87Flx4s/+GFArODNWtkcxiAQil/ewz6OaxQRNzhItXyCMxqTCbQ/PQjUk3dosH5HON4LFZHjnQIUtWLsYd+NLcR4= Received: from AM6P192CA0040.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::17) by AM6PR08MB2968.eurprd08.prod.outlook.com (2603:10a6:209:43::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Thu, 9 Jul 2020 05:13:28 +0000 Received: from AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::a3) by AM6P192CA0040.outlook.office365.com (2603:10a6:209:82::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20 via Frontend Transport; Thu, 9 Jul 2020 05:13:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT035.mail.protection.outlook.com (10.152.16.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Thu, 9 Jul 2020 05:13:28 +0000 Received: ("Tessian outbound 1c27ecaec3d6:v62"); Thu, 09 Jul 2020 05:13:27 +0000 X-CR-MTA-TID: 64aa7808 Received: from f52441a98fb4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4007E773-5DA6-4C6A-B5A2-3FB6CEF10A18.1; Thu, 09 Jul 2020 05:13:21 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f52441a98fb4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 09 Jul 2020 05:13:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PFh2x/GAO2XMmi/DRIOrhF1wfVKb7ahSpKYTu1ffQnZfgtgtFRUwkcsRY2OE7xCVR9ffFreL6iSYUA/PL2Bo4S9+Rn8WP7j4Adh7R2aDglDqkDh6qqN5hoZjEjBhfh4G9DarF0B/v3636m+JSiuoLdae3a8+s7TQdOGiNBKqdGos6+rcIRrfgbQ0Zh+ecem+DyWrKQspgvzUNebkvo68OzKNPs4978tLZz5/p/7203vU1qFmHKcr9ctt+YKnyDdNyU/QZzGhQKDxa6fj8HW2AvC50wFcCPNaYc5chRP2f+OnSX6CUfP0QxsLt3maQtrA5+1QdcG8LkrQzUdXkLTW1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6sN+udc5fe7rcS4kOYX0bFZpVWtQBB+c87d5Xdiyt0Q=; b=VWi12XQ2NnMohOZ6J+zYEOhkiggspcxRMaTo6r+oPiEFVbNiowHfuE2obFPkroLUgCGUEhbLzRIdsFrtXJK4C9r/CRV4rj4Hd5isKWtQ08uKZWn/p/f3acdtGKIElvyksgne09MmL4qOJ6O2Kwq9GZDQuLpuvZS9+kOXIDPsBwnyHV7PYI/txulMeD+5cLv96g40j50LBn1+w7e1jKA6vT5v7c8oDV5mcbZyFg1sE3jp4Ch1yRzBraMrfwVuXl1gMaYJ5TyJ1Jjm+nDYjQVlXuLc4avKV8O/IX+ft+yW0xBzdcSwrfturWIFl94Nc/WLHO6kUSqi62hPe1cJ9TFWFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6sN+udc5fe7rcS4kOYX0bFZpVWtQBB+c87d5Xdiyt0Q=; b=78LAvTS6+lh3bxCxaSawrml6yAPVzm1T90ysCP68srNIeY5iPiE3WZZZRhsuzaI2jkcSqm+cbhIskFWcoNr87Flx4s/+GFArODNWtkcxiAQil/ewz6OaxQRNzhItXyCMxqTCbQ/PQjUk3dosH5HON4LFZHjnQIUtWLsYd+NLcR4= Received: from AM6PR08MB4069.eurprd08.prod.outlook.com (2603:10a6:20b:af::32) by AM7PR08MB5335.eurprd08.prod.outlook.com (2603:10a6:20b:101::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.29; Thu, 9 Jul 2020 05:13:20 +0000 Received: from AM6PR08MB4069.eurprd08.prod.outlook.com ([fe80::8c97:9695:2f8d:3ae0]) by AM6PR08MB4069.eurprd08.prod.outlook.com ([fe80::8c97:9695:2f8d:3ae0%5]) with mapi id 15.20.3174.021; Thu, 9 Jul 2020 05:13:20 +0000 From: Justin He To: Dan Williams Subject: RE: [PATCH v3 5/6] device-dax: use fallback nid when numa_node is invalid Thread-Topic: [PATCH v3 5/6] device-dax: use fallback nid when numa_node is invalid Thread-Index: AQHWVZW+nx78d4gAuUOw9EWfEfkjTKj+macAgAAZ3LA= Date: Thu, 9 Jul 2020 05:13:19 +0000 Message-ID: References: <20200709020629.91671-1-justin.he@arm.com> <20200709020629.91671-6-justin.he@arm.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 569fc01c-900f-4ac6-9a2e-06ed3fe017b2.1 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.112] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4577b139-133a-477c-c348-08d823c6d07f x-ms-traffictypediagnostic: AM7PR08MB5335:|AM6PR08MB2968: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3968;OLM:3968; x-forefront-prvs: 04599F3534 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8Xbtp0259dtbnwCyTYPbOIVhEFoz+RPJOv7cNTnlI3Ff6NCyJBeGnEQj9r8qJEIuGZRM8BljAbbZkv9gvhNAjvCES85YbpE7ezGy/U82BfQm2vYB1MdovrMiugzggiztqeuNBO5ycNKAFOKloPWexdp3NLoZuCdTZ/Z8V7dbTF8xpwBDxwR2vsptRn+H/59sT+CjdW3yxD+BQ3SeNpizverlZ1Uyh6VvYonkgisZfW+ffcDBzdNtlmxUWOpy0W6kHhag9mm4t9NzJ6s/ZfgUcZHcjkUg4KmUhFHqd+z3PU5dsG1lKeWJwIZTQMIZaPHJOElcJ6bFc7Qi0HbysnkOQQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4069.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(376002)(366004)(346002)(136003)(396003)(54906003)(6506007)(26005)(8676002)(83380400001)(6916009)(76116006)(7406005)(7416002)(4326008)(8936002)(66446008)(7696005)(71200400001)(53546011)(478600001)(66946007)(66556008)(66476007)(316002)(64756008)(2906002)(5660300002)(9686003)(33656002)(86362001)(186003)(55016002)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: fkW/kph5UtYTIUPfsMjWGqBZaEYj9emNUlh9LjN0Tgpq3mTQxjGDzJC6w2tjJZP+faSBLrzfpLJCc52N27Njd7rFX/lLFmSUgVInJv+TL3AX2ZuJlEF7Ur9k5uTW89OSfnj6g3+z707uztDSUiGA6JJ7Lkpn0782fA6iZtK3LbGVBgATToe7bKhw2/FUjRoqtjihdK1sAIbM//koG1NF517P+FDLdta8ENbUPzOD49wcB5WNad8kUT/LWPIN4gy8rUj3Aoxal8fis1c7wtY3yiuQqj9FJehKA6HZA5VdOnDQYy+t/FzRz7/ELT96urZ2HlyZ/lXmGq0n5/M5NEcvrKNcoMTA7coOzGg/bwV3BAMQxZcDOkMG1Wr9TrniwVRG6h5rK/wK7YLVJEQg1Zq8EoHX5JmhxHORBkTlEc6ueKjJhM0a5fjSY7GhN2i2diWQ4HnkMoHC7gWS0meFtKTN17ccNOP2fqTidWXGfju3Tlg= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5335 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(346002)(396003)(39860400002)(136003)(376002)(46966005)(5660300002)(26005)(82740400003)(186003)(6506007)(53546011)(83380400001)(356005)(8936002)(336012)(47076004)(81166007)(478600001)(82310400002)(54906003)(7696005)(4326008)(2906002)(33656002)(8676002)(6862004)(70586007)(70206006)(52536014)(86362001)(9686003)(55016002)(36906005)(316002); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: c56af25b-e866-4f30-64fa-08d823c6cbdc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oRPplUDWlgQzLIfw3jttOvUe2uCrwUIaZmM4wM+ys14OOcYoOb3tjE9doJxdcHoDI2Y9rZQQn2jcvJBxycSMw3jvUh9ndaUu5rK6fYosaHNFiVFVlOi+pJbVIZQM7Xl4K2L1bRNS+iHHarMFH7aeLwFID7W2VopTGWoJ7EYqyYv8vNMp18iR64StbreLhp/Y4g7ALNEiePkRd+ZZvo61IxmVWg2XRZgr0l6HunSXifh2PdOfmA8geO1U+NYdwrROlO7Kjx3yMLjdOP35RBhnqpWmdXkV12bs+E4V7ws4/pdUXglGirTiM4OW0fgrHgq/xa/QYquoSzEcMUmbnrhRC6Gkr+K/U4J6bd8pJezeshFLai5hyheUoD0/0P55zXV2UBuA2l1HHAWgdAKMuyq0OQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2020 05:13:28.0816 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4577b139-133a-477c-c348-08d823c6d07f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2968 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_011334_931147_5527560C X-CRM114-Status: GOOD ( 26.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , "linux-ia64@vger.kernel.org" , David Hildenbrand , Peter Zijlstra , Catalin Marinas , Dave Hansen , Linux MM , Michal Hocko , "H. Peter Anvin" , Will Deacon , Dave Jiang , Yoshinori Sato , linux-nvdimm , Linux-sh , Vishal Verma , Masahiro Yamada , X86 ML , Mike Rapoport , Kaly Xin , Ingo Molnar , Fenghua Yu , Chuhong Yuan , Borislav Petkov , Andy Lutomirski , Jonathan Cameron , Thomas Gleixner , Linux ARM , Tony Luck , Baoquan He , Linux Kernel Mailing List , Andrew Morton , Logan Gunthorpe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dan > -----Original Message----- > From: Dan Williams > Sent: Thursday, July 9, 2020 11:39 AM > To: Justin He > Cc: Catalin Marinas ; Will Deacon > ; Tony Luck ; Fenghua Yu > ; Yoshinori Sato ; Rich > Felker ; Dave Hansen ; Andy > Lutomirski ; Peter Zijlstra ; > Thomas Gleixner ; Ingo Molnar ; > Borislav Petkov ; David Hildenbrand ; X86 > ML ; H. Peter Anvin ; Vishal Verma > ; Dave Jiang ; Andrew > Morton ; Baoquan He ; Chuhong > Yuan ; Mike Rapoport ; Logan > Gunthorpe ; Masahiro Yamada ; > Michal Hocko ; Linux ARM kernel@lists.infradead.org>; Linux Kernel Mailing List kernel@vger.kernel.org>; linux-ia64@vger.kernel.org; Linux-sh sh@vger.kernel.org>; linux-nvdimm ; Linux MM > ; Jonathan Cameron ; Kaly > Xin > Subject: Re: [PATCH v3 5/6] device-dax: use fallback nid when numa_node is > invalid > > On Wed, Jul 8, 2020 at 7:07 PM Jia He wrote: > > > > numa_off is set unconditionally at the end of dummy_numa_init(), > > even with a fake numa node. ACPI detects node id as NUMA_NO_NODE(-1) in > > acpi_map_pxm_to_node() because it regards numa_off as turning off the > numa > > node. Hence dev_dax->target_node is NUMA_NO_NODE on arm64 with fake numa. > > > > Without this patch, pmem can't be probed as a RAM device on arm64 if > SRAT table > > isn't present: > > $ndctl create-namespace -fe namespace0.0 --mode=devdax --map=dev -s 1g - > a 64K > > kmem dax0.0: rejecting DAX region [mem 0x240400000-0x2bfffffff] with > invalid node: -1 > > kmem: probe of dax0.0 failed with error -22 > > > > This fixes it by using fallback memory_add_physaddr_to_nid() as nid. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: Jia He > > --- > > drivers/dax/kmem.c | 21 +++++++++++++-------- > > 1 file changed, 13 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c > > index 275aa5f87399..218f66057994 100644 > > --- a/drivers/dax/kmem.c > > +++ b/drivers/dax/kmem.c > > @@ -31,22 +31,23 @@ int dev_dax_kmem_probe(struct device *dev) > > int numa_node; > > int rc; > > > > + /* Hotplug starting at the beginning of the next block: */ > > + kmem_start = ALIGN(res->start, memory_block_size_bytes()); > > + > > /* > > * Ensure good NUMA information for the persistent memory. > > * Without this check, there is a risk that slow memory > > * could be mixed in a node with faster memory, causing > > - * unavoidable performance issues. > > + * unavoidable performance issues. Furthermore, fallback node > > + * id can be used when numa_node is invalid. > > */ > > numa_node = dev_dax->target_node; > > if (numa_node < 0) { > > - dev_warn(dev, "rejecting DAX region %pR with invalid > node: %d\n", > > - res, numa_node); > > - return -EINVAL; > > + numa_node = memory_add_physaddr_to_nid(kmem_start); > > I think this fixup belongs to the core to set a fallback value for > dev_dax->target_node. > > I'm close to having patches to provide a functional > phys_addr_to_target_node() for arm64. Should My this patch(5/6) wait on your new phys_addr_to_target_node() patch? Thanks for the clarification. -- Cheers, Justin (Jia He) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel