From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9B50C04A95 for ; Wed, 28 Sep 2022 08:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OnzknO2rLtCqWksEYzQc3He3snedUW7eo3yi1WclzTE=; b=Crzu5VMpMwQ6bK fH3TLSGdZLqUEqkCP98huqPjewOqV9p3iTZqsxZBj/nXty+cUW9mZtM2qcNRW5hnzkr+2GVBZCaQC A4n4wQJ0jSQzY2GDC7igebdAU6ujl6KSbY1Jn41jnCmAShQrUwKzgBtAKfOR77lESqYRKxptnAChv stzMFk6Lh3GlOwRhkpC2YFL096uV4siEMZlk0oiJ1irAuYJ3N4d9rKUptCXGkGRYZ2fG0U9YoZZPL e6QMEPumXL9b0e9Db6kOioV5EHdJhU4lcfyb+4MvkvW3lCfWKy42N8/e4o51QQ35Dm8mhQukamHPX /Ji8Hi2+ky/L1EkPi3Ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odSUO-00Eu6j-NE; Wed, 28 Sep 2022 08:32:20 +0000 Received: from mail-am6eur05on2081.outbound.protection.outlook.com ([40.107.22.81] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odSUL-00Eu59-81 for linux-arm-kernel@lists.infradead.org; Wed, 28 Sep 2022 08:32:19 +0000 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=JBd6douIl5PM/BQxU+as+7YZ+tGhuohWVFDgLu0P5CpBmvnWoWx33l96neXsPIb8/dCf7mNQeZeUs0kpOSrYcgl6N6f/R51KR9HI+l/v3MiBYCanaKpmRqt7m7RiJhytDKhMtYPzrYsuAdKaEgEg99KwZrgGAKGuSPtxAyYw40s24nSif0Z/bHY9T7IKnK5DPlBq7VGXZrZJJhF83u/1+W/97yRy5lsreZM8Q5vO8lYSmBFin5SjB4Emy4MpVrIC5InUJes9xyeQJBkSQRLjjfsYeC8NOXG3F5mJxkfBlwHv44wGlD1ZlKErZrix/V0buN6slV8o75Jsq7KfHGUsCg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lLmNAV9UVIWJOsUKxpqrYQjU5/MJMCaxXtLsBy32TVQ=; b=lmn4v8gTpgS/twf4EPPH6S/OK7UHwbhf66PKllA6wJ3Ar+qA7WERcEZxDrgtI39bVKfV5BoP70mny+3YIYEnKZOmZ7LjoEXu33VievV3q2LQNosNFIjleljkjW/b7QK1hDa2EkGLYsqxgvuHBE4DzqWcWhComX7jk231RrALhBb0rcX+aoVLcz/l/fBLZJvQiUZVkV9HvOIRC76OOx+4c/xunsd34KDbNCoSBD4E+ROYRNpkJXI/hr/x0UHKWgLfOBetzPkemnw7F/iozUykvAdf9DroudJlHPrEozM/c27k9owvfHlvDBc1H/Mi70kW8Mg1W0EdSzURgfnxb9K2EA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lLmNAV9UVIWJOsUKxpqrYQjU5/MJMCaxXtLsBy32TVQ=; b=QPTdbE87XYNquL+MmeNjzn99kpST7Scco2BBHjaVgLtoTZrJeqbWMrR7uMBkjFRnlMdC8MQ3VRVOTKZpDlliy0wPZYFfG5iPTD9YAmluCw0JdlUE/xnqFJ9pfz9OEVz64cWv/Z7m2t4kr2rGC+2qma4gMLeex+jONHlMjYjRDE4= Received: from AM4PR0501CA0055.eurprd05.prod.outlook.com (2603:10a6:200:68::23) by AS8PR08MB8134.eurprd08.prod.outlook.com (2603:10a6:20b:54f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Wed, 28 Sep 2022 08:32:01 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:68:cafe::a1) by AM4PR0501CA0055.outlook.office365.com (2603:10a6:200:68::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Wed, 28 Sep 2022 08:32:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Wed, 28 Sep 2022 08:32:01 +0000 Received: ("Tessian outbound c2c2da38ad67:v128"); Wed, 28 Sep 2022 08:32:01 +0000 X-CR-MTA-TID: 64aa7808 Received: from 930896290dad.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C747B4F4-DCA2-43ED-8386-E298E63AE711.1; Wed, 28 Sep 2022 08:31:51 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 930896290dad.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 28 Sep 2022 08:31:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LXPbVyWHMwpdG8ZfZaEDO8w8DPL76D2GFDHKtC90VVw4GTfR0rmGRj0eF0FkK6KCfKLCt0Qiwv07Pdfip5R9jhHSQHxgEGgSRBkZWLMLpfEU2jdHftzUkXW/clcKLGrDHWCIie8yEdn3WSW3SIXVTrexMJ4T5Rwe9PXdCu0bhoXW7xyvlzhdAlWRMmj4+W+ldJRBLLv3I4x0ZHOf960ARYiVM/ITHXUVfMpQUuV51MBLRzxu3iQXi5Y5BD8VzjZy2rk0eSiLttFM3K0JD+06w1EIrBiSrp3L5MyH68C03+oh6orhsFjtdvrxjsQRfYKHFPZK+C2f8qokNH5jx/oY8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lLmNAV9UVIWJOsUKxpqrYQjU5/MJMCaxXtLsBy32TVQ=; b=mCwcbwWobY5eQ0unFpI1Tl5krvrmfAK/yqT4RThoJiZLRIA+D5sNJxpAb8P5pQZGuce56lpUyh0a5jO6TnGNg+YbdFIP1c3BegSC1p+AM1uoqldKJKFZVlThugI83afnRmxAEBBBhhrW0AOu35HWQWBIN13hkBR4NHLyZTJZHy/lf9NBAOFresX7Dz9N6+r45qeXGLhyT2TIeE2oks0Oc83KVhNAIon6+sOHYnLbxCwBrPlW2alOWFwelTAESiQ68t/Lcd/q/YBqDTA7/bHw0k55Go2u57m+UmpdUHnqYxxu++Prr1Wv/bvMxd2jvNAyEZOPUGxs/ry0fHJmb2VkzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lLmNAV9UVIWJOsUKxpqrYQjU5/MJMCaxXtLsBy32TVQ=; b=QPTdbE87XYNquL+MmeNjzn99kpST7Scco2BBHjaVgLtoTZrJeqbWMrR7uMBkjFRnlMdC8MQ3VRVOTKZpDlliy0wPZYFfG5iPTD9YAmluCw0JdlUE/xnqFJ9pfz9OEVz64cWv/Z7m2t4kr2rGC+2qma4gMLeex+jONHlMjYjRDE4= Received: from AS2PR08MB8576.eurprd08.prod.outlook.com (2603:10a6:20b:55f::9) by DB8PR08MB5436.eurprd08.prod.outlook.com (2603:10a6:10:111::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Wed, 28 Sep 2022 08:31:47 +0000 Received: from AS2PR08MB8576.eurprd08.prod.outlook.com ([fe80::2851:6fde:6262:5b76]) by AS2PR08MB8576.eurprd08.prod.outlook.com ([fe80::2851:6fde:6262:5b76%3]) with mapi id 15.20.5654.025; Wed, 28 Sep 2022 08:31:47 +0000 From: "Michael Williams (ATG)" To: Will Deacon , Besar Wicaksono CC: Suzuki Poulose , Robin Murphy , Catalin Marinas , Mark Rutland , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , Sudeep Holla , Thanu Rangarajan , "treding@nvidia.com" , "jonathanh@nvidia.com" , "vsethi@nvidia.com" , "mathieu.poirier@linaro.org" , "mike.leach@linaro.org" , "leo.yan@linaro.org" Subject: RE: [PATCH v4 1/2] perf: arm_cspmu: Add support for ARM CoreSight PMU driver Thread-Topic: [PATCH v4 1/2] perf: arm_cspmu: Add support for ARM CoreSight PMU driver Thread-Index: AQHYsAsiCzQrPgyEQ0K9q7o3XCKJDa3rtSeAgAkRkUA= Date: Wed, 28 Sep 2022 08:31:24 +0000 Deferred-Delivery: Wed, 28 Sep 2022 08:31:12 +0000 Message-ID: References: <20220814182351.8861-1-bwicaksono@nvidia.com> <20220814182351.8861-2-bwicaksono@nvidia.com> <20220922135257.GD12095@willie-the-truck> In-Reply-To: <20220922135257.GD12095@willie-the-truck> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C51E2B6074B41B46B1EB7454A261E962.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS2PR08MB8576:EE_|DB8PR08MB5436:EE_|VE1EUR03FT024:EE_|AS8PR08MB8134:EE_ X-MS-Office365-Filtering-Correlation-Id: d8fc601b-0789-499a-44bf-08daa12bea7c x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IFLjUgrPo0/qOhNxazxoy49RICbqvn2mrlrRwrxnFtBoTX5tq155S/shPNTInu366OzWNmoKClL4/cgTN0gMk+yn3yOb/dpf39VLsuZZmpM/mqUqG1XstDn3jNH87wu+g1/HGwdnUKq5xf1tRLfrn06pC23UucrKWuAbKGmFQdEPwZkcHVWxwE9XSne9kW59c6DZFSFN0n4Vo0zjou6+7mYKO8gkUOvIRZwxdi/f8kOKUgTkVSr8U7nI7Bs6SFnCLzYE1IEzEpUJE7PZoMVgZ3R/1tmQS02sP+nBn3iClZ0CdJQ6Thy0nLO4oyNp9IyUIA/0lxOVnkoQJoOguyGFYQe+u2bSy8hzPeGCTYunX02Bc/QwQ9mOpg8u+dIyCBHzspQlC0tpyrC3FHOadq8AuphIy2lVhKLGMvzlFsNiHDBALcKwtOk03H1y/N1JPoEgboZA26hLuSTfH7ccssBE04IezaUo8gNhhBUKHtn3BFL34z2jxY+qERaKgzXsfy9u++BLavF8aZTscgSxMaxjAt1DTf4G5UNl+hPX1xIhWSA7gD63CT+ubSW2NpWO3j6X58h3ADJ9hti59iQu+0D13nduigzFHSRPVXhqnN1uZb2xZzY6yVa1oCBQu8+ilMhN+eopleIjebADseJTiO9DVceaxsJjFRzryztY8rklmsU7OP9gvXRQkF6tny8EqmQRHf1UDB2e5I2l58IDfASqv9oDpZc1icGL3rGN4UXknkXvA5PyY+SGADVCUBt3s5rB8sLUJlOmZbIQdGjeMOv/bg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS2PR08MB8576.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(451199015)(52536014)(86362001)(76116006)(4326008)(8936002)(33656002)(66556008)(7416002)(66946007)(8676002)(64756008)(66476007)(54906003)(38100700002)(316002)(5660300002)(38070700005)(110136005)(122000001)(53546011)(7696005)(6506007)(41300700001)(66446008)(83380400001)(71200400001)(2906002)(9686003)(55016003)(478600001)(6666004)(186003);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5436 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c661b004-2d81-4089-2496-08daa12be1bd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EKkEnm3Qbi/k16ycg5IrjUCz9ujNseY3sjvA5NLEC5Ga8/kjj6U+OmHKCa5z5p/gBSUHkkQyhkBu0697hS/c79/1nfCLnZdrZLTg91PRonGnEZp7xSwuLWLSqHmDGVG/pCLsHzJpvHKFOz+h5x0kGyNe9w0ECV74k6nroGIfIo1DWP0W2Bby6SJYTpwTHptPJdLdcVK89yNV4cuX013/3NSkWXSotxwIkvbuhgKPNTfosDIUtC/8VGH3GibVeE5Lx9Un5+z/2thqRYMktNx7XIGguX8TVbBslQQ3FxNwcdQZLg59Mb2KJrpMzaKIBVPLjaqnjHmbLYsVexIXD4B5tbmkAdxvJRskKRnA1p4F+yuQG+TTASEBpZ8CRweVwmTRop0mV+ZrcPO5Xn1B5JUxGVplDbM9uMWU2eM4o3nwy9KDJ6k39zqEsUaM9LWS3cEzGd/KIKH3drind0thsBtamW8ekvfrBmDtg99ZW3rLkuDi4DLdrT44wrRFpi0WU5YvbHCk90rMwLw9e/PDiQbyTnlDxoQfELZ7b6289WzIaMrLFzvE5S2HswAaQZoYm3Aj57dWxlwStP+H44WE2wyp7pi/2pq/ueKqVbmCksQzI3xfkcpHueo3pcoWy/BtLPIbMWAllKXB/PlzjoedDkglutAEsH3BXa3CEBFzlCja5RM+wfyhF2Id0Bz69SRIy0c+xwLdkhaEPST3HorL0Ed+C/K51idtgoRWmfRW1BAISv+AUDjVRUMzc2C5tPZm489I31OEvhYJqzPKLdVKmHTG+Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(81166007)(33656002)(86362001)(356005)(36860700001)(5660300002)(186003)(40460700003)(41300700001)(336012)(55016003)(40480700001)(26005)(82310400005)(107886003)(53546011)(7696005)(478600001)(6506007)(9686003)(47076005)(6666004)(83380400001)(316002)(4326008)(110136005)(2906002)(54906003)(52536014)(8936002)(70206006)(8676002)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 08:32:01.4774 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8fc601b-0789-499a-44bf-08daa12bea7c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8134 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220928_013217_331860_690FF392 X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, > -----Original Message----- > From: Will Deacon > Sent: 22 September 2022 14:53 > To: Besar Wicaksono > Subject: Re: [PATCH v4 1/2] perf: arm_cspmu: Add support for ARM CoreSight > PMU driver [...] > > +/* Check if PMU supports 64-bit single copy atomic. */ static inline > > +bool supports_64bit_atomics(const struct arm_cspmu *cspmu) { > > + return CHECK_APMT_FLAG(cspmu->apmt_node->flags, ATOMIC, SUPP); } > > Is this just there because the architecture permits it, or are folks > actually hanging these things off 32-bit MMIO buses on arm64 SoCs? The CPU PMU is often exposed on the CoreSight APB bus (32-bit), and although this driver wouldn't normally be used to access that PMU, I wouldn't rule out similar legacy APB and AHB interfaces being used for other PMUs. A further issue is that the CoreSight PMU model includes a number of 32-bit control registers. Since issue H.a there is an alternative 64-bit native PMU interface described in the Arm ARM, which must support 64-bit atomic accesses. You might expect this to also appear in CoreSight PMU at some point soon. That would need some additional updates to this driver because all the registers are now 64 bit, which changes some offsets. Regards, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel