From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF002C433EF for ; Wed, 20 Apr 2022 06:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t3WM79T54Ppn4M7vdQJiqiERBFSJAvlEOzfmCFecTSg=; b=ZyveIxaGGG/p/9 6IqKle5/9S6q6aXStYbz9iUIKNQZZ7j9H/iDWwUAn3zcqHw+pQs+7+J6AvTndrcSceq12aS0+aZFS 2aFFauqcqOgwuo9DWPLQf9zb1nVZfQet3jVu6g785gMk3mlui4kkVw+vRZWEwOaRH7d9rQs+Jeh8F VBze39kUlisvmWvXefT912Wl74aOFXaHjDAzIk+8NiEJxlYClrd+i2sVnSQeo2bR2QQ0gJbs6hl90 PyqEjA4r88UuZReEtyd9NGtdJxBfR763/BU6R0cVRjYV/GS5j+RTP1UypAy9x+fl8zOykW+MWv26o YHvdnstOiYQ11WH2RjWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh3z8-007aMz-PB; Wed, 20 Apr 2022 06:38:43 +0000 Received: from mail-he1eur04on0621.outbound.protection.outlook.com ([2a01:111:f400:fe0d::621] helo=EUR04-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh3z5-007aLE-1F for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2022 06:38:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFBUNVeTPOGpRPKPMTvJZxkTQrxo6CQSxr+HMWZMsY76xoPahxwUrUyngh8+H9xOFIeB889OBKrOIwkgresjoVkfur/LGZcrvUjBCKQ2sS3Z3yfhQyUZsUZA6BxjRIYBG3WU4rQiVWzcE3nrBzkKpmrQ2KEVKHDPuHlqqEXxP5ZGhnCGIcz11PLGqTJx3oRjtszPgYpQtex+7SZQshbLkKnHUGBdfHBQ746FhX752h309TfA3qo9uIy0+zoS6LqxWtHB1megFhOLQC/jS90j0CxpobD/gIoi0erRkRMVJDC179wmRU2hgtYPZLEpfZ2n0F7Ih4tukJY3w7tAYXjBMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IimbG+ABu/1TN+ZiqXF4PAw8ZwtaujZPDLrayL47Qx0=; b=XP5sgNnY0WtoP+f0EzlOcHlnUP5SwM0GM721lw4nk1BIUknbWm7ZQnm6SCjhr0c0YdgRkmWKOcjtkikPul1EdAK0Un/nGyJU9ThlW03Mt5dJkvbpvlJwkhElY8RPbYIkZsoLVL3iCr1GL6vjV69SYppquGLYUQuRNGsHsQCSGiYYT9dWtE4VxQP9j/stDvLPNz21uqOkt5wQfFSFJQ6YPjexML0ls3RZA26ULuxfOxW/gz50FY9q92pISX88uXz/N0MRnNzkn4zUE33Jqeiygzv3CUZlVk533ZS82/YqtKW2Pccp8cgaIXldUzn2TeFXdN89qLeRmChoxW7ug3V76A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IimbG+ABu/1TN+ZiqXF4PAw8ZwtaujZPDLrayL47Qx0=; b=kuQeSioWPmPp+IgY1Kiu1nl2tZPs0qnehyDRHhoInGMy5Fx0/EMTH91oIbyXPxV4Y4RrAe0Q0uirlosAhGuM3h7bYkc+IShulI0yQAETmx/QVCsUI0ij5kZUmP69fYHyCiRacdsKfjGfT92Q3UHJWE7LfdPCWT+X6o95tPJyfHQ= Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by VI1PR04MB5888.eurprd04.prod.outlook.com (2603:10a6:803:ec::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr 2022 06:23:59 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::55a2:d9e8:2c99:1433]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::55a2:d9e8:2c99:1433%4]) with mapi id 15.20.5186.013; Wed, 20 Apr 2022 06:23:59 +0000 From: Sherry Sun To: Michal Simek , "bp@alien8.de" , "mchehab@kernel.org" , "tony.luck@intel.com" , "james.morse@arm.com" , "rric@kernel.org" CC: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx Subject: RE: [PATCH 2/2] EDAC: synopsys: re-enable the interrupts in intr_handler for V3.X Synopsys EDAC DDR Thread-Topic: [PATCH 2/2] EDAC: synopsys: re-enable the interrupts in intr_handler for V3.X Synopsys EDAC DDR Thread-Index: AQHYOrow3JqOaf3SgUSOl308YaQ1c6z4gZEAgAAG8wA= Date: Wed, 20 Apr 2022 06:23:59 +0000 Message-ID: References: <20220318111742.15730-1-sherry.sun@nxp.com> <20220318111742.15730-3-sherry.sun@nxp.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2518284f-e994-4611-69a4-08da22965b31 x-ms-traffictypediagnostic: VI1PR04MB5888:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jrQuIw43tTBkQQR4zJn6dLAiN72v+1rxylK5E139Aw5Z8y01BJ9s9yoRIsYyhoNr5okmTDIpROjm9OJYH0yFvgYYKQnXHBKqz4M2lYL8WMOUe1C3w2FGH8moV//6hcXI8tRYGLBFm+HPiS50npA1OKO7hFsFUFx+Nf60wxCKzBB/8oXvx91AwebB5vY/vnscefnArVxD46pM/uCTtYyj8YZLi2HjASgUF7VLRRrqZmGnuJEZ+CdQ+aLe/wXfSGSOCRMzjzNcy1XEx+fzG/mWxLCvipF+UPx/usb1xTjA6al0EmMB4YIfBM5qkd5PKzbsvZmBJlGQfgEL1UVY5D78YG5Cmay1D/SlmxdrWupSEzODh0JWq2cAmSF+a4dhAc2xE5/Wilw1+yTPXeebsd+TJqdP2rft4gKhLjMFzmEgnp/Qu8ivESAj8lNS8qM9wprHmFnGbsfxRIGA8AF2PQEPPGEIW8JGlvJ3CDd26x776rUDJR7h2m6AOc24XNMLc9ii6UVEPl7n9QhEQmDp8H3eRr7SSHPJn0p4WYW3bKP4mCGSImrraITxwwa6rxPFGqmiWVBvzgQIHRKcsAQsDVS9vTGiBae5JRwTmRHcweXi+jY7mZFxn44CHoduyEg5fhx/Q3CtvXjAfKJedf/icBbl7nEgeG7QBltPc5b+waHQOkMJmCy/vQkfd0TRp5khRZClTrvBhZniBmvpF+T99m8biw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8404.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(54906003)(76116006)(66476007)(86362001)(316002)(38100700002)(64756008)(110136005)(66556008)(66446008)(66946007)(33656002)(8936002)(186003)(55016003)(5660300002)(2906002)(4326008)(6506007)(44832011)(83380400001)(38070700005)(508600001)(52536014)(8676002)(122000001)(71200400001)(7696005)(26005)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QjQvdHlqbEVBb2JtSEJUazNLK0NrWXppbzNtRnNDT0RydERIbjhKME5MeDgz?= =?utf-8?B?QTNaN1psdjNBbU1zdlo1ZU1lYVJjQnlDY0RvTEVOWEZnd2VJVFR5WUREZTJL?= =?utf-8?B?NlhUSW5obGdWZnJ2U1VEdlJDTklEOGdjQnI1MGxHODZEeU1PZmRlWENtLy9x?= =?utf-8?B?UW9RNDBPQ1g1MWpuYlduY2FqQnFDeDlEV2Q2dmM3WXArNCtPb1FaN0JFVkhp?= =?utf-8?B?NTVDbWU5NEhWNCtkcnEzcEVEM0Z2Q0szb3NENUZNTHh0bmc0RzlyZkRscDdw?= =?utf-8?B?VlNyUFJaZ1ZPdUxXeTlFdG9SSEU2d0lzSlNNS0lBdmx2V2VFU1FITUxBOTZo?= =?utf-8?B?WUFyT3NNTFFoU2o0RXM1b3dKUkFxb0FXdmhpa0kwTnF2a28rOXpjZUw3d1ZS?= =?utf-8?B?RDV1UXovMFFEOUs5ZzZWRDV3ajJjcEtZcUhwVDU1VDFBVng5enhoRDdvdjJk?= =?utf-8?B?REdqWmMrM1JlU3lxL09WNldlTml3MGx6MkFWV21LQXZXV2xFdU80d25TemVW?= =?utf-8?B?cXZNN0FFOWR5ek9NdTFuT2I0ZFhaVm9maW9uY012S2MvNjkzNEE4b1FNOElp?= =?utf-8?B?Y1FkNlBUK1h4Z2hYVHo3akdJTUxGZFU5TkxhNnFRYnZTWGFVN0s1dVZZdmhq?= =?utf-8?B?cmNoM1IyS2tOMCtZMmdIWlVPUDZ3MzNBUDFUTkZ0aFNOYzN0Q2t6MlZNMVI3?= =?utf-8?B?L0JZNEI4SDlzUEpmeU9Kc2pOa09LbUFIY2g5S2MvN2VQSDJSVG5wSEdLYWtK?= =?utf-8?B?ZVdManpPdXlDem1QNzAyaXM5WFFLRVgycERVZEgvV3ZZT0k2TG1vRTZHZ09P?= =?utf-8?B?d2w2MHVYRzBZU0tQWWZTNGtyMDZSdXZsUi9PVmk4UHlIWVgrZHgrWWoxWHJ2?= =?utf-8?B?c0wrQ3UyTnVwdEJacUhCbjBkMXNnZVliRVJ3Ry8yRzRvR05rT1E2KzhhQUZL?= =?utf-8?B?OGc0V3ZkSWNQUDVBZTZFSU9CM2VsU000d0VsQUpEMmpMSTNrb0g5YjlpMkJp?= =?utf-8?B?c2VORWJRT0M4L3JFOVpaeXR1L2EwQTdGZ3M3Qy9Xb2hkbURkZ2pDRlRhUFRj?= =?utf-8?B?ckdCcnNHZHV5dWh6dUkza2lHNE4vZXp2TDRYN3d5L2ZZdjZONG5RYmdWWURO?= =?utf-8?B?aFNxajNCVlloc0M0SDRPYVY2akRqaU10YlJ5ckc2STdCOHhERjRNbGgwREJ2?= =?utf-8?B?ODlIOXRpWlIyaEp0VjY5U3JKQTZyM0QwdDV2YU5XbHdNRXg5K0lNRno4VjY2?= =?utf-8?B?L2JxTHZaZGpGYk9YendNcUk5QlJyRGM2TjAySmJSTWFvaXJ4V1hZV2x5bWkx?= =?utf-8?B?Z1FvalJ5TCtBSEFKSk5DbjdlN1phdTlyZkVZdDhrMWEwWmt4NzIyV2sxbXBq?= =?utf-8?B?STlBZ1JQY1Z4NENYSHE0bEt2TkFsalFsNnZjL0hpZFc0ZnlTZnpuM0lITVh0?= =?utf-8?B?U204K2N4R1ZFTkQ1cUsxMmRFMGF0NTMySFRta0lMaG1MR3FNRlVIMGJzSVY3?= =?utf-8?B?QUpEVUxDYVgzR0crTU84cWtBb3NxaWo4WUlDdHFhZnFaZGpSekNuWnpkdm45?= =?utf-8?B?VCsxWHp0Vkx1ZUFUN1ljNEh5VkVrcDB1WWdKb2gwam01aFNReGNVNkZKY01V?= =?utf-8?B?SHhvdjFFT0U5VVowOXRZcTd1SHlrT2V4ZWM4RUMzaGdVa0JWRGY3bVNWVFkr?= =?utf-8?B?NVMxRTZrSG1pOFBIbHk4RENPRldrSDJCQ2M0MUtCbzBETUtlNVEvN3g2ZzlQ?= =?utf-8?B?dkpYbUhmQktnS0JKR3FWeUJkdGlibnJoR0ZYRFBKK1BJZWU2M2dKNW1rckN6?= =?utf-8?B?RUhLUDU1bURIR0o1OFkzR1l2YUtsS05nbFkrWkZUTlcrQlUybzVHajZXSWF5?= =?utf-8?B?dE1aRWk2MWVMTnMvTkY2VWU5SXFac0h1ZzZVZnkrSnF6MUU1VzZXOWQ3eDE2?= =?utf-8?B?TzZraldZWVZRYTZJNG9VNHhYYjYrL0ZlK0RhbWQ4MEFPUE1QRHpFMVZaL3Ri?= =?utf-8?B?YXdtaThiSzk5aXdqaUpIVXpzaHFMSUJ2c2l4YW81Q1ZYUE1RUHdkd0l6dzJq?= =?utf-8?B?aGlVc25zVnI3VEdURlcyWEZzR3FZK3d5V3l6WCsxSk8wdEpMT2RMTE5TZnJ5?= =?utf-8?B?cmU3VTVnUlVOR1A4NGZnallyVkdZSmVFZkZRNk1aekw2cHJPdjE2ejNnMkl6?= =?utf-8?B?M1o0Z0RQZXZ6RCtIQ0JiYW12N2ZmcHZFTnpONkF5MlVTUlNFTEVNMk41a044?= =?utf-8?B?UjZGdWpBSGFiem5zMTZLQk1SMEhqVmpRdkdqYllOc3o1MHBrYkU1Qi9veGhF?= =?utf-8?B?VTZhM1VVZkpPWUdDRVAyRjZoQ3o4RmlMYlZVOXhVUkNOakJReXByUT09?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2518284f-e994-4611-69a4-08da22965b31 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 06:23:59.6594 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j4dI3X7kDCX7MVjwuM9ZL8ovbtVHlZDvC3tjfGM4hKiNGtbetkjErMZy5cNk/Qm9a82KTGKvUmnuPd+icRZkug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5888 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_233839_090752_9D5A4F5C X-CRM114-Status: GOOD ( 21.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > Since zynqmp_get_error_info() is called during CE/UE interrupt, at the > > end of zynqmp_get_error_info(), it wirtes 0 to ECC_CLR_OFST, which cause > > the CE/UE interrupts of V3.X Synopsys EDAC DDR been disabled, then the > > interrupt handler will be called only once, so need to re-enable the > > interrupts at the end of intr_handler for V3.X Synopsys EDAC DDR. > > > > Signed-off-by: Sherry Sun > > --- > > drivers/edac/synopsys_edac.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c > > index 1b630f0be119..3a1db34a8546 100644 > > --- a/drivers/edac/synopsys_edac.c > > +++ b/drivers/edac/synopsys_edac.c > > @@ -521,6 +521,8 @@ static void handle_error(struct mem_ctl_info *mci, > struct synps_ecc_status *p) > > memset(p, 0, sizeof(*p)); > > } > > > > +static void enable_intr(struct synps_edac_priv *priv); > > + > > /** > > * intr_handler - Interrupt Handler for ECC interrupts. > > * @irq: IRQ number. > > @@ -562,6 +564,8 @@ static irqreturn_t intr_handler(int irq, void *dev_id) > > /* v3.0 of the controller does not have this register */ > > if (!(priv->p_data->quirks & DDR_ECC_INTR_SELF_CLEAR)) > > writel(regval, priv->baseaddr + DDR_QOS_IRQ_STAT_OFST); > > + else > > + enable_intr(priv); > > nit: newline here would be good. Hi Michal, thanks for your comments, I will add the newline here in V2. Best regards Sherry > > > return IRQ_HANDLED; > > } > > > > Acked-by: Michal Simek > > Thanks, > Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel