From: Kuldeep Singh <kuldeep.singh@nxp.com>
To: Leo Li <leoyang.li@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Oleksij Rempel <linux@rempel-privat.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI flash
Date: Mon, 4 Oct 2021 05:53:45 +0000 [thread overview]
Message-ID: <AS8PR04MB867338457BEBF8BB91163420E0AE9@AS8PR04MB8673.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CADRPPNTKsO7MYoUUXLgC+XnPPsrzjeBggvRnKvaB=3HUJy9-1A@mail.gmail.com>
> -----Original Message-----
> From: Li Yang <leoyang.li@nxp.com>
> Sent: Saturday, October 2, 2021 1:38 AM
> To: Kuldeep Singh <kuldeep.singh@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>; Rob Herring <robh+dt@kernel.org>;
> devicetree@vger.kernel.org; Oleksij Rempel <linux@rempel-privat.de>; linux-
> arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for
> QSPI flash
>
> Caution: EXT Email
>
> On Fri, Oct 1, 2021 at 12:30 AM Kuldeep Singh <kuldeep.singh@nxp.com>
> wrote:
> >
> > Hi Leo,
> >
> > > -----Original Message-----
> > > From: Li Yang <leoyang.li@nxp.com>
> > > Sent: Friday, October 1, 2021 5:34 AM
> > > To: Shawn Guo <shawnguo@kernel.org>; Rob Herring
> > > <robh+dt@kernel.org>; devicetree@vger.kernel.org; Oleksij Rempel
> > > <linux@rempel-privat.de>; linux-arm-kernel@lists.infradead.org;
> > > linux- kernel@vger.kernel.org
> > > Cc: Leo Li <leoyang.li@nxp.com>
> > > Subject: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for
> > > QSPI flash
> > >
> > > Caution: EXT Email
> > >
> > > Add the missing node for qspi flash.
> > >
> > > Signed-off-by: Li Yang <leoyang.li@nxp.com>
> > > ---
> > > arch/arm/boot/dts/ls1021a-qds.dts | 15 +++++++++++++++
> > > 1 file changed, 15 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts
> > > b/arch/arm/boot/dts/ls1021a-qds.dts
> > > index e2aa569ff404..522e1dc51059 100644
> > > --- a/arch/arm/boot/dts/ls1021a-qds.dts
> > > +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> > > @@ -286,6 +286,21 @@ tbi0: tbi-phy@8 {
> > > };
> > > };
> > >
> > > +&qspi {
> > > + num-cs = <2>;
> >
> > Please drop "num-cs" property as it is not used by qspi driver.
> >
> > > + status = "okay";
> > > +
> > > + qflash0: flash@0 {
> >
> > Can we have flash chip name instead of qflash?
> > There is no hard requirement, it will help in aligning node properties with
> other board properties such as LX2160A-RDB, LS1046A-RDB etc.
>
> Thanks for the review. I find that there is no reference to the label at all. I
> don't know why we added it in the first place. Probably we can just remove it?
I believe yes, though I haven't checked it but I think it's safe to remove label and keep only flash@0.
Regards
Kuldeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-04 5:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 0:04 [PATCH v2 00/16] Cleanup of LS1021a device trees Li Yang
2021-10-01 0:04 ` [PATCH v2 01/16] dt-bindings: arm: fsl: add ls1021a-tsn board Li Yang
2021-10-01 0:04 ` [PATCH v2 02/16] dt-bindings: i2c: imx: update schema to align with original txt binding Li Yang
2021-10-01 13:16 ` Rob Herring
2021-10-01 13:23 ` Rob Herring
2021-10-01 17:37 ` Li Yang
2021-10-08 22:20 ` Rob Herring
2021-10-09 3:08 ` Li Yang
2021-10-01 0:04 ` [PATCH v2 03/16] ARM: dts: ls1021a: change to use SPDX identifiers Li Yang
2021-10-01 0:04 ` [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI flash Li Yang
2021-10-01 5:24 ` [EXT] " Kuldeep Singh
2021-10-01 20:08 ` Li Yang
2021-10-04 5:53 ` Kuldeep Singh [this message]
2021-10-01 0:04 ` [PATCH v2 05/16] ARM: dts: ls1021a: update pcie nodes for dt-schema check Li Yang
2021-10-01 0:04 ` [PATCH v2 06/16] ARM: dts: ls1021a: fix board compatible to follow binding schema Li Yang
2021-10-01 0:04 ` [PATCH v2 07/16] ARM: dts: ls1021a: breakup long values in thermal node Li Yang
2021-10-01 0:04 ` [PATCH v2 08/16] ARM: dts: ls1021a: disable ifc node by default Li Yang
2021-10-01 0:04 ` [PATCH v2 09/16] ARM: dts: ls1021a: remove regulators simple-bus Li Yang
2021-10-01 0:04 ` [PATCH v2 10/16] ARM: dts: ls1021a: fix memory node for schema check Li Yang
2021-10-01 0:04 ` [PATCH v2 11/16] ARM: dts: ls1021a: add #dma-cells to qdma node Li Yang
2021-10-01 0:04 ` [PATCH v2 12/16] ARM: dts: ls1021a: add #power-domain-cells for power-controller node Li Yang
2021-10-01 0:04 ` [PATCH v2 13/16] ARM: dts: ls1021a-qds: change fpga to simple-mfd device Li Yang
2021-10-01 0:04 ` [PATCH v2 14/16] ARM: dts: ls1021a-tsn: remove undocumented property "position" from mma8452 node Li Yang
2021-10-01 0:04 ` [PATCH v2 15/16] ARM: dts: ls1021a: move thermal-zones node out of soc/ Li Yang
2021-10-01 0:04 ` [PATCH v2 16/16] ARM: dts: ls1021a-tsn: use generic "jedec, spi-nor" compatible for flash Li Yang
2021-10-01 5:14 ` [EXT] [PATCH v2 16/16] ARM: dts: ls1021a-tsn: use generic "jedec,spi-nor" " Kuldeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR04MB867338457BEBF8BB91163420E0AE9@AS8PR04MB8673.eurprd04.prod.outlook.com \
--to=kuldeep.singh@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).