From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F447C433F5 for ; Tue, 19 Oct 2021 07:34:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34B2761264 for ; Tue, 19 Oct 2021 07:34:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 34B2761264 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nUPbtjTxs01IV59VRuJWFuTxOAqUPuOk5IouW1nH1iI=; b=GWnnBn2FnBvOxh RWDKtY1EtI7X+4pRERuoaO40aAa2ikCwAKnjSZc565LBGQROym1GNw+07RmtoJ2jz9kNdFWr0ktb6 CPabnaTtng6lRNhIQMKbvnzPVsadWTBY32BVznWQ+Bg04e5LpP9fQTOC5NBAb8lIUrVyfhyJeIkt5 lLe7hegTnB7UH/e2EgGceDZWjhLXNmzNmdnvzzzqtfinz4e1nu9R3iE9GoTorKYV8dANa6T0A1YCb HWVLBe1s3XkLlA6byyAn7eku+BIVGoURz2JcCDoT7DEVdfPNOlwTE1XbFmQc0D+H/cvOHqlSiNIci fbmlAayiON+EHlbig5oQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcjcO-000Pl6-WF; Tue, 19 Oct 2021 07:33:05 +0000 Received: from mail-db8eur05on2061.outbound.protection.outlook.com ([40.107.20.61] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcjcK-000Pjy-ND for linux-arm-kernel@lists.infradead.org; Tue, 19 Oct 2021 07:33:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HOHNpK/+N/sFf+1wRNgK/rntN9j7TCRkDLsX78ZrPw9Qq5CWiDZati1hl3fWh9rsOkt1w7JRJ3Jkw7pt2P4NQd6L9XahFp6u6eQt4fIgyKSUSZGzuJA287lb/LYCbzhMavDoDZApptnVR0i+8PBqDu++ie+vFzxbFr82uK6E6XanGpg7SMrEWRZZ1wVBnuGvMp+mysIkRvHmtBiIOe9P+lNvpFwENMTs9bl+2Cw0KrVvCoUVNzxjnA7srm27RhP3NLLsRtvLpURkezVSlDUoSZ/WNF6hZTsdaL2Cuhs4gGgSNhMZuJcbTwMZi+e4OEFDM45i1mRyN+YQfLPbLUl9Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=alg8bTvIpAAizR4bBPSNVZqwS1F9jF3VNh8rEU7yCfA=; b=SHj0oiXrNe1E7bghwydR8I7wfh65rkZlbwIKTWV4LLYeVBrgM1GjiS8mvv13VCBL5LPsK79PblMzB/l1n1EZFVGkO94lPu9wd/YEU8BJ+U/uApVBgItUFDVCYKMmMo0/tHmOFMAXqnqNh93KFJPLWmr7EGk/Ws7Bx2RBGq1YnE1XEvnIhEdnkzS2tB326sBtDQAj0tophBaD9/qBPQ30RgipgEvUERWgtNsqp3WLaowngea8Vwuk4uByBoODiPvVepOYY87HNGccgvaV3zOS5Oom02VqB7ykbNA+i0yT+eNcjXHGczC7KkJBLPTrqzppczUVZcUw3J6KZxB3IwHu5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=alg8bTvIpAAizR4bBPSNVZqwS1F9jF3VNh8rEU7yCfA=; b=OtAqA8irtEonlxqos63VGf1RfhxJ+OvCFqZ61yfoUH25SMW1BIgkGuVPCp0YHA9gI7z4zk8XK46CwDaT/C9lcN9DBPQJBH2NWAyv3iXLU0KD0p8gpSubbSPDSdn34Xpmda8DgUbCMDbHV5R7aRWRcdd5UHmXEuwMBvlmvk3Z0bg= Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by AS8PR04MB8882.eurprd04.prod.outlook.com (2603:10a6:20b:42d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct 2021 07:32:55 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::b059:46c6:685b:e0fc]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::b059:46c6:685b:e0fc%4]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 07:32:55 +0000 From: Richard Zhu To: Lucas Stach , "bhelgaas@google.com" , "lorenzo.pieralisi@arm.com" CC: "linux-pci@vger.kernel.org" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: RE: [RESEND v2 1/5] PCI: imx6: Encapsulate the clock enable into one standalone function Thread-Topic: [RESEND v2 1/5] PCI: imx6: Encapsulate the clock enable into one standalone function Thread-Index: AQHXwY4s6kZeP+E3uEGrVnpQc2fDkqvUXbIAgAWWIQA= Date: Tue, 19 Oct 2021 07:32:55 +0000 Message-ID: References: <1634277941-6672-1-git-send-email-hongxing.zhu@nxp.com> <1634277941-6672-2-git-send-email-hongxing.zhu@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e4313ebf-89cb-4c10-1f7c-08d992d2aacf x-ms-traffictypediagnostic: AS8PR04MB8882: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2331; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5sJi4GNeB1r5QkE9uGGC/DyelturoClOotDJgltQYnbNR/+caOym6NhQ0t++9xrOtAnVhxVuB9VJ1MJhPrOCrrvj8CoBHMQEv0NH0diail7sdKoLzAuNOTcoO/GMdthbKSmhY8SB+4mXRm8uTeM8UPSxZnC6jXq/+vIS9KI1Gztd2OeR0msk1I0XR7rZRKzfh+HHxSVCu6ZVu13a1e7ShUeJeThXXMCi/zGgOgBqkfpRyMumDwniJjo4kCFdjZzDrr2YqbKLNkG9HX+gXdHfJGmlQF9ZuYXiTaCawRrBiAr9y8tHSEmnPwE7TdrrbURUlDhMDHYWAwsFmqidduSePPDIeGbbjDd5ZK9vI7H/smvo1n3JhDfHVqyQAocyTct2zzLjr07ebOomPNZDU83TKA49jQSOGjiGpEZ5flv5w+B1P1YVNjaLWOsAVsbTg7HRWOxifJxZ1OD8chmNvDvXqzMlAUCXzuTNi87GtqAK6oV6D5ld3neZ5UiIvNk2cItaucQpk/w/TtGsXvVJvXFYNMOyGXRpXCAZVCLukGiqUqDssX6ijqjto2BqJTBAZfa1ZMtF6MzJl5ZaVPfInUOaMs+VH6y+Kxa2gVkhlYwRzqfQXjb2S0X0Ycb74tOTZY8nxeSHeOMyJs/7p8C46laUAmL4dEBaLsccabxMFMXpuP4fvAA9SV5yW7ulH0EQNW+BLJ1NCWHIocEV5iyqCavAog== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8676.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(52536014)(86362001)(2906002)(122000001)(33656002)(76116006)(508600001)(9686003)(6506007)(8676002)(66556008)(26005)(53546011)(110136005)(5660300002)(316002)(83380400001)(66946007)(54906003)(64756008)(66446008)(66476007)(38100700002)(38070700005)(55016002)(8936002)(7696005)(4326008)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bURMYVhXRGdjZmlTSlUvU2s0Y1dhaXIvM3pDdE82eGhSMkFlUHAzd1VmQXhD?= =?utf-8?B?V1pwT3JTTWRSTmJiRk5NcHdBZHg2elQwVGRRaWdDTGNncnoxZmYwQVJoejFN?= =?utf-8?B?TzlKS1Zvdy9IeXVrMFIrWGY4OEhRV1drNEpaZk9HNzhHVnJXdHNCVndaMG1M?= =?utf-8?B?M21Yakk5R1l6SlNNck5DVHhBMnlpVlRkbVk2N3RDYWhncnNGR3Vhd3o3d3Ir?= =?utf-8?B?YTdhblA5Q0JzU3VRL21Xa1RVNUlHZ1FVYW90cmowRGV4SU4yN2pqZ2M1Mzd3?= =?utf-8?B?U1kxQy85dElYN2wzeE40eXkrVSs1YlJ4cDhrYjNtOHRLOTN1TjRySGVvemxu?= =?utf-8?B?U3BCK3RZT2ZVNk1ZMDVDR1BKYlNOcDFmdzVJV2NOZUsvWVZCSkd4TXpLQ2s0?= =?utf-8?B?NStuMFNZMzRNanl1eTM3eHd0OUZ6Ly84Zkt0ZEpzekdOR0Z0UWtJWXFZeUNy?= =?utf-8?B?VmM5dVZkUVFIL1hLYjR5bGlSYTRvUVIyOHp6bjJTKzJmdEJyWDFxcmdnNzda?= =?utf-8?B?WkEzSllKWkhneXlOTURtck0wWE16ay9HNEo2VUhnaDBYbEoyM2luSW93Z2RH?= =?utf-8?B?Z2crYWF4RXgzVTY1UklmOXVSWTRDZmgrWHRGdHFGWVlxSVZ4T01BaXVsdmtt?= =?utf-8?B?MkgyRktVRTFvUzFOL0ttMXpETk9YbUNBaEFmeTFqUEp4MUhnT3l2WUVEYmYy?= =?utf-8?B?a29EQ3pNZEpLaktneFdFd1hEN1ZqY1ZpWGx3Qi91WFRFb0NBMjFsdjZBd1F6?= =?utf-8?B?MlRjYmNRVEg0cDhiUmZhQ3VwMXUrbU1OYWUrTzF4RCtHSThySDhvZEV4VEow?= =?utf-8?B?andCNzR4SzRrb3lIcjk4MDRtTGIvUzRpTk9kTmlxd0YvZ1BmclFYajVLMC93?= =?utf-8?B?cmptKytTSDN1M2pVN0l6aHF1TXI1T0FZNmZYM0lzUnNzYWVhMWN4Y2dvdFJr?= =?utf-8?B?ZnNOUzNUWXNMN1lSbE1Dam5uUlJheEhhOGx2RHVZWitMZlpRRTdrVG1tdnk3?= =?utf-8?B?RE5ZR2JKTnZWNnhwODJwVURIbXZ0SWdweFlLckdnQ3BtYmxxbDMvQ29BcFdu?= =?utf-8?B?MzQ1bWxZdGMweThmNERFNXJkbzBnL2F4OThadUR3NVgyTE9XVC9FbWNXbGts?= =?utf-8?B?M0E1Y2JrczJIVi9JYXg2ZjlldVBhOFpwMzNUV3BkSXVMVHhjaXI0ck1keDZs?= =?utf-8?B?L3JQdW1EYW1xMlJVa2IvbmNrQjFmYXJnVHJSZlFVMUVya2ErcGxHT25TL2Zp?= =?utf-8?B?TG5mMHZGQjZRazVaQjFtbFViUDU0a0xyL29zSEk4ZmZKRjVOYVl2clNFYTNC?= =?utf-8?B?L00zVEJQb1pkWHFORmswRmQvTnlQcWRTRWRHNWhrSjNVd3V0RHBKY3JjMWhw?= =?utf-8?B?bjN2dlp3aGF2RVNxeGhqUFhDSmlWNDJFeUZIUndKRTFyckNoREhqeVZCR2lM?= =?utf-8?B?aFFDV3NmRm4yWEdYUnJEUTdidjh6NVZGeVdxeTYxNlRhbzBtNUVvamdpV1BQ?= =?utf-8?B?RmRDbEh4NjZMcW9sY1IyTE10aDZkWDliam9acE1WSlRrcy9iWS8xU0ZBRG1M?= =?utf-8?B?VjhWZkJBMlIrdFB1Y1pRWWJGL0FRcDBYTGNraEtBZHN0ekVkUmJMaCswVVdt?= =?utf-8?B?U0M4RWxndW04ZlRBU09nMFc1ZGZEM0lZVjc1NjljTTFYcHQvMVY0cThqRVQ3?= =?utf-8?B?REVXQlZmUGJPWDg1M00zUUprWjVpeEF2YmgwZkFXOFh6bHJzUU14QXBjRG9L?= =?utf-8?Q?1aCn6uzqE73OMaw+i8iRdijhGTw3qzQ7F2IAUKK?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4313ebf-89cb-4c10-1f7c-08d992d2aacf X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 07:32:55.5188 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fiu4xH1rhyaWf5mFj6aqDeLBt/Cx6f6Vl+nCI8vvNMChRVJi96QQyeGLcdi/YBmq+cTtov8c2fkxsVV8nht72g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8882 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_003300_792378_A57AD6F6 X-CRM114-Status: GOOD ( 24.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Lucas Stach > Sent: Saturday, October 16, 2021 2:14 AM > To: Richard Zhu ; bhelgaas@google.com; > lorenzo.pieralisi@arm.com > Cc: linux-pci@vger.kernel.org; dl-linux-imx ; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > kernel@pengutronix.de > Subject: Re: [RESEND v2 1/5] PCI: imx6: Encapsulate the clock enable into > one standalone function > > Am Freitag, dem 15.10.2021 um 14:05 +0800 schrieb Richard Zhu: > > No function changes, just encapsulate the i.MX PCIe clocks enable > > operations into one standalone function > > > > Signed-off-by: Richard Zhu > > Reviewed-by: Lucas Stach > [Richard Zhu] Thanks. Best Regards Richard Zhu > > --- > > drivers/pci/controller/dwc/pci-imx6.c | 79 > > ++++++++++++++++----------- > > 1 file changed, 48 insertions(+), 31 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c > > b/drivers/pci/controller/dwc/pci-imx6.c > > index 26f49f797b0f..1fa1dba6da81 100644 > > --- a/drivers/pci/controller/dwc/pci-imx6.c > > +++ b/drivers/pci/controller/dwc/pci-imx6.c > > @@ -470,38 +470,16 @@ static int imx6_pcie_enable_ref_clk(struct > imx6_pcie *imx6_pcie) > > return ret; > > } > > > > -static void imx7d_pcie_wait_for_phy_pll_lock(struct imx6_pcie > > *imx6_pcie) -{ > > - u32 val; > > - struct device *dev = imx6_pcie->pci->dev; > > - > > - if (regmap_read_poll_timeout(imx6_pcie->iomuxc_gpr, > > - IOMUXC_GPR22, val, > > - val & IMX7D_GPR22_PCIE_PHY_PLL_LOCKED, > > - PHY_PLL_LOCK_WAIT_USLEEP_MAX, > > - PHY_PLL_LOCK_WAIT_TIMEOUT)) > > - dev_err(dev, "PCIe PLL lock timeout\n"); > > -} > > - > > -static void imx6_pcie_deassert_core_reset(struct imx6_pcie > > *imx6_pcie) > > +static int imx6_pcie_clk_enable(struct imx6_pcie *imx6_pcie) > > { > > struct dw_pcie *pci = imx6_pcie->pci; > > struct device *dev = pci->dev; > > int ret; > > > > - if (imx6_pcie->vpcie && !regulator_is_enabled(imx6_pcie->vpcie)) { > > - ret = regulator_enable(imx6_pcie->vpcie); > > - if (ret) { > > - dev_err(dev, "failed to enable vpcie regulator: %d\n", > > - ret); > > - return; > > - } > > - } > > - > > ret = clk_prepare_enable(imx6_pcie->pcie_phy); > > if (ret) { > > dev_err(dev, "unable to enable pcie_phy clock\n"); > > - goto err_pcie_phy; > > + return ret; > > } > > > > ret = clk_prepare_enable(imx6_pcie->pcie_bus); > > @@ -524,6 +502,51 @@ static void imx6_pcie_deassert_core_reset(struct > > imx6_pcie *imx6_pcie) > > > > /* allow the clocks to stabilize */ > > usleep_range(200, 500); > > + return 0; > > + > > +err_ref_clk: > > + clk_disable_unprepare(imx6_pcie->pcie); > > +err_pcie: > > + clk_disable_unprepare(imx6_pcie->pcie_bus); > > +err_pcie_bus: > > + clk_disable_unprepare(imx6_pcie->pcie_phy); > > + > > + return ret; > > +} > > + > > +static void imx7d_pcie_wait_for_phy_pll_lock(struct imx6_pcie > > +*imx6_pcie) { > > + u32 val; > > + struct device *dev = imx6_pcie->pci->dev; > > + > > + if (regmap_read_poll_timeout(imx6_pcie->iomuxc_gpr, > > + IOMUXC_GPR22, val, > > + val & IMX7D_GPR22_PCIE_PHY_PLL_LOCKED, > > + PHY_PLL_LOCK_WAIT_USLEEP_MAX, > > + PHY_PLL_LOCK_WAIT_TIMEOUT)) > > + dev_err(dev, "PCIe PLL lock timeout\n"); } > > + > > +static void imx6_pcie_deassert_core_reset(struct imx6_pcie > > +*imx6_pcie) { > > + struct dw_pcie *pci = imx6_pcie->pci; > > + struct device *dev = pci->dev; > > + int ret; > > + > > + if (imx6_pcie->vpcie && !regulator_is_enabled(imx6_pcie->vpcie)) { > > + ret = regulator_enable(imx6_pcie->vpcie); > > + if (ret) { > > + dev_err(dev, "failed to enable vpcie regulator: %d\n", > > + ret); > > + return; > > + } > > + } > > + > > + ret = imx6_pcie_clk_enable(imx6_pcie); > > + if (ret) { > > + dev_err(dev, "unable to enable pcie clocks\n"); > > + goto err_clks; > > + } > > > > /* Some boards don't have PCIe reset GPIO. */ > > if (gpio_is_valid(imx6_pcie->reset_gpio)) { @@ -578,13 +601,7 @@ > > static void imx6_pcie_deassert_core_reset(struct imx6_pcie *imx6_pcie) > > > > return; > > > > -err_ref_clk: > > - clk_disable_unprepare(imx6_pcie->pcie); > > -err_pcie: > > - clk_disable_unprepare(imx6_pcie->pcie_bus); > > -err_pcie_bus: > > - clk_disable_unprepare(imx6_pcie->pcie_phy); > > -err_pcie_phy: > > +err_clks: > > if (imx6_pcie->vpcie && regulator_is_enabled(imx6_pcie->vpcie) > 0) { > > ret = regulator_disable(imx6_pcie->vpcie); > > if (ret) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel