From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65730C433F5 for ; Wed, 20 Oct 2021 03:24:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F1B9611B0 for ; Wed, 20 Oct 2021 03:24:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1F1B9611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DyzMQTnDGic+hYow0ZQ2oWbvBPOARK7LE6Z9pewHr4E=; b=fhQd2/tr1jfynu HG8fB/N5x0BzdamlOCr45Qe/d9VB7hseAr4AeFBCZkuFUEEMP3i8LvB4ko/+aFyKfnQxYxTiGAdSG Jk5jbY0WtFajk/30FY3nT3EfDvFdCatQ02jR32zVcGVHe8yz4t/rhpaCiqKmhWfAa4TLlq0+sbYXF MQVfBsw6KLZDqFjCLAnYPJIHvQMyijySj9UK+To0DTLmzUPlKTEJQgQu20Tw9QOMhokPk3QZJSmA/ k7lqOm0caA0w0JHKukddMhtyZ4jZJb4FyJcuEvwuA44QldH5eOzDkJsLNuHZK7PsgOvuM97jj4JaW 2sqtuTf0P6u9xHBc4Gjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1md2BZ-003JAg-8Y; Wed, 20 Oct 2021 03:22:37 +0000 Received: from mail-eopbgr80079.outbound.protection.outlook.com ([40.107.8.79] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1md2BU-003J9a-4u for linux-arm-kernel@lists.infradead.org; Wed, 20 Oct 2021 03:22:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ciat/dZFr6gA64Z6p5jC6yRl3Ck1XdBSNzUXXS+IrLhW+NDf9QUHJmWehomRhtSzEdRqz3/wj63dRsocrEPe9+wRqDr8qLcn/KCXkw7Ls2gfG9W2Q4rwxd0/w1P0c49ihyh4kqYYiH5bqJR7vt5CzShC2w77tl9iLkeNTT+KKUuy4K6tsigS8kWhCYWB8Rds0WFDdB0JzMnL/tjC6qO0dDoc6I+HL5K/cMDoc5VkPXqhbpzZc4A7mkbl9CjP6aA8dgmgGjDYY1gt23/xUXr6wf8QisHwQZ4ABVhMbHiwPSxKdOtdPI0Qkmi7gWcM7AlNH89UcbnE0++HEFzd2h4OUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Kwqk8KyLExSgEuRlta7PWwX9K7PRjtulaOfk+ltPxg=; b=B7tOnHSv8wJqDnXo1N+l9iDiTUEnspLDMFFX7aA+F5hVkWy6F59WNncdq/zXxuXv1emMeGBkyD8ldR7fjduWxEMYvktp+2VgvOEtAAaQMZofZwAsOFJxu7GtE2OqtF+C1zVd+otkj597lbLjkWGakakdEhcmDojOi0TaidO9cSAkxryNnc4AC8evlWjW7KkCLGnSO/td85M3q0I7/F244HEpLkDldYyq2AA1glnl2gtXUdmWGFXUMK1MJohfPzPEdsg/US7sN5T8mY1YR/tJU5Ouu5NrCbylk5tKUnYswyxHWJKy2TnsC4cNLVfD/OEUFpp3TIjq0mvRdSxzFeVqXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Kwqk8KyLExSgEuRlta7PWwX9K7PRjtulaOfk+ltPxg=; b=cMzOGnndeeOd/Sah4Jt6gtg+d9Y0MKNAzvMvjL5ofCvHMoyc3pBdOkXlvmanNGSXpBMdn3X8635QPrO2tLaJLVcLie7lIHjyMR6/6JzXsxUSFOpnuQbjF/ptUI1xx/ejT/UrngJr4ETtQuRVF8oYLs7YJ7AvubFr+WuwBtzgtto= Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by AS8PR04MB8851.eurprd04.prod.outlook.com (2603:10a6:20b:42e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct 2021 03:22:28 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::b059:46c6:685b:e0fc]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::b059:46c6:685b:e0fc%4]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021 03:22:28 +0000 From: Richard Zhu To: Lucas Stach , "bhelgaas@google.com" , "lorenzo.pieralisi@arm.com" CC: "linux-pci@vger.kernel.org" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: RE: [RESEND v2 3/5] PCI: imx6: Fix the regulator dump when link never came up Thread-Topic: [RESEND v2 3/5] PCI: imx6: Fix the regulator dump when link never came up Thread-Index: AQHXwY4tcTr8p7Uwa0qomeYelO+fgavUYCcAgAWT+PCAAUsLYA== Date: Wed, 20 Oct 2021 03:22:28 +0000 Message-ID: References: <1634277941-6672-1-git-send-email-hongxing.zhu@nxp.com> <1634277941-6672-4-git-send-email-hongxing.zhu@nxp.com> <8f855cf445e2b7827524d5d4adfba80d3a924c60.camel@pengutronix.de> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17293ef5-31c2-43f8-111b-08d99378d899 x-ms-traffictypediagnostic: AS8PR04MB8851: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7zBY4l/lIMQXxBCjsEk4Snjz8N7ClLL3Me9L8zzKgl+mhNHVDw4/gkgksLfR6hOc3l8P1yRIQG2VdDETgg8ypyrD2lMKlVemGdbLqiiuavnZtRFWzome8+ckTYEU0N7bD4gEX4FehOWXU848xxzubOeXbl19D2D6GI1Cma3ojRI2F61sVG5BcYp28PHaBi+9o0LzCpHGqR5UtJj1v8voy81jN5XPhnRdjjvpyt3QTCRRdp5T061GzsJzisu4qi7+qYbBv4N2XhXfrT6WLRiKoQ0xwmBokwv4HuIk9fkWRRSzFYWeyzAjMt+/CXGFFgPy/+36j8dQHxR5BBOzEW14SKCfjQ71EEScFSMeoUDTqRWcY/O9e38f46qwfqVMK2g8tN+e+A0OjM5ZD1h8v4wAacN2XNubtK0dPhzZVrQ1XDrKPZfcAQy4s4t+ZOc6XAAzgOhTowbtnEGBvwuoFBm18ssIg3FB/CPP564RnyppiZTTBkVDbGA8cbkQG8ZUHZMAVJ6/Ezup/j/C4BIkJTi4EVYeJGWzSuKgIOxjEqT/WMlGteIrGUDwviaCSje63ESnHah6JfRO2OiGXBC77+0jdKzPCFHkvaYyuIgGvlyhct3Khed+V0w+HP8+zrBgie7BFNd1DLI7H/oxoroOufb+1FhFOthdHQSWlMn1mg4C0jxsvwHvBA/EvskEn067CbPIY4jArUv5ljdIjuXLGHmbiA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8676.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(38100700002)(86362001)(122000001)(66946007)(83380400001)(6506007)(4326008)(498600001)(52536014)(64756008)(26005)(5660300002)(45080400002)(110136005)(9686003)(2906002)(8936002)(71200400001)(54906003)(76116006)(8676002)(186003)(38070700005)(7696005)(33656002)(66476007)(55016002)(66446008)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NEFJSXFtL21VakFJanRJLytUV1NxbnNBMDJlbk44YUhMNXZWbVpxbCsxRHpO?= =?utf-8?B?SDZmT3pWK3ErTEgrWmdHak95QUFneWR6Rk9Sb0hwT0VCQVpYZEhWaHI1b3VP?= =?utf-8?B?Tkx5a3pHczU5dW16cll6MExWNC9VbUJjbzNKaUlzSFdaUkU4MWNPdzcyWUE2?= =?utf-8?B?azJoNk9EaDNxbHZHbmlXQXAyRFROdXZheWV6TWZySzVBTngwV0I2c2lOcDNW?= =?utf-8?B?aWhQWGNGaEFyZE5HcWMzZVRxUVlsL0tKUVgyR0twUTNCRWptU29sUzVHWWhX?= =?utf-8?B?ejUyWlBHaVBWeTBuZUZobHJwbmtRL2NnbVcxNFlmU2pCSmszdEhMY0hlSUtm?= =?utf-8?B?WGxXSDZMMkl3YVR2YTN1N1pNTS9FdFVaNWV6b1pPbjd1WFp2Vjk3aWtJaFdh?= =?utf-8?B?bHp5QVR5cVh4MURhUUlsWjVJTW5iOURKV2llakZpMlFXMGZObkRNNVNZd1I0?= =?utf-8?B?aGVxMXlIeUpYc2hZU1N1OHNSMU1QbjFpWE84SjY3ckg5TVlDVDJteUZTeXpl?= =?utf-8?B?TDFSYlZBY2xNZ3NScjYrdFpnMSs2QmZMWDhoVzd6Y2VMNDBJZUN5VzB3ck5N?= =?utf-8?B?d3g2VXN1TEp6M0JKNHFVd0dZL3pjeHlra2NoVG0yQzBEY1BVLzVYblpzMVI4?= =?utf-8?B?MmUvMFl1N3F0aEtPME4xUXhOWm1KK0Y3SG5OK0taRlBleGE3UHJKRU5EeFVH?= =?utf-8?B?VnhpZjFsMElEaEoyaGd2S1U4T0tZQjllQWkxQzd1bWM0ckkvOVIzaFBhcC9h?= =?utf-8?B?VXVKZlc2ZnFaSTFtaU5SMzRyWGdMejE5ZkVzNkZFT3FiWkIwMjloQktTdVRE?= =?utf-8?B?UGlWSlRzYTVyRDl1dm9lOU1VUitpSHNlc2E2SjdicTI2bGlrWE1VWjdLNStt?= =?utf-8?B?WjR0MmxZQjMwWEFRMjZrTytpRlR1cEtZTktrMnVrTXVaWTcxVS9rOG1PQWl3?= =?utf-8?B?aG1qaUhOcUJmTmg5M1ZMR2xMUCtON0cwTnBma0dXeEU3Mmh4cUJZVVorTFBG?= =?utf-8?B?SnVqajZ4WFpzTFhXR2E2c1dVYXJhUmFnZ0RCMXZSV0RjSEV5bkdTMXVJa0dv?= =?utf-8?B?YVF1VENaeFdmaUlFaU14NHl1bkZ2UElVSXYxZEQ2YTRVaytOQUQrN0hockRG?= =?utf-8?B?MHFkYVpydEl2SDRGc3phaEh4TWltVjI3eHM4S0lHWitZdUxMamxjU0lqVTBu?= =?utf-8?B?eWlkWXFKU0cyQmx1QkQ2TU9UTGtWLzR4ZjFwU09rN3AzWDF1RmFWcGw5bjc3?= =?utf-8?B?Q3EvVTJ3TXFyQm8zOGpTM2s5S1NDZWdSakJqNVNUMVRsNGY2dHJlemJxSVAx?= =?utf-8?B?U1gvdVBEekxvUjhGTnRTYmwxMnhCeEhjOVNuMEdkZkZKMnJIS0F3R1JOS1dG?= =?utf-8?B?VEExaVgxdkZuYzBHaDlHanZYR3BRVExrYlU1UGcwWXVSVC9DRkhEV0hMa1RG?= =?utf-8?B?YW84cWExdlIzNUJnM2IzOGJyZUJibTBCamM0NWs2VCtEa1dlZmtHdXhmL1Qw?= =?utf-8?B?MUpwNElJdTgzakVJUFJidUNZRWluU0l3OUMweHJ2VzFBVVVrRjBKNnF1enV1?= =?utf-8?B?TG9mQzlES2R6S0piK2xqS0JEOS9NT20rOW5YY1Vqei8vYy9Pb2lTWTJzUTlR?= =?utf-8?B?cHdpNUgrM2FuODg0UThjcFQ4U0ltNWNSc2JiOGhCdXdKd3RnM0kyZ0trN0xE?= =?utf-8?B?bFRVMWE2cDYrRTI0RnRjVDFHUytCWkN3NXl5TU1xRDJhdXJYeGEraW1veVZu?= =?utf-8?Q?uS38s6EByHNkTQTPM0iFrmQFNfzRqXL03YT9vZi?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17293ef5-31c2-43f8-111b-08d99378d899 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 03:22:28.7659 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zgJvTRaUItxtrFe6YavR7q5GcM3RpSaL0q/TRRb3miUb1feV4xDEEA4aprzjCj4YXGeMV/AEoEmw8L2ZzRuq7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8851 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_202232_449135_392B8459 X-CRM114-Status: GOOD ( 32.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Richard Zhu > Sent: Tuesday, October 19, 2021 3:40 PM > To: Lucas Stach ; bhelgaas@google.com; > lorenzo.pieralisi@arm.com > Cc: linux-pci@vger.kernel.org; dl-linux-imx ; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > kernel@pengutronix.de > Subject: RE: [RESEND v2 3/5] PCI: imx6: Fix the regulator dump when link > never came up > > > -----Original Message----- > > From: Lucas Stach > > Sent: Saturday, October 16, 2021 2:23 AM > > To: Richard Zhu ; bhelgaas@google.com; > > lorenzo.pieralisi@arm.com > > Cc: linux-pci@vger.kernel.org; dl-linux-imx ; > > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > > kernel@pengutronix.de > > Subject: Re: [RESEND v2 3/5] PCI: imx6: Fix the regulator dump when > > link never came up > > > > Am Freitag, dem 15.10.2021 um 14:05 +0800 schrieb Richard Zhu: > > > When PCIe PHY link never came up and vpcie regulator is present, > > > there would be following dump when try to put the regulator. > > > Disable this regulator to fix this dump when link never came up. > > > > > > imx6q-pcie 33800000.pcie: Phy link never came up > > > imx6q-pcie: probe of 33800000.pcie failed with error -110 > > > ------------[ cut here ]------------ > > > WARNING: CPU: 3 PID: 119 at drivers/regulator/core.c:2256 > > _regulator_put.part.0+0x14c/0x158 > > > Modules linked in: > > > CPU: 3 PID: 119 Comm: kworker/u8:2 Not tainted > > 5.13.0-rc7-next-20210625-94710-ge4e92b2588a3 #10 > > > Hardware name: FSL i.MX8MM EVK board (DT) > > > Workqueue: events_unbound async_run_entry_fn > > > pstate: 80000005 (Nzcv daif -PAN -UAO -TCO BTYPE=--) > > > pc : _regulator_put.part.0+0x14c/0x158 > > > lr : regulator_put+0x34/0x48 > > > sp : ffff8000122ebb30 > > > x29: ffff8000122ebb30 x28: ffff800011be7000 x27: > 0000000000000000 > > > x26: 0000000000000000 x25: 0000000000000000 x24: > ffff00000025f2bc > > > x23: ffff00000025f2c0 x22: ffff00000025f010 x21: ffff8000122ebc18 > > > x20: ffff800011e3fa60 x19: ffff00000375fd80 x18: 0000000000000010 > > > x17: 000000040044ffff x16: 00400032b5503510 x15: > > 0000000000000108 > > > x14: ffff0000003cc938 x13: 00000000ffffffea x12: 0000000000000000 > > > x11: 0000000000000000 x10: ffff80001076ba88 x9 : ffff80001076a540 > > > x8 : ffff00000025f2c0 x7 : ffff0000001f4450 x6 : ffff000000176cd8 > > > x5 : ffff000003857880 x4 : 0000000000000000 x3 : ffff800011e3fe30 > > > x2 : ffff0000003cc4c0 x1 : 0000000000000000 x0 : 0000000000000001 > > > Call trace: > > > _regulator_put.part.0+0x14c/0x158 > > > regulator_put+0x34/0x48 > > > devm_regulator_release+0x10/0x18 > > > release_nodes+0x38/0x60 > > > devres_release_all+0x88/0xd0 > > > really_probe+0xd0/0x2e8 > > > __driver_probe_device+0x74/0xd8 > > > driver_probe_device+0x7c/0x108 > > > __device_attach_driver+0x8c/0xd0 > > > bus_for_each_drv+0x74/0xc0 > > > __device_attach_async_helper+0xb4/0xd8 > > > async_run_entry_fn+0x30/0x100 > > > process_one_work+0x19c/0x320 > > > worker_thread+0x48/0x418 > > > kthread+0x14c/0x158 > > > ret_from_fork+0x10/0x18 > > > ---[ end trace 3664ca4a50ce849b ]--- > > > > > > Signed-off-by: Richard Zhu > > > --- > > > drivers/pci/controller/dwc/pci-imx6.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c > > > b/drivers/pci/controller/dwc/pci-imx6.c > > > index 3372775834a2..cc837f8bf6d4 100644 > > > --- a/drivers/pci/controller/dwc/pci-imx6.c > > > +++ b/drivers/pci/controller/dwc/pci-imx6.c > > > @@ -853,6 +853,8 @@ static int imx6_pcie_start_link(struct dw_pcie > *pci) > > > dw_pcie_readl_dbi(pci, PCIE_PORT_DEBUG0), > > > dw_pcie_readl_dbi(pci, PCIE_PORT_DEBUG1)); > > > imx6_pcie_reset_phy(imx6_pcie); > > > + if (imx6_pcie->vpcie && regulator_is_enabled(imx6_pcie->vpcie) > > 0) > > > + regulator_disable(imx6_pcie->vpcie); > > > > This doesn't seem like the right place to add this. I guess it would > > be better to have proper error handling after dw_pcie_host_init to > > roll back things like the clock and regulator enable. > [Richard Zhu] This is good suggestion. It's make sense that move the regulator > disable to the dw_pcie_host_init error handling since the regulator have the > enabled check, before to disable it. > But it seems that there are some potential problems when do the similar > operations to the clocks disable here. > Because that the dw_pcie_host_init might have some error returns when the > host_init is not invoked at all. > How to handle this situation although this is one corner case? > [Richard Zhu] I have an idea to handle this case. Add one more callback(e.x: host_exit() ) into dw_pcie_host_ops struct, then do the host_exit() when there is a error return after host_init() is invoked. How about this solution? I would send the v3 patch-set later if you don't say no to this method. BR Richard > Best Regards > Richard Zhu > > > > Regards, > > Lucas > > > > > return ret; > > > } > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel