From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC123C433F5 for ; Tue, 19 Oct 2021 07:45:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB407611EF for ; Tue, 19 Oct 2021 07:45:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AB407611EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I9VFaZrGiVg4j7xegvd8Jkr1UeTQvrvXOdSHYX46R44=; b=i1FkzqU1LX1Jhm VI14iceuvjeTZX1YTOhhWecdS3ZOs9h/tJLfQffcGLB+LOQNC+2RumP5TyuljoK6DO+bnnzpyNkBx vUIZda5/AQPEP9tmdfKd8h0hNMkB6QtuIaS8QWp/ppVUqQJMttxg+lxHc0lPaJNv+qvR3nmw77dQk fm//mi03joAMOHYY75vw92XHulieTl2GkCQOFRHd+SmWEswukUrBZkJNtpk5vUPox1HYq3ui3QVBz ywytmsQA6B4ZKEz1k4FzKz5nK4jmUxnSuxUMArhK713Jd9aOG1EmSlgg7CTU+lApBkffHQF6WDc+b nXwLBpreEO0szoqD5YoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcjnH-000RUj-OE; Tue, 19 Oct 2021 07:44:20 +0000 Received: from mail-eopbgr00042.outbound.protection.outlook.com ([40.107.0.42] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcjnE-000RSl-G2 for linux-arm-kernel@lists.infradead.org; Tue, 19 Oct 2021 07:44:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OC9w7S8OnKI/A3FOwKDvNNGMV8LzvSrwB3V/RquogUoc3iPzzfiugmDoFClBhrrKuGssP+9xHEN3ent/5QDNvjOEfLDn7TETztFLhemQMYEMKX8tOiRQwxTYZNM/NaTGTn0U7Hmwkgr5PwlkIhIr+/WDOMJWuGhTs5IFeq3U64pXs1KRIWowc5j3JYJTPDoRq/hgUGIMviu0tSQ1sWVp9K79O9mcepkTTs5Le+BLkBnDaS68pLPmElW1bWlV6MP+TsV6FwQ6WN+ZyovQXz45wG7Z83mflTKgASLfyXtzizqs/zcy6YY6hH8iQvbAzaRnRGD53AL5SghTRaXL/IsOXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MsZDdt5v0zd7n9k5jtqJwvkh+MsJbk99STmOOGJOaUE=; b=P6wngoB3N6gd7bx18ccfsXzZNl9x+8G0D2Fo0XrsPa1fBldKn2aXwjAMj3Qo7pGlw09HBlsq+4X6iQDATWh2YOjjuf5/y6D5Dgfo8cu2awZ06ZtbKN79wwC186wsWbC0nWQuAZHgHA0ZXOaZ6/ARtIxx8N6iwTzAVnFL+ahQmQWQ7+69jBpZUEqO5w6WA7OEHxde3TRtVRikgFWN6E/noHGvJSejUrbxJXVS2KDlCwz30KZtgaRbV4G3cfc9/haILlSvUG1Byn+EsWnKIRD4FRG+9bmqqrSBMkdh9WGPEgcOzYKZCN54lnMAj7hBPhTaw6mediK6dzGBn+fnFV3YVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MsZDdt5v0zd7n9k5jtqJwvkh+MsJbk99STmOOGJOaUE=; b=nU+Z6JcAAfFsJHNpZq1wWOfepzgev6DJPRoAHOE99fxRH3mnR4MNw2v/ONLq2BxDM594DKUQi47hDUYVwkaKu8ic2inN86H74HOw+8acFv5wz8xgKnlXXnZg8uY3Rf7XzrI3CUO6Pxn3BmPPkZgqy9cDJw9VaKSyy6lKS/VfiT8= Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by AS8PR04MB8721.eurprd04.prod.outlook.com (2603:10a6:20b:428::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct 2021 07:44:12 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::b059:46c6:685b:e0fc]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::b059:46c6:685b:e0fc%4]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 07:44:12 +0000 From: Richard Zhu To: Fabio Estevam CC: Lucas Stach , Bjorn Helgaas , Lorenzo Pieralisi , "linux-pci@vger.kernel.org" , dl-linux-imx , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , Sascha Hauer Subject: RE: [RESEND v2 3/5] PCI: imx6: Fix the regulator dump when link never came up Thread-Topic: [RESEND v2 3/5] PCI: imx6: Fix the regulator dump when link never came up Thread-Index: AQHXwY4tcTr8p7Uwa0qomeYelO+fgavUY4qAgAWTd1A= Date: Tue, 19 Oct 2021 07:44:12 +0000 Message-ID: References: <1634277941-6672-1-git-send-email-hongxing.zhu@nxp.com> <1634277941-6672-4-git-send-email-hongxing.zhu@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e782d28c-c99f-441e-fcaf-08d992d43e7d x-ms-traffictypediagnostic: AS8PR04MB8721: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d7t2AErR6LjQieQ66s7TEjNXNCSOvbe59uMQbteE9Fu8cZj2b8GvtzHL9vaSkVBGh8GH/bdp33V6U/J9BLxnnmZJKxOimzPIUwXKuFGIS2DTaCTJ1r/scQ8Z0bm0HnTdRcddcOS4ZG5Gvb7DcZwdmQTUN6PZV5BY67hSo6k3hp984HgYmdblgQTTpdPobz5AOFr6vIU+G4YtPFJRvkUwpVw4LovCwTqrcZBs6EUjJox9XFdHwm3iRvCtjHdRDiF3CQb+zewZaPTwMYNokCNQmuL81HNUdy2LJHdsJ0s0BC2UAKvNhMg7sIN/H5p2FM+nccG2J02s3/egRSuaJB0O3WlyCBSOraeXu47APsCYamdpCanARgN1PbMM6oy+ijHNEpR4YP/mGyPmqafoTK5+e/eX/WNc9taMwh7l4KObxnSgEebsg7TIm5Cfux/wxPok2oEu/Y6GRdBnDHCOzmgt1cSncOJWE1zCd2LPvfM+ecA5NVsfmPNfBH5/YJ+TkiT7DFe7KQDC22HK5/5W6xY0yFhtYLvb2qB+EblRMnsWwxn4r3vIVASsNK4EfZCjYnQLkts8V4LHdKX6sLYHMAV31wXBUjyboxDNr8oNIl6YcapSSpMLglmtxsoMsmrZXkFl3/fpq17bHVCMQFWrhoQFbnbwG4VJ+tzvqFJ0E3PzoF3/PMtSot5MIXhpwm3IRCH6LaLzUqIji1qAuXRliBV/hQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8676.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(55016002)(54906003)(45080400002)(6506007)(71200400001)(53546011)(186003)(66446008)(26005)(2906002)(9686003)(7696005)(316002)(86362001)(38100700002)(64756008)(122000001)(38070700005)(66946007)(33656002)(52536014)(4326008)(6916009)(76116006)(66556008)(8676002)(66476007)(83380400001)(508600001)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QnFCTHZPN25OV1R0UTNCcjVsTDlISkYvREM5cU5Eemk4WHJNT0d5Skx1d1VS?= =?utf-8?B?NCtncnF6ekVQQ042ekdrMm5ZcXRJdUcyVFNvbkQrZmN3Vlo2UHE2UjlsUkRn?= =?utf-8?B?WVRObXc5em4vMDV4dThvdlloMnYzOTlXMU9HVzM0R0hUSDJ3dE8yMTFRdU5O?= =?utf-8?B?ZUxhQWVjZGdyaGRMQTcyVldLTXprRXRKbnl5RW5Pc3pyU2o4QVhLTTE0dTR2?= =?utf-8?B?QlpEanBwcU4veVZiU25LcHZiMThRemFFYk1KNngxMmVSWUlPMitsNGlYSHl3?= =?utf-8?B?NWxLc2UrT1pVbWY2OE9adUcxY1ZFNHppeVhsMHJZK2Evb0V1U3dwYWw2MWF4?= =?utf-8?B?eUg0N21ZUzdoMmVLeUdSMHNCT0tOeWJDRTFINGFuV0dsZUNEdEliejRwaFNN?= =?utf-8?B?TjlZK0NYNmZyK3VlRGtZYzR6NlBtVzRzL2pTOTVxVVNxeThVWmlUaXlxMlIz?= =?utf-8?B?a2FIbVlaRllDZk1OR3QyUUFlSVF4V0NRN1NDN1AzNmZXYzdETFFCczJwRFQ2?= =?utf-8?B?TkduTDEzMkFodnM2a2h1dFhmY3pRU3ZvdFVwK3A0ZkFVaDZ6T0RxdE1xK1B0?= =?utf-8?B?b25Sbm5md3dnd3VmU1k0VVZCcHJJU0k5UEwxa0ZhZG9uTys0T0wrcmFlZENT?= =?utf-8?B?Um1JVFVScXRaUGxNbXYxMUhVL1hYbWgzN1RJWDRKYWp6ZjBUTzRCZ0oxTnM4?= =?utf-8?B?eURKZHFFOEhlZDRUODdFeXhtZVVFaTlRR0ZzWnF2eGE5Rk55dXBnV0hDOXRK?= =?utf-8?B?bkZ6OSswdERoSTh5UzNIMzJZWlR2V1JlSGZmeUlSTGdtbkVic2ZEMnpBNkdN?= =?utf-8?B?TVBQOWVwaWIxVndPZ045N1JsNGlqRm5EZ3pDNDhKZVB3OXdzRnBkanc3bGdi?= =?utf-8?B?YnpscUdhV2VVUzBROXAzRXhROGFQcTZDMmdYZzlNdjN4a0lSbjBYUldkTWFR?= =?utf-8?B?NS96eDFFOHhXL3h2UWRHNHp1c1FUNnh3ZVhuVVdUUXBocDBpVkl0UkU4b012?= =?utf-8?B?MjhDRVlLbWNmVFN5TnVGUHAyUUNDclBGYjloUHFOZVU3c2s5NTMrdDJ6dU00?= =?utf-8?B?YVFpcENPQUhTWHpwbDVpMFVqOWdJbUU5Vkg2d3FGM3hWSVZpWmdZVllURUlm?= =?utf-8?B?QitnQ2ZkeURQc1pkMzMvYzlEcjlQekxlZUJSSXA5Mmhzb1N2RksxN0xLWHd3?= =?utf-8?B?aTdNVGRGaTkvY0JPTFhDcHRkWWNBbW43NEpGUUZheU5OYnlyYVVBWEdCTzYv?= =?utf-8?B?OGhNNm81aTUyMmp5Z3JoSXNibHlUMmFPNlQ3U3ZvVTVrL21INXI2TEYzejlq?= =?utf-8?B?bkV6TzZXNHlhRmZHdUovTEdSVGNST1lUcGE2cGlmbDYwL1owWVhZbE5Vc25W?= =?utf-8?B?SkRCNzAyWkYrNjVGbmxaaVJ5WUhFRlBaVUpLUUc3aE9XZ0wvdlBwZ0FLTGlP?= =?utf-8?B?SHB0S1FRQ2NRV0hVTW12YUw2RG83Q09SM1cxVkozVUdQQmtGRFlZTjNGdHdy?= =?utf-8?B?RnFsT2xGUXBkUDMwVVNuU0R1YjE0R2RUQSs2eEVNQ3MrSUc1aEFkUUdZNFpm?= =?utf-8?B?eGtUdzBGSE4rMUNRd01KZitvVDJ0MEYyQ0MrSXBFam1oU0ZEREpPaUhma0Ey?= =?utf-8?B?eUhDM2pWNTdrSnE4V1g1ejZnRHJ4NzhVb1Ftdm1XMTJUV0JQRUwzeHhYaTJj?= =?utf-8?B?NjBuaDhLTzlycEdEVHBxRU42aUtLUmZCbkEzbGo4U1lGVjcvSnd6clVYV01x?= =?utf-8?Q?F6n7YF7uEQdRxiB6DP0Wf7OfpVhTVvsqBShlkdp?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e782d28c-c99f-441e-fcaf-08d992d43e7d X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 07:44:12.8015 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W/OAQ+uwnn+ng8ja0TLBRBRIRE3+MM0JfPhIvc1G95iSiFvrI4Q7ibDcGkrfBnmdDZbCHhHshTjOSnHFcSc8NQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8721 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_004416_569828_4F9016E8 X-CRM114-Status: GOOD ( 18.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Fabio Estevam > Sent: Saturday, October 16, 2021 2:35 AM > To: Richard Zhu > Cc: Lucas Stach ; Bjorn Helgaas > ; Lorenzo Pieralisi ; > linux-pci@vger.kernel.org; dl-linux-imx ; moderated > list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > ; linux-kernel > ; Sascha Hauer > Subject: Re: [RESEND v2 3/5] PCI: imx6: Fix the regulator dump when link > never came up > > Hi Richard, > > On Fri, Oct 15, 2021 at 3:32 AM Richard Zhu wrote: > > > > When PCIe PHY link never came up and vpcie regulator is present, there > > would be following dump when try to put the regulator. > > Disable this regulator to fix this dump when link never came up. > > > > imx6q-pcie 33800000.pcie: Phy link never came up > > imx6q-pcie: probe of 33800000.pcie failed with error -110 > > ------------[ cut here ]------------ > > WARNING: CPU: 3 PID: 119 at drivers/regulator/core.c:2256 > _regulator_put.part.0+0x14c/0x158 > > Modules linked in: > > CPU: 3 PID: 119 Comm: kworker/u8:2 Not tainted > 5.13.0-rc7-next-20210625-94710-ge4e92b2588a3 #10 > > Hardware name: FSL i.MX8MM EVK board (DT) > > Workqueue: events_unbound async_run_entry_fn > > pstate: 80000005 (Nzcv daif -PAN -UAO -TCO BTYPE=--) > > pc : _regulator_put.part.0+0x14c/0x158 > > lr : regulator_put+0x34/0x48 > > sp : ffff8000122ebb30 > > x29: ffff8000122ebb30 x28: ffff800011be7000 x27: 0000000000000000 > > x26: 0000000000000000 x25: 0000000000000000 x24: ffff00000025f2bc > > x23: ffff00000025f2c0 x22: ffff00000025f010 x21: ffff8000122ebc18 > > x20: ffff800011e3fa60 x19: ffff00000375fd80 x18: 0000000000000010 > > x17: 000000040044ffff x16: 00400032b5503510 x15: > 0000000000000108 > > x14: ffff0000003cc938 x13: 00000000ffffffea x12: 0000000000000000 > > x11: 0000000000000000 x10: ffff80001076ba88 x9 : ffff80001076a540 > > x8 : ffff00000025f2c0 x7 : ffff0000001f4450 x6 : ffff000000176cd8 > > x5 : ffff000003857880 x4 : 0000000000000000 x3 : ffff800011e3fe30 > > x2 : ffff0000003cc4c0 x1 : 0000000000000000 x0 : 0000000000000001 > > Call trace: > > _regulator_put.part.0+0x14c/0x158 > > regulator_put+0x34/0x48 > > devm_regulator_release+0x10/0x18 > > release_nodes+0x38/0x60 > > devres_release_all+0x88/0xd0 > > really_probe+0xd0/0x2e8 > > __driver_probe_device+0x74/0xd8 > > driver_probe_device+0x7c/0x108 > > __device_attach_driver+0x8c/0xd0 > > bus_for_each_drv+0x74/0xc0 > > __device_attach_async_helper+0xb4/0xd8 > > async_run_entry_fn+0x30/0x100 > > process_one_work+0x19c/0x320 > > worker_thread+0x48/0x418 > > kthread+0x14c/0x158 > > ret_from_fork+0x10/0x18 > > ---[ end trace 3664ca4a50ce849b ]--- > > > > Signed-off-by: Richard Zhu > > I am seeing this on imx6 too. When you send a v2, after addressing Lucas' > comments, please add a Fixes tag/ [Richard Zhu] Okay, no problem. Thanks. BR Richard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel