From: Icenowy Zheng <icenowy@aosc.io>
To: linux-arm-kernel@lists.infradead.org,Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH v5 2/5] dt-bindings: phy: add binding for Allwinner USB3 PHY
Date: Sat, 06 Apr 2019 15:24:14 +0800 [thread overview]
Message-ID: <B954438A-73B2-4156-81CD-197C08D0E3F5@aosc.io> (raw)
In-Reply-To: <20190406071402.GA6006@bogus>
于 2019年4月6日 GMT+08:00 下午3:14:02, Rob Herring <robh@kernel.org> 写到:
>On Sat, Apr 06, 2019 at 04:57:33AM +0800, Icenowy Zheng wrote:
>> The new Allwinner H6 SoC contains a USB3 PHY that is wired to the
>> external USB3 pins of the SoC.
>>
>> Add a device tree binding for the PHY.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>> Changes in v5:
>> - Dropped Vbus regulator and added connector subnode.
>>
>> Changes in v4:
>> - Changed Vbus regulator property to vbus-supply.
>>
>> Changes in v3:
>> - Added Chen-Yu's Review tag.
>>
>> No changes in v2, v1.
>>
>> .../bindings/phy/sun50i-usb3-phy.txt | 28
>+++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>> create mode 100644
>Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt
>>
>> diff --git
>a/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt
>b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt
>> new file mode 100644
>> index 000000000000..eeedc53e6360
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt
>> @@ -0,0 +1,28 @@
>> +Allwinner sun50i USB3 PHY
>> +-----------------------
>> +
>> +Required properties:
>> +- compatible : should be one of
>> + * allwinner,sun60i-h6-usb3-phy
>> +- reg : a list of offset + length pairs
>> +- #phy-cells : from the generic phy bindings, must be 0
>> +- clocks : phandle + clock specifier for the phy clock
>> +- resets : phandle + reset specifier for the phy reset
>> +
>> +Optional nodes:
>> +- connector : A sub-node required for representing the connector
>connected
>> + to the USB PHY. See ../connector/usb-connector.txt for
>details.
>> +
>> +Example:
>> + usb3phy: phy@5210000 {
>> + compatible = "allwinner,sun50i-h6-usb3-phy";
>> + reg = <0x5210000 0x10000>;
>> + clocks = <&ccu CLK_USB_PHY1>;
>> + resets = <&ccu RST_USB_PHY1>;
>> + #phy-cells = <0>;
>> +
>> + connector {
>> + compatible = "usb-a-connector";
>> + label = "USB3";
>
>The binding defines that a connector is a child of USB controller or
Please note that the word used is not "USB controller", but "USB interface
controller".
A USB controller is something that deal with USB protocol, and connect to a USB
PHY with ULPI/UTMI/PIPE interface. It's not connected to the connector
directly at all. Then the PHY is connected to the interface controller (if present), or
the connector, with D+, D- and SS pins.
>some port controller (such as USB-C ctrlr) with OF graph to USB
>controller. So either way, this is wrong unless this is more than just
>a
>phy.
>
>Rob
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
使用 K-9 Mail 发送自我的Android设备。
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-06 7:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 20:57 [PATCH v5 0/5] Allwinner H6 USB3 support Icenowy Zheng
2019-04-05 20:57 ` [PATCH v5 1/5] dt-bindings: usb-connector: add Vbus regulator for Type-A/B Icenowy Zheng
2019-04-06 7:10 ` Rob Herring
2019-04-05 20:57 ` [PATCH v5 2/5] dt-bindings: phy: add binding for Allwinner USB3 PHY Icenowy Zheng
2019-04-06 7:14 ` Rob Herring
2019-04-06 7:24 ` Icenowy Zheng [this message]
2019-04-09 1:09 ` Rob Herring
2019-04-08 7:14 ` Maxime Ripard
2019-04-05 20:57 ` [PATCH v5 3/5] phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC Icenowy Zheng
2019-04-06 17:21 ` [linux-sunxi] " Ondřej Jirman
2019-04-06 17:24 ` Icenowy Zheng
2019-04-09 16:34 ` Clément Péron
2019-04-11 0:15 ` Ondřej Jirman
2019-04-11 0:20 ` Ondřej Jirman
2019-04-05 20:57 ` [PATCH v5 4/5] arm64: allwinner: dts: h6: add USB3 device nodes Icenowy Zheng
2019-04-05 20:57 ` [PATCH v5 5/5] arm64: allwinner: dts: h6: enable USB3 port on Pine H64 Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B954438A-73B2-4156-81CD-197C08D0E3F5@aosc.io \
--to=icenowy@aosc.io \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).