From: Dragan Cvetic <draganc@xilinx.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: gregkh <gregkh@linuxfoundation.org>,
Michal Simek <michals@xilinx.com>,
Derek Kiernan <dkiernan@xilinx.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 04/12] misc: xilinx_sdfec: Add open, close and ioctl
Date: Tue, 19 Mar 2019 14:59:34 +0000 [thread overview]
Message-ID: <BL0PR02MB5681AEB47A24279266831D1BCB400@BL0PR02MB5681.namprd02.prod.outlook.com> (raw)
In-Reply-To: <CAK8P3a3uKOVW5HcQD9LLKfoeOkTnhE8M2rHsZuwjNUQv18=J_g@mail.gmail.com>
> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Tuesday 19 March 2019 13:18
> To: Dragan Cvetic <draganc@xilinx.com>
> Cc: gregkh <gregkh@linuxfoundation.org>; Michal Simek <michals@xilinx.com>; Linux ARM <linux-arm-kernel@lists.infradead.org>;
> Derek Kiernan <dkiernan@xilinx.com>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 04/12] misc: xilinx_sdfec: Add open, close and ioctl
>
> On Tue, Mar 19, 2019 at 1:05 PM Dragan Cvetic <dragan.cvetic@xilinx.com> wrote:
> >
> > Add char device interface per DT node present and support
> > file operations:
> > - open(), which keeps only one open per device at a time,
> > - close(), which release the open for this device,
> > - ioctl(), which provides infrastructure for a specific driver
> > control.
>
> > drivers/misc/xilinx_sdfec.c | 79 ++++++++++++++++++++++++++++++++++++++++
> > include/uapi/misc/xilinx_sdfec.h | 4 ++
> > 2 files changed, 83 insertions(+)
> >
> > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> > index a52a5c6..3407de4 100644
> > --- a/drivers/misc/xilinx_sdfec.c
> > +++ b/drivers/misc/xilinx_sdfec.c
> > @@ -81,8 +81,87 @@ struct xsdfec_dev {
> > struct xsdfec_clks clks;
> > };
> >
> > +static int xsdfec_dev_open(struct inode *iptr, struct file *fptr)
> > +{
> > + struct xsdfec_dev *xsdfec;
> > +
> > + xsdfec = container_of(iptr->i_cdev, struct xsdfec_dev, xsdfec_cdev);
> > + if (!xsdfec)
> > + return -EAGAIN;
>
> The result of container_of() will not be NULL here.
> Did you mean to check i_cdev? That probably also won't
> be NULL, but that check would be more reasonable.
Will be either removed fully or changed with i_cdev check
>
> > + /* Only one open per device at a time */
> > + if (!atomic_dec_and_test(&xsdfec->open_count)) {
> > + atomic_inc(&xsdfec->open_count);
> > + return -EBUSY;
> > + }
>
> What is that limitation for? Is it worse to open it twice than
> to dup() or fork()?
>
The device can be opened only once.
> Note that the test is not really atomic either: if three processes
> try to open the file at the same time, it gets decremented from
> 1 to -2, so only the second one sees 0 and increments it back
> to -1 afterwards...
It looks you are right. Will fix this. Thank you for the catch.
>
> > +static long xsdfec_dev_ioctl(struct file *fptr, unsigned int cmd,
> > + unsigned long data)
> > +{
> > + struct xsdfec_dev *xsdfec = fptr->private_data;
> > + void __user *arg = NULL;
> > + int rval = -EINVAL;
> > + int err = 0;
> > +
> > + if (!xsdfec)
> > + return rval;
> > +
> > + if (_IOC_TYPE(cmd) != XSDFEC_MAGIC) {
> > + dev_err(xsdfec->dev, "Not a xilinx sdfec ioctl");
> > + return -ENOTTY;
> > + }
>
> remove the error messages here as well.
>
> > + /* Access check of the argument if present */
> > + if (_IOC_DIR(cmd) & _IOC_READ)
> > + err = !access_ok((void *)arg, _IOC_SIZE(cmd));
> > + else if (_IOC_DIR(cmd) & _IOC_WRITE)
> > + err = !access_ok((void *)arg, _IOC_SIZE(cmd));
>
> This seems odd. Why two separate checks, and why the access_ok()
> check when you do a copy_from_user() that contains the same check
> later?
Accepted, will remove it.
>
> If you want to get fancy here, you could just copy the data in the main
> ioctl handler based on _IOC_SIZE, and pass around normal kernel
> pointers from there.
Will not be fancy. Thank you for the advice.
>
> > static const struct file_operations xsdfec_fops = {
> > .owner = THIS_MODULE,
> > + .open = xsdfec_dev_open,
> > + .release = xsdfec_dev_release,
> > + .unlocked_ioctl = xsdfec_dev_ioctl,
> > };
>
> This lacks a .compat_ioctl pointer.
This is new for me, I have to investigate more and propose a solution.
Thank you for suggestion.
>
> Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-19 14:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 12:04 [PATCH 00/12] misc: xilinx sd-fec driver Dragan Cvetic
2019-03-19 12:04 ` [PATCH 01/12] dt-bindings: xilinx-sdfec: Add SDFEC binding Dragan Cvetic
2019-03-19 12:04 ` [PATCH 02/12] misc: xilinx-sdfec: add core driver Dragan Cvetic
2019-03-19 12:04 ` [PATCH 03/12] misc: xilinx_sdfec: Add CCF support Dragan Cvetic
2019-03-19 12:04 ` [PATCH 04/12] misc: xilinx_sdfec: Add open, close and ioctl Dragan Cvetic
2019-03-19 13:17 ` Arnd Bergmann
2019-03-19 14:59 ` Dragan Cvetic [this message]
2019-03-19 15:36 ` Arnd Bergmann
2019-03-19 18:10 ` Dragan Cvetic
2019-03-19 19:46 ` Arnd Bergmann
2019-04-09 8:35 ` Dragan Cvetic
2019-03-19 12:04 ` [PATCH 05/12] misc: xilinx_sdfec: Store driver config and state Dragan Cvetic
2019-03-19 12:04 ` [PATCH 06/12] misc: xilinx_sdfec: Add ability to configure turbo mode Dragan Cvetic
2019-03-19 12:04 ` [PATCH 07/12] misc: xilinx_sdfec: Add ability to configure LDPC Dragan Cvetic
2019-03-19 12:04 ` [PATCH 08/12] misc: xilinx_sdfec: Add ability to get/set config Dragan Cvetic
2019-03-19 13:05 ` Arnd Bergmann
2019-03-19 14:02 ` Dragan Cvetic
2019-03-19 12:04 ` [PATCH 09/12] misc: xilinx_sdfec: Support poll file operation Dragan Cvetic
2019-03-19 12:04 ` [PATCH 10/12] misc: xilinx_sdfec: Add stats & status ioctls Dragan Cvetic
2019-03-19 12:04 ` [PATCH 11/12] Docs: misc: xilinx_sdfec: Add documentation Dragan Cvetic
2019-03-19 12:04 ` [PATCH 12/12] MAINTAINERS: add maintainer for SD-FEC support Dragan Cvetic
2019-03-19 12:17 ` [PATCH 00/12] misc: xilinx sd-fec driver Michal Simek
2019-03-19 13:44 ` Dragan Cvetic
2019-03-19 13:51 ` Michal Simek
2019-03-19 13:55 ` Dragan Cvetic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR02MB5681AEB47A24279266831D1BCB400@BL0PR02MB5681.namprd02.prod.outlook.com \
--to=draganc@xilinx.com \
--cc=arnd@arndb.de \
--cc=dkiernan@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).