From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_MUA_MOZILLA,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD1C3C433E1 for ; Sat, 11 Jul 2020 18:20:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EDD020748 for ; Sat, 11 Jul 2020 18:20:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tC94n5Qa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EDD020748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=live.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:In-Reply-To:Date:Message-ID:From:References:To:Subject: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X9/UOOHjTkQifTbRG8qlJUbaumv7A9kRcBced3i4Gwo=; b=tC94n5QahVX+EiYO5zz6yBnlg/ nsd8s7uKAhHAQoy6QcDo6qAQORPXrJLJOes/LUkn36o2ORUncPwBxSipz/0x/9EHnqxCkTSVDkUS7 VkKmG80DEINbYRVXH813ldqUjJ+LaES/Y0MoL+Z7H2YuPiUq7djca7+hykwOIPAwg9wluAxuB06YK dD4fL84mTKpf9jcbRn3BYbnWsfVL2yBZjzvE0Mq2hbTDdCzXdaYoNK7j7etYvQTS9plV3k0Mb+PjA MhWmsL2KHV4C6hH8LwlRlqsxOitf212ttGdmI4wuN8ahTd8pB3Qpo8DJ2bnQiWEJlbcBE8DIZweug s4ldltRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juK5O-0000BO-HA; Sat, 11 Jul 2020 18:18:54 +0000 Received: from mail-dm6nam11olkn2049.outbound.protection.outlook.com ([40.92.19.49] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juK5M-0000Af-3r for linux-arm-kernel@lists.infradead.org; Sat, 11 Jul 2020 18:18:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dsmEr0yB6WhOFGjTfmr7C2Oftjdpj7tH5s99pvxjc5FtSfwRMkc0XD3YO0zf6u5+dgWeZZsXIKISXLZLMEObXR5UpLl2vgUlL9ToF1yB1E/At+UGxQwGk2ZehHNIlXD7iW1NIyh0CEIQ82pWsZm2Y9Q08dhqWDtcHrAcT92gQDPNi3GCMpf/Im0UBoEf30W0uj2vp6jlD2FVLuShtfygh+7JSOuNwkrjYenquq1tVjwvwPUo3Ob1cgKCvfZ83F+hey2UoMVC/ssE36qrrxLlRQR1GMgJWD5LrXGZ6wxfoJwXPuwAQcHmtXGJ4S6VC9/onEiovnOewl46k/rRvCYFcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v/3H5Qp15Ji/VDc0m5kDEKKHgyUxwGZR4wHNX0v5cbA=; b=fw+ib2epDwbOF6wBOj4u5t87k79yrqE3+GZrSXNlBOJFW504RaktvATYlZBnshmjaeEIGbxkrjRthVEC1TlJOLI7iA3d5mOmXGYOwJ61HkYhsXaemfxFTM+OdO/3b66kvR7kBC7WtxxoO4b4L8MQSKh1q14BHseZReMkzoyXe8+IP+8BtW5kcg2V16qdBJYahJ26q6VMGgQ768BLrjPxDUt3MN5c2l0Ln4fmJrUFy4azdE2ggxKxeYirk0eNgL4M9pDtv+Q7Sk6NkaO35HINFDoZ4bazB/bTyiOyV2XO3/xdmdPBe7TdAXqHg2njH6E9p5LSSrQMqC8UHWUa5nKrfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6NAM11FT041.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4d::45) by DM6NAM11HT016.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4d::318) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Sat, 11 Jul 2020 18:18:50 +0000 Received: from BN6PR04MB0660.namprd04.prod.outlook.com (2a01:111:e400:fc4d::43) by DM6NAM11FT041.mail.protection.outlook.com (2a01:111:e400:fc4d::98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Sat, 11 Jul 2020 18:18:50 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:6F301C493BB595ACA55296A749C0BB73C061BF52215884F4ACC90F02979CF891; UpperCasedChecksum:B4396C0EF1F8BF50F664E0598DE52FAF6952286387767C7CE59EF9872EF08A6B; SizeAsReceived:9280; Count:48 Received: from BN6PR04MB0660.namprd04.prod.outlook.com ([fe80::b9c3:9bff:541d:f383]) by BN6PR04MB0660.namprd04.prod.outlook.com ([fe80::b9c3:9bff:541d:f383%9]) with mapi id 15.20.3174.024; Sat, 11 Jul 2020 18:18:50 +0000 Subject: Re: [PATCH 11/11] media: exynos4-is: Correct parallel port probing To: Sylwester Nawrocki , kyungmin.park@samsung.com, mchehab@kernel.org, kgene@kernel.org, krzk@kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200426022650.10355-1-xc-racer2@live.ca> <05381b4a-3581-e57d-3ecc-43eaafd9d527@samsung.com> From: Jonathan Bakker Message-ID: Date: Sat, 11 Jul 2020 11:18:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 In-Reply-To: <05381b4a-3581-e57d-3ecc-43eaafd9d527@samsung.com> Content-Language: en-US X-ClientProxiedBy: MWHPR19CA0085.namprd19.prod.outlook.com (2603:10b6:320:1f::23) To BN6PR04MB0660.namprd04.prod.outlook.com (2603:10b6:404:d9::21) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:569:fb68:9c00:8067:f823:1e15:7520] (2001:569:fb68:9c00:8067:f823:1e15:7520) by MWHPR19CA0085.namprd19.prod.outlook.com (2603:10b6:320:1f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20 via Frontend Transport; Sat, 11 Jul 2020 18:18:48 +0000 X-Microsoft-Original-Message-ID: X-TMN: [aeG9F7CT36SXSoG7+mQoj0Lk4fmE18ZZudW9Qc953ZMvoAK4HxdOCtbCKG8VgpH8] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 8589d836-1a41-40e5-e3e9-08d825c6dc2e X-MS-TrafficTypeDiagnostic: DM6NAM11HT016: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qp3N6CTTtQdBMKXy6DdldoRYfNX4qXuNAtD5P9nUOS6DUjqG05PZ6Wq1dhHP11g9+7H+INxKRk2gcX8JTNcq1sIy185lSf3MquyQAnoJTWcWCBXcz5jsNL/FHyjTFyYlvldPgvzYJCQC+NENcA0/j+9x67NzHdz7EysjyoGdb36ITTmN6oPPutFViKzR8/ViteGvESNDuY1T+GPkar1e4w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR04MB0660.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; X-MS-Exchange-AntiSpam-MessageData: 72Z21YTWq7QgusVeMQMm8GJFR6qzo3K/w1Hv+5ITy3iu6YAcDDw/UKkNSPARRMAfvA5WcmmK7iTj5NnnOl/tB0Yd/O2SKr3sT3D3AnzDjjDAJYw4IM7Zwyd7jeaxi/cofGYGEXb2PuEZm1WCoUoQAhbeOu2WUtZHSYReiDzq4k5mHjfuUns+midf50sKFpHw7/DFluMPDY9gBHUVvC3liw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8589d836-1a41-40e5-e3e9-08d825c6dc2e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2020 18:18:50.4256 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT041.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM11HT016 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200711_141852_200321_39404049 X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sylwester, On 2020-07-08 9:15 a.m., Sylwester Nawrocki wrote: > Hi, > > On 26.04.2020 04:26, Jonathan Bakker wrote: >> According to the binding doc[1], port A should be reg = 0 >> and port B reg = 1. Unfortunately, the driver was treating 0 >> as invalid and 1 as camera port A. Match the binding doc and >> make 0=A and 1=B. >> >> [1] Documentation/devicetree/bindings/media/samsung-fimc.txt > > Thank you for correcting this. I would prefer to correct the binding > documentation instead, so it says reg=1 for A and reg=2 for B. > Then it would also match what we have in dts for Goni and > enum fimc_input in include/media/drv-intf/exynos-fimc.h No problem, that works for me. I'll drop this patch and replace it with one changing the documentation. > > Thanks, Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel