From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E4ACC433B4 for ; Mon, 19 Apr 2021 12:31:32 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E94061245 for ; Mon, 19 Apr 2021 12:31:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E94061245 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=j7oMwJ+TvrctzZb/oziUTTH35UvCsL4t4E4b50P1XyM=; b=jwXqvfj1A4vZnQQvSQ9Mhu/yG MjTm91bIZNeN5+lv18clzkCE3CkMQ/nEt+HXeIicx0nXUaxlUWAoljw8JqNCnTk4XjY/OwFYE9jzj ugkLU4HSgEuE32o7GPxLaiEywNQ1viCQuq8e1yfwAGouRvyOgoiZp7CYf55pihSMCifEC0PAHIN2R 4WhlyQfQorNqnoDHlrkA4nba/Qn1xFWtk+VH6zz7hT3EhNz3GBxmrmI04zjq5gk/jUQSF7aCaoy5e qLBGK1maG/EqGA7hTB5eghqhxydWm7LE/GXzIHVR20Gy/IYsa5H3WERbv/48VR8J99QtC7ZpgPgtC UKzA1U0nA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYT2B-009rGF-8Q; Mon, 19 Apr 2021 12:29:47 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYT27-009rG2-I3 for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 12:29:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=GpcKr8WVpdl5+kx39LmohK15oFSvJoS84s7sMEt15qg=; b=GcHuz0PLtQGTO+3Hil1Ve3V7Ua T4HjBS/TsmMZlahGg5YrfH8qp8PgBt59GZ25cZEA9Iv8HZxJc+m9nAgciiSGFxaFq71BtY6NsbwMB woPhU304B28Ry24xyPADwlfvIt4b6us2vMqFVQTf7JN/y8suNBoj8Jn2s77kScsG3dmhh9JNTXrHT +aS8IKxzaivZcfQBQoB+fYDp6iTUhibJwxWYX5MS6RQHc4qNkmWwGF8yASkVYvEG8mu2f+PZVb8dU PwsfQmJgrkwbQCB9ZewvgX7xTncQzF08ZCLCpqoJ2Et+PMycH1t+0YkI4TluDsmcR5Iwgy+3ENgKi 6e6yUj/Q==; Received: from mail-eopbgr750052.outbound.protection.outlook.com ([40.107.75.52] helo=NAM02-BL2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYT24-00BLxK-M3 for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 12:29:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cQL5x6cf8xyG2O8KFZkfRy23K6bg4ljcwBXsoazunEHYNtyv1vxa1a5FCbSfnHI0CjivlBH1bXsBYQNm5RW7mWkcvKh5H9wR7eIKU9R9FkN0Nx9tke3iWseX3Ej1nDLsrczmuhcSRIe2gQg51hdTtcyw/MhuqMmhK0RUI1nyhvfVNtThCMI6IWRVtALD1v/BkE4kMK1DLgjK/56JTZI5HV1XBp7NUsy74NSwh3yOVug34gE46D9CHJU9nOmHRCtAex6C7CzZQxwxd2u/K44GVnEdJT1OF8o+bygm4W4BCV8HnjC6US6BBgtE3lw3rrVjbUf7q5EqnouabPy8sNPZMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GpcKr8WVpdl5+kx39LmohK15oFSvJoS84s7sMEt15qg=; b=oeAtzP+SGaJkUO5tfC7l7iL06KTEAbqggaozhB+TAxgVvKwVyAip7jEN18MgcLQjLVgsguiNy0K11Br6p58bVc6mG1MAmKLzaiNpVTVhMp4lrmTV/8wlZQe8AAbNLIa3DjGn6APtPw3i4eEU/svWRVNjN6z+Mem9Ajst7pSG89CT8p6B3BZX8BxPoETovSkIMAsCZyfmPDpL+kn6MUuvBYt1Wxe005DoLcquHGNtEqQfl/EAEbCEbw9mFe6LbGknhjRwplauGJBv+hlSdxqylk6zRV2rv8HtSdGJ7K/AaZ7BXbNesVZxdPKI1byny5m0oxLJTDK4dvZNZ6D8Y74neQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GpcKr8WVpdl5+kx39LmohK15oFSvJoS84s7sMEt15qg=; b=Xpi+32hNF2/D/5q1qoe2h+r4DJz/f0Jk4v9qEYdoKYHCyDIkunPhotqUb/0Hxhzo9Y+KjqJrARELjyyR4tW7L5/3KTjfDfvsvIN1r4l+WzmQmcHe6EF9EYb9GrBZdh5L9Hejh5vqh4gnQn6JbIaIn5Fq5YNiWQ9j+uP1eD3WzZM= Received: from BYAPR02MB3941.namprd02.prod.outlook.com (2603:10b6:a02:f8::18) by BY5PR02MB6899.namprd02.prod.outlook.com (2603:10b6:a03:234::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.19; Mon, 19 Apr 2021 12:29:35 +0000 Received: from BYAPR02MB3941.namprd02.prod.outlook.com ([fe80::f9c6:6c2f:3084:89b8]) by BYAPR02MB3941.namprd02.prod.outlook.com ([fe80::f9c6:6c2f:3084:89b8%3]) with mapi id 15.20.4042.024; Mon, 19 Apr 2021 12:29:34 +0000 From: Rajan Vaja To: Michael Tretter CC: "linux-arm-kernel@lists.infradead.org" , Michal Simek , Jolly Shah Subject: RE: [PATCH 0/4] soc: xilinx: pm_domains: cleanup and fix PM_INIT_FINALIZE Thread-Topic: [PATCH 0/4] soc: xilinx: pm_domains: cleanup and fix PM_INIT_FINALIZE Thread-Index: AQHXG0cu/KQyGhyIs0iTAJasKHZi6aq18C6AgAW1nYCAAFDW4A== Date: Mon, 19 Apr 2021 12:29:34 +0000 Message-ID: References: <20210317160410.2097178-1-m.tretter@pengutronix.de> <20210419073239.GA12636@pengutronix.de> In-Reply-To: <20210419073239.GA12636@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=xilinx.com; x-originating-ip: [149.199.62.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f43dd0ed-9cb4-41d0-7125-08d9032eca6a x-ms-traffictypediagnostic: BY5PR02MB6899: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kzJ1kBqHZLkWRGhFq+EdD26nHFiqF/l0NkjvkfMXGWEgH9g2X4Rn6iM/215nbZXykxojHg/zrUCnjwhBGyP108SUy6vN+TbUYhIlgRhMs3GxZ3rW/eHhM/kArnl0B5biX8eS2M8SNeGOJoKAHMnDknrNKMkMJDK9tdmXt7fe7wTW7+p2D6bw4Vm2WpXj+U36C6wu3y0r1BhUN+tQ8Vs/4B5U0YwX3mICZ/Ajk8OfVU1QMGtY0N1mTvk2XhZmyGFO+5L8c1mSrGvUnvtIQrILDzHOWr8p1X0E0XhsXQlFtS2aSn0URUHrCocAn3RbNHFY3O29iETkb+DS3yoIXbcprxwgbzHNv7uQz817l46pj/Y9oyHVNsxXKH260o5X0Qf/Ur64upLLaoHCW2zPgDmvJKQAcGrpCyB9cnE2JCyBwRkNWJoeGjMecbiDC8L9FK9Q+Z6SEccEJArtmS/A5Gj2yq9glPYArArv5vW8JHGHQNNQbTcQADlq2Fj4Li+/3MAvYCxKqXAgnoBjNiQyaKOI6LkT1ep2Kw3309WU02waPKOXXJYx7RyK0yO3qe6ChCpP3SzAtY2uUqepMseZmo11HDivjrW+6/e/JRhRc+IWa/M= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR02MB3941.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(39860400002)(366004)(346002)(7696005)(5660300002)(6916009)(478600001)(316002)(66946007)(76116006)(66446008)(33656002)(83380400001)(122000001)(64756008)(71200400001)(66476007)(8676002)(86362001)(38100700002)(8936002)(9686003)(55016002)(4326008)(66556008)(26005)(107886003)(53546011)(2906002)(186003)(52536014)(54906003)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?ekpram1FRXhEbFdINmducFBWTXZIYVlMVi9acFkzV3VqRVJLMmtWYjJPeVYy?= =?utf-8?B?VGJuNkRvTG1TbElRSnpEbHc0RkVaYnkvc2V1Qm5veVl6R0JSa3Nzd0p0eVp0?= =?utf-8?B?QlN0R1hJeWNiamtROFVCNzBvSWlURUNuNVNIeDVkYkVsMXN4dFlXcjBsZW1l?= =?utf-8?B?cXdVTlo3WU1oU054VktjdlVPbnVXQXRjMEgxNlZrUzU3bG1oRmNqcWkyazYr?= =?utf-8?B?ODUzTDkvZ2UvbWd5aUhHNE9EaG1zK0xrVGhYaS9rS25DYlc1YVR4UEUxcDBx?= =?utf-8?B?WU1qRThtUUhMYWZWdmdjU2NLSklPOEQyK1FlRWVLK0VlMEl5d2cvNHlGWE9J?= =?utf-8?B?Rld0ektnVGpFazh0NXBveWQ4Q2tHdkxKSjk4WUhQU3VIeDZqOHRvQkozOTZ1?= =?utf-8?B?VjU0aTFYK1JwRGNZZEdpMzJpMkF5OXlmNWQ1STg1ZFdBUTlScC83RHdtd2l5?= =?utf-8?B?czQxZEg5dk9DclpGN09rTjVjaEVZU3RQWUl0c25heitGMlVLR0UvaUg3Z1J2?= =?utf-8?B?dGp4ZjFyL2MxcndHeWd1cm43UmRuWUxucXhuN2hpQTlUeVhZU3lRQzNKL0dF?= =?utf-8?B?UjU2WlU2Nll1dEEzbERWZkZFVkJoNXpYMTZNWk13WTFIY2NMaFBtWnVlN0dv?= =?utf-8?B?dDduUE1oU0ZxeDNFbU93ZWc4S1J6M2lJTWlMeXV1ZTQvbWJpRXhSK0VwVC9t?= =?utf-8?B?ZWxsMFRTRUxzQk5Tbnkwa2RESzJtdVhOcDBpaStzUHZxWUFnVkpQbWN4UkRz?= =?utf-8?B?WTBLeEJPQVl3YmtSWHdLUHRqSlRYREh4cWdVcyt3UlFrYkphN2ZoLzlzRlgz?= =?utf-8?B?eEJiR1lmYUgrUmtVb1ByZ0E3RnRtaWtzVko2cHg2MFZlSUZDUElLVlMzdkhJ?= =?utf-8?B?VzlDUE5uU2w3MW5ydW80cTUxbUxyREJMN1o4WnhPUFo5Q2wyUjlPbGxVRXdN?= =?utf-8?B?aGZqUUplWVN2dDJWUGFRc3pPdDdyWGQvWEplRWlGNGVqNjF5MFAzVmdvVTVT?= =?utf-8?B?YjJpS0Q2dE5lb0NieHBEQnFEN21QWHljZ3dxNkxUVTNjcjFRZjg2ejhPK3Nr?= =?utf-8?B?T04rOEJlQWR3YWZpN0VLVTNleFd1K2luaTRVdWp4M0t3ZkZIejEvY3F0THlX?= =?utf-8?B?QzcvR2l1WGVveTkyMFBaUm9Jekg5VU5aVUVDUWhoamx6bm9wVy9CWTRqTzFw?= =?utf-8?B?ZitJSFl6TEx5eTc5NXNsZ1lXZENjNGJGellyd0E2UUtmVDJJZXViSndLSGd0?= =?utf-8?B?MWZrcVkvZ0ZZSUgybDZpc1ZST3JBOW9hN2hrekJUUjM0emw4N3F6SXMzQitV?= =?utf-8?B?SjVTOW1UQlN1d0ptQUtGT091VG1ET3YyVmJmSTFDVW1lbE9maFkxWkovNzF5?= =?utf-8?B?WUhoUTFaaGMySU05YUVaM0htSW9wQWdRSzk2bHN2MW1EVnpJeGJsS1hxVWVH?= =?utf-8?B?QWZSYXdqSlNsU1BmVkJhdmFMMnJMa2txWWN2SHp2NzMzamlhcExQN3EzVVg1?= =?utf-8?B?WHF6emxqTlFEWUdiYm5zVHNmWU9jL21PMXpnLzRUdk42N205NU1jRThPSzVX?= =?utf-8?B?M2RPaGhxb2ZKaGV3TnJoTW1rZVc3VkFmaFlHbStRT0M1UlArajAvVTlqY1hh?= =?utf-8?B?WFpOQVdTdHd2ZERHNHRyT0ltU2FwazJYVUttby9pcFRwU0dnNHBkaGdKN21T?= =?utf-8?B?MEl2QjE0WmZUL2FySU1FOXRIalpQdHFZZmNPa0E2bGZFem9yTTJ0Uk9XYmxy?= =?utf-8?Q?xgzpzS1Zs2Fn3eYBLXGaOPzGdRrBlhYWTgpcL5E?= MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR02MB3941.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f43dd0ed-9cb4-41d0-7125-08d9032eca6a X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2021 12:29:34.7828 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1rXI7wmpT6krKOAxThw5sRZm6usc/KAX2CauThxyarXumVZgJqoKb6BQ+GF0dcR9+L97JCo1GWc6pg9dk/Lahw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6899 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210419_052940_746535_93E46AE8 X-CRM114-Status: GOOD ( 35.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal, > -----Original Message----- > From: Michael Tretter > Sent: 19 April 2021 01:03 PM > To: Rajan Vaja > Cc: linux-arm-kernel@lists.infradead.org; Michal Simek ; Jolly > Shah > Subject: Re: [PATCH 0/4] soc: xilinx: pm_domains: cleanup and fix > PM_INIT_FINALIZE > > Hi Rajan, > > On Thu, 15 Apr 2021 16:27:58 +0000, Rajan Vaja wrote: > > Thanks for the patch. > > > > > -----Original Message----- > > > From: Michael Tretter > > > Sent: 17 March 2021 09:34 PM > > > To: linux-arm-kernel@lists.infradead.org > > > Cc: Michal Simek ; Rajan Vaja ; Jolly > > > Shah ; m.tretter@pengutronix.de > > > Subject: [PATCH 0/4] soc: xilinx: pm_domains: cleanup and fix > PM_INIT_FINALIZE > > > > > > Patch 1 of this series fixes the ZynqMP PMU FW power management > > > initialization, which was done by the wrong driver. PM_INIT_FINALIZE must be > > > called from the zynqmp_pm_domains driver, which handles power domains, > instead > > > of the zynmp_power driver, which is responsible for suspend and shutdown. > > [Rajan] I am fine with moving to genpd but zynqmp_pm_init_finalize() needs to > be late call. > > zynqmp_pm_init_finalize() should be called when Linux has requested all the > devices through > > genpd driver. Making it late call will make sure it. > > What is the reason why all devices have to be requested before calling > zynqmp_pm_init_finalize()? [Rajan] This is required if device is not to be powered down. If zynqmp_pm_init_finalize() Is called before requesting, device may go power down. So settings done in probe() may be lost. In this case, driver needs to do config during runtime resume. However, some driver may not do all config during runtime resume which may not work. > > I was expecting that calling PM_INIT_FINALIZE only would tell the PMU_FW that > Linux is using the PM API and the PMU_FW should power down/up PM slaves as > requested by Linux. It is somewhat surprising that this isn't the case and all > PM slaves have to be powered up before calling PM_INIT_FINALIZE. [Rajan] Basically PMUFW will do power up/down as per request. However, device config may be lost due to this power down. So device driver mat need to take care during runtime suspend/resume > > What would happen if some driver is built as a module? In that case, the > module would be loaded and request the pm node only after PM_INIT_FINALIZE > was > called. Do we have to avoid/disallow such cases? [Rajan] We allow that. When driver is init, it needs to setup device which will be fine As probe do most of settings. > > For USB, I am actually observing a similar situation: If I do not request the > USB PM slave before I call PM_INIT_FINALIZE, I see communication errors with > connected USB devices. Could this be related? [Rajan] Yes, device config might have lost due to power down because of init finalize call. Thanks, Rajan > > Thanks, > > Michael > > > > > > > > > Patches 2 to 4 are various cleanup patches to improve the readability and > > > debugging experience of the zynqmp_pm_domains driver. > > > > > > Michael > > > > > > Michael Tretter (4): > > > soc: xilinx: move PM_INIT_FINALIZE to zynqmp_pm_domains driver > > > soc: xilinx: cleanup debug and error messages > > > soc: xilinx: use a properly named field instead of flags > > > soc: xilinx: add a to_zynqmp_pm_domain macro > > > > > > drivers/soc/xilinx/zynqmp_pm_domains.c | 79 +++++++++++++------------- > > > drivers/soc/xilinx/zynqmp_power.c | 1 - > > > 2 files changed, 38 insertions(+), 42 deletions(-) > > > > > > -- > > > 2.29.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel