From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B7F5C43463 for ; Fri, 18 Sep 2020 18:03:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A101121734 for ; Fri, 18 Sep 2020 18:03:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NmxTG0wA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="XPtmalzS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A101121734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gxvHs8KyHBBqE6BJFmpfK5DhftR4NC87LjHuyo2FUhg=; b=NmxTG0wAWlGm91TtcWYoiVz2Z 92hXVa/igzFU0taYhHOylJaT6Yu8pFwdAlj4ZP+Hzgm19A+z0Ujbp5Ba+DzNMeFXdhDDv94Y4P6A7 UlAFL7LcGFNasUzgw0Gjx0RJc2e7IIY777uYph9TnlWBHocCO/ffSGWdDXvmN7hvrWViunN3VtWnL 4O69ZY2n437uU0Gvs+OwItweZQmwkCpcthQqFyVEs/+WL0WSuBlU8BzzHUqbBiCgUQrAux5Hhcf1V Dbpida+AiQjn5tT6yIOpGZ8urBdCPFV884YzquwfAO1Yz88of7BQs0Ik9FOUBEsz+qvV7E74UfUjT maHVS52hg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJKhO-0002q5-V5; Fri, 18 Sep 2020 18:01:30 +0000 Received: from mail-dm6nam10on2046.outbound.protection.outlook.com ([40.107.93.46] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJKhH-0002nx-0L for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 18:01:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dDrd4e202UgWdx+qQpB17IwAniy3Pn/kYFVb+JIDjxS0iky+0LneAleXsc7UkqmkrrpV3QD0Wt8/+7gQ3+dmE5sLQjUvWSSvylA3ZsCiAQFUImiW4PiVQI8kFODaAXdyFJf3YRnermMChBhHUYdiSjIwiD3o3WKRK98x1Lnd2kn+ovR9raKJi+PMMsgtLc0mlHR+V9qT+2WJXNlZLMfP80sJ4ZIcvli23teeZNmB+j05WeWyWA67lAD6RUfKcWTuimc7AxzjUmvdwg4My+7ucmoegGCnW9sXJHY3G5YFJPC1U0OyWaWhpe8xoLyTJqYqRG5QnMYfTm/bejzcXsYH6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jK6Hp2j6OF0rniuw+TGS7AFTjLXNm3qNtJzX+m+Bi80=; b=hXZuhErp6Jx5PQYj7foBlCBHAuJqqQnBv85ef7NiBWU/RhHJnFSWHq7+VJhpGCVSVydtJKdNYf+KcJUr2CtnIjitLzG7bGJVGF8uYFpwqil7+8swDPbRmwyBdOPZCONgSwygkJqq+DBVMD5/RsmC1Q3EnAwiclA2esRlPNeboCed+DTKTtNqqNJDDMgGMssWp+cshX4cLhWeAsTD0RPaF9tuixEcaJB/Icrg2bvYBabqWSGLpZzeee03QY7kZsPG5CABppI55YQl0A1+77HRdcBPThXXlXP+ALAqYatOs97SxQZjUpR27icQlM3L5IewVRC3URoWwIvyKTqLTtpyTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jK6Hp2j6OF0rniuw+TGS7AFTjLXNm3qNtJzX+m+Bi80=; b=XPtmalzSEZqW2CAvICTk/5/GMyN5cgkaXCD+dHc6xz5yG7w2amRwH+JgargQ9MpQT1MSuZyCNcZIsTVS5a3r5ui2RcpE507g2XKm4QoRAdPFa8t9uiNF5w6cnE+z9gBSdcLIXgGTOmwxRNDe77ZMpAER/TgHnpofSdz8lsnErYA= Received: from BYAPR02MB4407.namprd02.prod.outlook.com (2603:10b6:a03:55::31) by BY5PR02MB6611.namprd02.prod.outlook.com (2603:10b6:a03:205::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Fri, 18 Sep 2020 18:01:20 +0000 Received: from BYAPR02MB4407.namprd02.prod.outlook.com ([fe80::b0f6:b3a:6543:26f5]) by BYAPR02MB4407.namprd02.prod.outlook.com ([fe80::b0f6:b3a:6543:26f5%5]) with mapi id 15.20.3391.011; Fri, 18 Sep 2020 18:01:20 +0000 From: Ben Levinsky To: Michael Auchter , "punit1.agrawal@toshiba.co.jp" Subject: RE: RE: [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Thread-Topic: RE: [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Thread-Index: AQHWjSzx2v36zrUuJk25DA+tFuTaOqltZJcAgAAAbzCAAAnbcIABIlmAgAAd03A= Date: Fri, 18 Sep 2020 18:01:19 +0000 Message-ID: References: <20200917194341.16272-1-ben.levinsky@xilinx.com> <20200917194341.16272-6-ben.levinsky@xilinx.com> <20200917221120.GA15530@xaphan> <20200918160721.GD15530@xaphan> In-Reply-To: <20200918160721.GD15530@xaphan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=xilinx.com; x-originating-ip: [24.5.142.107] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0117ca30-c783-4a8e-37f5-08d85bfcd8e1 x-ms-traffictypediagnostic: BY5PR02MB6611: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t7iZhCgRX1CTD7LiWuzyTkfz5xz7Q1yriuk0T0okh5uhkc3Hxr85AlhVhxfgGFn2USNyVP0Ge25fdI2M9IpTJcKS2p6sqTjeQ5SnWVQwE1SVvSW68loLXuiq2bccfgqTRKOI4hxTDys3BmhfO35WlWzLUNMcImScIby2786nv94hmjUAPUTFQ/zz7TApUde8eFN46X1B4mo8AiuO4ncCfWQb7MmCaeAii/ZTsJ/v2QH6fkhHxcFDdVDfGfidE/cq8jgQRXSXjWolbicIcSGd+MIsQqDcdMP5pFVBujJBBc1TO2X+DAUf8+yMqIMyvLeVZiUQmfDqb8miNlcZCzA7ZQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR02MB4407.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(366004)(346002)(39860400002)(396003)(376002)(53546011)(52536014)(66946007)(8676002)(6506007)(86362001)(66446008)(9686003)(5660300002)(7696005)(66476007)(71200400001)(54906003)(64756008)(33656002)(66556008)(110136005)(76116006)(316002)(186003)(2906002)(26005)(55016002)(4326008)(478600001)(83380400001)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: ZdYWWshinkv7vbjqmZjHcy26V95JzzATETRwuNFuHQcLcZ5QAz7zlSrZTLb7/gHS7KNOwkTlzLpKYqJ21vQJU6wKJOeyyVXn8scadLlfoVV6lK6e90JEpZIaRo5uyy95YoADXFqiwcDshKOxcg79J1ZgX6wy1cNHc8njgLv81hL6KVmQ+31App6BoOoTyCD1EWyKDLqATL8lDk0o9/Apg7MfCNE9qOwBq8arG6ssubC11WgRbR2u9ScJOtlPI2BdT1qpfeXlUvZWg4OY2VZt32DGIP45tN0O896ZMNg2mweVh3l6+CxIGjy4jR7+tzAtWeVdYBGk+gcLWcbbmlXcacT15G7IjPoHWTha9hnJoYY+iakAtg8wfSI7NweaMURNB7Rtw1SFhqaGxXWleR6ydrcYg8lrgiCobvahEO2vHJCxKqstU1Ce9TptTVNPtkjde6KgHJQR6LXyF4gpOWGTwDF8cbWaSlNwU2fx/WuVdZi4+fU2yTZcEd84bOgvmWlP2DwetL5YBx3pBc8W7wQng8s93s1vIH+ut1XC3SnnRGWAllAN143ECFBhJeAirmVz2MLP7MlZYQyfmHgy6EEjejRPhsz4kH15zjEY6rdLFA8UtXLxCkoVcAp3y1xGrxqRcGLMZWO2xBw77IKHQFctdA== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR02MB4407.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0117ca30-c783-4a8e-37f5-08d85bfcd8e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2020 18:01:19.9411 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KfG0bNa6HpGcz6UYwHNz0qsWKX2OSt995FEbhDiQrElMVcQfyHRBBqVH1pAL4mhv3S1YStZ5qccfDeSMjdpjiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6611 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_140123_145521_3B874B56 X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michael, Punit, > -----Original Message----- > From: Michael Auchter > Sent: Friday, September 18, 2020 9:07 AM > To: Ben Levinsky > Cc: devicetree@vger.kernel.org; linux-remoteproc@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: RE: [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 > remoteproc driver > > On Thu, Sep 17, 2020 at 10:50:42PM +0000, Ben Levinsky wrote: > > In addition to device tree, is there particular linker script you use > > for your R5 application? For example with OCM? As presently this > > driver only has DDR and TCM as supported regions to load into > > The firmware is being loaded to TCM. > > I'm able to use this driver to load and run my firmware on both R5 > cores, but only after I change the incorrect: > > rpu_mode = lockstep_mode > > assignment to: > > rpu_mode = lockstep_mode ? PM_RPU_MODE_LOCKSTEP > : PM_RPU_MODE_SPLIT; There was a point raised by Punit that as "it is possible to set R5 to operatore in split or lock-step mode dynamically" which is true and can be done via sysfs and the Xilinx firmware kernel code. A suggestion that might clean up the driver so that the whole rpu_mode, tcm_mode configuration can be simplified and pulled out of the driver: - as Punit suggested, remove the lockstep-mode property - the zynqmp_remoteproc_r5 driver ONLY loads firmware and does start/stop. - the zynqmp_remoteproc_r5 driver does not configure and memory regions or the RPU. Let the Xilinx firmware sysfs interface handle this. Few advantages to this: 1. no extra configuration code in the zynqmp r5 remoteproc probe() for either R5 in the RPU cluster 2. less state to manage in the remoteproc driver 3. simpler documentation in the device tree binding Again thank you both for the thoughtful review comments on this Thanks Ben _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel