From: appana.durga.rao@xilinx.com (Appana Durga Kedareswara Rao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support
Date: Sat, 9 Jul 2016 08:36:05 +0000 [thread overview]
Message-ID: <C246CAC1457055469EF09E3A7AC4E11A4A5BC756@XAP-PVEXMBX01.xlnx.xilinx.com> (raw)
In-Reply-To: <20160708055328.GP12591@localhost>
Hi Vinod,
Thanks for the review...
> > +
> > + chan->is_dmacoherent = of_property_read_bool(node, "dma-
> coherent");
> > + zdev->chan = chan;
> > + tasklet_init(&chan->tasklet, zynqmp_dma_do_tasklet, (ulong)chan);
>
> where is this killed?
This is killed in the zynqmp_dma_chan_remove() API.
>
> > + spin_lock_init(&chan->lock);
> > + INIT_LIST_HEAD(&chan->active_list);
> > + INIT_LIST_HEAD(&chan->pending_list);
> > + INIT_LIST_HEAD(&chan->done_list);
> > + INIT_LIST_HEAD(&chan->free_list);
> > + zynqmp_dma_init(chan);
> > + chan->irq = platform_get_irq(pdev, 0);
> > + if (chan->irq < 0)
> > + return -ENXIO;
> > + err = devm_request_irq(&pdev->dev, chan->irq,
> zynqmp_dma_irq_handler, 0,
> > + "zynqmp-dma", chan);
>
> this needs to be freed/diabled in remove, dont see that
It is freed in the zynqmp_dma_chan_remove() API.
Regards,
Kedar.
next prev parent reply other threads:[~2016-07-09 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 11:37 [PATCH v12 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation Kedareswara rao Appana
2016-07-01 11:37 ` [PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support Kedareswara rao Appana
2016-07-08 5:53 ` Vinod Koul
2016-07-09 8:36 ` Appana Durga Kedareswara Rao [this message]
2016-07-08 5:58 ` [PATCH v12 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation Vinod Koul
2016-07-09 8:06 ` Appana Durga Kedareswara Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C246CAC1457055469EF09E3A7AC4E11A4A5BC756@XAP-PVEXMBX01.xlnx.xilinx.com \
--to=appana.durga.rao@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).