From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E75C43603 for ; Fri, 13 Dec 2019 22:29:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7F51214D8 for ; Fri, 13 Dec 2019 22:29:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oOmlidaa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VB0Qc7V7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7F51214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yfjwZ/Jpf8fsNILrtDLCG31h8b7NsNxIUz4ncDzKeqI=; b=oOmlidaaXF0BM3 e6irUxzuYDSJ2jktyfRjxqDNkDjS3JH51fObj3zf6DSuCTZB6Wn78+jxnqc/uIP62AiqgIMZUgYS+ f5umlb8owKM8PTgOtla6IxBq44CrTKBPQEUiLOaJ4eiX+57hDCulaB2v5eK8dYrScBukQfKtcmHys vIepxyEIxrP7Z1OTxROyboAEc7GG748XXfGOSIEFC8vLub8PN5ILgO7/VrzUsXzvxGjq370tSXFBA IeCn+CEX/PGd8YNai3paazWgZmekk0t8jbRAi/JGvVbrs/WcUJwp9nCSu3+D2BXUJ9gnBFQiFg8H5 FKljRkV8X7t7eXpHBS7A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifmx3-0001ER-NO; Fri, 13 Dec 2019 15:33:57 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifmx0-0001Dl-Kl for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2019 15:33:55 +0000 Received: by mail-wm1-x343.google.com with SMTP id b19so2640367wmj.4 for ; Fri, 13 Dec 2019 07:33:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SAYkCWa+UKUtmAHpxZPtyf0202Fu23Y0TOqeEazyr/Q=; b=VB0Qc7V7S5H1KmeOm9KBILALqgHQYmF0aObNiHutpNEkYKmbpAjtI6JvdXopT8ToXQ qm9DbdizY6eiF3/gk9eh3FqiObj0x6V2jvz6Ylw/I73linNPmdpuQtck7H3uv4ntHObE zQqLulojG9AR9iQ3V4qz2nPme4DxxHaa4KFNI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SAYkCWa+UKUtmAHpxZPtyf0202Fu23Y0TOqeEazyr/Q=; b=kedy8ue+GoHuybxO1gRMd73GVF88dhIGe5Xd3B+9MQf7uPtm8WB8Z1S353V7Gs5Ajq 9mfGI+cWqIUMbvq8Nd0JX8RHa5Hu15+8EVY0veDIvVNdu5SMEMcHXZMJgZhHfyxdtN93 YsGoyhRfdNgb6Zl1gSdaG1pJvb0QfwZ+i2c5WAJndvu9SM8Yb7h2ACqTPiHh3+9AtBqN V+t6fdPKxkuqg+hlucUlM1qNsbiAyKfGcGAyS4dGMoV0GZ73QM3jmDOe2FTMoUyjCNmR aDphorMGuTA1sBzrXKyVZB+YivPXqOGXR3WtVULXKRxsvRPesQymXJtZ7uhxsk0YaN7w fNSA== X-Gm-Message-State: APjAAAUBGoex+bR9pI608icX4iX1OpKTH0RGv0Z15/NjAGGIxzy47Eep taZuNbx9MOq/+d24KECfwySDJATptPTNKZQ32EdwKA== X-Google-Smtp-Source: APXvYqzG07t8L0rdT/jCMyiZ1bizG1mmA/UGnwTTkXBgBiB92Pia9cOilPnt362sCSti1OdNCJDkL78l3OzGZ3Q6Gso= X-Received: by 2002:a7b:c051:: with SMTP id u17mr13988989wmc.174.1576251232755; Fri, 13 Dec 2019 07:33:52 -0800 (PST) MIME-Version: 1.0 References: <20191212231213.29061-1-jquinlan@broadcom.com> <20191213114138.GB4644@sirena.org.uk> In-Reply-To: <20191213114138.GB4644@sirena.org.uk> From: Jim Quinlan Date: Fri, 13 Dec 2019 10:33:41 -0500 Message-ID: Subject: Re: [PATCH] spi: bcm2835: don't print error on clk_get() DEFER To: Mark Brown X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_073354_682443_6CEC2F4A X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Florian Fainelli , Scott Branden , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Ray Jui , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 13, 2019 at 6:41 AM Mark Brown wrote: > > On Thu, Dec 12, 2019 at 06:12:13PM -0500, Jim Quinlan wrote: > > Otherwise one may get multiple error messages for normal > > operation of a clock provider. > > > if (IS_ERR(bs->clk)) { > > err = PTR_ERR(bs->clk); > > - dev_err(&pdev->dev, "could not get clk: %d\n", err); > > + if (err != -EPROBE_DEFER) > > + dev_err(&pdev->dev, "could not get clk: %d\n", err); > > On the other hand if the clock isn't there and never appears then there > won't be anything saying why the driver isn't loading which won't be > helpful when trying to figure out what's going on. Understood; I could do a dev_dbg() on -EPROBE_DEFER and dev_err() on all other errors -- would that work for you? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel