linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Tim <elatllat@gmail.com>
To: Jun Li <lijun.kernel@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	devicetree@vger.kernel.org, khilman@baylibre.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Neil Armstrong <narmstrong@baylibre.com>,
	Dongjin Kim <tobetter@gmail.com>,
	linux-amlogic@lists.infradead.org, Rob Herring <robh@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
Date: Mon, 11 Nov 2019 09:05:27 -0500	[thread overview]
Message-ID: <CA+3zgmtJqN-3Q-kjMhh58B+T7z_1TA-C6be7+UP6nuQb7eq=8A@mail.gmail.com> (raw)
In-Reply-To: <CAKgpwJWU3jB0DWEKE09TOV+YLceBFJ75ZirAXQbuhj8v3FwjXg@mail.gmail.com>

Speculation;

Maybe the kernel maintainers prefer to optimistically permit future
products to easily remove workarounds via quirk flags.
Even if data from testing were shown, and it did not impact
performance, code reduction and clarity are desirable.

On Sun, Nov 10, 2019 at 8:58 PM Jun Li <lijun.kernel@gmail.com> wrote:
>
> Hi Neil
>
> As I got the information from Synopsys, this bug exists on current IP versions,
> and per my tests with external USB3 hub + 2 Super speed udisks on data
> read by dd, I can reproduce this issue with different kernel versions, also I
> didn't see obvious performance drop by dd tests after disable park mode for
> super speed, so should we just disable it by default so no need a quirk?
>
> Li Jun
>
> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道:
> >
> > Thanks for working on this Neil,
> > Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> > As previously mentioned the patch set fixes the issue on affected hardware;
> >     https://patchwork.kernel.org/patch/11164515/
> >
> >
> >
> > On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> > > > This patch updates the documentation with the information related
> > > > to the quirks that needs to be added for disabling all SuperSpeed XHCi
> > > > instances in park mode.
> > > >
> > > > CC: Dongjin Kim <tobetter@gmail.com>
> > > > Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> > > > Reported-by: Tim <elatllat@gmail.com>
> > > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > >
> > > Sigh, what's one more to the never ending list of quirks...
> > >
> > > Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-11-11 14:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 14:17 [PATCH 0/3] arm64: g12-common: parkmode_disable_ss_quirk on DWC3 controller Neil Armstrong
2019-10-14 14:17 ` [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode Neil Armstrong
2019-10-23 20:11   ` Rob Herring
2019-11-11  0:38     ` Tim
2019-11-11  1:58       ` Jun Li
2019-11-11 14:05         ` Tim [this message]
2019-11-12  1:48           ` Jun Li
2019-11-12  9:00         ` Neil Armstrong
2019-11-12 10:51           ` Jun Li
2019-11-12 20:03             ` Thinh Nguyen
2019-12-10  8:55               ` Neil Armstrong
2019-12-11  0:45                 ` Tim
2019-12-20  9:58                   ` Tim
2019-10-14 14:17 ` [PATCH 2/3] usb: dwc3: gadget: Add support " Neil Armstrong
2019-10-14 14:17 ` [PATCH 3/3] arm64: dts: g12-common: add parkmode_disable_ss_quirk on DWC3 controller Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+3zgmtJqN-3Q-kjMhh58B+T7z_1TA-C6be7+UP6nuQb7eq=8A@mail.gmail.com' \
    --to=elatllat@gmail.com \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jianxin.pan@amlogic.com \
    --cc=khilman@baylibre.com \
    --cc=lijun.kernel@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=robh@kernel.org \
    --cc=tobetter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).