From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4836C43381 for ; Thu, 28 Feb 2019 02:37:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B183320863 for ; Thu, 28 Feb 2019 02:37:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O4F03Rg1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QpIWPMKv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B183320863 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V+1XfzLDbUkbBs7KjJc8pd/vxoq4bTDVri6uFeokJPk=; b=O4F03Rg11KR56q dO1saQKXnEBkKcItmsvycm+v1y5B03ApSuhDD1SnzXAfaYgKn19K3pfMVaKG1/PTrvpl+qJKTNrv+ ZGh5Iy5sfXu+DxgI50Z7XoZvyH6ecuUfFZcEnpOg2smM22sVE82E73ki0qN4Yb4PHV0Kd8S0x9Ns0 GCt6hr2VugpJEOfUnNjaihS99LsWo42tW0EowJ1Ef2x9uVPmrgI97Gi1XtJ8eHV1Sm5tNy4huPW+2 YfzsGnlyW3Zb6Vlc6kUIyXWAmMev2J7TmnEBYBO7diyNUszDy9pkIJ9zcVPNnWGZloybFfaa8cC2x 426yF18rgdenUQcSzFnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzBZt-0001gS-CV; Thu, 28 Feb 2019 02:37:41 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzBZp-0001fs-Sv for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 02:37:39 +0000 Received: by mail-lj1-x242.google.com with SMTP id z7so15548023lji.0 for ; Wed, 27 Feb 2019 18:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EyqFOT7Inb7ltcsQAxtq2y609tKCB1dTKtt4XzU9cmo=; b=QpIWPMKvdXGzSz9fQZzVo3Fg8yZ75XyjkJzUB7aRlL4Bgly15JHZRf03PoDNEQeleX vTwDW7mtYYjRVJWogD8umPTbo9TShmKQZUpl5LZO2xpNgLQhw627MFSW7FxVr4z+2gve Gu9PicSY725DMThFkRGABZ+8V8NDzHsuKg7lk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EyqFOT7Inb7ltcsQAxtq2y609tKCB1dTKtt4XzU9cmo=; b=OBfLCaocVbrxarFrsFoBrWY3xmeWCjw2PLHHWZqnc3isQtUleLzCYxlRjdrYP62OB1 6kpkkSLi3wOOpr+AjaA19u+wCvkuqnkvIzBi/3zW92SQTfDZziilr0TXgG5kSJyEuocE cfVQuii7x6jwnIo5QMiaE7AowbxNy8tXQQkcVh4iWCNrK3MXxe8+PsrtP4rjz3HT9sxx pf4NkDWCzwrCtCikvKf/RZdhvNpn9mnVEGDoXU51LRbQlW7AN4fKlPz/wI3dlNrlYTNZ oHR/er/q2rxPyJ67ifJGjLISK3R8DZq7hFnuneG2vPtz7SA7OQnWRs4KlsdpFWrwkQVV oirw== X-Gm-Message-State: APjAAAUuexvXANZOhirU5bVz1t6540Cy55NPKqp4fmqRMBU59kJqe3Fd 0eroGLEIh5L6sVoSzXzte4rTgPYrbao= X-Google-Smtp-Source: AHgI3IYi8KjLiF5Ogx6QN/XZVKQ8wGiAbNmYbPPAGvpUA2vfD5/3vVwOhfw1lu37cAHu9205fggEKQ== X-Received: by 2002:a2e:3a04:: with SMTP id h4mr3294147lja.50.1551321455483; Wed, 27 Feb 2019 18:37:35 -0800 (PST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id m16sm4228341lfg.49.2019.02.27.18.37.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 18:37:35 -0800 (PST) Received: by mail-lf1-f41.google.com with SMTP id u21so14070529lfu.1 for ; Wed, 27 Feb 2019 18:37:35 -0800 (PST) X-Received: by 2002:a19:c98b:: with SMTP id z133mr2657642lff.88.1551320973346; Wed, 27 Feb 2019 18:29:33 -0800 (PST) MIME-Version: 1.0 References: <20190224140426.3267-1-marc.zyngier@arm.com> <20190226232822.GA174696@google.com> <20190227205754.GF174696@google.com> In-Reply-To: From: Brian Norris Date: Wed, 27 Feb 2019 18:29:21 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes To: "Rafael J. Wysocki" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190227_183737_941581_4356E467 X-CRM114-Status: GOOD ( 21.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Heiko Stuebner , Tony Lindgren , "Rafael J. Wysocki" , Amitkumar Karwar , Lorenzo Pieralisi , "open list:ARM/Rockchip SoC..." , linux-arm-kernel , Devicetree List , linux-pm , Marc Zyngier , Jeffy Chen , Nishant Sarmukadam , Rob Herring , Kalle Valo , Ganapathi Bhat , Ard Biesheuvel , Xinming Hu , "" , "" , Linux Kernel Mailing List , Enric Balletbo i Serra , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rafael, On Wed, Feb 27, 2019 at 3:04 PM Rafael J. Wysocki wrote: > On Wed, Feb 27, 2019 at 9:58 PM Brian Norris wrote: > > On Wed, Feb 27, 2019 at 11:16:12AM +0100, Ard Biesheuvel wrote: > > > So I'd argue that we should add an optional 'wake-gpio' DT property > > > instead to the generic PCI device binding, and leave the interrupt > > > binding and discovery alone. > > > > So I think Mark Rutland already shot that one down; it's conceptually an > > interrupt from the device's perspective. Perhaps I shouldn't speak for Mark, but I am basically quoting him off IRC. > Which device are you talking about? The one that signals wakeup? If > so, then I beg to differ. Yes, the endpoint device. > On ACPI platforms WAKE# is represented as an ACPI GPE that is signaled > through SCI and handled at a different level (on HW-reduced ACPI it > actually can be a GPIO interrupt, but it still is handled with the > help of AML). The driver of the device signaling wakeup need not even > be aware that WAKE# has been asserted. Frankly, ACPI is not relevant to how we represent WAKE# in DT, IMO. Also, we're talking about the *device*, not the driver. When talking about Device Tree, that distinction is relevant. So while the driver need not be aware (and I agree! it only needs to care about enabling/disabling wake), *something* should be aware, and the signal that "something" should be receiving is simply "did WAKE happen"? That sounds basically like the device is signalling an interrupt to me. Maybe this goes back to some confusion we had elsewhere: what is the meaning of "interrupt" in device tree? > > We just need to figure out a good way of representing it that doesn't stomp on the existing INTx > > definitions. > > WAKE# is a signal that is converted into an interrupt, but that > interrupt may arrive at some place your driver has nothing to do with. I could agree with that, perhaps. But that's also what Device Tree is all about, really. We describe the relation between devices. So some other handles events that are triggered by , so we use a phandle to relate to . > It generally doesn't make sense to represent it as an interrupt for > the target device. What would you suggest then? I'm not clearly understanding how you think we should (a) describe (in DT) and (b) implement this WAKE# handling. Brian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel